Re: [systemd-devel] Hackfest at Linux Plumbers Conference?

2013-09-10 Thread Harald Hoyer
On 09/10/2013 06:46 AM, David Strauss wrote: > On Wed, Aug 14, 2013 at 11:11 PM, Harald Hoyer wrote: >> Linux Foundation is looking into it. Right now they don't have space, but >> they >> are trying to find something for us. We should know early/mid next week. > > Any word on this? > They res

Re: [systemd-devel] [PATCH] make fsck fix mode a kernel command line option

2013-09-10 Thread Robert Schiele
Hi, On Tue, Sep 10, 2013 at 2:41 AM, Lennart Poettering wrote: > On Fri, 06.09.13 14:53, Robert Schiele (rschi...@gmail.com) wrote: >> I was choosing the interface described above since according to my >> observation this seems closest to how interfaces were constructed in >> this area before. I

Re: [systemd-devel] journalctl -x considered harmful

2013-09-10 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Sep 10, 2013 at 02:34:41AM +0200, Lennart Poettering wrote: > On Fri, 06.09.13 14:26, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > Hi, > > > > I think we should remove all recommendations to use -x for bug > > reports. Generic explanations are not useful one you know the b

Re: [systemd-devel] [PATCH] make fsck fix mode a kernel command line option

2013-09-10 Thread Jan Engelhardt
On Tuesday 2013-09-10 02:41, Lennart Poettering wrote: >On Fri, 06.09.13 14:53, Robert Schiele (rschi...@gmail.com) wrote: > >One possibility might be to add a new extended mount option (i.e. as >listed in fstab's fourth column) that systemd >would interpret. i.e. "x-systemd.yesfsck" or so. That s

Re: [systemd-devel] [PATCH] make fsck fix mode a kernel command line option

2013-09-10 Thread Dave Reisner
On Tue, Sep 10, 2013 at 01:40:32PM +0200, Jan Engelhardt wrote: > > On Tuesday 2013-09-10 02:41, Lennart Poettering wrote: > >On Fri, 06.09.13 14:53, Robert Schiele (rschi...@gmail.com) wrote: > > > >One possibility might be to add a new extended mount option (i.e. as > >listed in fstab's fourth c

Re: [systemd-devel] [PATCH] make fsck fix mode a kernel command line option

2013-09-10 Thread Kay Sievers
On Tue, Sep 10, 2013 at 1:52 PM, Dave Reisner wrote: > On Tue, Sep 10, 2013 at 01:40:32PM +0200, Jan Engelhardt wrote: >> >> On Tuesday 2013-09-10 02:41, Lennart Poettering wrote: >> >On Fri, 06.09.13 14:53, Robert Schiele (rschi...@gmail.com) wrote: >> > >> >One possibility might be to add a new

Re: [systemd-devel] [PATCH] make fsck fix mode a kernel command line option

2013-09-10 Thread Jan Engelhardt
On Tuesday 2013-09-10 13:52, Dave Reisner wrote: >> the FUSE program knows >> nothing about the systemd-specific "nofail" or "x-*". > >This should only be a problem if you directly use the FUSE mount helper. >If you instead invoke mount with -t fuse.$fusetype, then this isn't an >issue. mount(8) *

Re: [systemd-devel] [PATCH] make fsck fix mode a kernel command line option

2013-09-10 Thread Tom Gundersen
On Tue, Sep 10, 2013 at 2:31 PM, Jan Engelhardt wrote: > > On Tuesday 2013-09-10 13:52, Dave Reisner wrote: >>> the FUSE program knows >>> nothing about the systemd-specific "nofail" or "x-*". >> >>This should only be a problem if you directly use the FUSE mount helper. >>If you instead invoke mou

Re: [systemd-devel] [PATCH] Remove device and its relatives when action is offlined

2013-09-10 Thread MUNEDA Takahiro
On Mon, 9 Sep 2013 23:45:01 +0200, Kay Sievers wrote: On Mon, Sep 9, 2013 at 11:23 PM, MUNEDA Takahiro wrote: Ok, I found out another problem. Even if I have a following udev rules and 'remove' event happens, no systemd service will be called. ACTION=="add|remove", TAG+="systemd", ENV{SY

Re: [systemd-devel] [PATCH] Remove device and its relatives when action is offlined

2013-09-10 Thread MUNEDA Takahiro
On Tue, 10 Sep 2013 02:25:19 +0200, Lennart Poettering wrote: On Mon, 09.09.13 17:23, MUNEDA Takahiro (muneda.takah...@jp.fujitsu.com) wrote: Ok, I found out another problem. Even if I have a following udev rules and 'remove' event happens, no systemd service will be called. ACTION=="add|

Re: [systemd-devel] [PATCH] Remove device and its relatives when action is offlined

2013-09-10 Thread Kay Sievers
On Tue, Sep 10, 2013 at 3:14 PM, MUNEDA Takahiro wrote: >> Udev still does all what did before systemd. It was never really able >> to run or start long-running tasks. Udev can only reliably handle >> synchronously started and very short-living programs, and that was >> always the case. > > > Ahh

Re: [systemd-devel] [PATCH] make fsck fix mode a kernel command line option

2013-09-10 Thread Lennart Poettering
On Tue, 10.09.13 12:23, Robert Schiele (rschi...@gmail.com) wrote: > > Hi, > > On Tue, Sep 10, 2013 at 2:41 AM, Lennart Poettering > wrote: > > On Fri, 06.09.13 14:53, Robert Schiele (rschi...@gmail.com) wrote: > >> I was choosing the interface described above since according to my > >> observa

Re: [systemd-devel] [PATCH] service: remove pidfile after exit of a service

2013-09-10 Thread Lennart Poettering
On Wed, 28.08.13 19:27, Lukas Nykryn (lnyk...@redhat.com) wrote: Applied! Thanks! (Added a longer comment though) > --- > TODO | 2 -- > src/core/service.c | 4 > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/TODO b/TODO > index fe305ec..3527970 100644 >

Re: [systemd-devel] [PATCH 1/3] blkio bandwidth: don't clean up all of entries in blockio_device_bandwidths list

2013-09-10 Thread Lennart Poettering
On Fri, 30.08.13 10:56, Gao feng (gaof...@cn.fujitsu.com) wrote: > if we get BlockIOReadBandwidth="", we should only remove the > read-bandwidth-entries in blockio_device_bandwidths list. Thanks! Applied, though with one change: > +read = streq("BlockIOReadBandwidth", lvalue); > + >

Re: [systemd-devel] [PATCH 2/3] cgroup: setup BlockIORead/WriteBandwidth in bus_cgroup_set_property

2013-09-10 Thread Lennart Poettering
On Fri, 30.08.13 10:56, Gao feng (gaof...@cn.fujitsu.com) wrote: > This patch adds the support for setting up BlockIORead/WriteBandwidth > in bus_cgroup_set_property. Thanks! Applied! > --- > src/core/dbus-cgroup.c | 101 > + > 1 file changed, 1

Re: [systemd-devel] [PATCH 3/3] systemcl: add support for setting BlockIORead/WriteBandwidth for unit

2013-09-10 Thread Lennart Poettering
On Fri, 30.08.13 10:56, Gao feng (gaof...@cn.fujitsu.com) wrote: > This patch allows user to set up BlockIOReadBandwidth and > BlockIOWriteBandwidth > for unit through systemctl. Such as > > systemctl set-property sshd.service BlockIOReadBandwidth="/dev/sda 10" > systemctl set-property sshd.

Re: [systemd-devel] [PATCH] util, utf8: recognize wide characters in wellipsize_mem()

2013-09-10 Thread Zbigniew Jędrzejewski-Szmek
Hi Shawn, thank you for attacking this, and sorry for the long delay in answering. I think that the approach of copying working code from elsewhere for this is right, but I think it should go into its own file, so that two coding styles are not mixed. Also, can those new functions replace normal e

Re: [systemd-devel] [PATCH 2/3] systemcl: add support for setting BlockIODeviceWeight for unit

2013-09-10 Thread Lennart Poettering
On Tue, 27.08.13 13:36, Gao feng (gaof...@cn.fujitsu.com) wrote: > This patch allows user to set up BlockIODeviceWeight for unit > through systemctl. Such as Thanks! Applied! Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing li

Re: [systemd-devel] [PATCH 2/7] mount: don't pull in network.target, just order after it

2013-09-10 Thread Lennart Poettering
On Fri, 23.08.13 15:09, Tom Gundersen (t...@jklm.no) wrote: > --- > src/core/mount.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/core/mount.c b/src/core/mount.c > index c7d29b0..7838e60 100644 > --- a/src/core/mount.c > +++ b/src/core/mount.c > @@ -476,7 +476,7 @

Re: [systemd-devel] [PATCH] util, utf8: new wellipsize and wellipsize_mem that take into account multi-byte characters

2013-09-10 Thread Jan Engelhardt
On Monday 2013-09-09 01:17, Shawn wrote: >ping Lennart was away in (what seems to be) South America, systemd progress is resuming now. :) >> This version counts all multibyte characters as 1 width, not taking into >> account double width cjk characters and zerowidth characters _

[systemd-devel] PrivateNetwork=true conflicts with Type=notify

2013-09-10 Thread Pierre Schmitz
Hi all, when trying to disable network access to the PHP-FPM service I noticed that the service was no longer able to call back to systemd using Type=notify. Systemd then kills the service when reaching the timeout. It seems this could be a limitation by design in which case we might want to warn

Re: [systemd-devel] [PATCH 1/7] filesystem targets: disable default dependencies

2013-09-10 Thread Lennart Poettering
On Fri, 23.08.13 15:09, Tom Gundersen (t...@jklm.no) wrote: > This means we can use default dependencies on mount units without having to > get them automatically > ordered before the filesystem targets. Looks good. But before we merge this, Harald, can you comment? Any issue with this? > > Re

Re: [systemd-devel] [PATCH] libsystemd-login.so: fix undefined reference to 'cg_create'

2013-09-10 Thread Lennart Poettering
On Mon, 26.08.13 13:48, Chengwei Yang (chengwei.y...@intel.com) wrote: Hmm, can you elaborate on this one? libsystemd-login should be mostly passive, why would it need to change labels? What's the missing link here precisely? > --- > Makefile.am |1 + > 1 file changed, 1 insertion(+) > > di

Re: [systemd-devel] [PATCH] Remove device and its relatives when action is offlined

2013-09-10 Thread MUNEDA Takahiro
On Tue, 10 Sep 2013 15:36:26 +0200, Kay Sievers wrote: Udev still does all what did before systemd. It was never really able to run or start long-running tasks. Udev can only reliably handle synchronously started and very short-living programs, and that was always the case. Ahh, you are corr

Re: [systemd-devel] [PATCH] man: one more example in tmpfiles.d

2013-09-10 Thread Lennart Poettering
On Thu, 22.08.13 14:47, Lukas Nykryn (lnyk...@redhat.com) wrote: Thanks! Applied! > --- > man/tmpfiles.d.xml | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/man/tmpfiles.d.xml b/man/tmpfiles.d.xml > index 6a2193d..30e1314 100644 > --- a/man/tmpfiles.d.xml > +++ b/man/tmpfiles.d

Re: [systemd-devel] [PATCH 2/7] mount: don't pull in network.target, just order after it

2013-09-10 Thread Tom Gundersen
On Tue, Sep 10, 2013 at 6:40 PM, Lennart Poettering wrote: > On Fri, 23.08.13 15:09, Tom Gundersen (t...@jklm.no) wrote: > >> --- >> src/core/mount.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>. >> diff --git a/src/core/mount.c b/src/core/mount.c >> index c7d29b0..7838e60 100644 >

Re: [systemd-devel] [RFC v2] mount: improve DefaultDependencies and use in generator

2013-09-10 Thread Lennart Poettering
On Fri, 23.08.13 15:09, Tom Gundersen (t...@jklm.no) wrote: > This moves reduces redundancy between systemd core and the fstab-generator, by > improving and relying on the DefaultDependencies logic. Commented on two patches. The others look good, please commit those! > Functional changes: > >

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-10 Thread Tom Gundersen
On Tue, Sep 10, 2013 at 6:47 PM, Lennart Poettering wrote: > On Fri, 23.08.13 15:51, Colin Walters (walt...@verbum.org) wrote: > >> >> First, thanks for working on this, most of these patches look sane to >> me. >> >> On Fri, 2013-08-23 at 15:09 +0800, Tom Gundersen wrote: >> >> > +if (pat

Re: [systemd-devel] [PATCH resend] getty-generator: Enable getty on all active serial consoles.

2013-09-10 Thread Michael Marineau
On Tue, Sep 10, 2013 at 8:41 AM, Lennart Poettering wrote: > On Wed, 28.08.13 13:12, Michael Marineau (michael.marin...@coreos.com) > wrote: > > > This enables a getty on active kernel consoles even when they are not > > the last one specified on the kernel command line and mapped to > > /dev/cons

Re: [systemd-devel] implies "MemoryAccounting=true"

2013-09-10 Thread Lennart Poettering
On Mon, 26.08.13 11:19, Gao feng (gaof...@cn.fujitsu.com) wrote: > Hi > > The SYSTEMD.CGROUP(5) said if MemoryLimit=bytes is set for unit, it > implies MemeoryAccounting=true for this unit. > > But seems systemd didn't implement this hint. CPUShares & BlockIO have > the same problem, this is a s

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-10 Thread Colin Guthrie
'Twas brillig, and Tom Gundersen at 10/09/13 18:54 did gyre and gimble: > I'm not too keen on a blacklist. It would work for the simple case of > course, but I have seen lots of fancy/complicated stuff being mounted > in the initrd for people doing live media/install discs, which I > really don't t

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-10 Thread Lennart Poettering
On Fri, 23.08.13 15:51, Colin Walters (walt...@verbum.org) wrote: > > First, thanks for working on this, most of these patches look sane to > me. > > On Fri, 2013-08-23 at 15:09 +0800, Tom Gundersen wrote: > > > +if (path_equal(m->where, "/") || > > +path_equal(m->where, "/u

Re: [systemd-devel] [PATCH] Fix build without blkid

2013-09-10 Thread Lennart Poettering
On Mon, 26.08.13 13:06, Chengwei Yang (chengwei.y...@intel.com) wrote: > build systemd-gpt-auto-generator only if have blkid, otherwise, it will > fail. Tahnks! Already fixed now, with a pretty much identical patch from Marcel. > --- > Makefile.am |2 ++ > 1 file changed, 2 insertions(+) >

Re: [systemd-devel] [PATCH resend] getty-generator: Enable getty on all active serial consoles.

2013-09-10 Thread Lennart Poettering
On Wed, 28.08.13 13:12, Michael Marineau (michael.marin...@coreos.com) wrote: > This enables a getty on active kernel consoles even when they are not > the last one specified on the kernel command line and mapped to > /dev/console. Now the order "console=ttyS0 console=tty0" works in > addition to

Re: [systemd-devel] [PATCH 3/3] systemctl: show BlockIODeviceWeight for unit

2013-09-10 Thread Lennart Poettering
On Tue, 27.08.13 13:36, Gao feng (gaof...@cn.fujitsu.com) wrote: > We can use systemctl show unitname to show the BlockIODeviceWeight > of unit. Applied! Thanks! > --- > src/systemctl/systemctl.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/systemctl/systemc

Re: [systemd-devel] [PATCH] man: wording and grammar updates

2013-09-10 Thread Lennart Poettering
On Sun, 25.08.13 09:01, Jan Engelhardt (jeng...@inai.de) wrote: Thanks! Applied! > This includes regularly-submitted corrections to comma setting and > orthographical mishaps that appeared in man/ in recent commits. > > In this particular commit: > - the usual comma fixes > - expand contraction

Re: [systemd-devel] [PATCH] make fsck fix mode a kernel command line option

2013-09-10 Thread Colin Guthrie
'Twas brillig, and Tom Gundersen at 10/09/13 13:45 did gyre and gimble: > On Tue, Sep 10, 2013 at 2:31 PM, Jan Engelhardt wrote: >> >> On Tuesday 2013-09-10 13:52, Dave Reisner wrote: the FUSE program knows nothing about the systemd-specific "nofail" or "x-*". >>> >>> This should only be

Re: [systemd-devel] [PATCH 1/3] cgroup: setup BlockIODeviceWeight in bus_cgroup_set_property

2013-09-10 Thread Lennart Poettering
On Tue, 27.08.13 13:36, Gao feng (gaof...@cn.fujitsu.com) wrote: > This patch adds the support for setting up BlockIODeviceWeight > in bus_cgroup_set_property. most of the codes are copied from > the case that sets up DeviceAllow. Thanks! Applied! > --- > src/core/dbus-cgroup.c | 85 > +++

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-10 Thread Colin Walters
On Tue, 2013-09-10 at 18:47 +0200, Lennart Poettering wrote: > I'd actually prefer having an explicit blacklist for this, so that we > don't have to trust the initrd too much that... But nowadays it's systemd running in the initrd, what's not to trust? > However, I'd really like to see this blac

Re: [systemd-devel] [PATCH resend] getty-generator: Enable getty on all active serial consoles.

2013-09-10 Thread Michael Marineau
On Sep 10, 2013 6:41 PM, "Jan Engelhardt" wrote: > > > On Tuesday 2013-09-10 17:41, Lennart Poettering wrote: > >On Wed, 28.08.13 13:12, Michael Marineau (michael.marin...@coreos.com) wrote: > > > >> This enables a getty on active kernel consoles even when they are not > >> the last one specified

Re: [systemd-devel] [PATCH resend] getty-generator: Enable getty on all active serial consoles.

2013-09-10 Thread Jan Engelhardt
On Tuesday 2013-09-10 17:41, Lennart Poettering wrote: >On Wed, 28.08.13 13:12, Michael Marineau (michael.marin...@coreos.com) wrote: > >> This enables a getty on active kernel consoles even when they are not >> the last one specified on the kernel command line and mapped to >> /dev/console. Now t

Re: [systemd-devel] implies "MemoryAccounting=true"

2013-09-10 Thread Gao feng
On 09/10/2013 11:50 PM, Lennart Poettering wrote: > On Mon, 26.08.13 11:19, Gao feng (gaof...@cn.fujitsu.com) wrote: > >> Hi >> >> The SYSTEMD.CGROUP(5) said if MemoryLimit=bytes is set for unit, it >> implies MemeoryAccounting=true for this unit. >> >> But seems systemd didn't implement this hint

Re: [systemd-devel] [PATCH 1/3] blkio bandwidth: don't clean up all of entries in blockio_device_bandwidths list

2013-09-10 Thread Gao feng
On 09/10/2013 11:13 PM, Lennart Poettering wrote: > On Fri, 30.08.13 10:56, Gao feng (gaof...@cn.fujitsu.com) wrote: > >> if we get BlockIOReadBandwidth="", we should only remove the >> read-bandwidth-entries in blockio_device_bandwidths list. > > Thanks! Applied, though with one change: > >> +

Re: [systemd-devel] [PATCH] libsystemd-login.so: fix undefined reference to 'cg_create'

2013-09-10 Thread Yang Chengwei
On Tue, Sep 10, 2013 at 06:02:55PM +0200, Lennart Poettering wrote: > On Mon, 26.08.13 13:48, Chengwei Yang (chengwei.y...@intel.com) wrote: > > Hmm, can you elaborate on this one? libsystemd-login should be mostly This error occurs while building dbus with systemd support like below $ make make