Re: [systemd-devel] [systemd-commits] man/crypttab.xml

2013-11-27 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 25, 2013 at 12:31:24AM -0800, Lukas Nykryn wrote: > man/crypttab.xml |2 -- > 1 file changed, 2 deletions(-) > > New commits: > commit 517dcac840fe8d5bf30a05c0084eff219af10a4a > Author: Lukas Nykryn > Date: Mon Nov 25 09:31:09 2013 +0100 > > Revert "man: suggest using hash

Re: [systemd-devel] [RFC 04/12] build: add target to link binary sources

2013-11-27 Thread David Herrmann
Hi On Wed, Nov 27, 2013 at 10:31 PM, Greg KH wrote: > On Wed, Nov 27, 2013 at 07:48:39PM +0100, David Herrmann wrote: >> In several situations we want to link a binary file into our executable >> and access it from our C code. The easiest way is to transform it into a >> C-array and compile it as

Re: [systemd-devel] [systemd-commits] man/systemd-socket-proxyd.xml src/socket-proxy TODO

2013-11-27 Thread David Timothy Strauss
Wow, that was fast. I was working on my own patch to submit to the list today, but I'll just consider it an education in config and exec configuration. I'll make sure everything looks good with the CoreOS folks, too. Thanks! On Nov 28, 2013 6:17 AM, "Lennart Poettering" wrote: > On Wed, 27.11.1

Re: [systemd-devel] [RFC 02/12] ring: add basic ring-buffer helper

2013-11-27 Thread Lucas De Marchi
On Wed, Nov 27, 2013 at 4:48 PM, David Herrmann wrote: > This adds a very straightforward ring-buffer implementation to > libsystemd-shared. Ring-buffers allow pushing data to, and pulling data > from, both ends of a buffer without modifying existing/remaining buffer > content. This is very useful

Re: [systemd-devel] Seeing logging as user

2013-11-27 Thread Kay Sievers
On Thu, Nov 28, 2013 at 12:21 AM, Cecil Westerhof wrote: > I have to give a presentation about systemd/journald. One of the things I > want to show is that you do not need an administrator to see the log > messages that are generated by you. > > I did: > - makedir /var/log/journal > - systemctl ki

[systemd-devel] Seeing logging as user

2013-11-27 Thread Cecil Westerhof
I have to give a presentation about systemd/journald. One of the things I want to show is that you do not need an administrator to see the log messages that are generated by you. I did: - makedir /var/log/journal - systemctl kill -s SIGUSR1 systemd-journald As user cecil I did: printf "Cre

Re: [systemd-devel] [RFC 00/12] Bugfixes for CONFIG_VT=n

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: Looks pretty good. Commented on the invidiaul patches, but mostly looks good. I am not sure about the whole approach of making this a potentially public library though... Especially the monitor stuff sounds so specific. Commiti

Re: [systemd-devel] [RFC 12/12] console: add systemd-consoled

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: > + > +pid_t pty_new(unsigned short term_width, unsigned short term_height, > Terminal *t, Pty **out) { > +Pty *pty; > +pid_t pid; > +int fd, comm[2], slave, r; > +char d; > + > +pty = ca

Re: [systemd-devel] [RFC 08/12] gfx: add monitor

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: > While all previous sd-gfx interfaces are self-contained and can be used > directly on selected devices, this adds an interface to connect them all > together. The sd_gfx_monitor can be used to monitor a session for device > ho

Re: [systemd-devel] [RFC 07/12] gfx: add graphics layer

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: > +typedef struct gfx_config_pipe gfx_config_pipe; > +typedef struct gfx_connector gfx_connector; > +typedef struct gfx_encoder gfx_encoder; > + > +/* clock-wise framebuffer rotation */ > +enum { > +GFX_ROTATE_0, > +

Re: [systemd-devel] [RFC 06/12] gfx: add keyboard layer

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: > + > +enum { > +SD_GFX__LED_NUML, > +SD_GFX__LED_CAPSL, > +SD_GFX__LED_SCROLLL, > +SD_GFX__LED_COUNT, > +}; Double underscores? > + > +struct sd_gfx_kbd { > +char *name; > +stru

Re: [systemd-devel] [RFC 05/12] gfx: add sd-gfx library with unifont section

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: > This patch introduces sd-gfx, a systemd-internal library dealing with all > these things. Note that it is designed to be exported some day, but for > now we keep it internal. > While the library itself will be kept small and a

Re: [systemd-devel] [RFC 03/12] bus: add two new bus_*_map_*_properties() helpers

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: > +/* skip interface, but allow callers to do that themselves */ > +sd_bus_message_skip(m, "s"); This feels a bit like taping over bugs. I'd suggest adding an additional parameter "const char **interface" to the

Re: [systemd-devel] [RFC 02/12] ring: add basic ring-buffer helper

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: > +void ring_flush(Ring *r) { > +r->start = 0; > +r->end = 0; > +} > + > +void ring_clear(Ring *r) { > +free(r->buf); > +memset(r, 0, sizeof(*r)); zero(*r) is a tiny bit nicer. > +} > + > +/* >

Re: [systemd-devel] [RFC 01/12] event: allow EPOLLET as event flag

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote: Looks obvious. Applied. > EPOLLET enables edge-triggered mode (see epoll(7) for more). For most > use-cases, level-triggered is just fine, but for master-TTYs we need > edge-triggered to catch EPOLLHUP. master-TTYs signal EPOLL

Re: [systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 18:00, Lukas Nykryn (lnyk...@redhat.com) wrote: I merged a different patch that simply moves the earlier NUL byte check after the jumping over whitespace, so that we don't need two checks. I also added a test case for this, so that this doesn't break again. (That sad, the whole f

Re: [systemd-devel] [RFC 00/12] Bugfixes for CONFIG_VT=n

2013-11-27 Thread Greg KH
On Wed, Nov 27, 2013 at 07:48:35PM +0100, David Herrmann wrote: > Hi > > So booting without VTs is still a horrible experience on desktop-linux. If > anyone tried, they were presumably running away in tears. This series is a new > attempt to fix that. > > The first 4 patches are just small fixes/

Re: [systemd-devel] [RFC 04/12] build: add target to link binary sources

2013-11-27 Thread Greg KH
On Wed, Nov 27, 2013 at 07:48:39PM +0100, David Herrmann wrote: > In several situations we want to link a binary file into our executable > and access it from our C code. The easiest way is to transform it into a > C-array and compile it as usual. However, for large files (>1MB) such > compilations

Re: [systemd-devel] fstab, rootfs on btrfs

2013-11-27 Thread Chris Murphy
On Nov 27, 2013, at 12:52 PM, Lennart Poettering wrote: > On Wed, 27.11.13 12:15, Chris Murphy (li...@colorremedies.com) wrote: > >> On Nov 27, 2013, at 4:53 AM, Kay Sievers wrote: >>> >>> Right, it should not set 1 for btrfs. >> >> Since it can be mounted rw from the get go, is it going to

Re: [systemd-devel] [PATCH v2 20/26] dhcp: Handle received DHCP Offer message

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 17:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > +buflen = sizeof(DHCPPacket) + DHCP_CLIENT_MIN_OPTIONS_SIZE; > > > +buf = malloc0(buflen); > > > +if (!buf) { > > > +read(fd, &tmp, 1); > > > +return 0; > > > +

Re: [systemd-devel] [PATCH v2 19/26] dhcp: Add timeout and main loop support

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 16:57, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > Hi, > > On Tue, 2013-11-26 at 05:32 +0100, Zbigniew Jędrzejewski-Szmek wrote: > > > +static int client_timeout_resend(sd_event_source *s, uint64_t usec, > > > + void *userdata) >

Re: [systemd-devel] [PATCH v2 05/26] dhcp: Add option appending and parsing

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 16:51, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > On Tue, 2013-11-26 at 00:08 +0100, Lennart Poettering wrote: > > On Mon, 25.11.13 09:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > > > +#include > > > + > > > +#include "protocol.h" > > > + > > > +int dhc

Re: [systemd-devel] [PATCH v2 02/26] dhcp: Add DHCP client initialization

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 16:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > +int sd_dhcp_client_set_request_address(DHCPClient *client, > > > + const struct in_addr > > > *last_address); > > > > struct in_addr? Didn't you plan to use simple uint32_t for

Re: [systemd-devel] [systemd-commits] man/systemd-socket-proxyd.xml src/socket-proxy TODO

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 14:09, David Timothy Strauss (da...@davidstrauss.net) wrote: > > If this is about running multiple things in the same Network namespace, > > then there are certainly other, better ways to achieve the same. For > > example, we could introduce JoinPrivateNetwork=$SERVICE or so which

[systemd-devel] About a problem with GRUB2 rescue images and /dev/disk/by-label

2013-11-27 Thread Thomas Schmitt
Hi, the content of /dev/disk/by-label does not look right with USB sticks which carry bootable ISO 9660 images produced by GRUB2 script grub-mkrescue. The maintainer of Debian's udev package advised me to report the problem here: --- A

Re: [systemd-devel] fstab, rootfs on btrfs

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 12:15, Chris Murphy (li...@colorremedies.com) wrote: > > > On Nov 27, 2013, at 4:53 AM, Kay Sievers wrote: > > > On Wed, Nov 27, 2013 at 5:16 AM, Chris Murphy > > wrote: > >> > >> In Fedora 20, by default anaconda sets fs_passno in fstab to 1 for / on > >> btrfs. During of

Re: [systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 15:12, Hannes Reinecke (h...@suse.de) wrote: > On 11/27/2013 02:58 PM, Mantas Mikulėnas wrote: > > On Wed, Nov 27, 2013 at 3:31 PM, Hannes Reinecke wrote: > >> > >> Hi all, > >> > >> for some reason systemd has /bin/mount hardcoded in > >> src/core/mount.c:mount_enter_mounting()

Re: [systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 14:31, Hannes Reinecke (h...@suse.de) wrote: > Hi all, > > for some reason systemd has /bin/mount hardcoded in > src/core/mount.c:mount_enter_mounting() > > Which is a bit odd, seeing that everyting moved to /usr/bin. > So we always have to do a symlink here, which really is a b

Re: [systemd-devel] French translation for systemd

2013-11-27 Thread Sylvain Plantefeve
Hi Gentlemen, Just a little "ping" to get fixed the few typos in the french translation of the journal's catalog. See the patch in attachment. Thanks! 2013/11/19 Sylvain Plantefeve > You're right, my bad. > > Here is an updated patch to fix these issues. > > > Le 18 novembre 2013 17:22, Jean

Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-27 Thread Lennart Poettering
On Wed, 27.11.13 07:46, Shawn Landden (sh...@churchofgit.com) wrote: > > On Tue, Nov 26, 2013 at 7:57 PM, David Timothy Strauss > wrote: > > On Wed, Nov 27, 2013 at 7:57 AM, Shawn Landden > > wrote: > >> Are you sure applications can handle the extra file descriptor of > >> passing both the so

Re: [systemd-devel] fstab, rootfs on btrfs

2013-11-27 Thread Tom Gundersen
On Wed, Nov 27, 2013 at 8:15 PM, Chris Murphy wrote: > > On Nov 27, 2013, at 4:53 AM, Kay Sievers wrote: > >> On Wed, Nov 27, 2013 at 5:16 AM, Chris Murphy >> wrote: >>> >>> In Fedora 20, by default anaconda sets fs_passno in fstab to 1 for / on >>> btrfs. During offline updates, this is causi

Re: [systemd-devel] fstab, rootfs on btrfs

2013-11-27 Thread Chris Murphy
On Nov 27, 2013, at 4:53 AM, Kay Sievers wrote: > On Wed, Nov 27, 2013 at 5:16 AM, Chris Murphy wrote: >> >> In Fedora 20, by default anaconda sets fs_passno in fstab to 1 for / on >> btrfs. During offline updates, this is causing systemd-fstab-generator to >> freak out not finding fsck.btrf

[systemd-devel] [RFC 12/12] console: add systemd-consoled

2013-11-27 Thread David Herrmann
systemd-consoled is a very basic terminal-emulator to replace the in-kernel VT layer. It is based on libtsm as emulation layer (which itself has no external dependencies). systemd-consoled expects to be run in a logind-session. The caller must have already setup the session and prepared it for sys

[systemd-devel] [RFC 06/12] gfx: add keyboard layer

2013-11-27 Thread David Herrmann
To replace the kernel kbd layer, we need keyboard handling in user-space. The current de-facto standard is XKB and luckily, in the last 3 years there was an effort to make XKB indepedent of X11, namely libxkbcommon. libxkbcommon provides keyboard handling compatible (and even superior) to classic

[systemd-devel] [RFC 10/12] gfx: add graphics test

2013-11-27 Thread David Herrmann
The test-gfx helper simply renders a solid-color on all active pipelines. Useful to debug monitor-hotplugging and GPU selection. --- .gitignore| 1 + Makefile.am | 9 ++ src/libsystemd-gfx/test-gfx.c | 302 ++ 3 file

[systemd-devel] [RFC 11/12] gfx: add unbuilt GL test

2013-11-27 Thread David Herrmann
The test-gl helper shows how sd_gfx_card can be used to get a full OpenGL context on the device. It is not added to the build-tools as it requires mesa and might break on Khronos header-updates (yes, they break API *and* ABI compatibility often!). --- .gitignore | 1 + Makefile

[systemd-devel] [RFC 09/12] gfx: add kbd test

2013-11-27 Thread David Herrmann
The test-kbd helper simply attaches to the current session (or in case --all is passed to the system) and prints all keyboard events generated by attached keyboards. It's meant to be used to debug sd_gfx_kbd/monitor issues regarding keymap/kbd setup. --- .gitignore| 1 + Mak

[systemd-devel] [RFC 04/12] build: add target to link binary sources

2013-11-27 Thread David Herrmann
In several situations we want to link a binary file into our executable and access it from our C code. The easiest way is to transform it into a C-array and compile it as usual. However, for large files (>1MB) such compilations can take a considerable amount of time or even fail on low-memory syste

[systemd-devel] [RFC 01/12] event: allow EPOLLET as event flag

2013-11-27 Thread David Herrmann
EPOLLET enables edge-triggered mode (see epoll(7) for more). For most use-cases, level-triggered is just fine, but for master-TTYs we need edge-triggered to catch EPOLLHUP. master-TTYs signal EPOLLHUP if no client is connected, but a client may connect some time later (same happens during vhangup(2

[systemd-devel] [RFC 02/12] ring: add basic ring-buffer helper

2013-11-27 Thread David Herrmann
This adds a very straightforward ring-buffer implementation to libsystemd-shared. Ring-buffers allow pushing data to, and pulling data from, both ends of a buffer without modifying existing/remaining buffer content. This is very useful for network buffers and asynchronous writes. This implementati

[systemd-devel] [RFC 05/12] gfx: add sd-gfx library with unifont section

2013-11-27 Thread David Herrmann
If we want to interact with a user in the initrd, during emergency-situations, in single-user mode, or in any other rather limited situation, we currently rely on the kernel to do input and graphics access for us. More precisely, we rely on the VT layer to do keyboard parsing and font rendering. Or

[systemd-devel] [RFC 03/12] bus: add two new bus_*_map_*_properties() helpers

2013-11-27 Thread David Herrmann
This splits the core of bus_map_all_properties() out into a new helper called bus_message_map_all_properties(). Instead of sending a blocking dbus call, this helper takes the response message as argument and parses it. So the normal use-case is to send an async GetAll() request and once you get the

[systemd-devel] [RFC 00/12] Bugfixes for CONFIG_VT=n

2013-11-27 Thread David Herrmann
Hi So booting without VTs is still a horrible experience on desktop-linux. If anyone tried, they were presumably running away in tears. This series is a new attempt to fix that. The first 4 patches are just small fixes/helpers. Patch 5 to 8 introduce sd-gfx and patch 9-11 add tests/examples for s

Re: [systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

2013-11-27 Thread Dave Reisner
On Wed, Nov 27, 2013 at 06:45:06PM +0100, Tom Gundersen wrote: > On Wed, Nov 27, 2013 at 6:00 PM, Lukas Nykryn wrote: > > --- > > src/shared/util.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/src/shared/util.c b/src/shared/util.c > > index 3a4d196..c68ab09 10

Re: [systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

2013-11-27 Thread Tom Gundersen
On Wed, Nov 27, 2013 at 6:00 PM, Lukas Nykryn wrote: > --- > src/shared/util.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/shared/util.c b/src/shared/util.c > index 3a4d196..c68ab09 100644 > --- a/src/shared/util.c > +++ b/src/shared/util.c > @@ -383,7 +383,9 @

[systemd-devel] [PATCH] util: don't consider trailing whitespaces as an empty string in split_quoted

2013-11-27 Thread Lukas Nykryn
--- src/shared/util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/shared/util.c b/src/shared/util.c index 3a4d196..c68ab09 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -383,7 +383,9 @@ char *split_quoted(const char *c, size_t *l, char **state) {

Re: [systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Karel Zak
On Wed, Nov 27, 2013 at 04:41:27PM +0100, Kay Sievers wrote: > We support exactly two configurations: > the (conceptually pointless and confusing) legacy split-/user with > /bin/mount, and the one proper single /usr, where /bin must be a > symlink to /usr/bin. BTW, it's not about systemd only. The

Re: [systemd-devel] udev firmware loading

2013-11-27 Thread Kay Sievers
On Wed, Nov 27, 2013 at 5:04 PM, Matthias Clasen wrote: > On Wed, 2013-11-27 at 13:11 +0100, Kay Sievers wrote: > >> It would need a MESSSAGE_ID= and a few key/value pairs with the file >> name, the driver name and such to send out. The journal could get a >> service activation feature by message

Re: [systemd-devel] [PATCH 3/7] libsystemd-bus: add kdbus support for sd_bus_list_names()

2013-11-27 Thread Daniel Mack
On 11/27/2013 04:59 PM, Lukasz Skalski wrote: > My 2 cents inline. > > On 11/15/2013 07:32 PM, Daniel Mack wrote: >> kdbus will tell us the minimum buffer size it needs in case the default >> 8kb buffer doesn't suffice. >> --- >> src/libsystemd-bus/bus-control.c | 100 >> +++

Re: [systemd-devel] udev firmware loading

2013-11-27 Thread Matthias Clasen
On Wed, 2013-11-27 at 13:11 +0100, Kay Sievers wrote: > It would need a MESSSAGE_ID= and a few key/value pairs with the file > name, the driver name and such to send out. The journal could get a > service activation feature by message id ... Where does that stand, btw ? Hasn't activate-by-message

Re: [systemd-devel] [PATCH 3/7] libsystemd-bus: add kdbus support for sd_bus_list_names()

2013-11-27 Thread Lukasz Skalski
My 2 cents inline. On 11/15/2013 07:32 PM, Daniel Mack wrote: kdbus will tell us the minimum buffer size it needs in case the default 8kb buffer doesn't suffice. --- src/libsystemd-bus/bus-control.c | 100 ++- 1 file changed, 68 insertions(+), 32 deletions(

Re: [systemd-devel] [PATCH] core/socket: we only want one event on standard sockets

2013-11-27 Thread Shawn Landden
On Tue, Nov 26, 2013 at 7:57 PM, David Timothy Strauss wrote: > On Wed, Nov 27, 2013 at 7:57 AM, Shawn Landden wrote: >> Are you sure applications can handle the extra file descriptor of >> passing both the sockfd >> and the acceptfd in this case? I don't see why they wouldn't just do >> the acce

Re: [systemd-devel] [PATCH] networkd: Initialize variable to NULL

2013-11-27 Thread Tom Gundersen
On Wed, Nov 27, 2013 at 4:28 PM, Patrik Flykt wrote: > If any number of arguments are given, _cleanup_manager_free_ is used > with unitialized memory causing a crash. > --- > src/network/networkd.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/network/networkd.c

Re: [systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Kay Sievers
On Wed, Nov 27, 2013 at 3:12 PM, Hannes Reinecke wrote: > On 11/27/2013 02:58 PM, Mantas Mikulėnas wrote: >> On Wed, Nov 27, 2013 at 3:31 PM, Hannes Reinecke wrote: >>> for some reason systemd has /bin/mount hardcoded in >>> src/core/mount.c:mount_enter_mounting() >>> >>> Which is a bit odd, seei

[systemd-devel] [PATCH] networkd: Initialize variable to NULL

2013-11-27 Thread Patrik Flykt
If any number of arguments are given, _cleanup_manager_free_ is used with unitialized memory causing a crash. --- src/network/networkd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/networkd.c b/src/network/networkd.c index 1d43361..360afba 100644 --- a/src/ne

Re: [systemd-devel] [PATCH v2 20/26] dhcp: Handle received DHCP Offer message

2013-11-27 Thread Patrik Flykt
Hi, On Tue, 2013-11-26 at 00:23 +0100, Lennart Poettering wrote: > On Mon, 25.11.13 09:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > +static int client_receive_raw_message(sd_event_source *s, int fd, > > + uint32_t revents, void *userda

Re: [systemd-devel] [PATCH v2 19/26] dhcp: Add timeout and main loop support

2013-11-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Nov 27, 2013 at 04:57:19PM +0200, Patrik Flykt wrote: > > Hi, > > On Tue, 2013-11-26 at 05:32 +0100, Zbigniew Jędrzejewski-Szmek wrote: > > > +static int client_timeout_resend(sd_event_source *s, uint64_t usec, > > > + void *userdata) > > > +{ > ... >

Re: [systemd-devel] [PATCH v2 05/26] dhcp: Add option appending and parsing

2013-11-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Nov 27, 2013 at 04:51:42PM +0200, Patrik Flykt wrote: > On Tue, 2013-11-26 at 00:08 +0100, Lennart Poettering wrote: > > On Mon, 25.11.13 09:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > +static int parse_options(uint8_t *buf, int32_t buflen, int *overload, > > > >

Re: [systemd-devel] [PATCH v2 12/26] dhcp: Add function for sending a raw packet

2013-11-27 Thread Patrik Flykt
On Tue, 2013-11-26 at 00:10 +0100, Lennart Poettering wrote: > On Mon, 25.11.13 09:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > +int dhcp_network_send_raw_packet(int index, void *packet, int len); > > Should be "const void* packet", no? > > And "size_t len", no? Indeed.

Re: [systemd-devel] [PATCH v2 23/26] dhcp: Process DHCP Ack/Nak message

2013-11-27 Thread Patrik Flykt
On Tue, 2013-11-26 at 00:26 +0100, Lennart Poettering wrote: > On Mon, 25.11.13 09:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > -static int client_receive_offer(DHCPClient *client, > > -DHCPPacket *offer, int len) > > +static int client_verify_header

Re: [systemd-devel] [PATCH v2 19/26] dhcp: Add timeout and main loop support

2013-11-27 Thread Patrik Flykt
Hi, On Tue, 2013-11-26 at 05:32 +0100, Zbigniew Jędrzejewski-Szmek wrote: > > +static int client_timeout_resend(sd_event_source *s, uint64_t usec, > > + void *userdata) > > +{ ... > > + > > +return 0; > > + > > +error: > > +client_stop(clien

Re: [systemd-devel] [PATCH v2 19/26] dhcp: Add timeout and main loop support

2013-11-27 Thread Patrik Flykt
On Tue, 2013-11-26 at 00:15 +0100, Lennart Poettering wrote: > On Mon, 25.11.13 09:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > -DHCPClient *sd_dhcp_client_new(void) > > +DHCPClient *sd_dhcp_client_new(sd_event *event) > > { > > DHCPClient *client; > > > > +asse

Re: [systemd-devel] [PATCH v2 05/26] dhcp: Add option appending and parsing

2013-11-27 Thread Patrik Flykt
Hi, On Tue, 2013-11-26 at 00:08 +0100, Lennart Poettering wrote: > On Mon, 25.11.13 09:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > +#include > > + > > +#include "protocol.h" > > + > > +int dhcp_option_append(uint8_t **buf, int *buflen, uint8_t code, > >

Re: [systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Nov 27, 2013 at 03:12:02PM +0100, Hannes Reinecke wrote: > On 11/27/2013 02:58 PM, Mantas Mikulėnas wrote: > > On Wed, Nov 27, 2013 at 3:31 PM, Hannes Reinecke wrote: > >> > >> Hi all, > >> > >> for some reason systemd has /bin/mount hardcoded in > >> src/core/mount.c:mount_enter_mounting(

Re: [systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Colin Guthrie
'Twas brillig, and Hannes Reinecke at 27/11/13 14:12 did gyre and gimble: > On 11/27/2013 02:58 PM, Mantas Mikulėnas wrote: >> On Wed, Nov 27, 2013 at 3:31 PM, Hannes Reinecke wrote: >>> >>> Hi all, >>> >>> for some reason systemd has /bin/mount hardcoded in >>> src/core/mount.c:mount_enter_mounti

Re: [systemd-devel] [PATCH v2 02/26] dhcp: Add DHCP client initialization

2013-11-27 Thread Tom Gundersen
On Wed, Nov 27, 2013 at 3:13 PM, Patrik Flykt wrote: > > Hi, > > On Mon, 2013-11-25 at 23:59 +0100, Lennart Poettering wrote: >> On Mon, 25.11.13 09:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: >> >> > + >> > +DHCPClient *sd_dhcp_client_new(void) >> > +{ >> > +DHCPClient

Re: [systemd-devel] [PATCH v2 00/26] Initial DHCP v4 library implementation

2013-11-27 Thread Patrik Flykt
Hi, On Mon, 2013-11-25 at 23:52 +0100, Lennart Poettering wrote: > Of course, timer callbacks should only be called once, ence ONESHOT > mode is the default -- unless you change that explicitly. Event loop code said ONESHOT for timers, and I don't think I managed to change that. > If t

Re: [systemd-devel] [PATCH v2 02/26] dhcp: Add DHCP client initialization

2013-11-27 Thread Patrik Flykt
Hi, On Mon, 2013-11-25 at 23:59 +0100, Lennart Poettering wrote: > On Mon, 25.11.13 09:13, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: > > > + > > +DHCPClient *sd_dhcp_client_new(void) > > +{ > > +DHCPClient *client; > > + > > +client = new0(DHCPClient, 1); > > +

Re: [systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Hannes Reinecke
On 11/27/2013 02:58 PM, Mantas Mikulėnas wrote: > On Wed, Nov 27, 2013 at 3:31 PM, Hannes Reinecke wrote: >> >> Hi all, >> >> for some reason systemd has /bin/mount hardcoded in >> src/core/mount.c:mount_enter_mounting() >> >> Which is a bit odd, seeing that everyting moved to /usr/bin. >> So we a

Re: [systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Mantas Mikulėnas
On Wed, Nov 27, 2013 at 3:31 PM, Hannes Reinecke wrote: > > Hi all, > > for some reason systemd has /bin/mount hardcoded in > src/core/mount.c:mount_enter_mounting() > > Which is a bit odd, seeing that everyting moved to /usr/bin. > So we always have to do a symlink here, which really is a bit ann

[systemd-devel] Hard-coded /bin/mount in systemd

2013-11-27 Thread Hannes Reinecke
Hi all, for some reason systemd has /bin/mount hardcoded in src/core/mount.c:mount_enter_mounting() Which is a bit odd, seeing that everyting moved to /usr/bin. So we always have to do a symlink here, which really is a bit annoying. Is this by design or a simple left-over? Cheers, Hannes -- D

Re: [systemd-devel] udev firmware loading

2013-11-27 Thread Kay Sievers
On Wed, Nov 27, 2013 at 1:02 PM, Tom Gundersen wrote: > Couldn't the kernel simply log (one of these new fance structured log > messages it now supports) whenever it fails to load a piece of > firmware? Yes, drivers could explicitly log fatal failures, ones they cannot recover from without firmw

Re: [systemd-devel] udev firmware loading

2013-11-27 Thread Kay Sievers
On Wed, Nov 27, 2013 at 12:53 PM, Martin Pitt wrote: > Kay Sievers [2013-11-27 12:47 +0100]: >> All of that is gone and will not come back, udev has no idea about >> device firmware and does no longer want to know about it. There is no >> way to tell these days what firmware was requested or loade

Re: [systemd-devel] udev firmware loading

2013-11-27 Thread Tom Gundersen
On Wed, Nov 27, 2013 at 12:53 PM, Martin Pitt wrote: > Kay Sievers [2013-11-27 12:47 +0100]: >> All of that is gone and will not come back, udev has no idea about >> device firmware and does no longer want to know about it. There is no >> way to tell these days what firmware was requested or loade

Re: [systemd-devel] udev firmware loading

2013-11-27 Thread Martin Pitt
Kay Sievers [2013-11-27 12:47 +0100]: > All of that is gone and will not come back, udev has no idea about > device firmware and does no longer want to know about it. There is no > way to tell these days what firmware was requested or loaded, it's all > happening in the kernel only. > > Unless we

Re: [systemd-devel] fstab, rootfs on btrfs

2013-11-27 Thread Kay Sievers
On Wed, Nov 27, 2013 at 5:16 AM, Chris Murphy wrote: > > In Fedora 20, by default anaconda sets fs_passno in fstab to 1 for / on > btrfs. During offline updates, this is causing systemd-fstab-generator to > freak out not finding fsck.btrfs. > > https://bugzilla.redhat.com/show_bug.cgi?id=1034563

Re: [systemd-devel] udev firmware loading

2013-11-27 Thread Kay Sievers
On Wed, Nov 27, 2013 at 10:31 AM, Richard Hughes wrote: > I've been porting a lot of the gnome-packagekit functionality to > gnome-software these last few months. One thing that used to work > well, but I've not seen a bugreport about in *years* is the > install-package-for-missing-firmware thing

[systemd-devel] [PATCH] updates for TODO and README

2013-11-27 Thread Lukasz Skalski
* library support for setns() system call was added to glibc version 2.14 (setns() call is use in src/machine/machinectl.c and src/libsystemd-bus-container.c) * utf8 validation call are already exported (via sd-utf8.c file) - commit - 369c583b3fb3d672ef469d53141e274ec9d2e8a7 --- README |1 +

Re: [systemd-devel] udev firmware loading

2013-11-27 Thread Colin Guthrie
'Twas brillig, and Richard Hughes at 27/11/13 09:31 did gyre and gimble:> Hi all, > > I've been porting a lot of the gnome-packagekit functionality to > gnome-software these last few months. One thing that used to work > well, but I've not seen a bugreport about in *years* is the > install-package-

[systemd-devel] udev firmware loading

2013-11-27 Thread Richard Hughes
Hi all, I've been porting a lot of the gnome-packagekit functionality to gnome-software these last few months. One thing that used to work well, but I've not seen a bugreport about in *years* is the install-package-for-missing-firmware thing. IIRC, udev used to call /lib/udev/firmware.sh which us