[systemd-devel] [PATCH] journal: Add missing byte order conversions

2013-12-31 Thread George McCollister
Convert entry_array.items[0] to host byte order prior to passing it to chain_cache_put(). Signed-off-by: George McCollister --- src/journal/journal-file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/journal/journal-file.c b/src/journal/journal-file.c index

[systemd-devel] [PATCH 1/2] journald: fix vacuuming of archived journals

2013-09-04 Thread George McCollister
d_name is modified on line 227 so if the entire journal name is needed again p must be used. Before this change when journal_file_empty was called on archived journals it would always return with -2. Signed-off-by: George McCollister --- src/journal/journal-vacuum.c | 10 +- 1 file

[systemd-devel] [PATCH 2/2] journald: fix fd leak in journal_file_empty

2013-09-04 Thread George McCollister
Before my previous patch, journal_file_empty wasn't be called with the correct filename. Now that it's being called with the correct filename it leaks file descriptors. This patch closes the file descriptors before returning. Signed-off-by: George McCollister --- src/journal/journa

[systemd-devel] [PATCH] journald: fix vacuuming of archived journals

2013-08-27 Thread George McCollister
d_name is modified on line 227 so if the entire journal name is needed again p must be used. Before this change when journal_file_empty was called on archived journals it would always return with -2. Signed-off-by: George McCollister --- src/journal/journal-vacuum.c | 10 +- 1 file

[systemd-devel] [PATCH] fixed hashmap leaks in mmap-cache

2013-08-01 Thread George McCollister
hashmap_free() wasn't being called on m->contexts and m->fds resulting in a leak. To reproduce do: while(1) { sd_journal_open(&j, SD_JOURNAL_LOCAL_ONLY); sd_journal_close(j); } Memory usage will increase until OOM. Signed

[systemd-devel] [PATCH] ignore keep_free when creating a new journal

2013-04-26 Thread George McCollister
imple change. Signed-off-by: George McCollister --- src/journal/journal-file.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/journal/journal-file.c b/src/journal/journal-file.c index a44e126..f720d0b 100644 --- a/src/journal/journal-file.c +++ b/src/journal/journal-file.c @@ -2

Re: [systemd-devel] Socket is dying, how to automatically restart it?

2013-04-23 Thread George McCollister
On 04/20/2013 08:04 AM, Koen Kooi wrote: Op 18 apr. 2013, om 19:18 heeft George McCollister het volgende geschreven: On 04/10/2013 12:03 PM, Koen Kooi wrote: Hi, I have a bit of a heisenbug where dropbear.socket will just die and needs a systemctl restart dropbear.socket. I can't tel

Re: [systemd-devel] Socket is dying, how to automatically restart it?

2013-04-18 Thread George McCollister
a netstat after it dies (just says dead no useful information) and port 22 still shows up under listening. systemctl start sshd.socket fixes the problem. I just upgraded to systemd 201 so I'll let you know if the problem shows up again. The problem happens intermittently so its be

[systemd-devel] Future of systemd Python module

2013-01-22 Thread George McCollister
Are there plans (or desire) to expand the Python module included with systemd beyond Journal? Is there desire to replicate or wrap functionality provided by the DBUS API or is this beyond the design scope of this module? Regards, George McCollister