Hi,
On 10/02/15 13:30, Lennart Poettering wrote:
On Sun, 08.02.15 22:21, Philippe De Swert (philippedesw...@gmail.com) wrote:
In user_mkdir_runtime_path() there is no need to continue if the
creation of the directory fails for whatever reason, as subsequent
actions on that directory
As a malloc0 could fail, doing a strncpy without checking could
cause issues. Adding an assert should be good enough and in line
with other similar routines in the code.
Found with Coverity Fixes: CID#1261402
---
src/libsystemd-network/test-lldp.c | 1 +
1 file changed, 1 insertion(+)
diff
In user_mkdir_runtime_path() there is no need to continue if the
creation of the directory fails for whatever reason, as subsequent
actions on that directory will fail anyway.
Found with Coverity. Fixes: CID#1237538
---
src/login/logind-user.c | 3 ++-
1 file changed, 2 insertions(+), 1
Fix some resources leaks in test-lldp found with coverity:
CID#1261388, CID#1261385, CID#1261383
---
src/libsystemd-network/test-lldp.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/libsystemd-network/test-lldp.c
b/src/libsystemd-network/test-lldp.c
index
The variable r is already checked one time before and the same error returned.
So the second check is unneeded.
---
src/machine/machinectl.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c
index 0abc251..951b3cc 100644
---
When doing make clean the unit/machines.target file gets deleted.
This causes a build error later on when trying to rebuild systemd.
---
Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 28d2e4b..e1e0843 100644
--- a/Makefile.am
+++ b/Makefile.am
@@
When doing make clean the unit/machines.target file gets deleted.
This causes a build error later on when trying to rebuild systemd.
V2: The file probably belongs to dist_systemunit_DATA
---
Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.am
Hi,
On 17/10/14 02:09, Zbigniew Jędrzejewski-Szmek wrote:
On Fri, Oct 17, 2014 at 12:43:52AM +0300, philippedesw...@gmail.com wrote:
From: Philippe De Swert philippedesw...@gmail.com
Removes the following compilation warning:
src/shared/util.c: In function 'rm_rf_children_dangerous':
src
Hi,
On 22/09/14 15:58, Reindl Harald wrote:
Am 22.09.2014 um 14:44 schrieb Jóhann B. Guðmundsson:
Then file a bug report against rsyslog and provide a patch which fixes
the default log filtering in Fedora to your expectation but leave
systemd out of it.
wow - in any other case the
Hi,
On 18/09/14 17:13, Emil Renner Berthing wrote:
On 18 September 2014 16:10, Jóhann B. Guðmundsson johan...@gmail.com
wrote:
On 09/18/2014 01:24 PM, Emil Renner Berthing wrote:
The real reason is of course that I'd like to see systemd running
on my router and other small devices that
Hi all,
Just a short update to point out again that I am now making regular
coverity scans of systemd. If you want to check them out go to
http://scan.coverity.com (unfortunately requires an account to join
and see the actual defects)
Otherwise it seems to have already led to some healthy
Hi Thomas,
On 16/09/14 08:56, Thomas H.P. Andersen wrote:
Yesterday I finally got to revive the systemd Coverity project on
scan.coverity.org Unfortunately to see the errors reported you need
to sign up, but I will make sure to approve requests for seeing the
bugs whenever they show up.
Hi
Hi Thomas,
On 17/09/14 00:36, Thomas H.P. Andersen wrote:
We only break out of the pre-ceding loop into the rest of the code
if fd is actually = 0. So the 0 check will never be true and
not necessary.
Found with Coverity. Fixes: CID#1237577
I pushed a fix for this one 20 minutes ago. (I
Hi David,
On 11/09/14 18:43, David Herrmann wrote:
Hi
_public_ int sd_journal_sendv(const struct iovec *iov, int n) {
PROTECT_ERRNO;
-int fd;
+_cleanup_close_ int fd = -1;
This does not work. fd is used to hold the journal fd, but this is a
global fd shared
Hi,
On 10/09/14 13:12, Thomas H.P. Andersen wrote: On Wed, Sep 10, 2014 at
11:20 AM, philippedesw...@gmail.com wrote:
Yesterday I finally got to revive the systemd Coverity project on
scan.coverity.org Unfortunately to see the errors reported you need
to sign up, but I will make sure to
Hi,
On 10/09/14 13:30, Mantas Mikulėnas wrote:
On Wed, Sep 10, 2014 at 1:20 PM, Philippe De Swert
On a side note I noticed this mail :
http://permalink.gmane.org/gmane.comp.sysutils.systemd.devel/6248
Talking about some freeing macros. I noticed there seem to be some
here and there. So
From: Philippe De Swert philippedesw...@gmail.com
Hi,
Going through the code trying to learn how systemd exactly works and
try to understand the mounting better, hunting down some weird mount
related bug I came across something that did not look right.
If I understood things right, basic
From: Philippe De Swert philippedesw...@gmail.com
Smack mounts /run with some different parameters, we definitely
do not want to have a second mount over it afterwards
Signed-off-by: Philippe De Swert philippedesw...@gmail.com
---
src/core/mount-setup.c | 3 ++-
1 file changed, 2 insertions
options to
journalctl and the important bit is cut off.
If you guys are willing to also consider those other two gripes I will
glady submit patches for those also.
Regards,
Philippe
From b4c8bd945bc987edd64702e781daea2caff8eeab Mon Sep 17 00:00:00 2001
From: Philippe De Swert philippe.desw
Chevalier wrote:
2014-08-18 13:46 GMT+02:00 Philippe De Swert philippedesw...@gmail.com:
Having to often use journalctl it has slowly driven me insane with the
default options not matching common use cases.
Attached is already a patch to start the journal at the end. Usually people
check the logs
Hi,
Thanks for answering.
On 18/08/14 16:27, Lennart Poettering wrote:
On Mon, 18.08.14 14:46, Philippe De Swert (philippedesw...@gmail.com) wrote:
Well, its more complex than that. I know that a lot of people do
journalctl -b more often than journalctl -e. I really don#t want
21 matches
Mail list logo
