Re: [systemd-devel] How to get used to systemd vs init

On Wed, Jun 24, 2015 at 8:53 AM, Chad wrote: > Killermoehre, > Thank you for your time and reply. > > I intend to do exactly that when I start using systemd (I am still using > init.d at the moment). In fact I have already suggested that very thing on > the fail2ban mailing list so that can add it

Re: [systemd-devel] How to get used to systemd vs init

On Wed, Jun 24, 2015 at 1:37 AM, Chad wrote: > Oh, wait this is the reverse of what I want/need (systemd-sysv-generator > goes from init.d to systemd, I need from systemd to init.d). > I have a nagios script that runs something like: > /etc/init.d/httpd status > It then reads the output and makes

Re: [systemd-devel] How to get used to systemd vs init

On Wed, Jun 24, 2015 at 1:07 AM, Chad wrote: > Mr. Chevalier, > Thank you for your time and reply. > > On 6/23/2015 1:30 PM, Ronny Chevalier wrote: >> >> On Tue, Jun 23, 2015 at 9:45 PM, Chad wrote: >>> >>> I am sure this is the wrong place to

Re: [systemd-devel] How to get used to systemd vs init

On Tue, Jun 23, 2015 at 10:16 PM, Chad wrote: > On 6/23/2015 1:01 PM, Reindl Harald wrote: >> >> >> >> Am 23.06.2015 um 21:45 schrieb Chad: >>> >>> The new systemd way would be to type (23 total characters, no tab >>> complete): >>> systemctl restart httpd >>> Maybe I could tab complete systemctl,

Re: [systemd-devel] How to get used to systemd vs init

On Tue, Jun 23, 2015 at 9:45 PM, Chad wrote: > I am sure this is the wrong place to send this e-mail, but I could not find > another place to send it. Hi, It is the good place :) > I want to learn and use systemd, but have run into a few problems on my way. > Please don't see this as an attack

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

On Fri, Jun 12, 2015 at 5:30 AM, Filipe Brandenburger wrote: > On Thu, Jun 11, 2015 at 12:31 PM, Ronny Chevalier > wrote: >> On Thu, Jun 11, 2015 at 6:31 PM, Filipe Brandenburger >> wrote: >>> Another downside of adding comments to the commits is that e-mail >>

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

On Thu, Jun 11, 2015 at 6:31 PM, Filipe Brandenburger wrote: > On Wed, Jun 10, 2015 at 9:52 AM, Lennart Poettering > wrote: >> On Wed, 10.06.15 08:25, Filipe Brandenburger (filbran...@google.com) wrote: >>> On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy wrote: >>> > FWIW it only loses the comment

Re: [systemd-devel] Static test coverage

On Thu, Jun 11, 2015 at 11:07 AM, Daniel Mack wrote: > Hi, > > Now that we're using Semaphore CI for building all pull requests and > pushes to the master branch, I've set up a second VM instance to also > use their service for static code analysis on a nightly base. > > We've had the systemd proj

Re: [systemd-devel] Is SystemCallFilter working for you?

On Tue, Jun 9, 2015 at 1:00 PM, Martin Pitt wrote: > Hello all, > > I was about to (re-)enable seccomp support in our systemd packages, > and to write an integration test for it. However, it seems that this > currently does not seem to work at all. > > config.h has HAVE_SECCOMP==1, and systemctl -

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

On Tue, Jun 2, 2015 at 1:06 PM, David Herrmann wrote: > Hi > > On Mon, Jun 1, 2015 at 8:12 PM, David Herrmann wrote: >> Hi >> >> As of today we've disabled git-push to fd.o. The official development >> git repository is now at github [1]. The old repository will still be >> back-synced, but we ha

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

On Mon, Jun 1, 2015 at 8:12 PM, David Herrmann wrote: > Hi > > As of today we've disabled git-push to fd.o. The official development > git repository is now at github [1]. The old repository will still be > back-synced, but we had to disable push-access to avoid getting > out-of-sync with github.

Re: [systemd-devel] [PATCH 0/9] Allow \: escapes in nspawn command line

On Thu, May 28, 2015 at 2:02 PM, Richard Maw wrote: > File paths may contain : characters, and the nspawn command-line argument > parser had no way of being able to tell which were part of the paths, or used > to separate paths. > > This is fixable by introducing an escaping mechanism. > > The --o

Re: [systemd-devel] [systemd-commits] 4 commits - src/core src/libsystemd src/systemctl src/udev

On Wed, Apr 15, 2015 at 3:51 AM, Zbigniew Jędrzejewski-Szmek wrote: > src/core/selinux-access.c | 31 - > src/libsystemd/sd-device/device-private.h |2 - > src/systemctl/systemctl.c | 11 + > src/udev/udev-builtin-usb_id.c

Re: [systemd-devel] [PATCH] po: update French translation

On Wed, Apr 8, 2015 at 12:40 AM, Sylvain Plantefève wrote: > Add strings introduced by 5bdf22430e367799dfa66c724144b624c5479518 > --- > po/fr.po | 20 +--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/po/fr.po b/po/fr.po > index f26451f..69862fb 100644 > ---

Re: [systemd-devel] [PATCH] po: update French translation

Hi Sylvain, On Tue, Apr 7, 2015 at 8:26 PM, Sylvain Plantefève wrote: > Add strings introduced by 5bdf22430e367799dfa66c724144b624c5479518 > --- > po/fr.po | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/po/fr.po b/po/fr.po > index f26451f..3111c49 10

Re: [systemd-devel] systemctl edit TODO item

2015-03-18 13:39 GMT+01:00 Daniele Nicolodi : > On 18/03/15 10:09, Zbigniew Jędrzejewski-Szmek wrote: >> On Wed, Mar 18, 2015 at 12:13:39PM +0100, Ronny Chevalier wrote: >>> Hi, >>> >>> About the TODO item of systemctl edit: >>> "Upon editor exit,

Re: [systemd-devel] systemctl edit TODO item

2015-03-18 10:09 GMT+01:00 Zbigniew Jędrzejewski-Szmek : > On Wed, Mar 18, 2015 at 12:13:39PM +0100, Ronny Chevalier wrote: >> Hi, >> >> About the TODO item of systemctl edit: >> "Upon editor exit, lines with one # are removed, lines with two # are >> left

[systemd-devel] systemctl edit TODO item

Hi, About the TODO item of systemctl edit: "Upon editor exit, lines with one # are removed, lines with two # are left with one #, etc." I don't really agree, because if you have some comments in your drop-in file, you will have to remember every time you edit it to prepend one # to each one of yo

Re: [systemd-devel] [PATCH 6/6] refactor in_addr_to_string()

2015-03-11 16:13 GMT+01:00 Shawn Landden : > --- Hi, > src/resolve/resolved-dns-rr.c | 6 ++ > src/shared/in-addr-util.c | 32 +++- > 2 files changed, 13 insertions(+), 25 deletions(-) > > diff --git a/src/resolve/resolved-dns-rr.c b/src/resolve/resolved-dns-

Re: [systemd-devel] [PATCH] path-lookup: use secure_getenv()

2015-03-16 18:31 GMT+01:00 David Herrmann : > Hi > > On Sun, Mar 15, 2015 at 12:36 PM, Ronny Chevalier > wrote: >> 2015-03-15 3:27 GMT+01:00 Shawn Landden : >>> All these except user_data_home_dir() are certainly vectors for >>> arbitrary code execu

Re: [systemd-devel] [PATCH] fix compiler warning

2015-03-14 17:54 GMT+01:00 Shawn Landden : > On Sat, Mar 14, 2015 at 6:31 AM, Ronny Chevalier > wrote: >> >> 2015-03-11 4:42 GMT+01:00 Shawn Landden : >> > warning: pointer/integer type mismatch in conditional expression >> > --- >> > src/shared/s

Re: [systemd-devel] [PATCH] path-lookup: use secure_getenv()

2015-03-15 3:27 GMT+01:00 Shawn Landden : > All these except user_data_home_dir() are certainly vectors for > arbitrary code execution. These should use secure_getenv() > --- Hi, I don't see why secure_getenv() is appropriate here? These functions are never used in the libraries systemd provides,

Re: [systemd-devel] [PATCH 1/6] fix strict aliasing issues in src/udev/udev-ctrl.c

2015-03-11 16:13 GMT+01:00 Shawn Landden : > it is ironic that > "The only purpose of this structure is to cast the structure pointer > passed in addr in order to avoid compiler warnings. See EXAMPLE below." > from bind(2) > --- > src/udev/udev-ctrl.c | 19 ++- > 1 file changed, 1

Re: [systemd-devel] [PATCH] fix strict aliasing issue in src/libsystemd-network/sd-dhcp-client.c

2015-03-11 4:45 GMT+01:00 Shawn Landden : > --- > src/libsystemd-network/sd-dhcp-client.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/src/libsystemd-network/sd-dhcp-client.c > b/src/libsystemd-network/sd-dhcp-client.c > index 4224e01..a477ccc 100644 > ---

Re: [systemd-devel] [PATCH] fix compiler warning

2015-03-11 4:42 GMT+01:00 Shawn Landden : > warning: pointer/integer type mismatch in conditional expression > --- > src/shared/socket-util.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/shared/socket-util.c b/src/shared/socket-util.c > index 5820279..73e1177 10

Re: [systemd-devel] [PATCH] add REMOTE_ADDR and REMOTE_PORT for Accept=yes

2015-03-10 12:41 GMT+01:00 Shawn Landden : > --- > TODO | 2 - > man/systemd.socket.xml | 7 ++- > src/core/service.c | 41 - > src/libsystemd/sd-resolve/test-resolve.c | 2 +- > src/shared/socket-util.c

Re: [systemd-devel] [PATCH 1/3] Allow systemd-tmpfiles to set the file/directory attributes

2015-03-10 0:17 GMT+01:00 Goffredo Baroncelli : > On 2015-03-08 15:00, Ronny Chevalier wrote: >> 2015-03-08 12:48 GMT+01:00 Goffredo Baroncelli : >>> From: Goffredo Baroncelli >>> >> >> Hi, >> >>> Allow systemd-tmpfiles to set the file/d

Re: [systemd-devel] [PATCH] add REMOTE_ADDR and REMOTE_PORT for Accept=yes

2015-03-09 23:09 GMT+01:00 Shawn Landden : > On Mon, Mar 9, 2015 at 1:18 PM, Lennart Poettering > wrote: >> >> On Mon, 09.03.15 13:09, Shawn Landden (sh...@churchofgit.com) wrote: >> >> > +if (UNIT_DEREF(s->accept_socket)) { >> > +union sockaddr_union sa; >> > +

Re: [systemd-devel] [PATCH] po: update French translation

2015-03-09 18:36 GMT+01:00 Sylvain Plantefève : > Add strings for importd, following 587fec427c80b6c34dcf1d7570f891fcb652a7c5 Hi, Patch applied, thanks! Ronny > --- > po/fr.po | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/po/fr.po b/po/fr.po > in

Re: [systemd-devel] [PATCH] tmpfiles: port to unquote_many_words()

2015-03-09 18:51 GMT+01:00 daurnimator : Hi, > --- > TODO| 2 -- > man/tmpfiles.d.xml | 2 ++ > src/tmpfiles/tmpfiles.c | 24 ++-- > 3 files changed, 12 insertions(+), 16 deletions(-) > > diff --git a/TODO b/TODO > index 60efaaf..4d5e2b6 100644 > --

Re: [systemd-devel] [PATCH 2/3] Update the man page of tmpfiles.d(5), to document the new h/H command.

2015-03-08 12:48 GMT+01:00 Goffredo Baroncelli : > From: Goffredo Baroncelli > > Update the man page of tmpfiles.d(5), to document the new h/H command. > > Signed-off-by: Goffredo Baroncelli No Signed-off-by. Also, why not merge the 3 commits in one ? I don't see why separating the man page upd

Re: [systemd-devel] [PATCH 1/3] Allow systemd-tmpfiles to set the file/directory attributes

2015-03-08 12:48 GMT+01:00 Goffredo Baroncelli : > From: Goffredo Baroncelli > Hi, > Allow systemd-tmpfiles to set the file/directory attributes, like chattr(1) > does. Two more commands are added: 'H' and 'h' to set the attributes, > recursively and not. > > Signed-off-by: Goffredo Baroncelli

Re: [systemd-devel] [PATCH] po: update French translation

Le 19 février 2015 23:31, Sylvain Plantefève a écrit : > --- > po/fr.po | 76 > +--- > 1 file changed, 68 insertions(+), 8 deletions(-) > > diff --git a/po/fr.po b/po/fr.po > index 8e44e0c..58a0b85 100644 > --- a/po/fr.po > +++ b/po/fr.

Re: [systemd-devel] [PATCH] po: update French translation

Hi, Le 19 février 2015 20:47, Sylvain Plantefève a écrit : > --- > po/fr.po | 76 > +--- > 1 file changed, 68 insertions(+), 8 deletions(-) > > diff --git a/po/fr.po b/po/fr.po > index 8e44e0c..e0257cb 100644 > --- a/po/fr.po > +++ b/p

Re: [systemd-devel] Removing unnecessary includes

2015-02-07 14:05 GMT+01:00 Daniele Nicolodi : > On 07/02/15 10:29, Thomas H.P. Andersen wrote: >> I am looking at ways to automatically trim the unnecessary includes. >> One way to do it is a script[1] which simply tests if the compile >> still works after removing each include one at a time. It do

Re: [systemd-devel] [PATCH 0/2] Update french translations

2015-01-22 21:51 GMT+01:00 Sylvain Plantefève : > Hi folks, Hi, > > These pathes update the french translations of both systemd itself (fr.po) > and the catalog, to follow the changes > from 3d7415f43f0fe6a821d7bc4a341ba371e8a30ef3 and > 2057124e7910c4cab7e53d26e0c3749d326ae2bb respectively. >

Re: [systemd-devel] [PATCH] units: move machines.target to dist_systemunit_DATA

2014-12-30 0:22 GMT+01:00 Filipe Brandenburger : > Move units/machines.target from nodist_systemunit_DATA to > dist_systemunit_DATA, > since it's not a generated file. Otherwise, `make clean` would remove the > committed copy of the file. > > Tested that `./autogen.sh c` will not remove it and tha

Re: [systemd-devel] [PATCH] fix zsh completion typo

2015-01-14 15:33 GMT+01:00 Moez Bouhlel : > json-see => json-sse > > --- > shell-completion/zsh/_sd_outputmodes | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/shell-completion/zsh/_sd_outputmodes > b/shell-completion/zsh/_sd_outputmodes > index 2ce84a7..3836f79 100644 >

Re: [systemd-devel] Using `systemctl edit` on "invalid" unit names

2014-12-13 11:33 GMT+01:00 Ivan Shapovalov : > Hello all, Hi, > > it seems that the newly added `systemctl edit` command requires its arguments > to be valid unit names. > > This causes `edit` operation to fail in apparently valid use-cases like > > systemctl edit getty@.service This is fixe

Re: [systemd-devel] [PATCH] localed: forward xkbcommon errors

2014-12-02 14:02 GMT+01:00 Jan Synacek : Hi, > The errors are prefixed with "libxkbcommon", because they are quite > confusing. With the prefix, we at least know where they come from. > --- > src/locale/localed.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --

Re: [systemd-devel] [PATCH] man: fix link to systemd-networkd-wait-online.service in systemd-networkd.service(8)

2014-11-30 15:44 GMT+01:00 Chris Mayo : > > --- > man/systemd-networkd.service.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/systemd-networkd.service.xml > b/man/systemd-networkd.service.xml > index 0570798..7c20fa4 100644 > --- a/man/systemd-networkd.service.xm

Re: [systemd-devel] [PATCH] man: add a link to systemd-coredump(8) in Description of coredump.conf(5)

2014-11-30 15:45 GMT+01:00 Chris Mayo : > > --- > man/coredump.conf.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/coredump.conf.xml b/man/coredump.conf.xml > index 37916f0..fe7479f 100644 > --- a/man/coredump.conf.xml > +++ b/man/coredump.conf.xml > @@ -59,7 +59,

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-11-28 23:41 GMT+01:00 Zbigniew Jędrzejewski-Szmek : > On Fri, Nov 28, 2014 at 09:48:55PM +0100, Ronny Chevalier wrote: >> 2014-10-29 16:22 GMT+01:00 Ronny Chevalier : >> > It helps editing units by either creating a drop-in file, like >> > /etc/systemd/system/my.ser

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-29 16:22 GMT+01:00 Ronny Chevalier : > It helps editing units by either creating a drop-in file, like > /etc/systemd/system/my.service.d/override.conf, or by copying the > original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full > option is specified. > > It in

Re: [systemd-devel] [PATCH 2/2] tty-ask-password-agent: fix CID 996261

2014-11-17 19:36 GMT+01:00 Greg KH : > On Mon, Nov 17, 2014 at 06:47:33PM +0100, Ronny Chevalier wrote: >> 2014-11-17 18:31 GMT+01:00 Greg KH : >> > On Mon, Nov 17, 2014 at 10:44:14PM +0530, Susant Sahani wrote: >> >> On 11/17/2014 10:39 PM, Greg KH wrote: >> &g

Re: [systemd-devel] [PATCH 2/2] tty-ask-password-agent: fix CID 996261

2014-11-17 18:31 GMT+01:00 Greg KH : > On Mon, Nov 17, 2014 at 10:44:14PM +0530, Susant Sahani wrote: >> On 11/17/2014 10:39 PM, Greg KH wrote: >> >On Mon, Nov 17, 2014 at 10:36:53PM +0530, Susant Sahani wrote: >> >>On 11/17/2014 10:26 PM, Greg KH wrote: >> >>>On Mon, Nov 17, 2014 at 04:28:58PM +05

Re: [systemd-devel] [PATCH] udev: fix TOCTOU when creating a directory

2014-11-16 19:39 GMT+01:00 David Herrmann : > Hi > > On Sun, Nov 16, 2014 at 7:34 PM, David Herrmann wrote: >> Hi >> >> On Sun, Nov 9, 2014 at 3:42 PM, Ronny Chevalier >> wrote: >>> CID#979416 >>> --- >>> src/udev/collect/collect.c |

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-14 12:42 GMT+01:00 Jan Synacek : > Try to validate the input similarly to how setxkbmap does it. Multiple > layouts and variants can be specified, separated by a comma. Variants > can also be left out, meaning that the user doesn't want any particular > variant for the respective layout. >

Re: [systemd-devel] [PATCH] networkd: Support VXlan parameters

2014-11-14 8:44 GMT+01:00 Susant Sahani : Hi, > Add vxlan paramertes to config. > --- > man/systemd.netdev.xml | 30 + > src/network/networkd-netdev-gperf.gperf | 7 ++- > src/network/networkd-netdev-vxlan.c | 75 > + > src/networ

[systemd-devel] [PATCH] shared: explicitly ignore the return value of wait_for_terminate

CID#1237532 CID#1237523 CID#1237522 --- src/shared/pager.c| 2 +- src/shared/spawn-ask-password-agent.c | 2 +- src/shared/spawn-polkit-agent.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/shared/pager.c b/src/shared/pager.c index 5479094..00

[systemd-devel] [PATCH] udev: fix TOCTOU when creating a directory

CID#979416 --- src/udev/collect/collect.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/udev/collect/collect.c b/src/udev/collect/collect.c index dc849bd..6cb10fe 100644 --- a/src/udev/collect/collect.c +++ b/src/udev/collect/collect.c @@ -86,12 +86,13 @@ static vo

[systemd-devel] [PATCH] bus: fix null pointer dereference

CID#1237620 --- src/libsystemd/sd-bus/bus-message.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libsystemd/sd-bus/bus-message.c b/src/libsystemd/sd-bus/bus-message.c index be36d9f..edadacf 100644 --- a/src/libsystemd/sd-bus/bus-message.c +++ b/src/libsystemd/sd-bus/bus-message.c @@

Re: [systemd-devel] Leak mempool/hashmap

2014-11-06 19:59 GMT+01:00 Jan Janssen : Hi, > > > On 2014-11-06 19:05, Lennart Poettering wrote: >> >> On Thu, 06.11.14 18:36, Jan Janssen (medhe...@web.de) wrote: >> >>> Hi, >>> >>> I just noticed that mempool/hashmap leaks memory. It's as simple as this >>> to >>> trigger: >>> >>> #include "has

Re: [systemd-devel] [PATCH] udev: Fix parsing of udev.event-timeout kernel parameter.

2014-11-05 0:31 GMT+01:00 Richard W.M. Jones : Hi, > --- > src/udev/udevd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/udev/udevd.c b/src/udev/udevd.c > index 2e6c713..206a4d3 100644 > --- a/src/udev/udevd.c > +++ b/src/udev/udevd.c > @@ -994,7 +994,7 @@ static v

[systemd-devel] [PATCH] tests: add tests for strv.c

add tests for: - strv_find_startswith - strv_push_prepend - strv_consume_prepend --- src/test/test-strv.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/src/test/test-strv.c b/src/test/test-strv.c index bbfe306..915fa46 100644 --- a/src/test/test-strv.

[systemd-devel] [PATCH] tests: add tests for fileio.c

add tests for the following functions: - write_string_file_no_create - load_env_file_pairs --- src/test/test-fileio.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/src/test/test-fileio.c b/src/test/test-fileio.c index 7e7b4ac..a713abd 10064

[systemd-devel] [PATCH] shared: fix typo

--- src/shared/capability.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/capability.c b/src/shared/capability.c index d2b9013..0226542 100644 --- a/src/shared/capability.c +++ b/src/shared/capability.c @@ -228,7 +228,7 @@ int drop_privileges(uid_t uid, gid_t g

[systemd-devel] [PATCH 2/4] tests: add test-locale-util

-util.c new file mode 100644 index 000..1398a3a --- /dev/null +++ b/src/test/test-locale-util.c @@ -0,0 +1,59 @@ +/*** + This file is part of systemd + + Copyright 2014 Ronny Chevalier + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser

[systemd-devel] [PATCH 4/4] tests: add test-copy

000..6aa86a0 --- /dev/null +++ b/src/test/test-copy.c @@ -0,0 +1,115 @@ +/*** + This file is part of systemd + + Copyright 2014 Ronny Chevalier + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by

[systemd-devel] [PATCH 3/4] tests: add missing entry for LocalVariable to test-tables

--- src/test/test-tables.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/test-tables.c b/src/test/test-tables.c index 907958e..2138442 100644 --- a/src/test/test-tables.c +++ b/src/test/test-tables.c @@ -48,6 +48,7 @@ #include "link-config.h" #include "bus-policy.h" #include "j

[systemd-devel] [PATCH 1/4] shared: add missing includes

--- src/shared/copy.h| 3 +++ src/shared/locale-util.h | 4 2 files changed, 7 insertions(+) diff --git a/src/shared/copy.h b/src/shared/copy.h index 0bf2598..6b93107 100644 --- a/src/shared/copy.h +++ b/src/shared/copy.h @@ -21,6 +21,9 @@ along with systemd; If not, see

[systemd-devel] [PATCH] systemctl: add edit verb

It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/override.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. It invokes an editor on temporary files related to the unit files and if the edi

[systemd-devel] [PATCH] remove references of readahead

--- .gitignore | 1 - README | 1 - TODO | 7 --- 3 files changed, 9 deletions(-) diff --git a/.gitignore b/.gitignore index 0b71f09..14f1691 100644 --- a/.gitignore +++ b/.gitignore @@ -101,7 +101,6 @@ /systemd-quotacheck /systemd-random-seed /systemd-rc-local-generator -/system

[systemd-devel] [PATCH] systemctl: add edit verb

It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/override.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. It invokes an editor on temporary files related to the unit files and if the edi

[systemd-devel] [PATCH] NEWS: fix typos

--- NEWS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index c5f0db2..f4afcf6 100644 --- a/NEWS +++ b/NEWS @@ -70,7 +70,7 @@ CHANGES WITH 217: * Udev rules can now remove tags on devices with TAG-="foobar". * systemd's readahead implementat

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-22 11:15 GMT+02:00 Lennart Poettering : > On Wed, 22.10.14 01:48, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > >> On Sat, Oct 18, 2014 at 06:30:02PM +0200, Ronny Chevalier wrote: >> > It helps editing units by either creating a drop-in file, like >

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-13 13:40 GMT+02:00 David Herrmann : > Hi Hi, > > On Sat, Oct 11, 2014 at 8:17 PM, Daniel Buch wrote: >> Nice, I was in the process of implementing this. Looks good to me. But I >> think it would be better to use "vi" instead of "vim" if no &editor is set. >> Vim is not installed on every

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 21:24 GMT+02:00 Łukasz Stelmach : > --- > src/timesync/timesync-wait.c | 43 +++ > 1 file changed, 43 insertions(+) > create mode 100644 src/timesync/timesync-wait.c > > I am afraid TFD_TIMER_CANCEL_ON_SET doesn't help much here. You can > watch

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-22 18:30 GMT+02:00 Lennart Poettering : > On Wed, 22.10.14 18:28, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: > >> >> I'm not sure abou the name 'amendments.conf'. Wouldn't 'local.conf' >> >> be more idiomatic, and also ea

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-22 2:13 GMT+02:00 Ronny Chevalier : > 2014-10-22 1:48 GMT+02:00 Zbigniew Jędrzejewski-Szmek : >> On Sat, Oct 18, 2014 at 06:30:02PM +0200, Ronny Chevalier wrote: >>> It helps editing units by either creating a drop-in file, like >>> /etc/systemd/system/my.servi

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-22 1:48 GMT+02:00 Zbigniew Jędrzejewski-Szmek : > On Sat, Oct 18, 2014 at 06:30:02PM +0200, Ronny Chevalier wrote: >> It helps editing units by either creating a drop-in file, like >> /etc/systemd/system/my.service.d/amendments.conf, or by copying the >> original unit

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-21 0:51 GMT+02:00 Lennart Poettering : > On Sat, 18.10.14 18:30, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: > > Looks pretty good. A few comments. > >> + >> +static int unit_file_copy_if_needed(const char *unit_name, const char >> *

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-21 11:09 GMT+02:00 Lennart Poettering : > On Sat, 18.10.14 18:30, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: > > Three more suggestions after thinking about this a bit more... > >> +static int unit_file_drop_in(const char *unit_name, const char >> *conf

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-21 11:01 GMT+02:00 Lennart Poettering : > On Tue, 21.10.14 03:01, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: > >> >> +static int get_editors(char ***editors) { >> >> +char **tmp_editors = strv_new("nano", "vim", "v

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-21 0:51 GMT+02:00 Lennart Poettering : > On Sat, 18.10.14 18:30, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: > > Looks pretty good. A few comments. > >> + >> +static int unit_file_copy_if_needed(const char *unit_name, const char >> *

[systemd-devel] [PATCH v3] systemctl: add edit verb

It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/amendments.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. Then it invokes an editor to the related files and daemon-reload is invoked whe

Re: [systemd-devel] [PATCH v2] systemctl: add edit verb

Ignore this one, I rebased, then saved a modification in vim, so the rebase is reverted in the patch. Sorry for the noise. 2014-10-18 18:12 GMT+02:00 Ronny Chevalier : > It helps editing units by either creating a drop-in file, like > /etc/systemd/system/my.service.d/amendments.conf,

[systemd-devel] [PATCH v2] systemctl: add edit verb

It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/amendments.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. Then it invokes an editor to the related files and daemon-reload is invoked whe

Re: [systemd-devel] [PATCH, REVIEW, v2] find_symlinks: adds a cache of enabled unit symbolic link state

Hi, 2014-10-18 1:34 GMT+02:00 Ken Sedgwick : > The current find_symlinks_fd code traverses the config directories > duplicatively. This is a performance problem if 1000s of units are > being controlled. This patch adds a hashmap cache of symbolic link > state which is filled in one traversal and t

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-13 16:13 GMT+02:00 Simon McVittie : > On 13/10/14 14:38, Dale R. Worley wrote: >> My general understanding is that the traditional behavior when "you >> need an editor but the user hasn't specified one" is to use "vi", and >> so people who don't want "vi" *always* set $VISUAL in their >> en

[systemd-devel] [PATCH 1/4] man: add examples for coredumpctl

Add examples to clarify how to use coredumpctl See https://bugs.freedesktop.org/show_bug.cgi?id=83437 --- man/coredumpctl.xml | 28 1 file changed, 28 insertions(+) diff --git a/man/coredumpctl.xml b/man/coredumpctl.xml index a7b8793..03552b7 100644 --- a/man/coredum

[systemd-devel] [PATCH 4/4] man: fix project reference for archlinux

--- man/systemd-nspawn.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/systemd-nspawn.xml b/man/systemd-nspawn.xml index 22f2df4..c02aa88 100644 --- a/man/systemd-nspawn.xml +++ b/man/systemd-nspawn.xml @@ -106,7 +106,7 @@ yum8, deb

[systemd-devel] [PATCH 3/4] man: use instead of multiple for examples

--- man/systemd-activate.xml | 19 ++-- man/systemd-nspawn.xml | 75 2 files changed, 47 insertions(+), 47 deletions(-) diff --git a/man/systemd-activate.xml b/man/systemd-activate.xml index 717f5c0..cde4263 100644 --- a/man/systemd-activ

[systemd-devel] [PATCH 2/4] man: add missing commas

--- man/sd_journal_get_catalog.xml | 2 +- man/sysctl.d.xml| 2 +- man/systemd-bus-pro...@.service.xml | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/man/sd_journal_get_catalog.xml b/man/sd_journal_get_catalog.xml index 485bbba..c38a645 100644 -

[systemd-devel] [PATCH] avoid duplication of TIME_T_MAX

--- src/core/manager.c | 3 +-- src/shared/time-util.h | 2 ++ src/timesync/timesyncd-manager.c | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index e0c1cd1..dfd8cda 100644 --- a/src/core/manager.c +++ b/src/c

[systemd-devel] [PATCH] shared: remove unused functions

- mkdir_p_prefix: It has never been used - mkdir_parents_prefix_label: Unused since 1434ae6fd49f8377b0ddbd4c675736e0d3226ea6 --- src/shared/mkdir-label.c | 4 src/shared/mkdir.c | 4 src/shared/mkdir.h | 2 -- 3 files changed, 10 deletions(-) diff --git a/src/shared/mkdir-l

[systemd-devel] [PATCH] systemctl: add edit verb

It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/amendments.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. Then it invokes the $SYSTEMD_EDITOR or $EDITOR or vim to the related files and

Re: [systemd-devel] [PATCH] fstab-generator: Honor usr=, usrfstype= and usrflags=

Hi, 2014-09-30 21:18 GMT+02:00 Tobias Hunger : > Any feedback at all? Please? > > Am I doing something wrong in posting my patch here? No you just need to wait that someone review your patch. It rarely takes more than 2 weeks. > > Best Regards, > Tobias > > On Sat, Sep 27, 2014 at 5:59 PM, Tobias

[systemd-devel] [PATCH] tests: fix resource & mem leaks

--- src/test/test-condition-util.c | 2 +- src/test/test-fileio.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/test/test-condition-util.c b/src/test/test-condition-util.c index 4ee5600..35ee916 100644 --- a/src/test/test-condition-util.c +++ b/src/test/t

[systemd-devel] [PATCH] logind: fix typo

--- src/login/logind-session-dbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/login/logind-session-dbus.c b/src/login/logind-session-dbus.c index 7d81500..58836fc 100644 --- a/src/login/logind-session-dbus.c +++ b/src/login/logind-session-dbus.c @@ -249,7 +249,7 @@ st

[systemd-devel] [PATCH] man: fix typos

--- man/journalctl.xml| 6 +++--- man/systemctl.xml | 2 +- man/systemd-firstboot.xml | 4 ++-- man/systemd.network.xml | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/man/journalctl.xml b/man/journalctl.xml index bf18756..e10918a 100644 --- a/man/journalct

Re: [systemd-devel] [PATCH] journalctl: add "-t --identifier=STRING" option

2014-08-19 12:12 GMT+02:00 : > From: Harald Hoyer > > This turns journalctl to the counterpart of systemd-cat. > Messages sent with > > systemd-cat --identifier foo --prioritiy debug > > can now be shown with > > journalctl --identifier foo --prioritiy debug > > "--identifier" is not merged with

Re: [systemd-devel] [PATCH] util: do not execute files without exec permission

2014-08-18 21:10 GMT+02:00 Lennart Poettering : > On Mon, 18.08.14 20:47, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: > >> >> 2014-08-18 15:51 GMT+02:00 Lennart Poettering : >> > On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: >>

[systemd-devel] [PATCH] man: fix typo

--- man/systemd.exec.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd.exec.xml b/man/systemd.exec.xml index cfcf996..af103ff 100644 --- a/man/systemd.exec.xml +++ b/man/systemd.exec.xml @@ -1013,7 +1013,7 @@ made inaccessible and

[systemd-devel] [PATCH v2] bootchart: use NSEC_PER_SEC

--- src/bootchart/store.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index cedcba8..2d2ea42 100644 --- a/src/bootchart/store.c +++ b/src/bootchart/store.c @@ -34,6 +34,7 @@ #include #include "util.h" +#include "time-u

Re: [systemd-devel] [PATCH] util: do not execute files without exec permission

2014-08-18 15:51 GMT+02:00 Lennart Poettering : > On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: > > What's the rationale here? I think it makes a lot of sense to output an > error if people drop non-executable files in such a directory... > Yeah it

Re: [systemd-devel] [PATCH] condition-util: do not validate condition if paramater is garbage

2014-08-18 18:34 GMT+02:00 Lennart Poettering : > On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: > >> To follow the same behavior that src/core/condition.c do >> --- >> src/shared/condition-util.c| 2 +- >> src/test/test-conditi

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 13:46 GMT+02:00 Philippe De Swert : > Hi, Hi, > > Having to often use journalctl it has slowly driven me insane with the > default options not matching common use cases. > > Attached is already a patch to start the journal at the end. Usually people > check the logs when something went

[systemd-devel] [PATCH] man: fix typo

--- man/systemd-firstboot.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd-firstboot.xml b/man/systemd-firstboot.xml index 42fd753..c3fe0ed 100644 --- a/man/systemd-firstboot.xml +++ b/man/systemd-firstboot.xml @@ -249,7 +249,7 @@

[systemd-devel] [PATCH] condition-util: do not validate condition if paramater is garbage

To follow the same behavior that src/core/condition.c do --- src/shared/condition-util.c| 2 +- src/test/test-condition-util.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/shared/condition-util.c b/src/shared/condition-util.c index ff4a8ec..f21786f 100644 --- a/s

  1   2   >