On Tue, Nov 22, 2016 at 5:26 PM, Bastien Nocera wrote:
> On Tue, 2016-11-22 at 17:23 +0100, Lennart Poettering wrote:
> > On Tue, 22.11.16 12:13, Bastien Nocera (had...@hadess.net) wrote:
> >
> > > Hey,
> > >
> > > I'm adding support for reading the mount-matrix[1] from
> > > accelerometer
> > >
Hi,
I was wondering if anybody else had looked into this already. When building
with --enable-address-sanitizer I get the following error in test-selinux.
While trying the create a reduced test case I found that the problem comes
and goes when I remove logging either before or after the call where
On Wed, Aug 26, 2015 at 12:40 AM, David Herrmann wrote:
> Hi
>
> Trying to continue with our bi-weekly release schedule, we plan to
> release version 225 tomorrow. Please give it a spin and make sure
> there is no major breakage before the release.
Hi,
There is a mem leak triggered when running
On Thu, May 7, 2015 at 5:47 PM, Pavel Odvody wrote:
> Signed-off-by: Pavel Odvody
> ---
> src/import/pull.c | 28 +---
> 1 file changed, 17 insertions(+), 11 deletions(-)
>
> diff --git a/src/import/pull.c b/src/import/pull.c
> index ef7b035..8054612 100644
> --- a/src/im
On Mon, May 18, 2015 at 11:33 AM, Martin Pitt wrote:
> Hello all,
>
> We got a report [1] that systemd doesn't allow comments in
> /etc/hostname. If there is a comment, your host name ends up being
> "# comment". But the original hostname(1) tool documents that comments
> are allowed, thus in the
On Fri, May 15, 2015 at 7:30 PM, Lennart Poettering
wrote:
> On Fri, 15.05.15 18:41, Per Bergqvist (p...@bst.lu) wrote:
>
>> OK, now in git-format-patch.
>
> There's no patch in this mails of yours...
I see patches (nvme_id.patch) attached to Per's last two emails.
___
On Tue, May 12, 2015 at 6:17 PM, Lennart Poettering
wrote:
> On Tue, 12.05.15 01:00, Lennart Poettering (lenn...@poettering.net) wrote:
>
>> On Tue, 12.05.15 00:58, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>> >
>> > +#define FSCK_NO_ERROR 0
>> > +#defi
From: Thomas Hindoe Paaboel Andersen
---
src/fsck/fsck.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/fsck/fsck.c b/src/fsck/fsck.c
index 56d880a..5177adc 100644
--- a/src/fsck/fsck.c
+++ b/src/fsck/fsck.c
@@ -42,6 +42,15 @@
#include "path-util.h"
On Sun, Apr 26, 2015 at 8:31 PM, Thomas H.P. Andersen wrote:
> On Sun, Apr 26, 2015 at 8:23 PM, Shawn Landden wrote:
>> Actually you missed that free_sysvstub_hashmap does not tolerate NULL
>> pointers.
> Indeed. I will commit that.
Wait. free_sysvstub_hashmapp does tole
On Sun, Apr 26, 2015 at 8:23 PM, Shawn Landden wrote:
> Actually you missed that free_sysvstub_hashmap does not tolerate NULL
> pointers.
Indeed. I will commit that.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedes
On Sun, Apr 26, 2015 at 7:58 PM, Shawn Landden wrote:
> (coverity)
> ---
> src/shared/path-util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shared/path-util.c b/src/shared/path-util.c
> index 925bb28..95bfafc 100644
> --- a/src/shared/path-util.c
> +++ b/src/sha
Hi Shawn,
I fixed this a few hours ago. I also updated the status in coverity.
Is there something else I can do to avoid duplicated work?
On Sun, Apr 26, 2015 at 7:58 PM, Shawn Landden wrote:
> (coverity)
> ---
> src/sysv-generator/sysv-generator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
On Wed, Apr 1, 2015 at 3:00 PM, Tom Gundersen wrote:
> This provides equivalent functionality to libudev-device, but in the
> systemd style. The public API only caters to creating sd_device objects
> from for devices that already exist in /sys, there is no support for
> listening for monitoring ue
On Mon, Feb 23, 2015 at 2:02 PM, Lennart Poettering
wrote:
> On Sun, 22.02.15 14:56, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>
>> > For info I am attaching a diff with the changes so far: 1309 includes
>> > removed out of the current 7707. It is only compile and &qu
On Sun, Feb 15, 2015 at 11:53 PM, Thomas H.P. Andersen wrote:
> On Tue, Feb 10, 2015 at 10:05 PM, Lennart Poettering
> wrote:
>> On Sat, 07.02.15 10:29, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>>
>>> Hi,
>>>
>>> I am looking at ways to automat
On Wed, Feb 11, 2015 at 12:39 PM, Lennart Poettering
wrote:
> On Wed, 11.02.15 01:40, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>
>> Yep. Makes sense.
>>
>> Here is a status on what I have done so far.
>>
>> include-what-you-want does the following:
On Tue, Feb 10, 2015 at 10:13 PM, Lennart Poettering
wrote:
> On Mon, 09.02.15 10:19, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>
>> include-what-you-use is actually pretty nice. It is also a little bit
>> crazy. It wants to include everything directly and we would add a l
On Sat, Feb 7, 2015 at 3:38 PM, Thomas H.P. Andersen wrote:
> On Sat, Feb 7, 2015 at 2:37 PM, Ronny Chevalier
> wrote:
>> 2015-02-07 14:05 GMT+01:00 Daniele Nicolodi :
>>> On 07/02/15 10:29, Thomas H.P. Andersen wrote:
>>>> I am looking at ways to automatica
On Sat, Feb 7, 2015 at 2:37 PM, Ronny Chevalier
wrote:
> 2015-02-07 14:05 GMT+01:00 Daniele Nicolodi :
>> On 07/02/15 10:29, Thomas H.P. Andersen wrote:
>>> I am looking at ways to automatically trim the unnecessary includes.
>>> One way to do it is a script[1] which
On Sat, Feb 7, 2015 at 2:05 PM, Daniele Nicolodi wrote:
> On 07/02/15 10:29, Thomas H.P. Andersen wrote:
>> I am looking at ways to automatically trim the unnecessary includes.
>> One way to do it is a script[1] which simply tests if the compile
>> still works after removing
Hi,
I am looking at ways to automatically trim the unnecessary includes.
One way to do it is a script[1] which simply tests if the compile
still works after removing each include one at a time. It does this in
reverse order for all includes in the .c files. Using -Werror we catch
any new warnings
On Tue, Feb 3, 2015 at 12:50 AM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Mon, Feb 02, 2015 at 02:07:37PM -0800, Thomas H.P. Andersen wrote:
>> --- a/src/nspawn/nspawn.c
>> +++ b/src/nspawn/nspawn.c
>> @@ -3610,7 +3610,6 @@ int main
On Tue, Jan 20, 2015 at 8:08 PM, Martin Pitt wrote:
> Hey Jóhann,
>
> "Jóhann B. Guðmundsson" [2015-01-20 17:55 +]:
>> We only provide backwards compatibility with initscript which are lsb
>> compliance and I dont think . ending on a script confirms to
>> that standard hence that test should
On Sat, Dec 13, 2014 at 1:26 AM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Fri, Dec 12, 2014 at 12:58:04PM -0800, Thomas H.P. Andersen wrote:
>> Author: Thomas Hindoe Paaboel Andersen
>> Date: Fri Dec 12 19:51:41 2014 +0100
>>
>> wrap a few *_FOREACH macros in curl
On Mon, Nov 17, 2014 at 7:54 PM, Greg KH wrote:
> On Tue, Nov 18, 2014 at 12:21:29AM +0530, Susant Sahani wrote:
>> On 11/18/2014 12:06 AM, Greg KH wrote:
>> >On Mon, Nov 17, 2014 at 06:47:33PM +0100, Ronny Chevalier wrote:
>> >>2014-11-17 18:31 GMT+01:00 Greg KH :
>> >>>On Mon, Nov 17, 2014 at 10
On Sun, Sep 28, 2014 at 5:12 PM, wrote:
> From: Philippe De Swert
>
> Cpu's are assigned normally, so starting at 0, so the MAX_CPU index will
> always be one smaller than the actual number.
>
> Found with Coverity.
> ---
> src/bootchart/store.c | 2 +-
> 1 file changed, 1 insertion(+), 1 delet
+ my changes, and also with the version
installed with fedora 21.
- Thomas
On Fri, Sep 26, 2014 at 10:01 PM, Thomas H.P. Andersen wrote:
> From: Thomas Hindoe Paaboel Andersen
>
> Found by coverity. Fixes: CID#996409
> ---
> src/bootchart/store.c | 6 --
> 1 file changed,
From: Thomas Hindoe Paaboel Andersen
Spotted with coverity. If parsing both /etc/os-release and
/usr/lib/os-release fails then null would be passed on. The calls
to parse the two files are allowed to fail. A empty /etc may not
have had the /etc/os-release symlink restored yet and we just
try agai
From: Thomas Hindoe Paaboel Andersen
Found by coverity. Fixes: CID#996314 and #996312
---
src/bootchart/bootchart.c | 14 --
src/bootchart/svg.c | 6 --
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/src/bootchart/bootchart.c b/src/bootchart/bootchart.c
in
From: Thomas Hindoe Paaboel Andersen
Found by coverity. Fixes: CID#996409
---
src/bootchart/store.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/bootchart/store.c b/src/bootchart/store.c
index ed683e8..3099ff1 100644
--- a/src/bootchart/store.c
+++ b/src/bootchar
On Tue, Sep 16, 2014 at 11:27 PM, wrote:
> From: Philippe De Swert
>
> We only break out of the pre-ceding loop into the rest of the code
> if fd is actually >= 0. So the < 0 check will never be true and
> not necessary.
>
> Found with Coverity. Fixes: CID#1237577
I pushed a fix for this one 20
On Wed, Sep 10, 2014 at 11:20 AM, wrote:
> From: Philippe De Swert
>
> Hi,
>
> Yesterday I finally got to revive the systemd Coverity project on
> scan.coverity.org Unfortunately to see the errors reported you need
> to sign up, but I will make sure to approve requests for seeing the
> "bugs" wh
From: Thomas Hindoe Paaboel Andersen
The 3 calls to sd_bus_error_get_errno appear to expect a negative
return value.
This patch negates the returned value so it matches the other error
cases in the 3 functions where sd_bus_error_get_errno is used.
---
src/libsystemd-terminal/sysview.c | 6 +++--
From: Thomas Hindoe Paaboel Andersen
sd_bus_message_get_errno can currently return either a number of
different poitive errno values (from bus-error-mapping), or a negative
EINVAL if passed null as parameter.
The check for null parameter was introduced in
40ca29a1370379d43e44c0ed425eecc7218dcbc
On Wed, Sep 10, 2014 at 11:20 AM, wrote:
> From: Philippe De Swert
>
> Hi,
>
> Yesterday I finally got to revive the systemd Coverity project on
> scan.coverity.org Unfortunately to see the errors reported you need
> to sign up, but I will make sure to approve requests for seeing the
> "bugs" wh
On Sat, Aug 23, 2014 at 8:59 PM, Ivan Shapovalov wrote:
> resume-generator understands resume= kernel command line parameter and
> instantiates the systemd-resume@.service accordingly if it is passed.
>
> This enables resume from hibernation using device specified on the kernel
> command line, whe
On Sat, Aug 23, 2014 at 2:47 PM, Ivan Shapovalov wrote:
> This can be used to initiate a resume from hibernation by path to a swap
> device containing the hibernation image.
>
> The respective templated unit is also added. It is instantiated using
> path to the desired resume device.
> ---
> Make
Maybe these are candidates for this as well?
src/bootchart/bootchart.c:355:interval = (1.0 / arg_hz) * 10.0;
src/bootchart/bootchart.c:413:elapsed = (sample_stop -
sampledata->sampletime) * 10.0;
src/bootchart/bootchart.c:416:newint_s =
(time
On Fri, Aug 15, 2014 at 12:35 PM, David Herrmann wrote:
> Hi
>
> On Fri, Aug 15, 2014 at 12:29 PM, Thomas H.P. Andersen
> wrote:
>> On Fri, Aug 15, 2014 at 11:49 AM, David Herrmann
>> wrote:
>>> Thanks for trying!
>>>
>>> Result is as I
On Fri, Aug 15, 2014 at 10:55 AM, David Herrmann wrote:
> Hi
>
> On Thu, Aug 14, 2014 at 8:07 PM, Lennart Poettering
> wrote:
>> On Fri, 18.07.14 16:02, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>>
>>> 1716f6dcf54d4c181c2e2558e3d5414f54c8d9ca (resolved: add
On Sat, Jul 19, 2014 at 10:37 AM, Thomas H.P. Andersen wrote:
> From: Thomas Hindoe Paaboel Andersen
>
> ---
> src/resolve/resolved-dns-scope.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/resolve/resolved-dns-scope.c
> b/src/reso
On Sun, Aug 3, 2014 at 10:56 PM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Sun, Aug 03, 2014 at 10:53:05PM +0200, Thomas H.P. Andersen wrote:
>> From: Thomas Hindoe Paaboel Andersen
>>
>> In dns_scope_make_reply_packet the structs q, answer, and soa can be
>> null. We s
From: Thomas Hindoe Paaboel Andersen
In dns_scope_make_reply_packet the structs q, answer, and soa can be
null. We should check for null before reading their fields.
---
src/resolve/resolved-dns-scope.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/resolve/resolved-d
On Mon, Jul 21, 2014 at 4:18 AM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Thu, Jul 17, 2014 at 08:51:52PM +0200, Thomas H.P. Andersen wrote:
>> From recent commits I have noticed the following new issues from
>> static analysis with scan-build and with clang. I am not sure how th
From: Thomas Hindoe Paaboel Andersen
---
src/resolve/resolved-dns-scope.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/resolve/resolved-dns-scope.c b/src/resolve/resolved-dns-scope.c
index 190c5f4..41514a5 100644
--- a/src/resolve/resolved-dns-scope.c
+++ b/src/res
On Thu, Jul 17, 2014 at 8:51 PM, Thomas H.P. Andersen wrote:
> From recent commits I have noticed the following new issues from
> static analysis with scan-build and with clang. I am not sure how they
> should be fixed (or even if) but I just though I would let you know.
>
>
1716f6dcf54d4c181c2e2558e3d5414f54c8d9ca (resolved: add LLMNR support
for looking up names) broke the build on clang.
src/resolve/resolved-manager.c:553:43: error: non-const static data
member must be initialized out of line
uint8_t buffer[CMSG_SPACE(MAX(sizeof(struct in_pktinfo), sizeof(struct
in
>From recent commits I have noticed the following new issues from
static analysis with scan-build and with clang. I am not sure how they
should be fixed (or even if) but I just though I would let you know.
1) src/shared/barrier.c in barrier_read starting at line 274
if (pfd[1].revents) {
On Wed, Jul 16, 2014 at 11:57 AM, Jon Severinsson wrote:
> ---
> src/sysv-generator/sysv-generator.c | 29 +++--
> 1 file changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/src/sysv-generator/sysv-generator.c
> b/src/sysv-generator/sysv-generator.c
> index 5206279
From: Thomas Hindoe Paaboel Andersen
---
src/journal/coredump-vacuum.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/journal/coredump-vacuum.c b/src/journal/coredump-vacuum.c
index ad2e2fa..125bb3a 100644
--- a/src/journal/coredump-vacuum.c
+++ b/src/journal/coredum
From: Thomas Hindoe Paaboel Andersen
Checking the return values seems to have been forgotten in
ed6ee21953dac9c78383da00bc4514ece6b75ab5
---
src/libsystemd-network/sd-dhcp6-client.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/libsystemd-network/sd-dhcp6-client.c
b/src/libsystemd-n
On Thu, Jun 26, 2014 at 12:01 AM, Michael Biebl wrote:
> 2014-06-25 23:18 GMT+02:00 Adam Williamson :
>> Hi, folks. I'm about 90% sure there's a fairly significant bug in the
>> systemd-sysv-generator that was introduced in 214. It's a bit
>> complicated, and the full details are at
>> https://bug
On Tue, Jun 24, 2014 at 7:56 PM, Alexey Shabalin wrote:
> 2014-06-07 3:01 GMT+04:00 Thomas H.P. Andersen :
>> On Fri, Jun 6, 2014 at 4:09 PM, Lennart Poettering
>> wrote:
>>> On Sat, 31.05.14 23:29, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>&g
From: Thomas Hindoe Paaboel Andersen
---
src/cgls/cgls.c| 2 +-
src/journal/journal-remote-parse.c | 4 ++--
src/journal/journal-remote.c | 8
src/journal/microhttpd-util.c | 2 +-
src/nspawn/nspawn.c| 2 +-
src/readahead/readahead-common.c
From: Thomas Hindoe Paaboel Andersen
after 19f3934057d20c63f4c95791312038a41b4666d0 the errors from chown/chmod
will be cleared before being read. Presumably to clear the possible EEXIST
from copying to an existing directory.
Note: with this patch we stop immediately on error in chown/chmod while
On Fri, Jun 13, 2014 at 10:58 PM, Thomas H.P. Andersen wrote:
> From: Thomas Hindoe Paaboel Andersen
>
> We must use free instead of dhcp_lease_free here to avoid freeing
> client_id.data.
> ---
> src/libsystemd-network/sd-dhcp-server.c | 4 +++-
> 1 file changed, 3 inse
On Fri, Jun 13, 2014 at 7:04 PM, Tom Gundersen wrote:
> On Fri, Jun 13, 2014 at 6:48 PM, Andreas Henriksson wrote:
>> Hello all!
>
> Hi Andreas,
>
>> I was recently bitten by a problem which I found the solution to in
>> http://lists.freedesktop.org/archives/systemd-commits/2013-October/004421.ht
From: Thomas Hindoe Paaboel Andersen
---
src/network/networkd-link.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index baa0756..39c8329 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
On Thu, Jun 12, 2014 at 5:41 PM, Colin King wrote:
> From: Colin Ian King
>
> Signed-off-by: Colin Ian King
> ---
> src/sysv-generator/sysv-generator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sysv-generator/sysv-generator.c
> b/src/sysv-generator/sysv-gener
From: Thomas Hindoe Paaboel Andersen
We must use free instead of dhcp_lease_free here to avoid freeing
client_id.data.
---
src/libsystemd-network/sd-dhcp-server.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/libsystemd-network/sd-dhcp-server.c
b/src/libsystemd-netw
From: Thomas Hindoe Paaboel Andersen
---
src/network/networkd-link.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 81872f7..baa0756 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -1723,6 +1723,
From: Thomas Hindoe Paaboel Andersen
Removes _cleanup_dhcp_lease_free_. While the automatic cleanup
functions are great to have this one is never used and causes
a warning in clang.
---
src/libsystemd-network/sd-dhcp-server.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/libsystemd-n
On Fri, Jun 13, 2014 at 12:01 AM, Greg KH wrote:
> On Thu, Jun 12, 2014 at 11:49:35PM +0200, Thomas H.P. Andersen wrote:
>> On Thu, Jun 12, 2014 at 11:08 PM, Greg KH wrote:
>> > On Thu, Jun 12, 2014 at 10:55:50PM +0200, Thomas H.P. Andersen wrote:
>> >> From:
On Thu, Jun 12, 2014 at 11:08 PM, Greg KH wrote:
> On Thu, Jun 12, 2014 at 10:55:50PM +0200, Thomas H.P. Andersen wrote:
>> From: Thomas Hindoe Paaboel Andersen
>>
>> Beef up the assert to protect against passing null to strlen.
>>
>> Found with scan-build.
>&
From: Thomas Hindoe Paaboel Andersen
Beef up the assert to protect against passing null to strlen.
Found with scan-build.
---
src/cryptsetup/cryptsetup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c
index 812b32f..
On Fri, Jun 6, 2014 at 4:09 PM, Lennart Poettering
wrote:
> On Sat, 31.05.14 23:29, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>
> Thanks! Awesome work! I am enjoying this!
>
> A few comments:
>
>> +
>> +static int generate_unit_file(SysvStub *s) {
>> +
From: Thomas Hindoe Paaboel Andersen
The return value from udev_enumerate_scan_devices was stored but
never used. I assume this was meant to be checked.
---
src/udev/udevd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index 0f3f3f0..f1daf49 100644
--
..8351b4b
--- /dev/null
+++ b/src/sysv-generator/sysv-generator.c
@@ -0,0 +1,909 @@
+/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
+
+/***
+ This file is part of systemd.
+
+ Copyright 2014 Thomas H.P. Andersen
+ Copyright 2010 Lennart Poettering
+ Copyright 2011 Michal Schmidt
From: Thomas Hindoe Paaboel Andersen
Parsing sysv files was moved to the sysv-generator in the previous commit.
This patch removes the sysv parsing from serivce.c.
To avoid introducing an extra compat option in .service fies for identifying
sysv services we instead add a check if the SourcePath
From: Thomas Hindoe Paaboel Andersen
Compared to the previous version this one generates a .service file for
all initscripts in the sysvinit path that have execute permission. After
that it will adjust the before/after/wants/conflicts based on the rc.d's.
The patches have a few warts that I cons
On Sat, May 31, 2014 at 11:34 AM, Tom Gundersen wrote:
>
> On 31 May 2014 08:39, "Thomas H.P. Andersen" wrote:
>>
>> This needs some more work. Currently only initscripts linked from the rc?d
>> dirs are generated. We of course need to generate them all and
This needs some more work. Currently only initscripts linked from the rc?d
dirs are generated. We of course need to generate them all and have a way
to run the generator after a new initscript is installed.
Or do we want to run it just in time instead?
On May 30, 2014 3:28 PM, "Thoma
..565fcaa
--- /dev/null
+++ b/src/sysv-generator/sysv-generator.c
@@ -0,0 +1,899 @@
+/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
+
+/***
+ This file is part of systemd.
+
+ Copyright 2014 Thomas H.P. Andersen
+ Copyright 2010 Lennart Poettering
+ Copyright 2011 Michal Schmidt
From: Thomas Hindoe Paaboel Andersen
Parsing sysv files was moved to the sysv-generator in the previous commit.
This patch removes the sysv parsing from serivce.c.
To avoid introducing an extra compat option in .service fies for identifying
sysv services we instead add a check if the SourcePath
From: Thomas Hindoe Paaboel Andersen
Move initscript parsing to a generator
Compared to the previous version this one includes a fix for initscripts that
have no start priority. I have also updated the commit messages. The patches
have a few warts that I consider irrelevant but am willing to fix
From: Thomas Hindoe Paaboel Andersen
Parsing sysv files was moved to the sysv-generator.
To avoid introducing an extra compat option for identifying sysv services
we instead add a check if the SourcePath is a path to sysvinit.
Note that this patch drops the following now unused sysv-specific in
@@
+/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
+
+/***
+ This file is part of systemd.
+
+ Copyright 2014 Thomas H.P. Andersen
+ Copyright 2010 Lennart Poettering
+ Copyright 2011 Michal Schmidt
+
+ systemd is free software; you can redistribute it and/or modify it
+ under
On Thu, May 29, 2014 at 4:30 PM, Andrey Borzenkov wrote:
> В Thu, 29 May 2014 16:11:25 +0200
> "Thomas H.P. Andersen" пишет:
>
>> On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek
>> wrote:
>> > On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas
On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas H.P. Andersen wrote:
>> From: Thomas Hindoe Paaboel Andersen
>>
>> Reuses logic from service.c and the rc-local generator.
>>
>> Note tha
On Wed, May 28, 2014 at 2:14 AM, Peeters Simon wrote:
> 2014-05-28 1:12 GMT+02:00 Thomas H.P. Andersen :
>> From: Thomas Hindoe Paaboel Andersen
>>
>> Reuses logic from service.c and the rc-local generator.
>>
>> Note that this drops reading of chkconfi
On Wed, May 28, 2014 at 1:59 PM, Michael Biebl wrote:
> 2014-05-28 11:58 GMT+02:00 Thomas H.P. Andersen :
>> On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek
>> wrote:
>>> On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas H.P. Andersen wrote:
>>>>
On Wed, May 28, 2014 at 3:38 AM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Wed, May 28, 2014 at 01:12:23AM +0200, Thomas H.P. Andersen wrote:
>> From: Thomas Hindoe Paaboel Andersen
>>
>> Reuses logic from service.c and the rc-local generator.
>>
>> Note tha
H.P. Andersen
+ Copyright 2010 Lennart Poettering
+ Copyright 2011 Michal Schmidt
+
+ systemd is free software; you can redistribute it and/or modify it
+ under the terms of the GNU Lesser General Public License as published by
+ the Free Software Foundation; either version 2.1 of the License
On Wed, May 21, 2014 at 10:46 AM, Lennart Poettering
wrote:
> On Wed, 21.05.14 10:29, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>
>>
>> On Tue, May 20, 2014 at 5:43 PM, Lennart Poettering
>> wrote:
>> > On Mon, 19.05.14 19:52, Tom Gundersen (t...@jklm.no)
On Tue, May 20, 2014 at 5:43 PM, Lennart Poettering
wrote:
> On Mon, 19.05.14 19:52, Tom Gundersen (t...@jklm.no) wrote:
>
>> > _public_ int sd_peer_get_session(int fd, char **session) {
>> > -struct ucred ucred;
>> > +struct ucred ucred = {};
>>
>> I can't reproduce this warning,
On Mon, May 19, 2014 at 9:01 PM, Cristian Rodríguez
wrote:
> El 19/05/14 13:52, Tom Gundersen escribió:
>
>> I can't reproduce this warning, but more importantly, why is this
>> necessary in this function and not the subsequent noes (which all
>> seem to be more or less equivalent)?
>
> What compi
On Sat, May 17, 2014 at 12:07 AM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Fri, May 16, 2014 at 11:53:23PM +0200, Thomas H.P. Andersen wrote:
>> From: Thomas Hindoe Paaboel Andersen
>>
>> ---
>> src/libsystemd/sd-bus/bus-objects.c | 2 +-
>> src/libsystemd/sd-bus
On Sat, May 17, 2014 at 4:22 AM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Fri, May 16, 2014 at 11:53:24PM +0200, Thomas H.P. Andersen wrote:
>> From: Thomas Hindoe Paaboel Andersen
>>
>> This is followup on 05cae7f3431446236139434ee58a6275f3cb31e8
>>
>> I think t
On Sat, May 17, 2014 at 4:26 AM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Fri, May 16, 2014 at 11:53:25PM +0200, Thomas H.P. Andersen wrote:
>> From: Thomas Hindoe Paaboel Andersen
>>
>> After 1ea972174baba40dbc80c51cbfc4edc49764b59b err is no longer
>> set u
From: Thomas Hindoe Paaboel Andersen
---
src/libsystemd/sd-bus/bus-objects.c | 2 +-
src/libsystemd/sd-bus/sd-bus.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libsystemd/sd-bus/bus-objects.c
b/src/libsystemd/sd-bus/bus-objects.c
index 51d4a62..dbb04e5 100644
From: Thomas Hindoe Paaboel Andersen
This is followup on 05cae7f3431446236139434ee58a6275f3cb31e8
I think the intention was to use the newly introduced 'path'
variable in the inner loop instead of p.
---
src/systemctl/systemctl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
di
From: Thomas Hindoe Paaboel Andersen
After 1ea972174baba40dbc80c51cbfc4edc49764b59b err is no longer
set unless we hit a special case. Initialize it to 0 and remove
a check that will never fail.
---
src/udev/udevd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/udev
From: Thomas Hindoe Paaboel Andersen
The error message logged in finish: will not be very informative
but on the other hand I don't see how this should ever happen.
---
src/network/networkd-link.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/network/networkd-link.c
On Sat, Apr 5, 2014 at 10:08 PM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Sat, Apr 05, 2014 at 09:09:47PM +0200, Thomas H.P. Andersen wrote:
>> static int get_line(RemoteSource *source, char **line, size_t *size) {
>> ssize_t n, remain;
>> -char *c;
>&
From: Thomas Hindoe Paaboel Andersen
Found with scan-build
---
src/journal/journal-remote-parse.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/journal/journal-remote-parse.c
b/src/journal/journal-remote-parse.c
index 142de0e..239ff38 100644
--- a/src/journal/jou
On Tue, Apr 1, 2014 at 3:00 PM, Daniel Buch wrote:
> It seems to be a clang-analyzer problem since it don't behave like
> clang-compiler regarding -std={c99,gnu99}
> ---
> autogen.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/autogen.sh b/autogen.sh
> index 9b4781c..
On Tue, Mar 11, 2014 at 2:29 PM, Lennart Poettering
wrote:
> On Tue, 11.03.14 08:05, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>
>>
>> On Tue, Mar 11, 2014 at 4:52 AM, Lennart Poettering
>> wrote:
>> > On Wed, 05.03.14 23:48, Thomas H.P. Andersen (pho...@
On Tue, Mar 11, 2014 at 4:52 AM, Lennart Poettering
wrote:
> On Wed, 05.03.14 23:48, Thomas H.P. Andersen (pho...@gmail.com) wrote:
>
>> From: Thomas Hindoe Paaboel Andersen
>>
>> --system
>> -H --host
>> -M --machine
>> --service-type (options: simple
From: Thomas Hindoe Paaboel Andersen
--system
-H --host
-M --machine
--service-type (options: simple forking oneshot dbus notify idle)
--uid
--gid
--nice
--setenv
-p --property (options read from bus_append_unit_property_assignment)
---
shell-completion/bash/systemd-run | 39
From: Thomas Hindoe Paaboel Andersen
---
Only compile tested. I just wanted to get rid of the warnings about
use of the uninitialized variables.
Makefile.am| 3 ++-
src/network/network-util.h | 28
src/network/networkd-wait-online.c
1 - 100 of 174 matches
Mail list logo
