[systemd-devel] [RFC] systemd-swap

2017-02-20 Thread Timofey Titovets
Hi, some time ago (about 3 years ago, first commit at Apr 9, 2014) I created small project: systemd-swap. https://github.com/Nefelim4ag/systemd-swap Short description from README.md: Script for manage swap on: zswap - Enable/Configure zram - Autoconfigurating files - (sparse files for saving

[systemd-devel] [PATCH v4] Bootchart: use /proc/pid/mountinfo for root bdev

2014-10-31 Thread Timofey Titovets
parse get name of bdev from 10th column Not tested while boot process, code in separate binary file working good. From 97d259c38da3a32569e30bfaf7df56c062c570a6 Mon Sep 17 00:00:00 2001 From: Timofey Titovets Date: Fri, 31 Oct 2014 15:43:30 +0300 Subject: [PATCH] Bootchart: use /proc/pid

Re: [systemd-devel] [PATCH v3] Bootchart: use /proc/pid/mountinfo for root bdev

2014-10-31 Thread Timofey Titovets
2014-10-31 11:57 GMT+03:00 Karel Zak : > > somewhere in systemd code is mountinfo parser.. or see > https://github.com/karelzak/util-linux/blob/master/libmount/src/tab_parse.c#L124 > > it seems you also want to read: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentati

Re: [systemd-devel] [PATCH v3] Bootchart: use /proc/pid/mountinfo for root bdev

2014-10-30 Thread Timofey Titovets
2014-10-31 3:06 GMT+03:00 Zbigniew Jędrzejewski-Szmek : > On Thu, Oct 30, 2014 at 05:45:53PM +0300, Timofey Titovets wrote: >> Good time of day, list. >> I have try to fix "Fixme" in svg.c: >> /* FIXME: this works only in the simple case */ >> >> By

[systemd-devel] [PATCH v3] Bootchart: use /proc/pid/mountinfo for root bdev

2014-10-30 Thread Timofey Titovets
v, &ptr[6], 3); rootbdev[3] = '\0'; sprintf(filename, "block/%s/device/model", rootbdev); fd = openat(sysfd, filename, O_RDONLY); -- 2.1.3 >From df889766a0dae0700cbc1378699e1abbad6b3f8d Mon Sep 17 00:00:00 2001 From: Timofey

Re: [systemd-devel] [PATCH v2] Bootchart: allow parse LABEL, UUID, PARTUUID for svg info

2014-10-29 Thread Timofey Titovets
2014-10-29 16:20 GMT+03:00 Zbigniew Jędrzejewski-Szmek : > On Wed, Oct 29, 2014 at 04:16:22PM +0300, Timofey Titovets wrote: >> Why then developers use cmdline before? >> Maybe cmdline allow determine disk when bootchart working from or in initrd? > bootchart was merged into s

Re: [systemd-devel] [PATCH v2] Bootchart: allow parse LABEL, UUID, PARTUUID for svg info

2014-10-29 Thread Timofey Titovets
Why then developers use cmdline before? Maybe cmdline allow determine disk when bootchart working from or in initrd? 2014-10-28 15:37 GMT+03:00 Zbigniew Jędrzejewski-Szmek : > On Tue, Oct 28, 2014 at 07:56:32AM +0300, Timofey Titovets wrote: >> Good time of day, list. >> I try to

[systemd-devel] [PATCH v2] Bootchart: allow parse LABEL, UUID, PARTUUID for svg info

2014-10-27 Thread Timofey Titovets
ns. From 4d14e78977df92e010ea488f97acd6a5e8e30e97 Mon Sep 17 00:00:00 2001 From: Timofey Titovets Date: Tue, 28 Oct 2014 07:42:26 +0300 Subject: [PATCH] Bootchart: allow parse LABEL, UUID, PARTUUID for svg info --- src/bootchart/svg.c | 24 1 file changed, 20 insertions(+), 4 deletion

Re: [systemd-devel] [PATCH] Bootchart: allow parse LABEL, UUID, PARTUUID for svg info

2014-10-27 Thread Timofey Titovets
On 10/28/2014 03:45 AM, Ivan Shapovalov wrote: On Tuesday 28 October 2014 at 03:30:13, Timofey Titovets wrote: Good time of day, list. I try to fix "Fixme" in svg.c: /* FIXME: this works only in the simple case */ By default function try to get root=/dev/* I write small function to

[systemd-devel] [PATCH] Bootchart: allow parse LABEL, UUID, PARTUUID for svg info

2014-10-27 Thread Timofey Titovets
t can look more pretty. May be i missed(reimplemented) some internal functional of systemd? I also attach patch to email. Thanks. From 896ef1c040a6395375e3adcd230bf2b766db633c Mon Sep 17 00:00:00 2001 From: Timofey Titovets Date: Tue, 28 Oct 2014 03:17:40 +0300 Subject: [PATCH] Bootchart: allow p

Re: [systemd-devel] [PATCH] login: remove multi-seat-x

2014-10-27 Thread Timofey Titovets
when you send it inline! > > Lennart > > -- > Lennart Poettering, Red Hat I attached it to the first message, well, this is not a problem, i attach it again (below). =] -- Have a nice day, Timofey. From 57b2655d2041d2bb2e9b25bef577ead9b27ce6ee Mon Sep 17 00:00:00 2001 From: Timofey

Re: [systemd-devel] [PATCH] login: remove multi-seat-x

2014-10-27 Thread Timofey Titovets
2014-10-27 16:00 GMT+03:00 Lennart Poettering : > On Sun, 26.10.14 00:30, Timofey Titovets (nefelim...@gmail.com) wrote: > >> Completed TODO: remove multi-seat-x > > Hmm, I don't remember the details of this, did X release a new version > which makes this tool unnecess

[systemd-devel] [PATCH] login: remove multi-seat-x

2014-10-25 Thread Timofey Titovets
Completed TODO: remove multi-seat-x From 57b2655d2041d2bb2e9b25bef577ead9b27ce6ee Mon Sep 17 00:00:00 2001 From: Timofey Titovets Date: Sun, 26 Oct 2014 00:17:24 +0300 Subject: [PATCH] login: remove multi-seat-x --- Makefile.am | 14 -- TODO | 2

[systemd-devel] [RFC] initrd: systemd-{networkd,resolved}

2014-08-23 Thread Timofey Titovets
Good time of day list, i just want to hear your opinions - pro and con Pre story: Before i install bunch of systemd-{networkd,resolved} and wpa_supplicant (for connecting to HotSpots) After i spend some time to think about network handling by networkd and resolved, about some cases and i have ide

Re: [systemd-devel] [RFC] Integrate export mount command in code

2014-08-17 Thread Timofey Titovets
Thanks for explanation, it thread can be closed. 2014-08-18 0:41 GMT+03:00 Dave Reisner : > On Mon, Aug 18, 2014 at 12:25:00AM +0300, Timofey Titovets wrote: >> Good time of day, i just want to ask: >> Systemd depend on util-linux mount command and in code we call him, >>

[systemd-devel] [RFC] Integrate export mount command in code

2014-08-17 Thread Timofey Titovets
Good time of day, i just want to ask: Systemd depend on util-linux mount command and in code we call him, may have a sense to import and cleanup code to systemd base, and just call function in systemd, instead of using mount command? But only benefit what i see: it faster, when call external comma

Re: [systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Timofey Titovets
2014-08-15 2:00 GMT+03:00 Lennart Poettering : > On Fri, 15.08.14 01:43, Timofey Titovets (nefelim...@gmail.com) wrote: > >> >> +int fail_if_symlink(const char *unit, const char* where) { >> +assert(where); >> + >> +if (is_symlink(where) > 0

Re: [systemd-devel] [RFC] Remove warning: may be used uninitialized

2014-08-14 Thread Timofey Titovets
I just use: ./autogen.sh && ./configure && make But did not matter, thanks for explanation, i think what this thread can be closed. 2014-08-15 1:57 GMT+03:00 Lennart Poettering : > On Fri, 15.08.14 01:11, Timofey Titovets (nefelim...@gmail.com) wrote: > >> Good

[systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Timofey Titovets
Just complete TODO: * refuse mounting on symlinks I not add this TODO, but i think what it avoid potential security {and/or} bug issues v2 -> v3: Rebase on latest git Add message : Mount on symlink not allowed. if systemd try mounting entry from fstab on symlink, user get: $ systemctl status

[systemd-devel] [RFC] Remove warning: may be used uninitialized

2014-08-14 Thread Timofey Titovets
Good time of day, when i compile systemd i get ton of warning like: may be used uninitialized in function... May be i can spend some time and create patches with fixes of that warnings? As example declare it by default to 0 or something like that. Or this is not a bug, just feature? %) -- Have

Re: [systemd-devel] [PATCH v2] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-08-14 Thread Timofey Titovets
21.07.14 15:02, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > >> >> On Mon, Jul 21, 2014 at 09:38:57AM +0300, Timofey Titovets wrote: >> > Just completed TODO: >> > * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG >> >> This is

Re: [systemd-devel] [PATCH v2] Refuse mount on symlink

2014-08-14 Thread Timofey Titovets
Okay, i will rebase and resend, and add warning But what i must do with message: "symlink.mount failed to run 'mount' task: Too many levels of symbolic links"? Just leave and add additional massage error or replace? 2014-08-14 20:31 GMT+03:00 Timofey Titovets : > Okay, i

[systemd-devel] [PATCH v3] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-07-21 Thread Timofey Titovets
Just completed TODO: * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG ioctl, with START_IO commit d3fc81bd6a5a046b22600ac1204df220c93d2c15 refs/tags/v30 Author: Lennart Poettering Date: Wed Jun 15 15:39:10 2011 +0200 update TODO i no add this todo in TODO list (recur

[systemd-devel] [PATCH v2] Refuse mount on symlink

2014-07-21 Thread Timofey Titovets
Just complete TODO: * refuse mounting on symlinks I not add this TODO, but i think what it avoid potential security {and/or} bug issues if systemd try mounting entry from fstab on symlink, user get something systemctl status symlink.mount ● symlink.mount - /symlink Loaded: loaded (/etc/fs

Re: [systemd-devel] [PATCH v2] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-07-21 Thread Timofey Titovets
Zbyszek, i research problem and i found what in btrfs.h struct btrfs_ioctl_defrag_range_args not defined This acceptable if i add it in missing.h like: /* btrfs_ioctl_defrag_range_args now 21.07.2014 * not defined in btrfs.h and duplicated from /fs/btrfs/ctree.h */ #ifdef HAVE_LINUX_BTRFS_H stru

Re: [systemd-devel] [PATCH] Refuse mount on symlink

2014-07-21 Thread Timofey Titovets
2014-07-21 17:11 GMT+03:00 Lennart Poettering : > That would follow our usual coding style very closely... I know >_<, i do bad looking error codes >_< Lennart, thanks for explanation, i will fix it and resend patch. -- Best regards, Timofey. ___ syste

[systemd-devel] [PATCH] Refuse mount on symlink

2014-07-21 Thread Timofey Titovets
Just completed TODO: * refuse mounting on symlinks I not add this TODO, but i think what it avoid potential security{and/or} bug issues If systemd try mounting entry from fstab on symlink, user get something like that: Jul 19 15:49:38 beplan.lan systemd[1]: Mounting /var/tmp/symlink... Jul 1

Re: [systemd-devel] [PATCH v2] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-07-21 Thread Timofey Titovets
Zbyszek, thanks for comment, i will work on fixing what you say and resend patch. >> Just completed TODO: >> * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG > > This is still not an explanation. What is the difference between the > two? I can't explain it, because no i add thi

Re: [systemd-devel] [PATCH] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-07-20 Thread Timofey Titovets
I resend patch as v2 with fixed todo 2014-07-21 9:16 GMT+03:00 Timofey Titovets : > 2014-07-21 5:21 GMT+03:00 Andrey Borzenkov : >> В Sun, 20 Jul 2014 22:27:20 +0300 >> Timofey Titovets пишет: >> >>> Just completed TODO: >>> * readahead: use BTRFS_IOC_D

[systemd-devel] [PATCH v2] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-07-20 Thread Timofey Titovets
Just completed TODO: * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG //i save BTRFS_IOC_DEFRAG as fallback, because BTRFS_IOC_DEFRAG_RANGE not working (as i know) on several old kernels v1 -> v2 Fixed spelling in TODO TODO | 1 - src/rea

Re: [systemd-devel] [PATCH] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-07-20 Thread Timofey Titovets
2014-07-21 5:21 GMT+03:00 Andrey Borzenkov : > В Sun, 20 Jul 2014 22:27:20 +0300 > Timofey Titovets пишет: > >> Just completed TODO: >> * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG >> > > It would be helpful to give explanation "why&q

[systemd-devel] [PATCH] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-07-20 Thread Timofey Titovets
Just completed TODO: * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG TODO | 1 - src/readahead/readahead-collect.c | 22 +- src/shared/missing.h | 15 +++ 3 files changed, 32 insertions(+), 6 dele

[systemd-devel] [PATCH] Refuse mount on symlink

2014-07-19 Thread Timofey Titovets
Just completed TODO: * refuse mounting on symlinks If systemd try mounting entry from fstab on symlink, user get something like that: Jul 19 15:49:38 beplan.lan systemd[1]: Mounting /var/tmp/lol1... Jul 19 15:49:38 beplan.lan systemd[1]: var-tmp-lol1.mount Refuse mount on symlink: Operation no