Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-13 Thread Dimitri John Ledkov
On 12 March 2015 at 23:13, Jeff Waugh wrote: > On Fri, Mar 13, 2015 at 10:07 AM, Michael Biebl wrote: >>> Those are the as-installed versions (they're not manipulated again during >>> make). >> >> And how does that improve cross-compilation? > > It allows you to successfully build other software

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 13, 2015 at 09:54:48AM +1100, Jeff Waugh wrote: > On Fri, Mar 13, 2015 at 8:53 AM, Zbigniew Jędrzejewski-Szmek > wrote: > > So you prefer the second version to the first, right? Does not > > exec_prefix get assigned and then substituted, leading to an identical > > result? > > Those a

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Michael Biebl
2015-03-13 0:13 GMT+01:00 Jeff Waugh : > On Fri, Mar 13, 2015 at 10:07 AM, Michael Biebl wrote: >>> Those are the as-installed versions (they're not manipulated again during >>> make). >> >> And how does that improve cross-compilation? > > It allows you to successfully build other software that u

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Jeff Waugh
On Fri, Mar 13, 2015 at 10:11 AM, Lucas De Marchi wrote: > Both kmod and systemd are being crosscompiled for quite some time by yocto, > buildroot, etc It does interest me that buildroot doesn't have an equivalent change, despite (at least) pciutils depending on it. _

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Jeff Waugh
On Fri, Mar 13, 2015 at 10:11 AM, Lucas De Marchi wrote: > I can't but think this is just to conform to other (gnome) projects. These patches come from an absolutely non-GNOME environment (OpenWrt), but I'm appealing to an authority in actively maintained GNOME code as that's where pkg-config com

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Jeff Waugh
On Fri, Mar 13, 2015 at 10:07 AM, Michael Biebl wrote: >> Those are the as-installed versions (they're not manipulated again during >> make). > > And how does that improve cross-compilation? It allows you to successfully build other software that uses the library. A minor detail. :-) Thanks, Je

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Lucas De Marchi
On Thu, Mar 12, 2015 at 6:57 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Mar 12, 2015 at 11:00:55AM +0100, Kay Sievers wrote: >> On Thu, Mar 12, 2015 at 5:09 AM, Lucas De Marchi >> wrote: >> > On Tue, Mar 10, 2015 at 3:04 PM, Jeff Waugh wrote: >> >> Generate pkg-config files during configur

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Michael Biebl
2015-03-12 23:54 GMT+01:00 Jeff Waugh : > On Fri, Mar 13, 2015 at 8:53 AM, Zbigniew Jędrzejewski-Szmek > wrote: >> So you prefer the second version to the first, right? Does not >> exec_prefix get assigned and then substituted, leading to an identical >> result? > > Those are the as-installed vers

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Jeff Waugh
On Fri, Mar 13, 2015 at 8:53 AM, Zbigniew Jędrzejewski-Szmek wrote: > So you prefer the second version to the first, right? Does not > exec_prefix get assigned and then substituted, leading to an identical > result? Those are the as-installed versions (they're not manipulated again during make).

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 12, 2015 at 11:00:55AM +0100, Kay Sievers wrote: > On Thu, Mar 12, 2015 at 5:09 AM, Lucas De Marchi > wrote: > > On Tue, Mar 10, 2015 at 3:04 PM, Jeff Waugh wrote: > >> Generate pkg-config files during configure as God (Havoc) intended. This > >> fixes > >> all of systemd's pkg-confi

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Mar 12, 2015 at 06:27:14PM +1100, Jeff Waugh wrote: > On Thu, Mar 12, 2015 at 6:16 PM, Umut Tezduyar Lindskog > wrote: > > What does this fix Jeff, could you please explain? > > Here's the relevant part of a pkg-config file produced during make: > > prefix=/usr > exec_prefix=/usr > libdi

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Simon McVittie
On 12/03/15 16:17, Philip Van Hoof wrote: > I wonder if in a few years libsystemd.pc should have been > libsystemd-1.0.pc because a libsystemd-2.0.pc became needed? If libsystemd breaks C API, the systemd developers would just have to declare that "libsystemd" actually meant "libsystemd API 1.0",

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Philip Van Hoof
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/03/2015 8:27, Jeff Waugh wrote: > > Finally, a supporting appeal to authority: If you check > GNOME-land, practically all pkg-config files are generated at > configure time. :-) Yes and no. Certain projects in the confusing land of the gnomes

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Michael Biebl
2015-03-12 8:27 GMT+01:00 Jeff Waugh : > On Thu, Mar 12, 2015 at 6:16 PM, Umut Tezduyar Lindskog > wrote: >> What does this fix Jeff, could you please explain? > > Here's the relevant part of a pkg-config file produced during make: > > prefix=/usr > exec_prefix=/usr > libdir=/usr/lib > includedir=

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Simon McVittie
On 12/03/15 07:50, Umut Tezduyar Lindskog wrote: > Ok! I have another problem with pc files but I solve it downstream. > When I configure systemd with --configure=/usr and set the DESTDIR to > my host path, the pc files don't have the DESTDIR extension. I solve > it manually by 'sed'ding the files

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Kay Sievers
On Thu, Mar 12, 2015 at 5:09 AM, Lucas De Marchi wrote: > On Tue, Mar 10, 2015 at 3:04 PM, Jeff Waugh wrote: >> Generate pkg-config files during configure as God (Havoc) intended. This >> fixes >> all of systemd's pkg-config files when cross-compiling (and possibly other >> use >> cases). > Ka

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Umut Tezduyar Lindskog
Ok! I have another problem with pc files but I solve it downstream. When I configure systemd with --configure=/usr and set the DESTDIR to my host path, the pc files don't have the DESTDIR extension. I solve it manually by 'sed'ding the files after installation. I thought maybe your patch solves thi

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Jeff Waugh
On Thu, Mar 12, 2015 at 6:16 PM, Umut Tezduyar Lindskog wrote: > What does this fix Jeff, could you please explain? Here's the relevant part of a pkg-config file produced during make: prefix=/usr exec_prefix=/usr libdir=/usr/lib includedir=/usr/include Versus during configure: prefix=/usr exec

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Umut Tezduyar Lindskog
What does this fix Jeff, could you please explain? On Tue, Mar 10, 2015 at 7:04 PM, Jeff Waugh wrote: > Generate pkg-config files during configure as God (Havoc) intended. This fixes > all of systemd's pkg-config files when cross-compiling (and possibly other use > cases). > > (Note: I might've m

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-11 Thread Lucas De Marchi
On Tue, Mar 10, 2015 at 3:04 PM, Jeff Waugh wrote: > Generate pkg-config files during configure as God (Havoc) intended. This fixes > all of systemd's pkg-config files when cross-compiling (and possibly other use > cases). > > (Note: I might've missed some things to tidy up in Makefile.am, but not

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-11 Thread Jeff Waugh
On Wed, Mar 11, 2015 at 5:04 AM, Jeff Waugh wrote: > Generate pkg-config files during configure as God (Havoc) intended. This fixes > all of systemd's pkg-config files when cross-compiling (and possibly other use > cases). Thoughts, feelings? ___ system

[systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-10 Thread Jeff Waugh
Generate pkg-config files during configure as God (Havoc) intended. This fixes all of systemd's pkg-config files when cross-compiling (and possibly other use cases). (Note: I might've missed some things to tidy up in Makefile.am, but not 100% sure.) Signed-off-by: Jeff Waugh --- Makefile.am |