Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined

2013-12-26 Thread Holger Hans Peter Freyther
On Sat, Jul 20, 2013 at 08:37:14AM +0200, Holger Hans Peter Freyther wrote: > > But that looks like a plain automake bug. It should know that targets > > starting with a dot are not real targets. Could you file a bug > > report with automake, so this gets fixed properly? > > I sent an email to th

Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined

2013-07-20 Thread Holger Hans Peter Freyther
On Sat, Jul 20, 2013 at 03:20:02PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > ... that's at least how it looks in my testing. I don't think that > having %MAKEFILE% in the final Makefile makes any sense, and it > swhould always be "Makefile". Maybe automake forgets to substitute it > in your case

Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined

2013-07-20 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jul 20, 2013 at 08:37:14AM +0200, Holger Hans Peter Freyther wrote: > On Sat, Jul 20, 2013 at 01:09:35AM +0200, Zbigniew Jędrzejewski-Szmek wrote: > > Hi, > > > > Applied for now. > > > I picked %MAKEFILE% as this is what was in the generated Makefile before > my patch. I just tried to

Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined

2013-07-19 Thread Holger Hans Peter Freyther
On Sat, Jul 20, 2013 at 01:09:35AM +0200, Zbigniew Jędrzejewski-Szmek wrote: Hi, > Applied for now. I picked %MAKEFILE% as this is what was in the generated Makefile before my patch. I just tried to match the output. > But that looks like a plain automake bug. It should know that targets > st

Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined

2013-07-19 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jul 18, 2013 at 09:18:55AM +0200, Holger Hans Peter Freyther wrote: > From: Holger Hans Peter Freyther > > Yesterday I added test-suite.log as dependency to the .PRECIOUS > target. Automake is warning about this target being redefined > and from what I see there is no way I can stop the w

[systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined

2013-07-18 Thread Holger Hans Peter Freyther
From: Holger Hans Peter Freyther Yesterday I added test-suite.log as dependency to the .PRECIOUS target. Automake is warning about this target being redefined and from what I see there is no way I can stop the warning but I can add the %MAKEFILE% as dependency. automake warning: Makefile.am:35: