Zbigniew Jędrzejewski-Szmek writes:
> I have now pushed a change that adds UNIT= or USER_UNIT= to most
> syntax error messages. This patch mostly follows Oleksii's approach,
> but extends it to all syntax parsing functions.
>
For the last time I tried to use next approach: I added reporting
call
On Wed, 17.04.13 06:47, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:
> > If we do this, I am not entirely sure about the name "issue" though. If
> > we do this I'd like a good name that expresses that this requires
> > resolving by the admin, and sufficiently makes clear that this is not
On Fri, Apr 05, 2013 at 08:51:39PM +0200, Lennart Poettering wrote:
> On Tue, 02.04.13 07:33, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:
>
> > > +return log_struct(error ? LOG_ERR : LOG_WARNING,
> > > + "MESSAGE=[%s:%d]: %s", file, line, buf,
> > > +
On Tue, 02.04.13 07:33, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:
> > +return log_struct(error ? LOG_ERR : LOG_WARNING,
> > + "MESSAGE=[%s:%d]: %s", file, line, buf,
> > + "MESSAGE_ID=%s\n", error ? CONF_PARSER_ERROR :
> > CON
> The working assumption in systemd is that the journal is available,
> can can be used. So it storing messages in systemd (patch 2/2) goes against
> current design.
I thought about that, but that is not right I think. Journal is not the
place to store the state. It can be rotated, It can be disab
On Mon, Apr 01, 2013 at 10:17:04AM +0300, Oleksii Shevchuk wrote:
> ---
> src/shared/conf-parser.c | 86
> ++--
> src/shared/conf-parser.h | 3 ++
> 2 files changed, 57 insertions(+), 32 deletions(-)
>
> diff --git a/src/shared/conf-parser.c b/src/sha
---
src/shared/conf-parser.c | 86 ++--
src/shared/conf-parser.h | 3 ++
2 files changed, 57 insertions(+), 32 deletions(-)
diff --git a/src/shared/conf-parser.c b/src/shared/conf-parser.c
index c2cf5a6..60a6b35 100644
--- a/src/shared/conf-parser.c
++
