[Tails-dev] Please review whisperback:a4dfd008

2013-11-24 Thread Alan
Please review the following commit in whisperback master (yes, I know it's bad to work on master...) commit a4dfd008a9b11c9f6d41d4e25de891c21af6d235 Author: Tails developers Date: Tue Oct 29 14:15:05 2013 + More generic IP and MAC sanitizing regexp This fixes #6391 diff --git

Re: [Tails-dev] Please review whisperback:a4dfd008

2013-11-25 Thread bertagaz
Hi, On Sun, Nov 24, 2013 at 12:51:10PM +, Alan wrote: > Please review the following commit in whisperback master (yes, I know > it's bad to work on master...) > > commit a4dfd008a9b11c9f6d41d4e25de891c21af6d235 > Author: Tails developers > Date: Tue Oct 29 14:15:05 2013 + > > More

Re: [Tails-dev] Please review whisperback:a4dfd008

2013-11-25 Thread intrigeri
Alan wrote (24 Nov 2013 12:51:10 GMT) : > # IPs > -log_string = re.sub(r'\<([\d]{1,3}\.){3}[\d]{1,3}\>', > +log_string = re.sub(r'([\d]{1,3}\.){3}[\d]{1,3}', > r'[IP REMOVED]', > log_string) > # MAC addresses > -log_string = re

Re: [Tails-dev] Please review whisperback:a4dfd008

2013-11-25 Thread Alan
On Mon, 25 Nov 2013 10:24:49 +0100 intrigeri wrote: > Alan wrote (24 Nov 2013 12:51:10 GMT) : > > # IPs > > -log_string = re.sub(r'\<([\d]{1,3}\.){3}[\d]{1,3}\>', > > +log_string = re.sub(r'([\d]{1,3}\.){3}[\d]{1,3}', > > r'[IP REMOVED]', > >

Re: [Tails-dev] Please review whisperback:a4dfd008

2013-11-25 Thread intrigeri
Alan wrote (25 Nov 2013 13:25:23 GMT) : > On Mon, 25 Nov 2013 10:24:49 +0100 > intrigeri wrote: >> I find it slightly disturbing to see regexp changes without any single >> example (be it in the commit message, some design doc, or executable >> specification^W^Wtest suite) of what strings are new