Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread Mike Thompson
On Tue, Nov 28, 2017 at 2:28 PM, Pierre Béland wrote: > Wow again, this time a lot more efficient. With 29,000 ways, very fast > Result. > Glad it is fast on 29,000, I only tested on 2,500. Any additional ideas or suggestions can be entered on GitHub (or you can just send them to me directly).

Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread john whelan
I don't have an interest in buildings as such what a lot of my mapping is concerned with validating HOT projects. I generally sit on three and check the work as its done. Working like this I can catch new mappers making mistakes and give them gentle feedback to get the overall quality of mapping

Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread Pierre Béland
Hi Frederik, I tried with the area I provided as example in Bali. Interesting to learn that we can export a group like that to JOSM for editing / correcting.See this zone https://www.openstreetmap.org/#map=17/-8.447237794027034/115.40394650097596 As I said in a thread for Maproulette, QA tools

Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread SandorS
: Frédéric Rodrigo Cc: OpenStreetMap talk mailing list Subject: Re: [OSM-talk] finding overlapping buildings The problem is how do you fix them?  Having something directly in JOSM is useful. They tend to appear in clusters so step one is find the cluster.  Step two is sort the duplicates out. There

Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread Pierre Béland
Wow  again, this time a lot more efficient.  With 29,000 ways, very fast Result. I did not believe it since only perfect duplicates of buildings were selected. This was done by a new contributor that did participate to a geoweek mapathon responding for the Volcano emergency in Bali. He did use

Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread Frédéric Rodrigo
You can use the export menu to load all the pinned objects into JOSM, by using the remote command. Le 28/11/2017 à 22:11, john whelan a écrit : The problem is how do you fix them?  Having something directly in JOSM is useful. They tend to appear in clusters so step one is find the cluster.  S

Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread john whelan
The problem is how do you fix them? Having something directly in JOSM is useful. They tend to appear in clusters so step one is find the cluster. Step two is sort the duplicates out. There really is some very poor mapping of buildings and this at least identifies the ones that there should be no

Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread john whelan
Very nice. The process I'm using is run it to find the rough area that contains duplicate overlapping buildings. Then redownload the area so its fresh. Then scroll through the buildings. Sometimes one is beeter tagged and more accurate than the other so you really do have to scroll through them

Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread Frédéric Rodrigo
With Osmose you can also get only large building intersection by filter on severity http://osmose.openstreetmap.fr/en/map/#zoom=11&lat=49.9788&lon=8.3169&layer=Mapnik&overlays=T&item=0%2C8300&level=1%2C2&tags=&fixable= Or addressee the class 2 only. http://osmose.openstreetm

Re: [OSM-talk] finding overlapping buildings

2017-11-28 Thread Mike Thompson
John, Pierre, I made some improvements to the select duplicate buildings script. It now uses a spatial index, which makes it a lot faster on large datasets. It also now uses the actual area of the buildings and their intersection, as opposed to their bounding boxes. I will work on your other reque

Re: [OSM-talk] finding overlapping buildings

2017-11-25 Thread john whelan
ts. But please, do not touch the source data. What you think is an > error probably not error to me/others and your corrections will just make > more troubles to me/others. > > Regards, Sandor. > > > > > > > > Sent from Mail <https://go.microsoft.com/fwlink/?

Re: [OSM-talk] finding overlapping buildings

2017-11-25 Thread john whelan
Thinking it through I can already select buildings then validate for crossing ways. Dump the selection in a new layer and save it. Restart JOSM to clear the memory then load up the saved layer and the todo list. I can even chap down the number loaded into the layer. I think this is workable. U

Re: [OSM-talk] finding overlapping buildings

2017-11-25 Thread SandorS
: 22 November 2017 00:19 To: OpenStreetMap talk mailing list Subject: [OSM-talk] finding overlapping buildings Can someone describe a method I can locate these in JOSM.  I'm not after crossing buildings but just those that are mapped twice so two buildings with 50% or more overlap. Str

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread Pierre Béland
John Whelan saying> I wouldn't like to say I specialize on validating maperthons so much as do clean ups in areas> where they have left their foot print. Sorry, I wanted to say you have a lot of expertise with validations, and yes ending up cleaning after big mapping operations with new contrib

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread john whelan
My gut feel is as simple as possible especially when dealing with larger areas. I loaded a 215 kb file into JOSM and found 181 duplicated buildings but after dumping them in a todo list JOSM seemed reluctant to delete them one at a time. Could it work through a selected area? There is already a

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread Pierre Béland
I am not sure what is already included in JOSM validations, but with orthogonal and Duplicates, we cover most of the  newbies tracing buildings problems that we can automatically spot analyzing the data. Others would be about dimensions that exceed normal building size, this including big insti

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread Mike Thompson
I have a fix for the speed issue, but need to test before posting. There is also bug with how the overlap is computed. Do you want both tests in the same script? I could include "building ways with unclosed area", anything else? On Fri, Nov 24, 2017 at 4:14 PM, Pierre Béland wrote: > Ok > > for

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread Pierre Béland
Ok for the script, I simply commented the console print message and it does work. Great if developpers could collaborate to improve this as a Building Validation plugin. It could include other features such as building ways with unclosed area   Pierre Le vendredi 24 novembre 2017 18:03:4

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread Mike Thompson
Pierre, Sorry about that. I have placed a new version on Github. Alternatively, within JOSM: Scripting -> Show scripting console (not needed with the new version). Mike On Fri, Nov 24, 2017 at 3:58 PM, Pierre Béland wrote: > Great > > Thanks Mike. I installed both plugins. > > Here is my exp

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread Mike Thompson
On Fri, Nov 24, 2017 at 3:43 PM, john whelan wrote: > For a small number it works well. When faced with a sample with a thousand buildings it takes a little longer. I will work on speeding it up. It this proves useful to the community, I may try and make it into a plugin (to also include the Se

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread Pierre Béland
Great Thanks Mike. I installed both plugins. Here is my experience with the installation. To add the Scripting button on the Main Menu, I went to the Plugins section and installed the Scripting plugin. I was then able to follow your instructions to install and run SelectDuplicateBuilding.js and

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread john whelan
For a small number it works well. When faced with a sample with a thousand buildings it takes a little longer. The real test is how do you cope with a 2 mb file of OSM data containing a few thousand buildings? But having said that what you can do is if you spot one then download the surrounding

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread Mike Thompson
Pierre, Here is a script to select buildings that are not square (not orthogonal): https://github.com/MikeTho16/JOSM-Scripts SelectNonOrthogonalBuilding.js To Run: * Install JOSM's Scripting Plugin * Place ab

Re: [OSM-talk] finding overlapping buildings

2017-11-24 Thread Mike Thompson
https://github.com/MikeTho16/JOSM-Scripts SelectDuplicateBuildings.js To Run: * Install JOSM's Scripting Plugin * Place above file in a convenient location on your system * Click "Scripting" (on top menu bar) * Click "Run" * Click "..." button and select this file. * Click "Run" Selects duplicate

Re: [OSM-talk] finding overlapping buildings

2017-11-21 Thread Denis Carriere
+1 Good question John, I'll also look into that as well, I really don't think there's a solution for that in JOSM (find me all overlapping buildings that overlap by +50%). *~~* *@DenisCarriere* On Tue, Nov 21, 2017 at 5:53 PM, john whelan wrote: > >Might have to write a script to do that.

Re: [OSM-talk] finding overlapping buildings

2017-11-21 Thread john whelan
>Might have to write a script to do that. I will look into it. I don't think there is a way to do it with the standard query syntax or mapcss. Thanks John On 21 November 2017 at 20:31, Mike Thompson wrote: > > I'm not after ever building that overlaps by a small amount > Might have to write a

Re: [OSM-talk] finding overlapping buildings

2017-11-21 Thread Mike Thompson
> I'm not after ever building that overlaps by a small amount Might have to write a script to do that. I will look into it. I don't think there is a way to do it with the standard query syntax or mapcss. On Tue, Nov 21, 2017 at 6:25 PM, john whelan wrote: > > > in JOSM > > Search Syntax = M

Re: [OSM-talk] finding overlapping buildings

2017-11-21 Thread john whelan
>Osmose has an 'overlapping building' option. Top of the list I want something to feed into JOSM and not just any building that overlaps by 5%. Thanks John On 21 November 2017 at 19:49, Dave F wrote: > Osmose has an 'overlapping building' option. Top of the list > > Note: Some building are dra

Re: [OSM-talk] finding overlapping buildings

2017-11-21 Thread john whelan
> in JOSM Search Syntax = Mapcss selector (lower left of search dialog) enter the following for the search string: area:closed:areaStyle[building] ⧉ area:closed:areaStyle[building] (The character ⧉ is unicode 29c9) This works but gives the same results as select buildings then validate with cro

Re: [OSM-talk] finding overlapping buildings

2017-11-21 Thread Mateusz Konieczny
On Wed, 22 Nov 2017 00:49:10 + Dave F wrote: > Note: Some building are drawn on top of eachother to produce 3D > rendering of multi-storey buildings. It is still tagging that should be fixed (building:part is typical solution, in rare cases like http://wiki.openstreetmap.org/wiki/File:Ankar

Re: [OSM-talk] finding overlapping buildings

2017-11-21 Thread Dave F
Osmose has an 'overlapping building' option. Top of the list Note: Some building are drawn on top of eachother to produce 3D rendering of multi-storey buildings. DaveF On 21/11/2017 23:16, john whelan wrote: Can someone describe a method I can locate these in JOSM. I'm not after crossing b

Re: [OSM-talk] finding overlapping buildings

2017-11-21 Thread Mike Thompson
This doesn't take into account the 50% overlap, but: in JOSM Search Syntax = Mapcss selector (lower left of search dialog) enter the following for the search string: area:closed:areaStyle[building] ⧉ area:closed:areaStyle[building] (The character ⧉ is unicode 29c9) On Tue, Nov 21, 2017 at 4:1

[OSM-talk] finding overlapping buildings

2017-11-21 Thread john whelan
Can someone describe a method I can locate these in JOSM. I'm not after crossing buildings but just those that are mapped twice so two buildings with 50% or more overlap. Straight duplicates aren't a problem but ones that are drawn twice by two different mappers are. Yes I know it shouldn't happ