[Talk-GB] JOSM Plugin for the FHRS API

2020-06-25 Thread Kai Michael Poppe - OSM
Good morning everyone, I built a plugin for JOSM that allows you to merge data from the FHRS API into OSM with a few clicks. I'd love to find some people that would be willing to test the 0.1.2 version and report bugs they found and/or comment on the user experience. Just throw me a line at o...@

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Tony OSM
Hi Kai I'd like to help as its a good idea - however I don't know you, so could you get some community people who are well known to vouch for you, its just that I don't want strange software on my machine. Regards Tony Shield TonyS999 On 26/06/2020 05:58, Kai Michael Poppe - OSM wrote: Go

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread osm
Hey Tony, as I'm from the other side of the Channel, I doubt that there's someone from the UK community that knows me well enough to reassure you about my person (I could always ask people from the German Telegram group to tell you I'm not a lunatic *g*)

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Tony OSM
Hi Kai I've looked at github and your OSM profile - impressive, more so than mine. Pleased to make your acquaintance. I will download the fhrs app and give you feedback. Regards Tony On 26/06/2020 10:45, o...@poppe.dev wrote: Hey Tony, as I'm from the other side of the Channel, I doubt th

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Dave F via Talk-GB
As the OSM entity has to already contain the FHRS:ID tag it limits the usefulness of this plugin. Won't most have address data added when contributors initially add the FHRS tag? I certainly do. What would be useful is a way to search the LA's database for retailers which don't have a FHRS tag

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread osm
Hi Dave, whilst doing the current week's Q&A session (https://wiki.openstreetmap.org/wiki/Schwerpunkt_der_Woche/Overpass_Postcodes), where we check postcodes against their country's respective pattern I came across multiple object, that _had_ an fhrs:id but were m

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread osm
And of course, you're right Dave, it would be great to lookup stuff that hasn't got FHRS info. As I was already planning on implementing the Business Types from the API to check if the amenity fits, I shall see if I can gather information on objects on the layer that could poentially ha

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Robert Skedgell
The fhrs:authority tag isn't normally necessary as it can be inferred from the surrounding local authority boundary. There are some exceptions to this, including premises where the food hygiene authority is the City of London Corporation, but which are not located within the City of London boundar

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Tony OSM
Hi It works without the FHRS:ID - just used it on 5 businesses I know. It needs the address detailsĀ  - road and place seem to be sufficient, post code is optional. The FHRS -> Search entry will take the address details and get one or more entries - select which you want. Then a dialog appear

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread osm
Thanks for the praise, Tony, yes, the plugin needs EITHER of addr:city, addr:street or addr:postcode (addr:housenumer will not be sufficient). If these are missing, the FHRS API will complain that the process might take too much CPU capacity, and thus will not ret

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Dave F via Talk-GB
I'm getting this after selecting the Search Entry option: https://snipboard.io/7J6Eb0.jpg Latest JOSM version Any ideas? On 26/06/2020 10:45, o...@poppe.dev wrote: Hey Tony, as I'm from the other side of the Channel, I doubt that there's someone from the UK community that knows me well enou

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Tony OSM
Hi I get that also. In my case its caused by not selecting an entry in the table presented after the initial Search entry. I've reported this issue & Kai is aware. Tony On 26/06/2020 15:54, Dave F via Talk-GB wrote: I'm getting this after selecting the Search Entry option: https://snipboar

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Kai Michael Poppe - OSM
Hi Tony, Hi Dave, yep, that's the same Issue (https://github.com/kmpoppe/fhrsPlugin/issues/2) - current, you HAVE to select an entry, even if there is only one. I have covered for that now in code, but I'm thinking it might be easier, if there is just one entry, to automatically go for that one wi

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Tony OSM
Hi Kai Was thinking that automatically selecting the first array element which will be highlighted in the display will solve it. My belt and braces is to catch that exception and display a suitable error message ( should never occur) Tony On 26/06/2020 16:35, Kai Michael Poppe - OSM wrote:

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-26 Thread Kai Michael Poppe - OSM
Hi everyone, Version 0.1.3 is now available for download from https://github.com/kmpoppe/fhrsPlugin Thank you all for being so active in helping with the development of this small part of the OSM bubble! Good n8! Kai On 26.06.2020 17:48, Tony OSM wrote: > Hi Kai > > Was thinking that automati

Re: [Talk-GB] JOSM Plugin for the FHRS API

2020-06-28 Thread Kai Michael Poppe - OSM
Good evening, with (most) issues fixed, I've upgraded the plugin to v 0.1.5 and also published it in the JOSM wiki so that you can download it via your plugin dialog within JOSM. I hope you find it as useful as others have already reported :-) Thanks to everyone who has tested and helped me move