Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-02-10 Thread Guy Harris via tcpdump-workers
--- Begin Message --- On Jan 27, 2023, at 4:53 AM, Denis Ovsienko wrote: > On Fri, 27 Jan 2023 01:40:48 -0800 > Guy Harris wrote: > >> *don't* support C99 inline? If not, we could just remove the call >> from configure.ac and the definition from aclocal.m4. > > In 2002 in commit b1263c6 you w

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-02-08 Thread Denis Ovsienko via tcpdump-workers
--- Begin Message --- On Fri, 27 Jan 2023 12:53:28 + Denis Ovsienko via tcpdump-workers wrote: [...] > I do not understand yet if AC_LBL_C_INLINE could just disappear safely > altogether instead of being replaced with AC_C_INLINE. In order to play safe, it has been replaced with an AC_C_INLI

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-27 Thread Denis Ovsienko via tcpdump-workers
--- Begin Message --- On Fri, 27 Jan 2023 01:40:48 -0800 Guy Harris wrote: > On Jan 22, 2023, at 9:59 AM, Denis Ovsienko via tcpdump-workers > wrote: > > > I have also removed AC_LBL_C_INLINE and a conditional substitute for > > Tru64 pfopen() from tcpslice. Interestingly, tcpslice and tcpdump

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-27 Thread Guy Harris via tcpdump-workers
--- Begin Message --- On Jan 22, 2023, at 9:59 AM, Denis Ovsienko via tcpdump-workers wrote: > I have also removed AC_LBL_C_INLINE and a conditional substitute for > Tru64 pfopen() from tcpslice. Interestingly, tcpslice and tcpdump, > which don't call pfopen(), used to have this substitute, and

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-25 Thread Denis Ovsienko via tcpdump-workers
--- Begin Message --- Hello all. I have removed some unused Autoconf macros here and there, including AC_LBL_CHECK_LIB in tcpslice and libpcap. This macro still remains in tcpdump, where it was a part of the initial git commit in 1999, and where it became unused in 2001 (commit d57c77a), with the

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-22 Thread Denis Ovsienko via tcpdump-workers
--- Begin Message --- On Thu, 19 Jan 2023 15:57:30 -0800 Guy Harris wrote: > On Jan 19, 2023, at 3:20 PM, Denis Ovsienko > wrote: > > > * AC_LBL_SSLEAY -- is there anything useful to take from here? > > No, it's been replaced by the "Check for OpenSSL/libressl libcrypto" > code in configure.

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-19 Thread Guy Harris via tcpdump-workers
--- Begin Message --- On Jan 19, 2023, at 3:20 PM, Denis Ovsienko wrote: > * AC_LBL_SSLEAY -- is there anything useful to take from here? No, it's been replaced by the "Check for OpenSSL/libressl libcrypto" code in configure.ac.--- End Message --- ___

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-19 Thread Denis Ovsienko via tcpdump-workers
--- Begin Message --- On Wed, 18 Jan 2023 15:53:21 -0800 Guy Harris wrote: > On Jan 18, 2023, at 3:32 PM, Denis Ovsienko via tcpdump-workers > wrote: > > > As it turns out, there is another unused macro > > (AC_LBL_HAVE_RUN_PATH), tcpslice became the first to lose this > > luggage. > > Unuse

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-18 Thread Guy Harris via tcpdump-workers
--- Begin Message --- On Jan 18, 2023, at 3:32 PM, Denis Ovsienko via tcpdump-workers wrote: > As it turns out, there is another unused macro (AC_LBL_HAVE_RUN_PATH), > tcpslice became the first to lose this luggage. Unused in libpcap back to 0.4 and tcpdump back to 3.4, so it may be another one

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-18 Thread Denis Ovsienko via tcpdump-workers
--- Begin Message --- On Wed, 18 Jan 2023 09:22:28 -0500 Michael Richardson wrote: > I haven't heard a clear argument as to what autoconf/configure gets > us today over cmake, and maintaining both seems a huge waste of > energy. There's a comment buried in one of the build files: a release tarba

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-18 Thread Guy Harris via tcpdump-workers
--- Begin Message --- On Jan 18, 2023, at 1:07 AM, Denis Ovsienko wrote: > Thank you for explaining the context Guy, it is very educational. A significant part of what's in autoconf, and a significant part of what's in at least some configure scripts, dates back to old UN*Xes. ISO C and POSIX

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-18 Thread Denis Ovsienko via tcpdump-workers
--- Begin Message --- On Tue, 17 Jan 2023 18:35:58 -0800 Guy Harris wrote: > If you're curious what AC_LBL_FIXINCLUDES is for, and why most > platforms don't need it, continue reading. Thank you for explaining the context Guy, it is very educational. Is AC_LBL_UNION_WAIT of a similar origin? N

Re: [tcpdump-workers] AC_LBL_FIXINCLUDES does not make it into configure

2023-01-17 Thread Guy Harris via tcpdump-workers
--- Begin Message --- On Jan 17, 2023, at 3:13 PM, Denis Ovsienko via tcpdump-workers wrote: > In tcpdump commit cee234c there are three messages changed in > aclocal.m4, but only two messages changed in the resulting configure > script. After a brief look it is clear that it is the third messa