Re: [teampractices] Code review social norms

2016-03-18 Thread Antoine Musso
Le 16/03/2016 00:48, Kevin Smith a écrit : > There are lots of different cases here, as well as existing norms, and > also preferences. > > I would mention that in some cases, I would prefer to accept the commit > as is, and then perform minor refactoring, such as changing a name, > fixing a typo,

Re: [teampractices] Code review social norms

2016-03-18 Thread Subramanya Sastry
On 03/16/2016 02:33 AM, Rob Lanphier wrote: On Tue, Mar 15, 2016 at 8:03 PM, Mukunda Modell > wrote: On Tue, Mar 15, 2016 at 6:48 PM, Kevin Smith mailto:ksm...@wikimedia.org>> wrote: I would mention that in some cases, I would prefer to accept t