Rfc 3442 is what I referred to.
Ken
On 3 Dec 2013 22:54, "Matthew Dempsky" wrote:
> On Tue, Dec 3, 2013 at 5:55 PM, Kenneth R Westerback
> wrote:
> > Located here, the addition of the 255.255.255.255 route is not done in
> the
> > presence of DHO_CLASSLESS_STATIC_ROUTES. As I recall only D
On Tue, Dec 3, 2013 at 5:55 PM, Kenneth R Westerback
wrote:
> Located here, the addition of the 255.255.255.255 route is not done in the
> presence of DHO_CLASSLESS_STATIC_ROUTES. As I recall only DHO_ROUTERS and
> DHO_STATIC_ROUTES are incompatible with DHO_CLASSLESS_STATIC_ROUTES. So
> we may wa
On Tue, Dec 03, 2013 at 04:15:10PM -0800, Matthew Dempsky wrote:
> The patch below extends dhclient to mimic this logic from ISC DHCP's
> linux script:
>
> if [ "x$new_subnet_mask" = "x255.255.255.255" ] ; then
> route add -host $router dev $interface
> fi
> route
An unused function in wpi(4). #if 0 out the function for now.
if_wpi.c:510:1: error: unused function 'wpi_mem_write'
[-Werror,-Wunused-function]
OK?
Index: if_wpi.c
===
RCS file: /home/cvs/src/sys/dev/pci/if_wpi.c,v
retrieving rev
The ValleyView PCI ids are #ifdef notyet in the table which references these
structs so
stick these under #ifdef notyet too until the ids are enabled.
i915_drv.c:288:39: error: unused variable 'intel_valleyview_m_info'
[-Werror,-Wunused-const-variable]
i915_drv.c:297:39: error: unused variable '
The patch below extends dhclient to mimic this logic from ISC DHCP's
linux script:
if [ "x$new_subnet_mask" = "x255.255.255.255" ] ; then
route add -host $router dev $interface
fi
route add default gw $router $metric_arg dev $interface
With this change, dhclient
ieee80211_edca_table is unused within the code so just #if 0 it out for
but but keeping it around for future reference in case it ever becomes
useful.
ieee80211_output.c:311:5: error: unused variable 'ieee80211_edca_table'
[-Werror,-Wunused-const-variable]
OK?
Index: ieee80211_output.c
===
An unused function in the UVM code. #if 0 it out for now.
uvm_map.c:171:14: error: unused function 'uvm_mapentry_freecmp'
[-Werror,-Wunused-function]
uvm_map.c:353:1: error: unused function 'uvm_mapentry_freecmp'
[-Werror,-Wunused-function]
OK?
Index: uvm_map.c
===
The relvent code using amd64_errata_set4 is #if 0'd out so do the same
to the variable.
amd64errata.c:103:22: error: unused variable 'amd64_errata_set4'
[-Werror,-Wunused-const-variable]
OK?
Index: amd64/amd64/amd64errata.c
===
RC
Some unused functions in ohci(4). #if 0 them out to appease the warnings but
keep the code around in case it will be used at some point in the future.
ohci.c:193:1: error: unused function 'OREAD1' [-Werror,-Wunused-function]
ohci.c:200:1: error: unused function 'OREAD2' [-Werror,-Wunused-function]
Put UREAD4 under #ifdef UHCI_DEBUG as it is only used by a function
for debugging which is also under UHCI_DEBUG.
uhci.c:256:1: error: unused function 'UREAD4' [-Werror,-Wunused-function]
OK?
Index: uhci.c
===
RCS file: /home/cvs/s
On 2013/12/03 17:32, Brad Smith wrote:
> The bit of code that calls this function is #if 0'd out so leave the function
> there but #if 0 it out as well.
>
> atw.c:3021:1: error: unused function 'atw_hw_decrypted'
> [-Werror,-Wunused-function]
OK, though after looking through BUGS in the manpage,
Matthew Dempsky:
> I think you're missing a "{" after the do. :)
Hmm, yes. This survives a make build:
Index: sys/sys/select.h
===
RCS file: /cvs/src/sys/sys/select.h,v
retrieving revision 1.13
diff -u -p -r1.13 select.h
--- sys/sy
The bit of code that calls this function is #if 0'd out so leave the function
there but #if 0 it out as well.
atw.c:3021:1: error: unused function 'atw_hw_decrypted'
[-Werror,-Wunused-function]
OK?
Index: atw.c
===
RCS file: /home
This popped out at me when I was looking at this driver awhile ago but I see
now LLVM even warns about the fact that it is unused within the smc91cxx
driver code.
smc91cxx.c:191:1: error: unused function 'ether_cmp' [-Werror,-Wunused-function]
OK?
Index: smc91cxx.c
=
This is unused within the aic79xx code.
aic79xx.c:93:20: error: unused variable 'num_chip_names'
[-Werror,-Wunused-const-variable]
OK?
Index: aic79xx.c
===
RCS file: /home/cvs/src/sys/dev/ic/aic79xx.c,v
retrieving revision 1.51
di
On Tue, Dec 03, 2013 at 08:53:37PM +0100, Christian Weisgerber wrote:
> The xenocara fallout from libcompat removal is actually minimal.
>
> I don't know if there are any extant operating systems that still
> require for getrusage().
>
ok.
> Index: app/xgc/tests.c
> ===
> I wasn't sure if people might be calling FD_COPY()/FD_ZERO() with
> void* or char* typed arguments (or other custom sized types). If we
> can assume they'll only pass fd_set* arguments, then they could be
> done away with.
Hmm, that's a good question. The base appears clean, but it rarely
make
On Tue, Dec 3, 2013 at 1:39 PM, Philip Guenther wrote:
> What problem does the casts solve?
I wasn't sure if people might be calling FD_COPY()/FD_ZERO() with
void* or char* typed arguments (or other custom sized types). If we
can assume they'll only pass fd_set* arguments, then they could be
don
On Tue, Dec 3, 2013 at 1:55 PM, Christian Weisgerber wrote:
> +#if __BSD_VISIBLE
> +#defineFD_COPY(f, t) (void)(*(t) = *(f))
> +#endif
> +#defineFD_ZERO(p) do \
> + fd_set *_p = (p); \
> + __size_t _n = _
Combining the various suggestions, I now have this:
Index: sys/sys/select.h
===
RCS file: /cvs/src/sys/sys/select.h,v
retrieving revision 1.13
diff -u -p -r1.13 select.h
--- sys/sys/select.h29 Oct 2013 02:44:52 - 1.13
+++
> On Tue, Dec 3, 2013 at 12:37 PM, Philip Guenther wrote:
> > needs to stay until FD_ZERO() and FD_COPY() are changed to
> > not use memset()/memcpy().
>
> Good point.
>
> Would something like this work?
>
> #define FD_COPY(f, t) (*(fd_set *)(t) = *(const fd_set *)(f))
Regarding your FD_ZER
On Tue, Dec 3, 2013 at 1:03 PM, Matthew Dempsky wrote:
> On Tue, Dec 3, 2013 at 12:37 PM, Philip Guenther wrote:
>> needs to stay until FD_ZERO() and FD_COPY() are changed to
>> not use memset()/memcpy().
>
> Good point.
>
> Would something like this work?
>
> #define FD_COPY(f, t) (*(fd_set *
On Tue, Dec 3, 2013 at 12:37 PM, Philip Guenther wrote:
> needs to stay until FD_ZERO() and FD_COPY() are changed to
> not use memset()/memcpy().
Good point.
Would something like this work?
#define FD_COPY(f, t) (*(fd_set *)(t) = *(const fd_set *)(f))
static const fd_set __fd_zero_set;
#defi
Philip Guenther:
> needs to stay until FD_ZERO() and FD_COPY() are changed to
> not use memset()/memcpy().
We could grab this from FreeBSD:
#if __BSD_VISIBLE
#define FD_COPY(f, t) (void)(*(t) = *(f))
#endif
#define FD_ZERO(p) do { \
fd_set *_p;
> I read sys/dev/usb/if_cdce.c and found sc->cdce_unit is refered but
> none initializes. Maybe the fix is required like this :-
>
[...]
> + sc->cdce_unit = self->dv_unit;
I really dislike variables that serve no purpose. The same thing is
available straight out of struct device. I've also
Hello,
I read sys/dev/usb/if_cdce.c and found sc->cdce_unit is refered but
none initializes. Maybe the fix is required like this :-
Index: if_cdce.c
===
RCS file: /cvs/src/sys/dev/usb/if_cdce.c,v
retrieving revision 1.57
diff -u -p -
Hello,
jca@ privately advised that I should write my own copyright to
describe who modified the code.
I am planning to add notice like if_axe.c and sent the diff to
him but there is no answer (too busy?). So I ask here.
Is there any good solution?
Thanks,
SASANO Takayoshi
Index: if_ugl.c
On Tue, Dec 3, 2013 at 12:08 PM, Christian Weisgerber
wrote:
> POSIX says select() and everything it needs should come from
> . Eight years ago our headers have been fixed to
> provide this. Time to acknowledge this in the man page, too.
>
> ok?
...
> -.Fd #include
needs to stay until FD_ZERO
On Tue, Dec 3, 2013 at 12:08 PM, Christian Weisgerber
wrote:
> ok?
ok matthew
> +.Fd #include
Worth using .In instead while you're at it?
POSIX says select() and everything it needs should come from
. Eight years ago our headers have been fixed to
provide this. Time to acknowledge this in the man page, too.
ok?
Index: select.2
===
RCS file: /cvs/src/lib/libc/sys/sele
The xenocara fallout from libcompat removal is actually minimal.
I don't know if there are any extant operating systems that still
require for getrusage().
Index: app/xgc/tests.c
===
RCS file: /cvs/xenocara/app/xgc/tests.c,v
retriev
On Tue, Dec 3, 2013 at 3:55 AM, Stuart Henderson wrote:
> On 2013/12/02 23:39, Eitan Adler wrote:
>> Hi all,
>>
>> This is a simple enough patch:
>>
>> Index: pf.os
>> ==*=
>> RCS file: /cvs/src/etc/pf.os,v
>> retrieving revision 1.26
On 3/12/2013 7:12 PM, Björn Ketelaars wrote:
/etc/nsd.conf has been moved to /var/nsd/etc/nsd.conf. /etc/changelist has been
changed accordingly, /etc/mtree/special has not. NSD's configuration file
resides in a root:_nsd owned directory with permission set at 0750. As such
there should be no nee
* Stuart Henderson [2013-12-03 09:55]:
> On 2013/12/02 23:39, Eitan Adler wrote:
> > Index: pf.os
> DragonFly 2.7 is 3 years old; should the version range in this last one
> be extended, or has the signature changed now?
there was a much more complete update of pf.os committed a longish
time ago,
On 2013/12/03 09:12, Björn Ketelaars wrote:
> /etc/nsd.conf has been moved to /var/nsd/etc/nsd.conf. /etc/changelist has
> been
> changed accordingly, /etc/mtree/special has not. NSD's configuration file
> resides in a root:_nsd owned directory with permission set at 0750. As such
> there should b
On 2013/12/02 23:39, Eitan Adler wrote:
> Hi all,
>
> This is a simple enough patch:
>
> Index: pf.os
> ==*=
> RCS file: /cvs/src/etc/pf.os,v
> retrieving revision 1.26
> diff -u -r1.26 pf.os
> --- pf.os 3 Aug 2012 12:25:16 - 1.2
On 03/12/2013, Ian McWilliam wrote:
> On 3/12/2013 7:12 PM, Björn Ketelaars wrote:
> >/etc/nsd.conf has been moved to /var/nsd/etc/nsd.conf. /etc/changelist has
> >been
> >changed accordingly, /etc/mtree/special has not. NSD's configuration file
> >resides in a root:_nsd owned directory with permi
/etc/nsd.conf has been moved to /var/nsd/etc/nsd.conf. /etc/changelist has been
changed accordingly, /etc/mtree/special has not. NSD's configuration file
resides in a root:_nsd owned directory with permission set at 0750. As such
there should be no need for inclusion of nsd.conf in the mtree specif
39 matches
Mail list logo
