Re: feed l4 information into trunk(4) hash

2014-12-12 Thread Sebastian Benoit
Stuart Henderson(st...@openbsd.org) on 2014.12.11 23:52:44 +: I'm wondering what reception this will get. It feeds TCP/UDP port numbers into the hash for trunk(4) load balancing, so connections between a single pair of hosts will get distributed across NICs. Taken from FreeBSD r232629,

Re: random and time

2014-12-12 Thread FRIGN
On Thu, 11 Dec 2014 19:49:35 -0700 Theo de Raadt dera...@cvs.openbsd.org wrote: From the code I've been reading, I am certain some folk have looked into it. I'd even go as far as saying that there should be some folk around owning 0-days building on top of that. It's easy to synchronize with a

pcap(3) manpage fixes

2014-12-12 Thread Kaspars Bankovskis
Function arguments in synopsis for pcap_inject and pcap_sendpacket are a bit messed up by comma. Types updated from actual code. And some .An and .In macro fixes while there. Index: pcap.3 === RCS file: /cvs/src/lib/libpcap/pcap.3,v

swapctl(2) manpage cleanup

2014-12-12 Thread Kaspars Bankovskis
The last sentence in HISTORY perhaps made sense before forking from Nx, but imho it's not relevant afterwards, especially since it mentions a header file which didn't come to Ox. .In and .An macro fixes, while there. Index: swapctl.2

Re: Reduce OPENSSL_VERSION_TEXT to LibreSSL

2014-12-12 Thread Brent Cook
On Thu, Dec 11, 2014 at 04:57:21PM +0100, Mark Kettenis wrote: From: Bob Beck b...@openbsd.org Date: Thu, 11 Dec 2014 08:39:15 -0700 i.e. if we want the openssl command to report someting specific we put it in there, not a globally visible string that will be used for the wrong

Re: pcap(3) manpage fixes

2014-12-12 Thread Ingo Schwarze
Hi Kaspars, Kaspars Bankovskis wrote on Fri, Dec 12, 2014 at 03:22:16PM +0200: Function arguments in synopsis for pcap_inject and pcap_sendpacket are a bit messed up by comma. Types updated from actual code. And some .An and .In macro fixes while there. Committed, thanks. Some more argument

chmod: range checks

2014-12-12 Thread Tobias Stoeckmann
Hi, chmod doesn't check if the program name is at least 3 characters long before checking its index 2. Also, there is a compiler warning about signed vs unsigned when val is used. In one instance, it's used with strtoul, in another with strtol, checking its ranges. It's okay due to automatic

panic: ehci_device_clear_toggle: queue active

2014-12-12 Thread Abel Abraham Camarillo Ojeda
I think this problem is particular to these machine because I cannot reproduce in my other openbsd machines when using same kernel and usb dongle... serial transcript - dmesg + ddb - attached - cannot paste well because of gmail. transcript Description: Binary data

Re: chmod: range checks

2014-12-12 Thread Todd C. Miller
On Fri, 12 Dec 2014 18:16:35 +0100, Tobias Stoeckmann wrote: chmod doesn't check if the program name is at least 3 characters long before checking its index 2. OK. Also, there is a compiler warning about signed vs unsigned when val is used. In one instance, it's used with strtoul, in

Re: panic: ehci_device_clear_toggle: queue active

2014-12-12 Thread Claus Assmann
On Fri, Dec 12, 2014, Abel Abraham Camarillo Ojeda wrote: I think this problem is particular to these machine because I cannot reproduce in my other openbsd Something similar happens on a Dell 6150 laptop (see below). The same (ANT+) USB stick does not trigger a panic on a Dell D830 (running

Re: relayd: convert to siphash

2014-12-12 Thread Ted Unangst
On Wed, Dec 10, 2014 at 21:51, Max Fillinger wrote: Here's a version without malloc'ing the key. Looks like it still does? + if (sip_key == NULL) { + sip_key = malloc(SIPHASH_KEY_LENGTH); +

Re: Make dhclient not use lease files

2014-12-12 Thread patric conant
Why aren't you just deleting the lease file on shutdown? On Dec 8, 2014 10:04 AM, Jurjen Oskam jur...@osk.am wrote: Hi, My (residential) ISP assigns me an IP address using DHCP. The lease time is 7 days or so. I just put dhcp in hostname.re1 and everything works, except for a minor

Re: chmod: range checks

2014-12-12 Thread patrick keshishian
On Fri, Dec 12, 2014 at 10:45:04AM -0700, Todd C. Miller wrote: On Fri, 12 Dec 2014 18:16:35 +0100, Tobias Stoeckmann wrote: chmod doesn't check if the program name is at least 3 characters long before checking its index 2. OK. Just throwing this out there: will this program ever get

ospfd siphash

2014-12-12 Thread Ted Unangst
This is pretty easy. Index: lsupdate.c === RCS file: /cvs/src/usr.sbin/ospfd/lsupdate.c,v retrieving revision 1.41 diff -u -p -r1.41 lsupdate.c --- lsupdate.c 17 Jan 2013 09:06:35 - 1.41 +++ lsupdate.c 12 Dec 2014 18:53:50

Re: chmod: range checks

2014-12-12 Thread Tobias Stoeckmann
On Fri, Dec 12, 2014 at 10:42:21AM -0800, patrick keshishian wrote: Just throwing this out there: will this program ever get installed with filename shorter than ch{grp,mod,own,flags}? No. It's still a form of input validation. Therefore, it should be done. And a user can create such a link

Re: relayd: convert to siphash

2014-12-12 Thread Reyk Floeter
On Fri, Dec 12, 2014 at 12:57:08PM -0500, Ted Unangst wrote: On Wed, Dec 10, 2014 at 21:51, Max Fillinger wrote: Here's a version without malloc'ing the key. Looks like it still does? + if (sip_key == NULL) { + sip_key =

Re: siphash in bgpd

2014-12-12 Thread Ted Unangst
On Mon, Dec 08, 2014 at 18:58, Ted Unangst wrote: bgpd seemed like a good place to try out the new siphash functions. Three hash tables are pretty straight forward conversions. Diff below. Done. rde_rib.c nexthop_hash uses hash32 for ipv6, and a simple xor hash for ipv4. I left that alone

acpithinkpad handle event 0x6060

2014-12-12 Thread Frederic Nowak
Hi! My ThinkPad Edge E130 (see dmesg below) generates this message, if the Fn-key is pressed for a few seconds: acpithinkpad0: unknown event 0x6060 I am not quite sure what the event is for, so the event name in the diff below might be misleadig, but I found some hints that the windows drivers

ldapd: server response code should be long long

2014-12-12 Thread Matthew Weigel
The function send_ldap_extended_response() takes as its second-to-last argument a long long result_code, but the infrastructure for handling LDAP extended operations in ldap_extended() restricts them to an int. I don't think there's any risk or bug here, this is just type correctness. Index:

Re: LibreSSL 2.1.2 released

2014-12-12 Thread Jan Engelhardt
With libressl 2.1.2, I observe: ldd -r /usr/lib64/libtls.so.1 linux-vdso.so.1 (0x7ffe5462e000) libc.so.6 = /lib64/libc.so.6 (0x7ffe5405f000) /lib64/ld-linux-x86-64.so.2 (0x7ffe5463) undefined symbol: GENERAL_NAME_free (/usr/lib64/libtls.so.1)

Re: LibreSSL 2.1.2 released

2014-12-12 Thread Brent Cook
On Dec 12, 2014, at 5:04 PM, Jan Engelhardt jeng...@inai.de wrote: With libressl 2.1.2, I observe: ldd -r /usr/lib64/libtls.so.1 linux-vdso.so.1 (0x7ffe5462e000) libc.so.6 = /lib64/libc.so.6 (0x7ffe5405f000) /lib64/ld-linux-x86-64.so.2 (0x7ffe5463)

ukbd.c update for older macbook airs

2014-12-12 Thread William Orr
Hey, On some macbook airs, the function keys have different functionality when the Fn key is pressed. I've added an additional munge function to handle these particular cases. Thanks, William Orr Index: sys/dev/usb/ukbd.c === RCS