rc.d.8 should reference rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility in rc.d.8. Regards, Index: rc.d.8 === RCS file: /cvs/src/share/man/man8/rc.d.8,v retrieving revision 1.28 diff -u -p -r1.28 rc.d.8 --- rc.d.8 25 Feb 2015 23:01:28 - 1.28 +++ rc.d.8

Re: syslogd tls read write events

2015-09-18 Thread Bob Beck
ok beck@ On Fri, Sep 18, 2015 at 5:17 PM, Alexander Bluhm wrote: > On Fri, Sep 18, 2015 at 05:04:55PM -0600, Bob Beck wrote: >> ... and just to be clear, you only need to event_del when you are >> switching to wanting a write when you did want a read before, and vice >>

Re: mpsafe ip_carp

2015-09-18 Thread David Gwynne
> On 13 Sep 2015, at 6:34 pm, David Gwynne wrote: > > i did this yesterday, but havent had a chance to beat on it properly > yet. > > if anyone would like to give it a go it would be much appreciated. > im particularly interested in stability while carp configuration > is

Re: doas closefrom

2015-09-18 Thread Sebastian Benoit
Ted Unangst(t...@tedunangst.com) on 2015.09.17 21:12:28 -0400: > Sebastian Benoit wrote: > > ok, but in other places we have closefrom(STDERR_FILENO + 1) > > is that really more clear? it only makes sense if you know stderr is 2. sure, but writing closefrom(3) requires the same or equivalent

libsa: explicit_bzero

2015-09-18 Thread Sebastien Marie
Hi, I noted that in libsa, explicit_bzero just calls bzero. Giving that now we support softraid fulldisk encryption, a compiler optimisation could make the current version of explicit_bzero in libsa going nop, leaving encryption keys (or other sensible material) in memory. The following patch

[patch] tame regress for "dns" / "cmsg"

2015-09-18 Thread Sebastien Marie
Hi, In the internal conversion of _TM_* to TAME_*, some bits were lost for "dns" and "cmsg" in the `tamereq' array. The initial version of tamereq array (in 1.39) was (for interesting bits): { "malloc", _TM_SELF | _TM_MALLOC }, { "unix", _TM_SELF | _TM_RW | _TM_UNIX },

Re: reuse pf state ids to "hash" packets onto trunk members

2015-09-18 Thread Stuart Henderson
On 2015-09-18, David Gwynne wrote: > this lets pf embed the state id into the mbuf as a "flow id" so > other subsystems can use it. eg, trunk can pull it out and use it. I like this but it does change the path distribution. Previously all flows from host A to host B were

ipmi(4) - Support ipmitool IOCTL etc.

2015-09-18 Thread Masao Uebayashi
I've prepared a set of patches to make OpenBSD's ipmi(4) work with ipmitool via /dev/ipmi*, following what FreeBSD did. I'd like to hear feedback from developers and users. https://github.com/uebayasi/openbsd-ipmi I'm also looking for someone whose machine supports BT (block transfer)

Re: reuse pf state ids to "hash" packets onto trunk members

2015-09-18 Thread David Gwynne
> On 18 Sep 2015, at 6:17 pm, Stuart Henderson wrote: > > On 2015-09-18, David Gwynne wrote: >> this lets pf embed the state id into the mbuf as a "flow id" so >> other subsystems can use it. eg, trunk can pull it out and use it. > > I like this but

Re: Brainy: a few bugs

2015-09-18 Thread Mark Kettenis
> From: Maxime Villard > Date: Fri, 11 Sep 2015 21:18:18 +0200 > > _23/ USE-AFTER-FREE: sys/dev/sun/z8530ms.c rev1.2 This one's fixed now as well. Thanks.

rc.8 should reference rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility in rc.8. Regards, Index: rc.8 === RCS file: /cvs/src/share/man/man8/rc.8,v retrieving revision 1.40 diff -u -p -r1.40 rc.8 --- rc.822 Jul 2014 07:38:52 - 1.40 +++ rc.818 Sep

rc.conf.8 should ref rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility in rc.conf.8 (which discusses rc.conf.local). Rob Index: rc.conf.8 === RCS file: /cvs/src/share/man/man8/rc.conf.8,v retrieving revision 1.26 diff -u -p -r1.26 rc.conf.8 --- rc.conf.8 4 May 2015

afterboot.8 should reference rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility from afterboot.8. Regards, Index: afterboot.8 === RCS file: /cvs/src/share/man/man8/afterboot.8,v retrieving revision 1.147 diff -u -p -r1.147 afterboot.8 --- afterboot.8 30 Jul 2015 08:03:49 -

Re: kill struct inpcbtable's inpt_lastport

2015-09-18 Thread David Hill
On Fri, Sep 18, 2015 at 11:05:55PM +0200, Vincent Gross wrote: > On 09/18/15 15:18, David Hill wrote: > > Is this 'if (count)' statement needed? We know first > last, so count > > will always be positive. lastport will always be set. > > > if last == first, then the if statement will be false

Re: kill struct inpcbtable's inpt_lastport

2015-09-18 Thread Vincent Gross
On 09/18/15 15:18, David Hill wrote: > Is this 'if (count)' statement needed? We know first > last, so count > will always be positive. lastport will always be set. > if last == first, then the if statement will be false and lastport will > be uninitialized, I believe. > Both remarks are

syslogd tls read write events

2015-09-18 Thread Alexander Bluhm
Hi, I discovered what caused the strange event loss in syslogd during the hackaton. I had mixed EV_READ and EV_WRITE events on the ev_read and ev_write event structures. The correct way is to use each event for its read and write purpose and instead switch the handler. Then libevent is no

Re: syslogd tls read write events

2015-09-18 Thread Bob Beck
... and just to be clear, you only need to event_del when you are switching to wanting a write when you did want a read before, and vice versa... correct? if that's the case it reads ok... On Fri, Sep 18, 2015 at 4:55 PM, Alexander Bluhm wrote: > Hi, > > I discovered

Re: syslogd tls read write events

2015-09-18 Thread Alexander Bluhm
On Fri, Sep 18, 2015 at 05:04:55PM -0600, Bob Beck wrote: > ... and just to be clear, you only need to event_del when you are > switching to wanting a write when you did want a read before, and vice > versa... correct? Yes. When I am doing reads and get a TLS_WANT_POLLOUT, I have to do a

Re: reuse pf state ids to "hash" packets onto trunk members

2015-09-18 Thread Stuart Henderson
On 2015/09/18 20:18, David Gwynne wrote: > > > On 18 Sep 2015, at 6:17 pm, Stuart Henderson wrote: > > > > On 2015-09-18, David Gwynne wrote: > >> this lets pf embed the state id into the mbuf as a "flow id" so > >> other subsystems can use it. eg,

Re: doas closefrom

2015-09-18 Thread Martin Pieuchot
On 18/09/15(Fri) 12:02, Sebastian Benoit wrote: > Ted Unangst(t...@tedunangst.com) on 2015.09.17 21:12:28 -0400: > > Sebastian Benoit wrote: > > > ok, but in other places we have closefrom(STDERR_FILENO + 1) > > > > is that really more clear? it only makes sense if you know stderr is 2. What's

Re: reuse pf state ids to "hash" packets onto trunk members

2015-09-18 Thread Martin Pieuchot
On 18/09/15(Fri) 15:55, David Gwynne wrote: > hashing bits of packet headers to tie connections to particular > physical interfaces within a trunk turns out to be fairly expensive. > in my very unscientific testing it is about 20% of the cost of udp > traffic generated with tcpbench -u. > > we

Re: Brainy: a few bugs

2015-09-18 Thread Visa Hankala
On Fri, Sep 11, 2015 at 09:18:18PM +0200, Maxime Villard wrote: > _20/ UNINITIALIZED VARIABLE: sys/arch/sgi/dev/if_iec.c rev1.14 Fixed. Thank you.

Re: reuse pf state ids to "hash" packets onto trunk members

2015-09-18 Thread Stuart Henderson
On 2015/09/18 13:36, Martin Pieuchot wrote: > On 18/09/15(Fri) 15:55, David Gwynne wrote: > > hashing bits of packet headers to tie connections to particular > > physical interfaces within a trunk turns out to be fairly expensive. > > in my very unscientific testing it is about 20% of the cost of

Re: openvpn-2.3.8p1 segv in libcrypto BN_bn2dec on OpenBSD/i386 current Sep 16, 2015

2015-09-18 Thread Miod Vallat
> CC'ing tech@. > > The last commit to bn_print.c is wrong, it dereferences t while it's still > NULL. > > Backout diff below. Argh, sorry about that. This is how it should have been done (diff against 1.25) Index: bn_print.c ===

Re: [patch]diff: uninitialized values

2015-09-18 Thread Fritjof Bornebusch
On Wed, Jun 17, 2015 at 09:19:28PM +0200, Fritjof Bornebusch wrote: > On Wed, Jun 17, 2015 at 08:53:57PM +0200, Fritjof Bornebusch wrote: > > Hi tech@, > > > > *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. > > > > Such initializers hiding a false positive, cause the

Re: [patch]rcs: mark unlink as (void)

2015-09-18 Thread Fritjof Bornebusch
On Mon, Jun 15, 2015 at 09:56:18PM +0200, Fritjof Bornebusch wrote: > Hi tech@, > > mark this unlink(2) call as *(void)*, as there is no need to check the return > value. > This makes it more consistent to all other unlink(2) calls, since they are > marked as *(void)* as > well. > > Regards, >

Re: kill struct inpcbtable's inpt_lastport

2015-09-18 Thread David Hill
On Sun, Sep 13, 2015 at 11:49:45AM +0200, Vincent Gross wrote: > On 09/13/15 10:37, Claudio Jeker wrote: > > On Sun, Sep 13, 2015 at 12:18:10AM +0200, Vincent Gross wrote: > >> On 09/12/15 22:10, Claudio Jeker wrote: > >>> On Sat, Sep 12, 2015 at 02:40:59PM +0200, Vincent Gross wrote: >

Re: kill struct inpcbtable's inpt_lastport

2015-09-18 Thread Claudio Jeker
On Fri, Sep 18, 2015 at 02:58:40PM +0200, Vincent Gross wrote: > On 09/13/15 11:49, Vincent Gross wrote: > > On 09/13/15 10:37, Claudio Jeker wrote: > >> On Sun, Sep 13, 2015 at 12:18:10AM +0200, Vincent Gross wrote: > >>> On 09/12/15 22:10, Claudio Jeker wrote: > On Sat, Sep 12, 2015 at

rtsock diff

2015-09-18 Thread David Hill
Hello - I believe the wrong var is being free'd. While here, add the size. Index: sys/net/rtsock.c === RCS file: /cvs/src/sys/net/rtsock.c,v retrieving revision 1.170 diff -u -p -r1.170 rtsock.c --- sys/net/rtsock.c11 Sep 2015

Re: kill struct inpcbtable's inpt_lastport

2015-09-18 Thread Vincent Gross
On 09/13/15 11:49, Vincent Gross wrote: > On 09/13/15 10:37, Claudio Jeker wrote: >> On Sun, Sep 13, 2015 at 12:18:10AM +0200, Vincent Gross wrote: >>> On 09/12/15 22:10, Claudio Jeker wrote: On Sat, Sep 12, 2015 at 02:40:59PM +0200, Vincent Gross wrote: > inpt_lastport is never read

Re: [patch]rcs: usage functions above the main ones

2015-09-18 Thread Fritjof Bornebusch
On Mon, Jun 15, 2015 at 11:42:10AM +0100, Nicholas Marriott wrote: > > this seems fine to me > Ping ... > > On Sun, Jun 14, 2015 at 10:38:40PM +0200, Fritjof Bornebusch wrote: > > Hi tech@, > > > > most of the tools implements the *usage* function above the *main* function. > > This patch

Re: rtsock diff

2015-09-18 Thread Stuart Henderson
On 2015/09/18 09:05, David Hill wrote: > Hello - > > I believe the wrong var is being free'd. While here, add the size. > > Index: sys/net/rtsock.c > === > RCS file: /cvs/src/sys/net/rtsock.c,v > retrieving revision 1.170 > diff -u

Re: Use M_ZERO in malloc(9)

2015-09-18 Thread Michael McConville
Michael McConville wrote: > Michael McConville wrote: > > Martin Pieuchot wrote: > > > On 18/09/15(Fri) 11:47, Michael McConville wrote: > > > > Index: arch/arm/xscale/pxa27x_udc.c > > > > === > > > > RCS file:

Re: Use M_ZERO in malloc(9)

2015-09-18 Thread Miod Vallat
> Does this look better? > Index: arch/arm/xscale/pxa27x_udc.c > if (xfer != NULL) > SIMPLEQ_REMOVE_HEAD(>sc_free_xfers, next); > - else > - xfer = malloc(sizeof(struct pxaudc_xfer), M_USB, M_NOWAIT); > - if (xfer != NULL) > bzero(xfer,

Re: Use M_ZERO in malloc(9)

2015-09-18 Thread David Hill
On Fri, Sep 18, 2015 at 12:31:25PM -0400, Michael McConville wrote: > Michael McConville wrote: > > Martin Pieuchot wrote: > > > On 18/09/15(Fri) 11:47, Michael McConville wrote: > > > > Index: arch/arm/xscale/pxa27x_udc.c > > > > ===

intro.8 should reference rcctl(8)

2015-09-18 Thread Rob Pierce
Reference the rcctl(8) utility in intro.8 Regards, Index: intro.8 === RCS file: /cvs/src/share/man/man8/intro.8,v retrieving revision 1.25 diff -u -p -r1.25 intro.8 --- intro.8 26 Aug 2014 19:33:48 - 1.25 +++ intro.8

Re: Use M_ZERO in malloc(9)

2015-09-18 Thread Michael McConville
Martin Pieuchot wrote: > On 18/09/15(Fri) 11:47, Michael McConville wrote: > > Index: arch/arm/xscale/pxa27x_udc.c > > === > > RCS file: /cvs/src/sys/arch/arm/xscale/pxa27x_udc.c,v > > retrieving revision 1.31 > > diff -u -p -r1.31

Re: Use M_ZERO in malloc(9)

2015-09-18 Thread Martin Pieuchot
On 18/09/15(Fri) 11:47, Michael McConville wrote: > Index: arch/arm/xscale/pxa27x_udc.c > === > RCS file: /cvs/src/sys/arch/arm/xscale/pxa27x_udc.c,v > retrieving revision 1.31 > diff -u -p -r1.31 pxa27x_udc.c > ---

Use M_ZERO in malloc(9)

2015-09-18 Thread Michael McConville
Index: arch/arm/xscale/pxa27x_udc.c === RCS file: /cvs/src/sys/arch/arm/xscale/pxa27x_udc.c,v retrieving revision 1.31 diff -u -p -r1.31 pxa27x_udc.c --- arch/arm/xscale/pxa27x_udc.c15 May 2015 13:32:08 - 1.31 +++

[PATCH] SSH tunnels without root permissions

2015-09-18 Thread Ossi Herrala
Hi everyone, The following patch makes it possible to build SSH layer 2 (and layer 3) tunnels without using root permissions when connecting. This is achieved by root setting up everything beforehand so sshd doesn't have to do it. However, the old functionality of sshd setting things up with