Re: Checking MAC address of incoming unicast packets

On Sat, Jan 02, 2016 at 04:04:33PM +0100, Mark Kettenis wrote: > > Date: Sat, 2 Jan 2016 10:57:41 +0100 > > From: Martin Pieuchot > > > > If it's acceptable performance-wise to do the check unconditionally I > > believe that's the way to go. If not I'm a bit afraid of

Re: onerng(4): new TRNG device

On 04/01/16(Mon) 10:34, Devin Reade wrote: > This patch adds kernel support for the OneRNG hardware random number > generator, which is similar to ualea(4). onerng(4) is configured to > deliver ~319kb/s of true randomness. > > Since usbdevs.h and usbdevs_data.h are generated files, it's not

Re: em watchdog timeout

On 3.1.2016. 21:26, Hrvoje Popovski wrote: > Hi all, > > i accidentally managed to trigger em watchdog timeout -- resetting on my > test box which is clean -current from today at 20:00 CET. > Test box is IBM X3550M4 with 4 onboard em I350 (em0,em1,em2,em3) and 2 > ix (ix2,ix3) 82599 interfaces.

Re: xr mktime

Hi Ted, Ted Unangst wrote on Wed, Dec 30, 2015 at 11:51:34AM -0500: > Neither strftime nor strptime describe the fields inside struct tm, > and while they eventually point that way in references, strftime > provides no guidance as to which of its nine (9!) references > I should read next. I

HISTORY and AUTHORS for rs(1), lam(1), jot(1)

These are FreeBSD commits 731fe330c9 and 739c57d8c2. A request from what appears to be the author himself prompted these changes: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196786 And a comment in the source files of these tools verifies the authorship: * Author: John Kunze, Office

Clarify fold(1)

The first diff explains what happens to a word longer than 'width'. This diff comes from NetBSD and FreeBSD. The explanation is quite complicated and I couldn't understand what this flag does at first, the source code makes it much clearer (the variable is called split_words). But I didn't change

cd9660 uiomove() conversion

Below the uiomove conversion for isofs/cd9660/cd9660_vnops.c. cheers, natano Index: isofs/cd9660/cd9660_vnops.c === RCS file: /cvs/src/sys/isofs/cd9660/cd9660_vnops.c,v retrieving revision 1.73 diff -u -p -r1.73 cd9660_vnops.c ---

i386/nvram.c uiomove() conversion

Below a diff to convert i386/nvram.c to use uiomove(). A similar diff for amd64 has already been committed. (See https://marc.info/?l=openbsd-tech=142860367111291) Also, pos is converted to off_t for both amd64 and i386 to prevent truncation and signedness mismatch. Calling nvramread() with a

Re: getopt.3 / getopt_long.3: Remove NOTREACHED comment as per style(9)

On Mon, Jan 04, 2016 at 11:48:10AM +, Juuso Lapinlampi wrote: > Here's a revised patch that updates the $Mdocdate if seemed necessary. Thanks. I like the first version of your patch, it's a good point. There's no need to update $Mdocdate$ manually. This is taken care of when the patch is

Re: smtpd.conf(5) term filter misleading use

On Sat, Jan 02, 2016 at 06:27:29PM +0100, Marcus MERIGHI wrote: > When the text is not talking about filters, but about accept/reject > rules and using the term "filter", try to find some other wording. > > Bye, Marcus > committed, thanks > Index: smtpd.conf.5 >

Re: getopt.3 / getopt_long.3: Remove NOTREACHED comment as per style(9)

Here's a revised patch that updates the $Mdocdate if seemed necessary. Ok? Index: getopt.3 === RCS file: /cvs/src/lib/libc/stdlib/getopt.3,v retrieving revision 1.44 diff -u -p -r1.44 getopt.3 --- getopt.321 Jan 2014 03:15:45

getopt.3 / getopt_long.3: Remove NOTREACHED comment as per style(9)

style(9) revision 1.61 updated the guidelines, and mentions the only lint-style comment that should be used is FALLTHROUGH. Ok? Index: getopt.3 === RCS file: /cvs/src/lib/libc/stdlib/getopt.3,v retrieving revision 1.44 diff -u -p

Re: Make em(4) more mpsafe again

> /* > - * These parameters control when the driver calls the routine to reclaim > - * transmit descriptors. > + * Thise parameter controls the minimum number of available transmit > + * descriptors needed before we attempt transmission of a packet. > */ There seems to be a typo in there.

Re: hashfree, a counterpart to hashinit

Hello, Holidays are over, I'm getting back to this diff, anyone is ok with it? Martin Natano wrote: > Hi, > > the diff reads fine to me, except for following nit-picks: It would be > nice if the hashfree() function would check for negative/zero element > counts, like hashinit() does. Also, new

Re: HISTORY and AUTHORS for rs(1), lam(1), jot(1)

Hi, Michal Mazurek wrote on Mon, Jan 04, 2016 at 09:08:58PM +0100: > These are FreeBSD commits 731fe330c9 and 739c57d8c2. A request > from what appears to be the author himself prompted these changes: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196786 > And a comment in the source files

Re: Checking MAC address of incoming unicast packets

On Sun, 3 Jan 2016, Theo de Raadt wrote: > >On Friday 01 January 2016 16:25:59, Theo de Raadt wrote: > >> dlg writes: > >> > should we just do it unconditionally? is there a downside to that? > > > >It may decrease performance a tiny bit. Since such bits tend to add > >up, I would be hesitant to

Re: Checking MAC address of incoming unicast packets

> Date: Mon, 4 Jan 2016 21:30:31 +0100 > From: Claudio Jeker > > On Sat, Jan 02, 2016 at 04:04:33PM +0100, Mark Kettenis wrote: > > > Date: Sat, 2 Jan 2016 10:57:41 +0100 > > > From: Martin Pieuchot > > > > > > If it's acceptable performance-wise to

Re: Clarify fold(1)

Hi, Michal Mazurek wrote on Mon, Jan 04, 2016 at 08:27:50PM +0100: > Fold line after the last blank character within the first > .Ar width > column positions (or bytes). > +If a blank character does not exist within the width, then > +a longer line will still be split at the width. > The

Re: remove language catalogs from vi

On Mon, Jan 04, 2016 at 05:16:57PM +0100, Martijn van Duren wrote: > Slight change in that lenght wasn't always preserved in msg.c. > This revision works well for me and millert@ > The diff looks good to me and the only remark I have is that catalog/README should be updated as well. Nobody

Re: Clarify fold(1)

On 01:24:35, 5.01.16, Ingo Schwarze wrote: > +If an output line would be broken after a non-blank character but > +contains at least one blank character, break the line earlier, > +after the last blank character. > +This is useful to avoid line breaks in the middle of words, if > +possible.

Re: npppd: simplify and lock down priv_open()

I'm sorry for delay. ok yasuoka tested. On Fri, 1 Jan 2016 10:55:14 -0800 Philip Guenther wrote: > On Fri, 4 Dec 2015, Todd C. Miller wrote: >> On Fri, 04 Dec 2015 09:47:46 -0800, Philip Guenther wrote: >> > We should fix open(2); please try the diff below. Are you sure

Re: USB keyboards with multiple displays

Mark Kettenis writes: > OpenBSD/amd64 and OpenBSD/i386 have been supporting multiple > wsdisplay(4) devices for a while now. Somewhat recently it became > also possible to use inteldrm(4) as a secondary display device. There > have always been some issues with pairing

starttls support for nc(1)

Hello, I've written some code which basically allows to emulate the behavior of starttls-enabled clients and servers via nc(1). I mainly use it for debugging purposes since it is more generic than openssl s_client -starttls. However, the solution is probably ugly since I'm not very

Re: remove language catalogs from vi

Slight change in that lenght wasn't always preserved in msg.c. This revision works well for me and millert@ On 12/16/15 17:43, Martijn van Duren wrote: ping On 12/02/15 20:36, Martijn van Duren wrote: Hello tech@, I've had a discussion with bentley@ about some patches for vi. Some of which

Re: onerng(4): new TRNG device

Thanks for your feedback, Martin. See below. --On Monday, January 04, 2016 08:02:34 PM +0100 Martin Pieuchot wrote: On 04/01/16(Mon) 10:34, Devin Reade wrote: This patch adds kernel support for the OneRNG hardware random number generator, which is similar to ualea(4).

Re: Checking MAC address of incoming unicast packets

On Mon, 4 Jan 2016, Claudio Jeker wrote: > On Sat, Jan 02, 2016 at 04:04:33PM +0100, Mark Kettenis wrote: > > > Date: Sat, 2 Jan 2016 10:57:41 +0100 > > > From: Martin Pieuchot > > > > > > If it's acceptable performance-wise to do the check unconditionally I > > > believe

Re: onerng(4): new TRNG device

On 04/01/16(Mon) 14:53, Devin Reade wrote: > --On Monday, January 04, 2016 08:02:34 PM +0100 Martin Pieuchot > wrote: > [...] > An earlier version of the code (not submitted) matched on only vendor > and product, but I was seeing onerng_match being invoked twice; one for > the

onerng(4): new TRNG device

This patch adds kernel support for the OneRNG hardware random number generator, which is similar to ualea(4). onerng(4) is configured to deliver ~319kb/s of true randomness. Since usbdevs.h and usbdevs_data.h are generated files, it's not clear to me that they are supposed to be part of the

Re: USB keyboards with multiple displays

On 01/03/16 16:00, Mark Kettenis wrote: OpenBSD/amd64 and OpenBSD/i386 have been supporting multiple wsdisplay(4) devices for a while now. Somewhat recently it became also possible to use inteldrm(4) as a secondary display device. There have always been some issues with pairing wskbd(4)

Re: bugs in printf(3)

Hi Todd, Todd C. Miller wrote on Mon, Dec 28, 2015 at 10:46:08AM -0700: > On Fri, 25 Dec 2015 00:30:29 +0100, Ingo Schwarze wrote: >> Besides, i don't see the point in messing with FILE flags at all >> in case of encoding errors. As opposed to fgetwc(3) and fputwc(3), >> the manual doesn't