Re: Patches for improving npppd with rdomain support

> On 2 Mar 2016, at 02:32, Claer wrote: > > Hello dear developers, > > I asked a friend, Mathieu Papineau, to help me with an issue I have with > npppd. > For a project here, I thought building multitenancy firewall with rdomain > support. For remote access, I wanted to use npppd to be able to

bump the max_linkhdr size from 16 bytes to 64

the max_link hdr is basically how much space to reserve before an ip packet for link headers, eg, ethernet. 16 bytes was a good choice when everything was just ip inside ethernet, but now we deal with a bunch of encapsulations which blow that out of the water. 16 bytes isnt even enough if we have

mpw(4) vlan handling

ive got a large reworking of vlan(4) to make vlan tx mpsafe, which affected mpw(4). the biggest effect was that it was no longer safe to traverse the interface parent hierarchy looking for vlan interfaces. however, from what i could tell from the rfc, such traversal is unecessary. this refactors

Re: zaurus: disentangle zboot from compat/linux

On Sun, Feb 28, 2016 at 05:25:06PM +0100, Christian Weisgerber wrote: > This disentangles the zaurus bootstrap from compat/linux. > > We only need a small subset of syscall numbers and constants, so > this moves the definitions directly into zboot/compat_linux.h. > Compared to compat/linux/*.h, I

factor out vlan header injection

this factors out the vlan shim header injection as vlan_inject() i intend to use this code in mpw in an upcoming diff. ok? Index: if_vlan.c === RCS file: /cvs/src/sys/net/if_vlan.c,v retrieving revision 1.151 diff -u -p -r1.151 if_v

Re: ddb/x86: backtrace with bpt on 'syscall'

On Tue, Mar 01, 2016 at 11:50:28PM +0100, Martin Pieuchot wrote: > Trying to get a backtrace after setting a breakpoint on the ``syscall'' > symbol on ddb(4) does not work well. On am64 it faults: > > Breakpoint at syscall:pushq %rbp > ddb{0}> tr > syscall() at syscall > Xsysc

Re: ddb: show regs with address

On Tue, Mar 01, 2016 at 11:58:57PM +0100, Martin Pieuchot wrote: > As explained previously I'm implementing an instrumentation system based > on ddb(4) and relying on breakpoints to execute kernel probes. > > For debugging purposes I need a way to dump the content of the registers > when a breakpo

ddb: show regs with address

As explained previously I'm implementing an instrumentation system based on ddb(4) and relying on breakpoints to execute kernel probes. For debugging purposes I need a way to dump the content of the registers when a breakpoint-not-for-ddb(4) fired. So I hacked the "show regs" to dump the register

ddb/x86: backtrace with bpt on 'syscall'

Trying to get a backtrace after setting a breakpoint on the ``syscall'' symbol on ddb(4) does not work well. On am64 it faults: Breakpoint at syscall:pushq %rbp ddb{0}> tr syscall() at syscall Xsyscall() at Xsyscall+0xcb uvm_fault(0xff000f6c3100, 0x1008, 0, 1) -> e ker

Re: [patch] Fix carp(4) with balancing ip / ip-stealth

On 18/02/16(Thu) 16:46, Florian Riehm wrote: > On 02/16/16 11:23, Martin Pieuchot wrote: > > On 12/02/16(Fri) 16:33, Florian Riehm wrote: > >> Hi Tech, > >> > >> I have noticed that CARP IP-Balancing is broken, so I am testing and > >> fixing it. > >> > >> The first problem came in with this commit

Re: x86 BPTTRAP

On 28/02/16(Sun) 17:34, Martin Pieuchot wrote: > On 28/02/16(Sun) 17:02, Mike Belopuhov wrote: > > On 28 February 2016 at 14:38, Martin Pieuchot wrote: > > > In order to dynamically instrument kernel functions, I plan to add > > > breakpoints where a probe needs to be executed. Trap handlers will

Delete compat/* mentions from man pages

sys/compat/* is unhooked from the rest of the kernel and will go away shortly. This removes the remaining man page mentions I could find. Note: syscall.9 also mentions COMPAT_XX. That appears to be a generic feature in makesyscalls.sh (one not used by Linux compat), so I'll leave it alone. Ind

Re: cpu.h: parens in macros

Michal Mazurek wrote: > I noticed these macros, I think they should have more parenthesis. I > don't know how to test this though. tentative ok mmcc@ > Index: sys/arch/alpha/include/cpu.h > === > RCS file: /cvs/src/sys/arch/alpha/inc

cpu.h: parens in macros

I noticed these macros, I think they should have more parenthesis. I don't know how to test this though. Index: sys/arch/alpha/include/cpu.h === RCS file: /cvs/src/sys/arch/alpha/include/cpu.h,v retrieving revision 1.55 diff -u -p -r1

Re: df(1): remove unneeded includes

Theo Buehler wrote: > On Tue, Mar 01, 2016 at 12:37:17PM +0100, Theo Buehler wrote: > > Wasn't this the part of your previous header cleanup that mmcc > > decided not to commit for some reason? > > if mmcc no longer objects, this once more ok tb@ Right, I misunderstood which file this was removi

Patches for improving npppd with rdomain support [11-12/12]

Hello, Patches 11 & 12. # HG changeset patch # User MJP # Date 1452862954 -3600 # Fri Jan 15 14:02:34 2016 +0100 # Node ID 5c95b08cdd4fa9db47ced3b8b1a331dbdab41ec6 # Parent 842c1c22848e171f174cc45ba7b961883fc3c184 Feature: Configure interface with the specified rdomain. diff -r 842c1c2284

Patches for improving npppd with rdomain support [8/12]

Hello, Patch 8 # HG changeset patch # User MJP # Date 1452862954 -3600 # Fri Jan 15 14:02:34 2016 +0100 # Node ID 55eeedfb0cb54ed0d91c7de080b507fc79f64c30 # Parent 8d76f9f8cc873602c8593b896133648cdedb6afd Add: Introduce priv_get_if_rdomain() to get the rdomain of a device. diff -r 8d76f9f

Patches for improving npppd with rdomain support [9/12]

Hello, Patch 9 # HG changeset patch # User MJP # Date 1452862954 -3600 # Fri Jan 15 14:02:34 2016 +0100 # Node ID 97146d7e9ebbb07f93d734dbdd7afe942f5cc557 # Parent 55eeedfb0cb54ed0d91c7de080b507fc79f64c30 Add: Introduce priv_set_if_rdomain() to set the rdomain of a device. diff -r 55eeedf

Patches for improving npppd with rdomain support [10/12]

Hello, patch 10 # HG changeset patch # User MJP # Date 1452862954 -3600 # Fri Jan 15 14:02:34 2016 +0100 # Node ID 842c1c22848e171f174cc45ba7b961883fc3c184 # Parent 97146d7e9ebbb07f93d734dbdd7afe942f5cc557 Add: Route functions handle rdomain. diff -r 97146d7e9ebb -r 842c1c22848e usr.sbin/

Patches for improving npppd with rdomain support [7/12]

Hello, Patch 7 # HG changeset patch # User MJP # Date 1452862954 -3600 # Fri Jan 15 14:02:34 2016 +0100 # Node ID 8d76f9f8cc873602c8593b896133648cdedb6afd # Parent 90fa2a12bfaa8776e883c168aaf39be0b16fea4d Add: In the configuration file, define the rdomain of an interface. diff -r 90fa2a12

Patches for improving npppd with rdomain support [1/12]

Hello, This patch fix an incorrect check. # HG changeset patch # User MJP # Date 1452429700 -3600 # Sun Jan 10 13:41:40 2016 +0100 # Node ID 5df6e3ec88c3933dd06ced5fd459921a8043cead # Parent e414626941ab329294b3d6c26657e1b2a509f5f0 Fix: "authconf.users_file_path" is a char[] but is checked

Patches for improving npppd with rdomain support [6/12]

Hello, patch 6, # HG changeset patch # User MJP # Date 1452862925 -3600 # Fri Jan 15 14:02:05 2016 +0100 # Node ID 90fa2a12bfaa8776e883c168aaf39be0b16fea4d # Parent fd7f48f3955596de5fe098de0f4208106578c9db Feature: Can listen on an interface with a specific rdomain. diff -r fd7f48f39555 -

Patches for improving npppd with rdomain support [5/12]

Hello, Patch 5 # HG changeset patch # User MJP # Date 1452861496 -3600 # Fri Jan 15 13:38:16 2016 +0100 # Node ID fd7f48f3955596de5fe098de0f4208106578c9db # Parent 52f96bbfc0cb83010e78d49b63a18bdc00a7 Add: Introduce common tools to get and set the rdomain of an interface. diff -r 52f9

Patches for improving npppd with rdomain support [2-4/12]

Hello, These patches add support for defining pid-file & control-socket from configuration file. Claer # HG changeset patch # User MJP # Date 1452430850 -3600 # Sun Jan 10 14:00:50 2016 +0100 # Node ID 12ffa641c5d987c3e1373f8a9156f4951faa54ed # Parent 5df6e3ec88c3933dd06ced5fd459921a8043ce

Patches for improving npppd with rdomain support

Hello dear developers, I asked a friend, Mathieu Papineau, to help me with an issue I have with npppd. For a project here, I thought building multitenancy firewall with rdomain support. For remote access, I wanted to use npppd to be able to authenticate users in different domains in their respecti

Re: Kill db_lookup()

On 01/03/16(Tue) 15:10, Mike Belopuhov wrote: > On 1 March 2016 at 12:59, Martin Pieuchot wrote: > > No need for an empty wrapper. ok? > > > > I'm certainly fine with calling db_elf_sym_lookup directly from the > db_value_of_name, but i'm not sure about moving db_value_of_name into > db_elf.c as

sched_bsd.c update comment

Index: sys/kern/sched_bsd.c === RCS file: /cvs/src/sys/kern/sched_bsd.c,v retrieving revision 1.42 diff -u -p -r1.42 sched_bsd.c --- sys/kern/sched_bsd.c8 Nov 2015 20:45:57 - 1.42 +++ sys/kern/sched_bsd.c1 Ma

fortune(6): replace hand-rolled strtonum

The option parsing code of fortune(6) contains a hand-rolled strtonum. There are several problems with it: fortune won't accept any files whose name starts with a number larger than 100 and the string conversion is susceptible to overflow, which leads to bizarre errors: $ fortune 101dalmatians per

Re: db_sym_numargs() is always false

On 1 March 2016 at 13:04, Martin Pieuchot wrote: > I'd like to remove this dead code because I'd like to unify to some > extend the frame walking code between archs and this doesn't help. > > ok? > OK mikeb

Re: Kill db_lookup()

On 1 March 2016 at 12:59, Martin Pieuchot wrote: > No need for an empty wrapper. ok? > I'm certainly fine with calling db_elf_sym_lookup directly from the db_value_of_name, but i'm not sure about moving db_value_of_name into db_elf.c as it makes it sort of stand out by not having consistent nami

Re: Kill db_find_trace_symbols()

On 1 March 2016 at 13:06, Martin Pieuchot wrote: > This is also dead code. ok? > Sure, OK mikeb

Re: df(1): tidy function declarations and definitions

On 13:00:53, 1.03.16, Theo Buehler wrote: > > +int bread(int, off_t, void *, int); > ^ > space before tab here, otherwise ok tb@ Oups Index: bin/df/df.c === RCS file: /cvs/src/bin/df/df.c,v retrieving revision

Re: df(1): return from main() and simplify maxwidth

I agree that this is nicer. ok tb@ On Tue, Mar 01, 2016 at 12:42:24PM +0100, Michal Mazurek wrote: > Index: bin/df/df.c > === > RCS file: /cvs/src/bin/df/df.c,v > retrieving revision 1.55 > diff -u -p -r1.55 df.c > --- bin/df/df.c

Kill db_find_trace_symbols()

This is also dead code. ok? diff --git sys/arch/amd64/amd64/db_trace.c sys/arch/amd64/amd64/db_trace.c index 27fe24d..f0af6ec 100644 --- sys/arch/amd64/amd64/db_trace.c +++ sys/arch/amd64/amd64/db_trace.c @@ -106,30 +106,10 @@ db_x86_64_regop(struct db_variable *vp, db_expr_t *val, int opcode) #

db_sym_numargs() is always false

I'd like to remove this dead code because I'd like to unify to some extend the frame walking code between archs and this doesn't help. ok? diff --git sys/arch/amd64/amd64/db_trace.c sys/arch/amd64/amd64/db_trace.c index 7c86efe..27fe24d 100644 --- sys/arch/amd64/amd64/db_trace.c +++ sys/arch/amd6

Re: df(1): remove unneeded includes

On Tue, Mar 01, 2016 at 12:37:17PM +0100, Theo Buehler wrote: > Wasn't this the part of your previous header cleanup that mmcc decided > not to commit for some reason? if mmcc no longer objects, this once more ok tb@

Re: df(1): tidy function declarations and definitions

> +int bread(int, off_t, void *, int); ^ space before tab here, otherwise ok tb@

Kill db_lookup()

No need for an empty wrapper. ok? Index: ddb/db_elf.c === RCS file: /cvs/src/sys/ddb/db_elf.c,v retrieving revision 1.18 diff -u -p -r1.18 db_elf.c --- ddb/db_elf.c1 Mar 2016 11:56:00 - 1.18 +++ ddb/db_elf.c

df(1): tidy function declarations and definitions

Index: bin/df/df.c === RCS file: /cvs/src/bin/df/df.c,v retrieving revision 1.55 diff -u -p -r1.55 df.c --- bin/df/df.c 8 Feb 2016 16:23:54 - 1.55 +++ bin/df/df.c 1 Mar 2016 11:33:08 - @@ -49,21 +49,21 @@ extern char *

df(1): replace __progname with getprogname()

Index: bin/df/df.c === RCS file: /cvs/src/bin/df/df.c,v retrieving revision 1.55 diff -u -p -r1.55 df.c --- bin/df/df.c 8 Feb 2016 16:23:54 - 1.55 +++ bin/df/df.c 1 Mar 2016 11:36:54 - @@ -47,8 +47,6 @@ #include #inclu

df(1): return from main() and simplify maxwidth

Index: bin/df/df.c === RCS file: /cvs/src/bin/df/df.c,v retrieving revision 1.55 diff -u -p -r1.55 df.c --- bin/df/df.c 8 Feb 2016 16:23:54 - 1.55 +++ bin/df/df.c 1 Mar 2016 11:40:40 - @@ -161,23 +161,20 @@ main(int argc,

Re: df(1): remove unneeded includes

Wasn't this the part of your previous header cleanup that mmcc decided not to commit for some reason? On Tue, Mar 01, 2016 at 12:27:36PM +0100, Michal Mazurek wrote: > > Index: bin/df/ext2fs_df.c > === > RCS file: /cvs/src/bin/df/ex

df(1): remove unneeded includes

Index: bin/df/ext2fs_df.c === RCS file: /cvs/src/bin/df/ext2fs_df.c,v retrieving revision 1.15 diff -u -p -r1.15 ext2fs_df.c --- bin/df/ext2fs_df.c 8 Feb 2016 16:23:54 - 1.15 +++ bin/df/ext2fs_df.c 1 Mar 2016 11:26:06 -000