Re: opendev(3) tweak

2016-06-10 Thread Sebastien Marie
On Thu, Jun 09, 2016 at 09:19:30PM +0200, Theo Buehler wrote: > On Tue, Mar 15, 2016 at 12:32:16PM -0600, Theo de Raadt wrote: > > I am simply saying that pledge before opendev() makes no sense, > > because opendev() does not gaurantee the type of descriptor it is > > opening. > > I noticed that t

Re: cbfb: coreboot framebuffer console

2016-06-10 Thread Ted Unangst
joshua stein wrote: > +int > +cb_parse_table(paddr_t addr) > +{ > + int i, j; > + > + for (i = 0; i < (4 * 1024); i += 16) { > + struct cb_header *cbh; > + struct cb_entry *cbe; > + void *cbtable; > + > + cbh = (struct cb_header *)(PMAP_DIRECT

Re: cbfb: coreboot framebuffer console

2016-06-10 Thread Mark Kettenis
> Date: Fri, 10 Jun 2016 14:38:05 -0500 > From: joshua stein > > This implements a new framebuffer console (based on efifb) for amd64 > devices running Coreboot, which do not have otherwise working EFI, > VGA text, inteldrm, or serial console. So mostly just Skylake > Chromebooks. > > This is r

cbfb: coreboot framebuffer console

2016-06-10 Thread joshua stein
This implements a new framebuffer console (based on efifb) for amd64 devices running Coreboot, which do not have otherwise working EFI, VGA text, inteldrm, or serial console. So mostly just Skylake Chromebooks. This is required for my HP Chromebook 13 (and would have previously been required for

Re: MBIM Patch (Round 3)

2016-06-10 Thread Mark Kettenis
> Date: Fri, 10 Jun 2016 17:20:18 +0100 > From: Stuart Henderson > > On 2016/06/10 16:05, Mark Kettenis wrote: > > In any case this is something we can figure out once the code hits the > > tree. Unless mpi@ is still unhappy with the way the driver performs > > ioctls, I think we should get the

Fix typos in comments in amd64/stand

2016-06-10 Thread Tom Cosgrove
Thanks Tom Index: sys/arch/amd64/stand/efiboot/efiboot.c === RCS file: /home/OpenBSD/cvs/src/sys/arch/amd64/stand/efiboot/efiboot.c,v retrieving revision 1.12 diff -u -p -u -r1.12 efiboot.c --- sys/arch/amd64/stand/efiboot/efiboot.c

Fix typos in comments in i386/stand

2016-06-10 Thread Tom Cosgrove
Thanks Tom Index: sys/arch/i386/stand/libsa/apmprobe.c === RCS file: /home/OpenBSD/cvs/src/sys/arch/i386/stand/libsa/apmprobe.c,v retrieving revision 1.18 diff -u -p -u -r1.18 apmprobe.c --- sys/arch/i386/stand/libsa/apmprobe.c

Re: MBIM Patch (Round 3)

2016-06-10 Thread Stuart Henderson
On 2016/06/10 16:05, Mark Kettenis wrote: > In any case this is something we can figure out once the code hits the > tree. Unless mpi@ is still unhappy with the way the driver performs > ioctls, I think we should get the driver bits into the tree such that > we can work on fixing the remaining iss

Re: MBIM Patch (Round 3)

2016-06-10 Thread Stuart Henderson
I found https://lists.freedesktop.org/archives/libmbim-devel/2016-April/000704.html which suggests that the Lenovo firmware build of the 7455 is definitely one that needs the fccauth command. I don't think fccauth or device support are things that should stop the driver going in though. It doesn'

Re: tetris(6): -Wshadow cleanup

2016-06-10 Thread Todd C. Miller
On Fri, 10 Jun 2016 16:32:43 +0200, Theo Buehler wrote: > Get rid of the two gcc -Wshadow warnings: > > numnames is public in > i shadows the local loop indexing variable of scr_update, so no need to > rename it. OK millert@ - todd

tetris(6): -Wshadow cleanup

2016-06-10 Thread Theo Buehler
Get rid of the two gcc -Wshadow warnings: numnames is public in i shadows the local loop indexing variable of scr_update, so no need to rename it. Index: scores.c === RCS file: /var/cvs/src/games/tetris/scores.c,v retrieving revisio

Re: MBIM Patch (Round 3)

2016-06-10 Thread Mark Kettenis
> From: Gerhard Roth > Date: Fri, 10 Jun 2016 00:31:44 +0200 > > On 10.06.2016 00:22, Stuart Henderson wrote: > > On 2016/06/10 00:10, Mark Kettenis wrote: > >>> From: Gerhard Roth > >>> Date: Thu, 9 Jun 2016 23:48:23 +0200 > >>> > >>> On 09.06.2016 23:42, Mark Kettenis wrote: > > Date: Thu,

Re: MBIM Patch (Round 3)

2016-06-10 Thread Bryan Vyhmeister
On Fri, Jun 10, 2016 at 09:43:36AM +0200, Gerhard Roth wrote: > Hmm, I don't see the missing break. It is still stuck in the same > state trying to turn on the radio and always getting non-confirmative > resonses. > > If the break before "case UMB_S_RADIO:" is missing, I would expect > to see a de

Re: httpd(8) fix incorrect comment

2016-06-10 Thread Florian Obser
On Tue, Jun 07, 2016 at 12:18:48PM +0200, Frank Schoep wrote: > Came across an incorrect comment in httpd(8) explaining memory > allocation. Comment claims that 5 times the source memory needs to > be allocated if source consists solely of "<" and ">", but those > characters expand to four bytes ("

iwm(4): Add missing iwm_free_rx_ring(). Free nvm_sections[i].data buffers.

2016-06-10 Thread Imre Vadasz
Hi, After parsing the nvm_sections data in iwm_nvm_init(), we can free the nvm_sections[i].data allocations again. In the iwm_attach() failure path, the iwm_free_rx_ring() call for freeing the rx ring memory was missing. Index: if_iwm.c ===

Re: `rt_addr' or the end of `rt_ifa'

2016-06-10 Thread Florian Obser
Any reason you are not adding the free(9) sizes in rtrequest(), too? OK florian@ On Wed, Jun 08, 2016 at 04:23:33PM +0200, Martin Pieuchot wrote: > Being able to remove the requirement of an configured address for every > route entry would have multiple benefit: > > . We could add route before

Re: tetris(6): clear row zero when eliding a row

2016-06-10 Thread Theo Buehler
On Fri, Jun 10, 2016 at 06:00:48AM +0200, Theo Buehler wrote: > The tetris playing field has an extra row on top of the visible rows. > It is possible and not an error to place a tile in such a way that it > occupies a square of this invisible row (the game ends when the next > tile starts out on a

Re: MBIM Patch (Round 3)

2016-06-10 Thread Gerhard Roth
On 10.06.2016 05:09, Bryan Vyhmeister wrote: On Thu, Jun 09, 2016 at 10:31:58PM +0200, Gerhard Roth wrote: If that doesn't help, please set UMB_DEBUG and set umb_debug to 5. I left that break commented out which perhaps I shouldn't have but below is the output when I set an apn and bring umb0