Re: ksh "clear-screen" editing command

2018-06-18 Thread Alexander Hall
On June 18, 2018 11:00:00 PM GMT+02:00, Richard Procter wrote: > >On 6/06/2018, at 10:20 AM, Alexander Hall wrote: > >> This adds a "clear-screen" editing command to the emacs editing mode. >> This is the same name as bash and zsh uses, and then I stopped >looking. >> >> Thoughts? OK? >

Re: ksh "clear-screen" editing command

2018-06-18 Thread Richard Procter
On 6/06/2018, at 10:20 AM, Alexander Hall wrote: > This adds a "clear-screen" editing command to the emacs editing mode. > This is the same name as bash and zsh uses, and then I stopped looking. > > Thoughts? OK? It's unclear to me what need is being being addressed here --- are you wanting a

Re: 6.3 and Prolific PL-2303 USB serial adapter

2018-06-18 Thread Mike Belopuhov
On Mon, Jun 18, 2018 at 19:29 +0200, Paul de Weerd wrote: > Updated diff included below. I've set the product name to LD220. > This diff lacks the updates to usbdevs{,_data}.h, whoever commits > should update those too. > > Any takers to commit this? Tested by an owner of the actual device, >

Re: errors in usage.c - libusbhid

2018-06-18 Thread David Bern
I take back my previous answer to this question: > Are you sure the name always contain an underscore? Can't it be > "Button:Button42" ? In my previous response I had only discovered three cases of usage -1. I took another look and discovered that there indeed is a scenario as you mention other

Re: getaddrinfo(3) leak in whois(1)

2018-06-18 Thread Todd C. Miller
On Mon, 18 Jun 2018 20:14:37 +0200, Jeremie Courreges-Anglas wrote: > here are two tweaks for whois.c: > - in whois() call freeaddrinfo(3) asap, there is no reason to keep the > results around for longer than necessary. whois() is recursive so > this should reduce the amount of memory used

getaddrinfo(3) leak in whois(1)

2018-06-18 Thread Jeremie Courreges-Anglas
Hi, here are two tweaks for whois.c: - in whois() call freeaddrinfo(3) asap, there is no reason to keep the results around for longer than necessary. whois() is recursive so this should reduce the amount of memory used when following redirects. - choose_server() doesn't attempt to free the

Re: 6.3 and Prolific PL-2303 USB serial adapter

2018-06-18 Thread Jan-Piet Mens
maybe you can share a dmesg of the machine with the device attached as uplcom(4)? uplcom0 at uhub3 port 2 configuration 1 interface 0 "Prolific Technology Inc. USB-Serial Controller" rev 1.10/3.10 addr 4 ucom3 at uplcom0 -JP

Re: 6.3 and Prolific PL-2303 USB serial adapter

2018-06-18 Thread Paul de Weerd
Updated diff included below. I've set the product name to LD220. This diff lacks the updates to usbdevs{,_data}.h, whoever commits should update those too. Any takers to commit this? Tested by an owner of the actual device, so that's good. Jan-Piet, maybe you can share a dmesg of the machine

Re: mandoc potential memory leak fix

2018-06-18 Thread Florian Obser
On Mon, Jun 18, 2018 at 04:37:32PM +0200, Jan Schreiber wrote: > Hi, > > this patch closes potential memory leaks in the mandoc memory wrapper > functions and follows the examples in the manpages. > These are not leaks since mandoc exits via err(3) immediately after an allocation failure. Which

Re: ed remove parse_char_class

2018-06-18 Thread Todd C. Miller
On Mon, 18 Jun 2018 18:40:05 +0200, Martijn van Duren wrote: > parse_char_class does a really fancy *s != '\n' dance. > I say we remove it and let regcomp determine if we have a properly > formatted char_class. > > This changes our error message for a unbalanced char_class from: > unbalanced

ed remove parse_char_class

2018-06-18 Thread Martijn van Duren
Hello tech@, parse_char_class does a really fancy *s != '\n' dance. I say we remove it and let regcomp determine if we have a properly formatted char_class. This changes our error message for a unbalanced char_class from: unbalanced brackets ([]) to: brackets ([ ]) not balanced OK? martijn@

Re: Unlock sendit-based syscalls

2018-06-18 Thread Mark Kettenis
> Date: Mon, 18 Jun 2018 11:24:00 +0200 > From: Martin Pieuchot > > Diff below is the last of the serie to remove the KERNEL_LOCK() from > sendto(2) and sendmsg(2) for sockets protected by the NET_LOCK(). > > As explained previously [0] this diff uses a simple non-intrusive > approached based

Re: fdinsert(), take 3

2018-06-18 Thread Mark Kettenis
> Date: Mon, 18 Jun 2018 09:07:58 +0200 > From: Martin Pieuchot > > On 16/06/18(Sat) 19:28, Mark Kettenis wrote: > > > Date: Thu, 14 Jun 2018 14:28:07 +0200 > > > From: Martin Pieuchot > > > > > > This version should fixes the previous issue where LARVAL files were > > > incorrectly accounted

Re: 6.3 and Prolific PL-2303 USB serial adapter

2018-06-18 Thread Jan-Piet Mens
I've made up a product name (the "product HP USB2SER 0x3524 Prolific uplcom" part of the diff). That should be improved first. Do you have a model name for this HP product? Any additional stickers that help identify it? A URL from the HP website for this product? The product is an "LD220-HP"

Re: 6.3 and Prolific PL-2303 USB serial adapter

2018-06-18 Thread Paul de Weerd
Hi Jan-Piet! On Mon, Jun 18, 2018 at 04:16:34PM +0200, Jan-Piet Mens wrote: | > Only one way to find out :) | | I spare you a lot of details by pointing you at a photo I just took of the | working display: if you'd please scroll to the bottom of [1] .. ? | | A final (hah!) question: will your

Re: 6.3 and Prolific PL-2303 USB serial adapter

2018-06-18 Thread Jan-Piet Mens
Only one way to find out :) I spare you a lot of details by pointing you at a photo I just took of the working display: if you'd please scroll to the bottom of [1] .. ? A final (hah!) question: will your patch be incorporated into OpenBSD? Best regards, -JP [1]

Re: ksh "clear-screen" editing command

2018-06-18 Thread Todd C. Miller
On Sun, 17 Jun 2018 15:52:34 -0600, "Todd C. Miller" wrote: > On Sun, 17 Jun 2018 17:29:31 +0200, Mark Kettenis wrote: > > > If folks indeed think that this is a must-have feature, this is > > certainly a better approach. I wonder though if the setupterm() call > > should happen earlier when

mandoc potential memory leak fix

2018-06-18 Thread Jan Schreiber
Hi, this patch closes potential memory leaks in the mandoc memory wrapper functions and follows the examples in the manpages. diff --git mandoc_aux.c mandoc_aux.c index 7c23ecfdd01..dbfb83faffc 100644 --- mandoc_aux.c +++ mandoc_aux.c @@ -66,27 +66,43 @@ mandoc_malloc(size_t size) void *

pfkey & solock()

2018-06-18 Thread Martin Pieuchot
Instead of grabbing the KERNEL_LOCK() in pfkey_sendup(), assert the corresponding socket lock is held. It's currently the same since the kernel lock is still the socket lock for pfkey sockets. However this prepare the terrain for using a different lock. This reuse the same pattern already used

PF: minor changes to TCP option parsing

2018-06-18 Thread richard . n . procter
Hi, I have committed a patch to -current which refactors the six ways that PF finds TCP options into one new function. I expect no side-effects, and the minor changes to finding MSS and WSCALE options that this involved were immaterial to the large sample of live traffic that I've examined.

Unlock sendit-based syscalls

2018-06-18 Thread Martin Pieuchot
Diff below is the last of the serie to remove the KERNEL_LOCK() from sendto(2) and sendmsg(2) for sockets protected by the NET_LOCK(). As explained previously [0] this diff uses a simple non-intrusive approached based on a single mutex. I'd like to get this in before doing any refactoring of

Re: conf files tweak

2018-06-18 Thread Claudio Jeker
On Sun, Jun 17, 2018 at 09:23:50PM +0100, Jason McIntyre wrote: > hi. > > diff below removes the section header SECTIONS for conf files, > preventing a one line DESCRIPTION. it also stops numbering the amount of > sections because a) it is unimportant and b) every time we add or remove > a

Re: fdinsert(), take 3

2018-06-18 Thread Martin Pieuchot
On 16/06/18(Sat) 19:28, Mark Kettenis wrote: > > Date: Thu, 14 Jun 2018 14:28:07 +0200 > > From: Martin Pieuchot > > > > This version should fixes the previous issue where LARVAL files were > > incorrectly accounted in find_last_set() resulting in a panic() in > > fd_unused(). > > > > If you

ospfd: deal with /etc/netstart, changes of netmask and dest_addr

2018-06-18 Thread Remi Locherer
Hi, in some circumstances ospfd behaves not the way a user would expect and it's not easy understand how to recover. With below diff ospfd recovers automatically from the following three cases. 1) netstart When someone runs the netstart script on a running system it most likely assigns the