On Sat, Nov 10, 2018 at 05:03:42PM -0700, Alexander Bluhm wrote:
> On Sun, Nov 11, 2018 at 09:48:09AM +1000, David Gwynne wrote:
> > this good idea was suggested by kn@ and deraadt@
> >
> > ok?
>
> OK bluhm@
>
> I think the cast to socklen_t in (socklen_t)sizeof(optval) is not
> good. We
Alexander Bluhm wrote:
> I think the cast to socklen_t in (socklen_t)sizeof(optval) is not
> good. We should just let the compiler make its job.
true, I have a name for those,
"potentially truncating casts"
of course you need to determine what the types are, but that's the
whole point, it is
On Sun, Nov 11, 2018 at 09:48:09AM +1000, David Gwynne wrote:
> this good idea was suggested by kn@ and deraadt@
>
> ok?
OK bluhm@
I think the cast to socklen_t in (socklen_t)sizeof(optval) is not
good. We should just let the compiler make its job.
bluhm
> Index: ping.c
>
this good idea was suggested by kn@ and deraadt@
ok?
Index: ping.c
===
RCS file: /cvs/src/sbin/ping/ping.c,v
retrieving revision 1.232
diff -u -p -r1.232 ping.c
--- ping.c 10 Nov 2018 23:44:53 - 1.232
+++ ping.c
> On 11 Nov 2018, at 4:13 am, Jason McIntyre wrote:
>
> On Sat, Nov 10, 2018 at 10:50:14AM -0700, Alexander Bluhm wrote:
>> On Sat, Nov 10, 2018 at 12:54:49PM +0100, Klemens Nanni wrote:
>>> Yes, although I agree with jmc on simpler wording. FWIW, FreeBSD just
>>> goes with "-D Set the
On Sat, Nov 10, 2018 at 01:22:47PM -0500, Brandon Mercer wrote:
> On Sat, Nov 10, 2018 at 03:45:41PM +, Ben Pye wrote:
> > On Sat, Nov 10, 2018 at 06:30:37AM +, Ben Pye wrote:
> > > On Wed, Nov 07, 2018 at 05:33:13PM +0100, Mark Kettenis wrote:
> > > > > From: Ben Pye
> > > > >
On Thu, Nov 08, 2018 at 12:00:26AM -0800, Ayaka Koshibe wrote:
> After a second thought, I've split off the diff for switchd.conf(5)
> from the diffs for changing switchd(8)'s default listen port.
>
> As suggested by kn@, it now notes the default listen port and address.
OK with me, thanks.
Add core 4g thermal id from one of my systems. ok?
Index: pcidevs
===
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1866
diff -u -p -u -r1.1866 pcidevs
--- pcidevs 8 Nov 2018 06:54:13 - 1.1866
+++
Hi,
ripd wants curly braces for interface blocks even if no parameters are
specified. This is inconsistent with other daemons and a bit annoying.
Below diff makes ripd accepting
interface if0
without { } afterwards. The example in the man page shows the interface
statement with and
On Sat, Nov 10, 2018 at 01:38:13PM -0500, Daniel Dickman wrote:
> Below patch removes use of sbrk from mkhybrid.
>
> sbrk is only used here when mkhybrid is run in verbose mode to print a
> diagnostic (see src/mkisofs.c).
>
> ok?
ok
On Sat, Nov 10, 2018 at 01:49:25PM -0500, Daniel Dickman wrote:
> sync the text in csh(1) with text from getrlimit(2) and remove mention of
> sbrk.
>
> ok?
ok
sync the text in csh(1) with text from getrlimit(2) and remove mention of
sbrk.
ok?
Index: csh.1
===
RCS file: /cvs/src/bin/csh/csh.1,v
retrieving revision 1.79
diff -u -p -u -r1.79 csh.1
--- csh.1 12 Dec 2017 11:34:38 -
Below patch removes use of sbrk from mkhybrid.
sbrk is only used here when mkhybrid is run in verbose mode to print a
diagnostic (see src/mkisofs.c).
ok?
Index: src/config.h
===
RCS file:
On Fri, Nov 09, 2018 at 04:25:13PM +, Ben Pye wrote:
> On Thu, Nov 08, 2018 at 11:25:37PM -0600, joshua stein wrote:
> > On Fri, 09 Nov 2018 at 03:30:07 +, b...@curlybracket.co.uk wrote:
> > > Hi all,
> > >
> > > This patch adds a new touchpad driver, elan(4), which supports older non
> >
On Sat, Nov 10, 2018 at 03:45:41PM +, Ben Pye wrote:
> On Sat, Nov 10, 2018 at 06:30:37AM +, Ben Pye wrote:
> > On Wed, Nov 07, 2018 at 05:33:13PM +0100, Mark Kettenis wrote:
> > > > From: Ben Pye
> > > > Content-Type: text/plain; charset="utf-8"
> > > >
> > > > I have been attempting to
On Sat, Nov 10, 2018 at 10:50:14AM -0700, Alexander Bluhm wrote:
> On Sat, Nov 10, 2018 at 12:54:49PM +0100, Klemens Nanni wrote:
> > Yes, although I agree with jmc on simpler wording. FWIW, FreeBSD just
> > goes with "-D Set the Don't Fragment bit" as well.
>
> There is no "Don't Fragment
On Sat, Nov 10, 2018 at 12:54:49PM +0100, Klemens Nanni wrote:
> Yes, although I agree with jmc on simpler wording. FWIW, FreeBSD just
> goes with "-D Set the Don't Fragment bit" as well.
There is no "Don't Fragment bit" in IPv6, so this is wrong.
In IPv4 we do set the don't fragment bit in the
Hi,
Make use of the new LFPRINT() debug macro.
Comments? OK?
Index: kern/vfs_lockf.c
===
RCS file: /cvs/src/sys/kern/vfs_lockf.c,v
retrieving revision 1.30
diff -u -p -r1.30 vfs_lockf.c
--- kern/vfs_lockf.c10 Nov 2018 11:54:03
On Sat, Nov 10, 2018 at 05:54:21PM +0100, Remi Locherer wrote:
> Hi,
>
> the default for triggered-updates is no.
>
> OK?
Sure.
> Remi
>
>
> cvs diff: Diffing .
> Index: ripd.conf.5
> ===
> RCS file:
Hi,
the default for triggered-updates is no.
OK?
Remi
cvs diff: Diffing .
Index: ripd.conf.5
===
RCS file: /cvs/src/usr.sbin/ripd/ripd.conf.5,v
retrieving revision 1.15
diff -u -p -r1.15 ripd.conf.5
--- ripd.conf.5 18 Jun 2018
Klemens Nanni wrote:
> Yes, although I agree with jmc on simpler wording. FWIW, FreeBSD just
> goes with "-D Set the Don't Fragment bit" as well.
Suppose so.
> On Sat, Nov 10, 2018 at 03:27:19PM +1000, David Gwynne wrote:
> > @@ -681,6 +681,13 @@ main(int argc, char *argv[])
> >
On Sat, Nov 10, 2018 at 06:30:37AM +, Ben Pye wrote:
> On Wed, Nov 07, 2018 at 05:33:13PM +0100, Mark Kettenis wrote:
> > > From: Ben Pye
> > > Content-Type: text/plain; charset="utf-8"
> > >
> > > I have been attempting to run OpenBSD on my HP Chromebook 13, it's a
> > > Skylake device with
On Sat, Nov 10, 2018 at 12:32:01PM +, Tom Smyth wrote:
> Does That card need specific firmware loaded?
> like the older bnx cards ?
> I dont see a reference to it in the bnxt man page...
The firmware is stored on the card. You can see the firmware package version
printed when the driver
On Sat, Nov 10, 2018 at 02:25:49PM +0100, Klemens Nanni wrote:
> On Sat, Nov 10, 2018 at 02:01:56PM +0100, Klemens Nanni wrote:
> > OK kn with using defines, see inline with one other irrelevant nit.
> We should of course check the lower bound, too.
>
> > > + if (vlan_num > 4095) {
> if
On Sat, Nov 10, 2018 at 02:01:56PM +0100, Klemens Nanni wrote:
> OK kn with using defines, see inline with one other irrelevant nit.
We should of course check the lower bound, too.
> > + if (vlan_num > 4095) {
if (vlan_num < EVL_VLID_MIN || vlan_num > EVL_VLID_MAX) {
ifconfig must not accept reserved IDs, it'll fail:
/sys/net/if_vlan.c:
646 case SIOCSVNETID:
647 if (ifr->ifr_vnetid < EVL_VLID_MIN ||
648 ifr->ifr_vnetid > EVL_VLID_MAX) {
649 error =
On Sat, Nov 10, 2018 at 10:05:18AM +0100, Denis Fondras wrote:
> 'tcpdump vlan $vlan_number' will not return anything if priority is not 0.
>
> Fix that by not comparing vlan number against priority.
> Also deny usage of vlan number greater than 4095 while at it.
4095 is reserved, 4094 is the
Does That card need specific firmware loaded?
like the older bnx cards ?
I dont see a reference to it in the bnxt man page...
On Sat, 10 Nov 2018 at 05:10, David Gwynne wrote:
>
>
>
> > On 10 Nov 2018, at 12:22 pm, Jonathan Matthew wrote:
> >
> > On Fri, Nov 09, 2018 at 04:35:38AM -0700,
Yes, although I agree with jmc on simpler wording. FWIW, FreeBSD just
goes with "-D Set the Don't Fragment bit" as well.
On Sat, Nov 10, 2018 at 03:27:19PM +1000, David Gwynne wrote:
> @@ -681,6 +681,13 @@ main(int argc, char *argv[])
>
On Sat, Nov 10, 2018 at 11:22:48AM +0100, Claudio Jeker wrote:
> On Fri, Nov 09, 2018 at 03:49:32PM -0700, Alexander Bluhm wrote:
> > On Fri, Nov 09, 2018 at 09:03:20PM +0100, Jan Klemkow wrote:
> > > On Fri, Nov 09, 2018 at 12:36:20PM -0700, Alexander Bluhm wrote:
> > > > On Fri, Nov 09, 2018 at
On Fri, Nov 09, 2018 at 08:11:06PM +0100, Denis Fondras wrote:
> When querying a non-existent table, do not reply "no such peer"
>
> Index: bgpd/bgpd.h
> ===
> RCS file: /cvs/src/usr.sbin/bgpd/bgpd.h,v
> retrieving revision 1.352
>
On Fri, Nov 09, 2018 at 03:49:32PM -0700, Alexander Bluhm wrote:
> On Fri, Nov 09, 2018 at 09:03:20PM +0100, Jan Klemkow wrote:
> > On Fri, Nov 09, 2018 at 12:36:20PM -0700, Alexander Bluhm wrote:
> > > On Fri, Nov 09, 2018 at 08:24:47PM +0100, Jan Klemkow wrote:
> > > > Perfect, I also think its
'tcpdump vlan $vlan_number' will not return anything if priority is not 0.
Fix that by not comparing vlan number against priority.
Also deny usage of vlan number greater than 4095 while at it.
Index: gencode.c
===
RCS file:
On Sat, Nov 10, 2018 at 03:27:19PM +1000, David Gwynne wrote:
> this brings -D over to ping6.
>
> ok?
>
morning.
could we reduce the entire text to just "Disable fragmentation of
transmitted packets.", without special casing ip4/6?
or perhaps "Don;t fragment transmitted packets.", since that
34 matches
Mail list logo
