[patch] smtpd: fix for ctype casts

2020-02-01 Thread Hiltjo Posthuma
Hi, This (pedantic) patch fixes a few casts for ctype functions/macros, like isspace, isalpha and isdigit. The isspace(3) man page says: "CAVEATS The argument c must be EOF or representable as an unsigned char; otherwise, the result is undefined." POSIX says: "The c argument is an int, the

Re: [patch] /bin/cp: reduce scope variable

2020-02-01 Thread Ingo Schwarze
Hi Jeremie, Jeremie Courreges-Anglas wrote on Sat, Feb 01, 2020 at 01:37:32PM +0100: > On Fri, Jan 31 2020, Ingo Schwarze wrote: >> ngc...@gmail.com wrote on Fri, Jan 31, 2020 at 10:14:52PM +0900: >>> Reduce scope of a few variables. >> No, this contradicts OpenBSD coding style. >> We want loca

Re: em(4) diff to test

2020-02-01 Thread Martin Pieuchot
On 31/01/20(Fri) 13:46, Mike Larkin wrote: > On Thu, Jan 30, 2020 at 09:15:35AM +0100, Martin Pieuchot wrote: > > On 21/01/20(Tue) 12:31, Martin Pieuchot wrote: > > > On 20/01/20(Mon) 16:42, Martin Pieuchot wrote: > > > > Diff below is a refactoring of the actual em(4) code and defines that > > > >

Re: acme-client: prevent duplicate definitions of global variables

2020-02-01 Thread Jeremie Courreges-Anglas
On Fri, Jan 31 2020, Michael Forney wrote: > Every source file that includes extern.h will have its own definition > of these variables. Since many compilers allocate the variables with > .comm, they end up getting merged by the linker without error. > However, ISO C requires exactly one definitio

Re: rdomain.4: Use -rdomain to delete rdomain

2020-02-01 Thread Jeremie Courreges-Anglas
On Sat, Feb 01 2020, Klemens Nanni wrote: > Small nit but this properly reflects the "delete" semantic, much better > than the implicit "reassign". > > ifconfig(8) also nicely mentions IPv4 and IPv6 addresses being purged > in the `-rdomain' part, should the reader consult this manual afterwards.

Re: [patch] /bin/cp: reduce scope variable

2020-02-01 Thread Jeremie Courreges-Anglas
On Fri, Jan 31 2020, Ingo Schwarze wrote: > Hi, > > ngc...@gmail.com wrote on Fri, Jan 31, 2020 at 10:14:52PM +0900: > >> Reduce scope of a few variables. > > No, this contradicts OpenBSD coding style. > We want local variables declared up front in functions > such that you can see at one glance w