Re: suggest to run rpki-client hourly

2020-04-16 Thread Theo de Raadt
Job Snijders wrote: > In cases where rpki-client for some reason ends up taking longer than an > hour, the next execution attempt of the command will be skipped. Better > to just try again an hour later, this helps avoid concurrent rpki-client > processes crossing streams. Agree. As discussed

Re: suggest to run rpki-client hourly

2020-04-16 Thread Job Snijders
Now that cron(8) was put on a quick steroids programme, we have new options available! Awesome work Todd, Theo. On Mon, Apr 13, 2020 at 02:43:27PM +, Job Snijders wrote: > I'm reviewing some of the timers associated with the workings of the > end-to-end propagation from ROA to VRP. I think

Re: patch: Enable dock audio on Thinkpad dock (Thinkpad L460)

2020-04-16 Thread Abel Abraham Camarillo Ojeda
On Tuesday, February 11, 2020, Abel Abraham Camarillo Ojeda < acam...@verlet.org> wrote: > > > On Wednesday, January 8, 2020, Abel Abraham Camarillo Ojeda < > acam...@verlet.org> wrote: > >> >> >> On Mon, Dec 30, 2019 at 1:24 PM Abel Abraham Camarillo Ojeda < >> acam...@verlet.org> wrote: >> >>>

Re: implement locale(1) charmap argument

2020-04-16 Thread Todd C . Miller
Makes sense to me. OK millert@ - todd

distrib/notes/arm64/prep update

2020-04-16 Thread Stuart Henderson
any comments? ok? Index: prep === RCS file: /cvs/src/distrib/notes/arm64/prep,v retrieving revision 1.9 diff -u -p -r1.9 prep --- prep15 Apr 2020 11:41:08 - 1.9 +++ prep16 Apr 2020 20:29:56 - @@ -24,11

implement locale(1) charmap argument

2020-04-16 Thread Ingo Schwarze
Hi, our locale(1) implementation is intentionally simplistic and implements only a subset of this POSIX specification: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/locale.html However, one feature is missing that is actually useful and arguably also well-placed inside the

Re: Some small nits with httpd and relayd and a relayd question

2020-04-16 Thread Kevin Chadwick
On 2020-04-16 18:34, Kevin Chadwick wrote: > If httpd is put in front of a reverse proxy of grafana. I seem to get some > http/1.1 js requests become http/1.0 bad requests. I should add that this was with httpd fcgi. So it may just be, my bad.

Some small nits with httpd and relayd and a relayd question

2020-04-16 Thread Kevin Chadwick
If httpd is put in front of a reverse proxy of grafana. I seem to get some http/1.1 js requests become http/1.0 bad requests. Perhaps related "http://daemonforums.org/showthread.php?p=68392; With relayd there is no problem. However relayd seems to not like the nistp521 keys that httpd was quite

Re: rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Theo de Raadt
Claudio Jeker wrote: > On Thu, Apr 16, 2020 at 09:45:45AM -0600, Theo de Raadt wrote: > > I don't understand the point of any of this cleanup. The process > > is dying and none of these things maintain external state. > > > > I'm going to call it what it is: stylistically stupid and rigid. > >

Re: rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Theo de Raadt
Claudio Jeker wrote: > On Thu, Apr 16, 2020 at 09:45:45AM -0600, Theo de Raadt wrote: > > I don't understand the point of any of this cleanup. The process > > is dying and none of these things maintain external state. > > > > I'm going to call it what it is: stylistically stupid and rigid. > >

Re: rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Claudio Jeker
On Thu, Apr 16, 2020 at 09:45:45AM -0600, Theo de Raadt wrote: > I don't understand the point of any of this cleanup. The process > is dying and none of these things maintain external state. > > I'm going to call it what it is: stylistically stupid and rigid. > > Why? Because it would mean

Re: cron: support single instance jobs

2020-04-16 Thread Leo Unglaub
Hey, i think this is a brilliant idea and it would remove a lot of bloat from my scripts. So i gave your code a try on the latest snapshot and it worked very well. Thanks for this! Thanks and greetings Leo Am 16.04.2020 um 16:56 schrieb Todd C. Miller: One annoying issue with cron is that

Re: cleanup an bad and unneeded typecast in rpki-client

2020-04-16 Thread Todd C . Miller
On Thu, 16 Apr 2020 12:00:04 +0200, Claudio Jeker wrote: > There is a bit of strange code in the ip parser of rpki-client to parse > the AFI. This is a 2byte network byte order value. Instead of using a a > char buf and a short just do everything with a one uint16_t. The current > code does

Re: rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Theo de Raadt
I don't understand the point of any of this cleanup. The process is dying and none of these things maintain external state. I'm going to call it what it is: stylistically stupid and rigid. Why? Because it would mean every call to errx() in the program is wrong because they don't attempt this,

randomize daily/weekly/monthly crons

2020-04-16 Thread Paul de Weerd
Really like the ~ feature in cron. I'm moving every machine that gets updated to -current to use this for the daily/weekly/monthly crons, so they are randomized in the 30 minute window after the original start time. Especially useful on machines running a few (or more) VMs. Something (or

cron: support single instance jobs

2020-04-16 Thread Todd C . Miller
One annoying issue with cron is that it has no way to prevent jobs from being run concurrently. As a result, cron jobs have to do their own locking to prevent concurrent execution. The following adds a "-s" flag to the command field which indicates that only a single instance of the job should

Re: Update www/groups.html

2020-04-16 Thread Ingo Schwarze
Hi, clematis wrote on Thu, Apr 16, 2020 at 12:53:19PM +0200: > Hello, > Here's a few suggestions to update www/groups.html > I was checking if all those links were still existing/active/valid. Thanks, both for doing the checks and providing details about what exactly you did. > Does anyone has

Update www/groups.html

2020-04-16 Thread clematis
Hello, Here's a few suggestions to update www/groups.html I was checking if all those links were still existing/active/valid. 1/ Removing the groups listed in India for the reason below: - Jharkhand (India) http://www.arithme.net doesn't look like an openbsd user group... I've been digging the

Re: sysupgrade: add BUILDINFO file to fetched files

2020-04-16 Thread Stuart Henderson
On 2020/04/13 08:44, Mikolaj Kucharski wrote: > Hi, > > Would below be okay? > > On Tue, Apr 07, 2020 at 04:46:38AM +, Mikolaj Kucharski wrote: > > Hi, > > > > When I'm upgrading my machines, I find it useful to have BUILDINFO > > file around. Tested on RPi3. > > > > Please carbon-copy me

rpki-client: replace deprecated ERR_remove_state

2020-04-16 Thread Claudio Jeker
ERR_remove_state(0) is deprecated use the new api ERR_remove_thread_state(NULL) instead. -- :wq Claudio Index: main.c === RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v retrieving revision 1.61 diff -u -p -r1.61 main.c --- main.c

cleanup an bad and unneeded typecast in rpki-client

2020-04-16 Thread Claudio Jeker
There is a bit of strange code in the ip parser of rpki-client to parse the AFI. This is a 2byte network byte order value. Instead of using a a char buf and a short just do everything with a one uint16_t. The current code does *(uint16_t)buf which is not save since buf is a char array. Lucky us

slaacd(8): only pay attention to interfaces in our routing domain

2020-04-16 Thread Florian Obser
While slaacd(8) doesn't receive router advertisements for interface in a different rdomain it still touches those interfaces, i.e. removing addresses. OK diff --git frontend.c frontend.c index 8c6d48810e9..8f5894a77de 100644 --- frontend.c +++ frontend.c @@ -69,6 +69,7 @@ void

Re: Simplify NET_LOCK() variations

2020-04-16 Thread Alexandr Nedvedicky
Hello, On Thu, Apr 16, 2020 at 10:57:42AM +0200, Martin Pieuchot wrote: > On 14/04/20(Tue) 10:08, Martin Pieuchot wrote: > > On 13/04/20(Mon) 03:20, Alexandr Nedvedicky wrote: > > > On Sun, Apr 12, 2020 at 07:02:43PM +0200, Mark Kettenis wrote: > > > > > From: "Theo de Raadt" > > > > > Date:

Re: Simplify NET_LOCK() variations

2020-04-16 Thread Martin Pieuchot
On 14/04/20(Tue) 10:08, Martin Pieuchot wrote: > On 13/04/20(Mon) 03:20, Alexandr Nedvedicky wrote: > > On Sun, Apr 12, 2020 at 07:02:43PM +0200, Mark Kettenis wrote: > > > > From: "Theo de Raadt" > > > > Date: Sun, 12 Apr 2020 10:28:59 -0600 > > > > > > > > > + if ((p->p_flag & P_SYSTEM) &&

sys/conf.h buglet

2020-04-16 Thread Martin Pieuchot
dev_type_poll() functions return POLL* value or 0 if nothing is supported. Diff below fixes the cdev_ipmi_init() definition by passing selfalse instead of returning ENODEV in a poll function. While here make comments match reality, ok? Index: sys/conf.h