Re: cat(1): simplify/flatten argument loops

2020-11-30 Thread Martijn van Duren
This one reads a lot better to me and even shaves of 2LoC. :-) OK martijn@ On Mon, 2020-11-30 at 18:28 -0600, Scott Cheloha wrote: > Hi, > > The cook_args() and raw_args() functions in cat(1) are too clever. > They handle multiple special cases in a single big loop with lots of > branches.  It's

Re: wireguard + witness

2020-11-30 Thread Sebastien Marie
On Mon, Nov 30, 2020 at 11:14:46PM +, Stuart Henderson wrote: > Thought I'd try a WITNESS kernel to see if that gives any clues about > what's going on with my APU crashing all over the place (long shot but > I got bored with trying different older kernels..) > > I see these from time to time

Re: ACPI diff that needs wide testing

2020-11-30 Thread Greg Steuck
Mark Kettenis writes: > The diff below fixes the way we handle named references in AML > packages. This fixes some bugs but I'd like to make sure that this > doesn't inadvertedly break things. So tests on a wide variety of > machines are welcome. I see a prompt crash: https://photos.app.goo.gl

Re: stdio: fclose(3), fopen(3): intended locking hierarchy?

2020-11-30 Thread Philip Guenther
On Mon, Nov 30, 2020 at 6:10 PM Scott Cheloha wrote: > On Sat, Nov 28, 2020 at 01:41:50PM -0800, Philip Guenther wrote: > ... > > After thinking through states more, #4 isn't safe: _fwalk() can't take > > sfp_mutex because it's called from __srefill() which has its FILE locked, > > which would r

[PATCH] Convert ddb_sysctl to sysctl_bounded_arr

2020-11-30 Thread Greg Steuck
Tested with a bunch of manual sysctl -w's. OK? >From 24ae202fd5d39c3c40c029fb878aa15eee33b709 Mon Sep 17 00:00:00 2001 From: Greg Steuck Date: Mon, 30 Nov 2020 19:42:19 -0800 Subject: [PATCH] Convert ddb_sysctl to sysctl_bounded_arr --- sys/ddb/db_usrreq.c | 22 ++ 1 file c

Re: stdio: fclose(3), fopen(3): intended locking hierarchy?

2020-11-30 Thread Scott Cheloha
On Sat, Nov 28, 2020 at 01:41:50PM -0800, Philip Guenther wrote: > On Fri, Nov 27, 2020 at 10:35 PM Philip Guenther wrote: > ... > > > So yeah, maybe it does work to: > > 1) make __sfp() FLOCKFILE() the allocated FILE before unlocking sfp_mutex > > 2) update f{,d,mem,un}open() and open_*memstream

Re: stdio: fclose(3), fopen(3): intended locking hierarchy?

2020-11-30 Thread Scott Cheloha
On Fri, Nov 27, 2020 at 10:35:59PM -0800, Philip Guenther wrote: > On Wed, Nov 25, 2020 at 4:23 PM Scott Cheloha > wrote: > > > In stdio, which lock are you supposed to take first? The global > > sfp_mutex or the per-FILE lock? > > > > In __sfp() we hold sfp_mutex while iterating through the poo

Re: an(4): tsleep(9) -> tsleep_nsec(9)

2020-11-30 Thread Scott Cheloha
On Thu, Nov 26, 2020 at 08:25:48PM +1100, Jonathan Gray wrote: > On Tue, Nov 24, 2020 at 07:20:46PM -0600, Scott Cheloha wrote: > > Hi, > > > > Both kettenis@ and mpi@ have mentioned in private that my proposed > > changes to tsleep_nsec(9) etc. would be nicer if we could just get rid > > of tslee

Re: [PATCH] Fix a bug where GDB could not display symbols

2020-11-30 Thread Masato Asou
I fixed the patch a bit. The bt command does not work correctly with the core created when calling the ABORT(3) as follows: $ cat main.c #include #include #include int main(int argc, char *argv[]) { printf("argc = %d\n", argc); abort(); return (0); } $ cc -static main.

cat(1): simplify/flatten argument loops

2020-11-30 Thread Scott Cheloha
Hi, The cook_args() and raw_args() functions in cat(1) are too clever. They handle multiple special cases in a single big loop with lots of branches. It's been like this since at least 1989: https://svnweb.freebsd.org/csrg/bin/cat/cat.c?view=markup&pathrev=37179 The goal seems to be to avoid ca

wireguard + witness

2020-11-30 Thread Stuart Henderson
Thought I'd try a WITNESS kernel to see if that gives any clues about what's going on with my APU crashing all over the place (long shot but I got bored with trying different older kernels..) I see these from time to time (one during netstart, and another 4 in 15 mins uptime), anyone know if they'

ACPI diff that needs wide testing

2020-11-30 Thread Mark Kettenis
The diff below fixes the way we handle named references in AML packages. This fixes some bugs but I'd like to make sure that this doesn't inadvertedly break things. So tests on a wide variety of machines are welcome. Index: dev/acpi/acpi.c ===

Re: Prevent race in single_thread_set()

2020-11-30 Thread Martin Pieuchot
On 04/11/20(Wed) 11:19, Martin Pieuchot wrote: > Here's a 3rd approach to solve the TOCTOU race in single_thread_set(). > The issue being that the lock serializing access to `ps_single' is not > held when calling single_thread_check(). > > The approach below is controversial because it extends the

Use SMR_TAILQ for `ps_threads'

2020-11-30 Thread Martin Pieuchot
Every multi-threaded process keeps a list of threads in `ps_threads'. This list is iterated in interrupt and process context which makes it complicated to protect it with a rwlock. One of the places where such iteration is done is inside the tsleep(9) routines, directly in single_thread_check() or

Re: Switch select(2) to kqueue-based implementation

2020-11-30 Thread Martin Pieuchot
On 30/11/20(Mon) 17:06, Visa Hankala wrote: > On Mon, Nov 30, 2020 at 01:28:14PM -0300, Martin Pieuchot wrote: > > I plan to commit this in 3 steps, to ease a possible revert: > > - kevent(2) refactoring > > - introduction of newer kq* APIs > > - dopselect rewrite > > Please send a separate pat

Re: snmp trap usage

2020-11-30 Thread Theo de Raadt
ok Martijn van Duren wrote: > I missed an argc check which causes snmp trap to segfault if called with > too few arguments instead of showing usage. > > OK? > > martijn@ > > Index: snmpc.c > === > RCS file: /cvs/src/usr.bin/snmp/

Re: rad(8): rdomain support

2020-11-30 Thread Florian Obser
On Sun, Nov 29, 2020 at 12:20:31PM +0100, Florian Obser wrote: > > Let rad(8) handle all rdomains in a single daemon, similar to previous > work in slaacd. > > Suggested / requested by tb who showed me previous work by reyk which > unfortunately predated my work in slaacd and followed a diffe

Switch select(2) to kqueue-based implementation

2020-11-30 Thread Martin Pieuchot
Now that the kqueue refactoring has been committed, here's once again the diff to modify the internal implementation of {p,}select(2) to query kqfilter handlers instead of poll ones. {p,}poll(2) are left untouched to ease the transition. I plan to commit this in 3 steps, to ease a possible revert

snmp trap usage

2020-11-30 Thread Martijn van Duren
I missed an argc check which causes snmp trap to segfault if called with too few arguments instead of showing usage. OK? martijn@ Index: snmpc.c === RCS file: /cvs/src/usr.bin/snmp/snmpc.c,v retrieving revision 1.30 diff -u -p -r1.3

Re: [PATCH] umb(4) fix for X20 (DW5821e) in Dell Latitude 7300

2020-11-30 Thread Bryan Vyhmeister
On Mon, Oct 19, 2020 at 08:11:04PM -0700, Bryan Vyhmeister wrote: > On Fri, Oct 02, 2020 at 12:33:15PM -0700, Bryan Vyhmeister wrote: > > On Wed, Sep 30, 2020 at 04:05:51PM -0700, Bryan Vyhmeister wrote: > > > Gerhard Roth provided a patch to me to get the Qualcomm Snapdragon X20 > > > umb(4) inter

libressl pc files

2020-11-30 Thread Stuart Henderson
Several ports are patched to cope with the version number in pkgconfig files for libressl libs (currently all at 1.0.0) portoriginally wanted lang/php/7.2>= 1.0.1 lang/php/7.3>= 1.0.1 lang/php/7.4>= 1.0.1 multimedia/xine-lib >= 1.0.2 secu

Re: tcpdump: use unsigned char in isprint

2020-11-30 Thread Vitaliy Makkoveev
On Sun, Nov 29, 2020 at 07:21:53PM -0800, Greg Steuck wrote: > Vitaliy Makkoveev writes: > > > Hi. > > > > For me `ch' is unwanted here. > > > > Index: usr.sbin/tcpdump/util.c > > === > > RCS file: /cvs/src/usr.sbin/tcpdump/util.c,v

Re: relayd and TLS client cert verification

2020-11-30 Thread Markus Läll
Hi! > I have patch on top of this which allows to pass remote certificate > and/or parts of it to backend hosts via http headers. Did this patch ever arrive and would it also make sense inside httpd (in addition to relayd)? -- Markus Läll

Re: amdgpu(4): use DRM_INFO instead of printf for printing compute unit info

2020-11-30 Thread Jonathan Gray
On Mon, Nov 30, 2020 at 12:02:15AM -0600, Charlie Burnett wrote: > Doesn’t DRM_INFO output even if DRMDEBUG is enabled? I thought DRM_DEBUG > only output when debug’s enabled while DRM_INFO is pretty much just a > wrapper for printk? Currently DRM_INFO will call into printk which returns early for