pair: send without kernel lock

2021-01-06 Thread Klemens Nanni
pair(4)'s output path can run without kernel lock just fine. NB: Looking at CVS log, it seems this was not done during import because IFXF_MPSSAFE became a thing afterwards. Feedback? Objections? OK? Index: if_pair.c === RCS file:

Re: tpm(4): don't use tvtohz(9)

2021-01-06 Thread Mark Kettenis
> Date: Wed, 6 Jan 2021 16:16:27 -0600 > From: Scott Cheloha > > On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > > As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in > > the tree. > > > > However, we don't need to use tvtohz(9) in tpm(4) at all. Converting >

Re: tpm(4): don't use tvtohz(9)

2021-01-06 Thread Scott Cheloha
On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in > the tree. > > However, we don't need to use tvtohz(9) in tpm(4) at all. Converting > from milliseconds to ticks is trivial. Using an intermediary timeval > is

Re: New ujoy(4) device for USB gamecontrollers

2021-01-06 Thread Marcus Glocker
On Mon, Dec 28, 2020 at 05:03:14PM -0700, Thomas Frohwein wrote: > Hi, > > This is a diff to propose a new device type for USB gamecontrollers, > 'ujoy'. > > Rationale > - > > Since the tightening of security around USB devices, USB > gamecontrollers that generally attach to the

Re: fix opsfd parse.y shit/reduce conflicts

2021-01-06 Thread Sebastian Benoit
Thanks, i think the dependon might have been my fault. code reads ok. I also checked a few configs, including an artificial one that uses depend on. /Benno Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.01.06 11:11:49 +0100: > The dependon statement in ospfd parse.y introduces some troubles

Re: video(4) multiple opens

2021-01-06 Thread Jeremie Courreges-Anglas
On Wed, Jan 06 2021, Marcus Glocker wrote: > On Tue, Jan 05, 2021 at 11:54:31PM +0100, Jeremie Courreges-Anglas wrote: [...] >> Here's the diff. IIUC the use of atomic operations isn't strictly >> needed here since open(2) runs with the kernel lock, but the result >> is easy to understand IMO.

Re: tpm(4): don't use tvtohz(9)

2021-01-06 Thread Klemens Nanni
On Wed, Jan 06, 2021 at 12:16:13PM -0600, Scott Cheloha wrote: > As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in > the tree. > > However, we don't need to use tvtohz(9) in tpm(4) at all. Converting > from milliseconds to ticks is trivial. Using an intermediary timeval > is

tpm(4): don't use tvtohz(9)

2021-01-06 Thread Scott Cheloha
As mentioned in a prior mail, tpm(4) is the last user of tvtohz(9) in the tree. However, we don't need to use tvtohz(9) in tpm(4) at all. Converting from milliseconds to ticks is trivial. Using an intermediary timeval is just pointless indirection. With this committed I will be able to remove

Re: sleep(3): don't bypass nanosleep(2)

2021-01-06 Thread Todd C . Miller
On Wed, 06 Jan 2021 10:31:28 -0600, Scott Cheloha wrote: > Other benefits: > > - sleep(3) now *always* shows up in ktrace. > > - sleep(3) with a zero input now blocks for up to 1 tick, just like > nanosleep(2) does with a zero input (more intuitive behavior). > > - Neither NetBSD nor FreeBSD

sleep(3): don't bypass nanosleep(2)

2021-01-06 Thread Scott Cheloha
In sleep(3), if seconds is zero we don't call nanosleep(2). I don't like this. If sleep(3) really is a simplified interface to nanosleep(2) (as we claim in the manpage) we should let nanosleep(2) handle the input and make decisions. Other benefits: - sleep(3) now *always* shows up in ktrace.

Re: fix opsfd parse.y shit/reduce conflicts

2021-01-06 Thread Kapetanakis Giannis
On 06/01/2021 12:11, Claudio Jeker wrote: The dependon statement in ospfd parse.y introduces some troubles since it holds an empty rule that then conflicts with optnl. This diff changes dependon into dependon and dependonopt so that in the place where it is optional dependonopt can be used and

Re: Make ospf6d work on point-to-point links

2021-01-06 Thread Kapetanakis Giannis
On 06/01/2021 14:02, Claudio Jeker wrote: The code in ospf6d is a bit broken when it comes to point-to-point links. This diff fixes this by a) using the neighbor address instead of the unset interface destination address and by b) matching the incomming packet against all possible IPs of that

Re: video(4) multiple opens

2021-01-06 Thread Marcus Glocker
On Tue, Jan 05, 2021 at 11:54:31PM +0100, Jeremie Courreges-Anglas wrote: > > I hit a weird failure with firefox and BigBlueButton > (https://bigbluebutton.org/) where firefox can't use my webcam. > video(1) works, same for other webrtc sites in firefox, eg meet.jit.si. > ktrace shows that a

Re: ntpd.conf.5 duplicate word

2021-01-06 Thread Jason McIntyre
On Wed, Jan 06, 2021 at 08:53:04PM +0800, Sean Davies wrote: > Index: ntpd.conf.5 > === > RCS file: /cvs/src/usr.sbin/ntpd/ntpd.conf.5,v > retrieving revision 1.46 > diff -u -p -u -r1.46 ntpd.conf.5 > --- ntpd.conf.5 16 May 2020

ntpd.conf.5 duplicate word

2021-01-06 Thread Sean Davies
Index: ntpd.conf.5 === RCS file: /cvs/src/usr.sbin/ntpd/ntpd.conf.5,v retrieving revision 1.46 diff -u -p -u -r1.46 ntpd.conf.5 --- ntpd.conf.5 16 May 2020 16:58:12 - 1.46 +++ ntpd.conf.5 6 Jan 2021 12:41:49 - @@ -119,7

Re: unbound: missing null check

2021-01-06 Thread Stuart Henderson
On 2021/01/06 10:24, Florian Obser wrote: > On Wed, Jan 06, 2021 at 10:11:01AM +0100, Anton Lindqvist wrote: > > Hi, > > I have a unbound forward zone configured on my router for my $DAYJOB. > > The address associated with the zone is only accessible when the router > > is connected to a VPN. If

Make ospf6d work on point-to-point links

2021-01-06 Thread Claudio Jeker
The code in ospf6d is a bit broken when it comes to point-to-point links. This diff fixes this by a) using the neighbor address instead of the unset interface destination address and by b) matching the incomming packet against all possible IPs of that interface. I tripped on b) because my P2P

Re: unbound: missing null check

2021-01-06 Thread Anton Lindqvist
On Wed, Jan 06, 2021 at 10:24:47AM +0100, Florian Obser wrote: > On Wed, Jan 06, 2021 at 10:11:01AM +0100, Anton Lindqvist wrote: > > Hi, > > I have a unbound forward zone configured on my router for my $DAYJOB. > > The address associated with the zone is only accessible when the router > > is

fix opsfd parse.y shit/reduce conflicts

2021-01-06 Thread Claudio Jeker
The dependon statement in ospfd parse.y introduces some troubles since it holds an empty rule that then conflicts with optnl. This diff changes dependon into dependon and dependonopt so that in the place where it is optional dependonopt can be used and in the places where it must not be optional

Extend IP_ADD_MEMBERSHIP to support struct ip_mreqn

2021-01-06 Thread Claudio Jeker
Linux and FreeBSD both support the use of struct ip_mreqn in IP_ADD_MEMBERSHIP and IP_DROP_MEMBERSHIP. This struct adds one more field to pass an interface index to the kernel (instead of using the IP address). struct ip_mreqn { struct in_addr imr_multiaddr; /* IP multicast address of

Re: unbound: missing null check

2021-01-06 Thread Florian Obser
On Wed, Jan 06, 2021 at 10:11:01AM +0100, Anton Lindqvist wrote: > Hi, > I have a unbound forward zone configured on my router for my $DAYJOB. > The address associated with the zone is only accessible when the router > is connected to a VPN. If the VPN connection is absent, trying to > resolve any

unbound: missing null check

2021-01-06 Thread Anton Lindqvist
Hi, I have a unbound forward zone configured on my router for my $DAYJOB. The address associated with the zone is only accessible when the router is connected to a VPN. If the VPN connection is absent, trying to resolve any domain that must be handled by the zone crashes unbound. Turns out there's