Re: interface group name validation

2021-02-09 Thread Anton Lindqvist
On Tue, Feb 09, 2021 at 11:08:09PM +0100, Alexander Bluhm wrote: > Hi, > > Next try to fix syzkaller crash > https://syzkaller.appspot.com/bug?id=54e16dc5bce6929e14b42e2f1379f1c18f62be43 > > Interface group names must fit into IFNAMSIZ and be unique. But > the kernel makes the unique check

Re: [patch] typos in ldap.1

2021-02-09 Thread Jason McIntyre
On Tue, Feb 09, 2021 at 09:31:10PM -0500, Dave Voutila wrote: > Three small changes: > > 1. product -> produce > 2. remove '.' from sizelimit description > 3. remove linebreaks on statements about {size,time}limit > > -Dave Voutila > fixed, thanks. jmc > Index: usr.bin/ldap/ldap.1 >

Re: interface group name validation

2021-02-09 Thread Greg Steuck
Alexander Bluhm writes: > Hi, > > Next try to fix syzkaller crash > https://syzkaller.appspot.com/bug?id=54e16dc5bce6929e14b42e2f1379f1c18f62be43 > > Interface group names must fit into IFNAMSIZ and be unique. But > the kernel makes the unique check before trunkating with strlcpy(). > So there

[patch] typos in ldap.1

2021-02-09 Thread Dave Voutila
Three small changes: 1. product -> produce 2. remove '.' from sizelimit description 3. remove linebreaks on statements about {size,time}limit -Dave Voutila Index: usr.bin/ldap/ldap.1 === RCS file: /cvs/src/usr.bin/ldap/ldap.1,v

interface group name validation

2021-02-09 Thread Alexander Bluhm
Hi, Next try to fix syzkaller crash https://syzkaller.appspot.com/bug?id=54e16dc5bce6929e14b42e2f1379f1c18f62be43 Interface group names must fit into IFNAMSIZ and be unique. But the kernel makes the unique check before trunkating with strlcpy(). So there can be two interfaces groups with the

video(4) multiple opens

2021-02-09 Thread Marcus Glocker
jca@ has recently committed a change to video(4) to allow the same process to do multiple opens on the same video device to satisfy certain applications, and start to go in to the V4L2 "1.1.4 Multiple Opens" specification direction as described here:

Re: PF_UNIX sockets unlocking

2021-02-09 Thread Alexander Bluhm
On Tue, Feb 09, 2021 at 09:14:44PM +0300, Vitaliy Makkoveev wrote: > On Tue, Feb 09, 2021 at 05:20:33PM +0100, Alexander Bluhm wrote: > > > +extern struct rwlock unp_lock; > > > > Could you put this declaration into a header file? > > I see no such sense to do this. `unp_lock' is not system wide

Re: PF_UNIX sockets unlocking

2021-02-09 Thread Vitaliy Makkoveev
On Tue, Feb 09, 2021 at 05:20:33PM +0100, Alexander Bluhm wrote: > On Thu, Feb 04, 2021 at 03:07:44PM +0300, Vitaliy Makkoveev wrote: > > I hope someone else will try it and gives positive feedback which allow > > to push it forward. > > OK bluhm@ > Thanks. > > +extern struct rwlock unp_lock; >

Re: PF_UNIX sockets unlocking

2021-02-09 Thread Alexander Bluhm
On Thu, Feb 04, 2021 at 03:07:44PM +0300, Vitaliy Makkoveev wrote: > I hope someone else will try it and gives positive feedback which allow > to push it forward. OK bluhm@ > +extern struct rwlock unp_lock; Could you put this declaration into a header file?

Re: uhidpp(4): logitech hid++ device driver

2021-02-09 Thread Anindya Mukherjee
On Tue, Feb 09, 2021 at 08:34:00AM +0100, Anton Lindqvist wrote: > Hi, > > On Mon, Feb 08, 2021 at 02:50:39PM -0800, Anindya Mukherjee wrote: > > Hi, I have a Logitech M570 which seems to be handled by this new driver. > > However I don't see any battery level information. > > > > dmesg: > >

Re: ocspcheck try all returned addresses from getaddrinfo

2021-02-09 Thread Klemens Nanni
On Tue, Feb 09, 2021 at 10:54:39AM +0100, Claudio Jeker wrote: > Running regress/usr.sbin/ocspcheck with a resolv.conf that has > 'family inet6 inet4' fails because ocspcheck only tries to contact ::1. > The following diff fixes the issue by not breaking out early from the > getaddrinfo loop over

ocspcheck try all returned addresses from getaddrinfo

2021-02-09 Thread Claudio Jeker
Running regress/usr.sbin/ocspcheck with a resolv.conf that has 'family inet6 inet4' fails because ocspcheck only tries to contact ::1. The following diff fixes the issue by not breaking out early from the getaddrinfo loop over the results. With this the regress test works and I guess it may help

pppac(4): remove `sc_dead' logic

2021-02-09 Thread Vitaliy Makkoveev
`sc_dead' is used to prevent pppac_ioctl() be called on dying pppac(4) interface. But now if_detach() makes dying `ifp' inaccessible and waits for references which are in-use. This logic is not required anymore. Also I moved if_detach() before klist_invalidate() to prevent the case while