Re: rpki-client http keep-alive support

2021-04-16 Thread Theo de Raadt
> The benefit of using keep-alive is less CPU time wasted on constant TLS > handshakes. I did not notice any speed improvements. And... not bouncing between inconsistant CA endpoints. Further discussion about that problem will occur elsewhere.

Re: another slowcgi cleanup

2021-04-16 Thread Todd C . Miller
On Fri, 16 Apr 2021 17:34:38 +0200, Claudio Jeker wrote: > Every code using SLIST_REMOVE() should just switch to proper LISTs. > I realized slowcgi was using SLIST where it should use LIST but that was > only the start of the rabbit hole. There is also no need to double wrap > the request. So

another slowcgi cleanup

2021-04-16 Thread Claudio Jeker
Every code using SLIST_REMOVE() should just switch to proper LISTs. I realized slowcgi was using SLIST where it should use LIST but that was only the start of the rabbit hole. There is also no need to double wrap the request. So this diff make this all nice and shiny. -- :wq Claudio Index:

Re: slowcgi ignore SIGPIPE

2021-04-16 Thread Florian Obser
OK On Fri, Apr 16, 2021 at 05:20:00PM +0200, Claudio Jeker wrote: > This is an optimisation. > > Instead of installing a signal handler that does nothing just ignore the > signal. Now to ensure that the cgi processes run with a default SIGPIPE > restore it before execve. > > -- > :wq Claudio >

Re: slowcgi ignore SIGPIPE

2021-04-16 Thread Alexander Bluhm
On Fri, Apr 16, 2021 at 05:20:00PM +0200, Claudio Jeker wrote: > This is an optimisation. > > Instead of installing a signal handler that does nothing just ignore the > signal. Now to ensure that the cgi processes run with a default SIGPIPE > restore it before execve. OK bluhm@ > Index:

slowcgi ignore SIGPIPE

2021-04-16 Thread Claudio Jeker
This is an optimisation. Instead of installing a signal handler that does nothing just ignore the signal. Now to ensure that the cgi processes run with a default SIGPIPE restore it before execve. -- :wq Claudio Index: slowcgi.c

Re: slowcgi: scriptname and chdir vs execve

2021-04-16 Thread Claudio Jeker
On Fri, Apr 16, 2021 at 03:43:51PM +0200, Claudio Jeker wrote: > I tried to use slowcgi to execute a binary in cgi-bin/ when accessing a > resource. > > So the config looked a bit like this: > > location "/foo/bar" { > fastcgi param SCRIPT_FILENAME "/cgi-bin/foobar" >

slowcgi: scriptname and chdir vs execve

2021-04-16 Thread Claudio Jeker
I tried to use slowcgi to execute a binary in cgi-bin/ when accessing a resource. So the config looked a bit like this: location "/foo/bar" { fastcgi param SCRIPT_FILENAME "/cgi-bin/foobar" root "" } With this slowcgi fails with: slowcgi[98607]:

rpki-client http keep-alive support

2021-04-16 Thread Claudio Jeker
This diff changes the http module to support keep-alive. It splits requests (for a resource) from connections (to a server). When a request is received the code tries to first use a IDLE connection, if none is around a new connection is started (unless there are too many connections inflight).

Re: wcwidth of soft hyphen

2021-04-16 Thread Martijn van Duren
On Thu, 2021-04-15 at 14:20 +0200, Martijn van Duren wrote: > I did some archeology today and found that it used to behave as > non-printable, but it got broken in release 334 (august 2018), when > CharWidth was introduced. Before that my_wcwidth was used directly. > > Since there doesn't appear

Re: relayd regress tcp performance

2021-04-16 Thread Claudio Jeker
On Thu, Apr 15, 2021 at 08:43:02PM +0200, Alexander Bluhm wrote: > Hi, > > I found another regression with Jan's TCP diff that sends less ACK > packets. relayd run-args-http-slow-consumer.pl fails on i386 due > to his commit. This test writes a lot of data from the http server, > but blocks