Re: Silence vmd rtc_update_rega non-32KHz timebase spam

2021-12-08 Thread Brian Conway
Ping with complete diff. Thanks. Brian Conway diff --git usr.sbin/vmd/mc146818.c usr.sbin/vmd/mc146818.c index e3599c685..001c1a055 100644 --- usr.sbin/vmd/mc146818.c +++ usr.sbin/vmd/mc146818.c @@ -34,7 +34,6 @@ #include "vmd.h" #include "vmm.h" -#define MC_DIVIDER_MASK 0xe0 #define MC_RATE_

sndiod: -F does not switch back to preferred device

2021-12-08 Thread Klemens Nanni
Following https://www.openbsd.org/faq/faq13.html#usbaudio and reading sndiod(8)'s -F device Specify an alternate device to use. If it doesn't work, the one given with the last -f or -F options will be used. For instance, specifying a USB d

Re: net write in pcb hash

2021-12-08 Thread Alexander Bluhm
On Wed, Dec 08, 2021 at 03:28:34PM -0300, Martin Pieuchot wrote: > On 04/12/21(Sat) 01:02, Alexander Bluhm wrote: > > Hi, > > > > As I want a read-only net lock for forwarding, all paths should be > > checked for the correct net lock and asserts. I found code in > > in_pcbhashlookup() where readi

Re: Do not send SIGHUP to syslogd on wtmp rotation

2021-12-08 Thread Martijn van Duren
Comitted, thanks. Although your patch was mangled, so I needed to apply it by hand. Please make sure that you mail is properly formatted. martijn@ On Wed, 2021-12-08 at 13:03 +0300, Антон Касимов wrote: > Hi, > I've noticed that newsyslog sends SIGHUP to syslogd on /var/log/wtmp > rotation. > But

Re: kbind(2): push kernel lock down as needed

2021-12-08 Thread Scott Cheloha
> On Dec 8, 2021, at 12:24, Martin Pieuchot wrote: > > On 06/12/21(Mon) 14:58, Scott Cheloha wrote: >> On Mon, Dec 06, 2021 at 08:35:15PM +0100, Mark Kettenis wrote: Date: Sun, 5 Dec 2021 18:01:04 -0600 From: Scott Cheloha Two things in sys_kbind() need an explicit kernel l

Re: relayd: small ssl.c cleanup

2021-12-08 Thread Alexander Bluhm
On Wed, Dec 08, 2021 at 04:59:36AM +0100, Theo Buehler wrote: > BIO_new_mem_buf has had const since 2018, so this workaround is no > longer needed. OK bluhm@ > Index: ssl.c > === > RCS file: /cvs/src/usr.sbin/relayd/ssl.c,v > retriev

Re: Do not send SIGHUP to syslogd on wtmp rotation

2021-12-08 Thread Alexander Bluhm
On Wed, Dec 08, 2021 at 01:03:10PM +0300, ?? ?? wrote: > Hi, > I've noticed that newsyslog sends SIGHUP to syslogd on /var/log/wtmp > rotation. > But syslogd does not deal with the wtmp log file so there is no need for > SIGHUP. > > I propose to make slightly changes to default

Re: net write in pcb hash

2021-12-08 Thread Martin Pieuchot
On 04/12/21(Sat) 01:02, Alexander Bluhm wrote: > Hi, > > As I want a read-only net lock for forwarding, all paths should be > checked for the correct net lock and asserts. I found code in > in_pcbhashlookup() where reading the PCB table results in a write > to optimize the cache. > > Porperly pr

Re: kbind(2): push kernel lock down as needed

2021-12-08 Thread Martin Pieuchot
On 06/12/21(Mon) 14:58, Scott Cheloha wrote: > On Mon, Dec 06, 2021 at 08:35:15PM +0100, Mark Kettenis wrote: > > > Date: Sun, 5 Dec 2021 18:01:04 -0600 > > > From: Scott Cheloha > > > > > > Two things in sys_kbind() need an explicit kernel lock. First, > > > sigexit(). Second, uvm_map_extract(

Re: [patch] urndis: uncomment watchdog

2021-12-08 Thread Mikhail
On Wed, Dec 08, 2021 at 03:26:25PM +0100, Gerhard Roth wrote: > > I don't want to fight for this diff, if you think that it's too naive to > > expect proper reset from unresponsive device - that's fine, I'm ready to > > drop the diff, but who knows how those devices are engineered and trade > > of

Re: [patch] urndis: uncomment watchdog

2021-12-08 Thread Gerhard Roth
On 12/8/21 15:13, Mikhail wrote: On Wed, Dec 08, 2021 at 02:43:04PM +0100, Gerhard Roth wrote: Well, the RNDIS device doesn't respond to REMOTE_NDIS_KEEPALIVE_MSG messages anymore, but now you hope that it'll still process the REMOTE_NDIS_RESET_MSG we are sending? Sounds like wishful thinking. I

Re: [patch] urndis: uncomment watchdog

2021-12-08 Thread Mikhail
On Wed, Dec 08, 2021 at 02:43:04PM +0100, Gerhard Roth wrote: > Well, the RNDIS device doesn't respond to REMOTE_NDIS_KEEPALIVE_MSG > messages anymore, but now you hope that it'll still process the > REMOTE_NDIS_RESET_MSG we are sending? Sounds like wishful thinking. > I'd say a usbd_reset_port() m

Re: IPsec TDB locking

2021-12-08 Thread Vitaliy Makkoveev
ok mvs@ > On 8 Dec 2021, at 16:41, Alexander Bluhm wrote: > > On Wed, Dec 08, 2021 at 02:41:47AM +0300, Vitaliy Makkoveev wrote: >> [IN] looks strange. If this field modified after creation it is >> mutable. There are cases when such field could modified only once, >> but it still is atomic. >

Re: IPsec TDB locking

2021-12-08 Thread Vitaliy Makkoveev
>> [IN] looks strange. If this field modified after creation it is >> mutable. There are cases when such field could modified only once, >> but it still is atomic. It is mistype. I mean "..could modified only once, but it still is mutable" > On 8 Dec 2021, at 08:56, Visa Hankala wrote: > > On W

Re: [patch] urndis: uncomment watchdog

2021-12-08 Thread Gerhard Roth
On 12/8/21 14:31, Mikhail wrote: On Wed, Dec 08, 2021 at 02:10:49PM +0100, Gerhard Roth wrote: Well, there's only one watchdog thread for all of the network interfaces. If it is blocked, not other watchdogs can run. I don't think this is a big loss. On one side - no other watchdogs can run for

Re: IPsec TDB locking

2021-12-08 Thread Alexander Bluhm
On Wed, Dec 08, 2021 at 02:41:47AM +0300, Vitaliy Makkoveev wrote: > [IN] looks strange. If this field modified after creation it is > mutable. There are cases when such field could modified only once, > but it still is atomic. You are right. tdb_dst and tdb_src are initialized before the TDB is

Re: [patch] urndis: uncomment watchdog

2021-12-08 Thread Mikhail
On Wed, Dec 08, 2021 at 02:10:49PM +0100, Gerhard Roth wrote: > Well, there's only one watchdog thread for all of the > network interfaces. If it is blocked, not other watchdogs > can run. I don't think this is a big loss. On one side - no other watchdogs can run for 5 secs, but on other side - wa

Re: [patch] urndis: uncomment watchdog

2021-12-08 Thread Gerhard Roth
On 12/8/21 14:08, Mikhail wrote: On Wed, Dec 08, 2021 at 10:39:15AM +0100, Gerhard Roth wrote: urndis_watchdog() calls urndis_ctrl_keepalive() which sends an RNDIS keepalive msg and then waits for the reply with USBD_DEFAULT_TIMEOUT. That means if the device stopped responding, the if_watchdog_t

Re: [patch] urndis: uncomment watchdog

2021-12-08 Thread Mikhail
On Wed, Dec 08, 2021 at 10:39:15AM +0100, Gerhard Roth wrote: > urndis_watchdog() calls urndis_ctrl_keepalive() which sends an RNDIS > keepalive msg and then waits for the reply with USBD_DEFAULT_TIMEOUT. > That means if the device stopped responding, the if_watchdog_thread > will be blocked for 5

Do not send SIGHUP to syslogd on wtmp rotation

2021-12-08 Thread Антон Касимов
Hi, I've noticed that newsyslog sends SIGHUP to syslogd on /var/log/wtmp rotation. But syslogd does not deal with the wtmp log file so there is no need for SIGHUP. I propose to make slightly changes to default newsyslog.conf file: --- /etc/newsyslog.conf Thu Oct 11 22:18:27 2018 +++ /tmp/newsyslo

Re: [patch] urndis: uncomment watchdog

2021-12-08 Thread Gerhard Roth
On 12/8/21 10:26, Mikhail wrote: On Tue, Nov 30, 2021 at 09:40:35PM +0300, Mikhail wrote: Currently watchdog functionality for urndis driver is disabled (commented), I've tested it and it works properly - reset messages are correctly sent and cmplt packets are received according to RNDIS spec (I

Re: [patch] urndis: uncomment watchdog

2021-12-08 Thread Mikhail
On Tue, Nov 30, 2021 at 09:40:35PM +0300, Mikhail wrote: > Currently watchdog functionality for urndis driver is disabled > (commented), I've tested it and it works properly - reset messages are > correctly sent and cmplt packets are received according to RNDIS spec (I > patched the driver to force