On 12/8/21 10:26, Mikhail wrote:
On Tue, Nov 30, 2021 at 09:40:35PM +0300, Mikhail wrote:Currently watchdog functionality for urndis driver is disabled (commented), I've tested it and it works properly - reset messages are correctly sent and cmplt packets are received according to RNDIS spec (I patched the driver to forcedly send reset message and act on it with device reset every 5 seconds). I suggest to uncomment it.The hardware is Megafon 4G МM200-1: urndis0 at uhub3 port 2 configuration 1 interface 0 "Qualcomm MM200-1" rev 2.00/3.18 addr 5 Tests, comments or objections?Ping. Commenting was introduced by mk@ in 61cec9357e4f with the following note:At some point we probably want to use the watchdog functionality but the current code is completely untested so disable it entirely rather than enabling it this close to release.I've tested it and it works, maybe there will be a committer who can enable the watchdog? - the functionality is widely used in other drivers and seem to be useful in general.
Hi, urndis_watchdog() calls urndis_ctrl_keepalive() which sends an RNDIS keepalive msg and then waits for the reply with USBD_DEFAULT_TIMEOUT. That means if the device stopped responding, the if_watchdog_thread will be blocked for 5 seconds. Not sure if that's a good idea. Gerhard
smime.p7s
Description: S/MIME cryptographic signature
