Re: enable resume from text console on X301 Was:Re: enable/fix vt switching on sandybridge machines

2012-03-08 Thread Owain Ainsworth
On Thu, Mar 08, 2012 at 10:45:11AM -0800, Dave Del Debbio wrote: On Sun, Mar 4 Mar 2012 12:27:56 -0800, Mike Larkin wrote: This really has nothing to do with ACPI. It could be due to missing a repost in resume, but ACPI is really not involved in that part of the sequence. There

Re: enable/fix vt switching on sandybridge machines

2012-03-05 Thread Owain Ainsworth
On Sun, Mar 04, 2012 at 10:21:55PM +0100, Mark Kettenis wrote: Date: Sun, 4 Mar 2012 12:27:56 -0800 From: Mike Larkin mlar...@azathoth.net Cc: joshua stein j...@openbsd.org, tech@openbsd.org Reply-To: mlar...@azathoth.net List-Owner: mailto:owner-t...@openbsd.org X-Loop:

Re: (mostly) fix rotation in the intel X driver.

2012-02-27 Thread Owain Ainsworth
On Wed, Dec 21, 2011 at 09:27:03PM +, Owain Ainsworth wrote: There seems to be a damage issue with roatated screens and at least rectangle composition still, but this makes rotation possible at all. (this is a bug only we have because we still have the UMS code). it's a git diff

(mostly) fix rotation in the intel X driver.

2011-12-21 Thread Owain Ainsworth
There seems to be a damage issue with roatated screens and at least rectangle composition still, but this makes rotation possible at all. (this is a bug only we have because we still have the UMS code). it's a git diff, but should apply clean from /usr/xenocara/driver/xf86-video-intel Cheers,

Re: libedit wchar allocation issue

2011-11-16 Thread Owain Ainsworth
On Tue, Nov 15, 2011 at 11:09:08PM +, Nicholas Marriott wrote: Hi libedit miscalculates the amount of space needed for constructing it's wchar_t version of argv, causing it to overrun the buffer. I don't see how the output of mbstowcs can be longer than (sum(strlen(argv)) * sizeof

Re: X Intel driver update. [TESTING NEEDED]

2011-09-12 Thread Owain Ainsworth
On Mon, Sep 12, 2011 at 05:08:46PM +0200, Mark Kettenis wrote: Date: Mon, 12 Sep 2011 17:51:14 +0300 From: Paul Irofti p...@irofti.net This breaks X on my sandybridge workstation. (This plus the kernel patch you sent before). I mailed you the dmesg in private, but I'll attach it here

Re: X Intel driver update. [TESTING NEEDED]

2011-09-12 Thread Owain Ainsworth
On Mon, Sep 12, 2011 at 12:31:46AM +0100, Owain Ainsworth wrote: I've been sitting on various stages of this update for far too long, about time i sent it out. This updates the rendering code in the in-tree intel driver to much more recent versions of the upstream intel driver, while

Sandybridge graphics support: part 1 basic kernel support.

2011-09-07 Thread Owain Ainsworth
A few months ago jcs@ got a sandybridge laptop, he did some work to get it almost working. I continued this a few months ago in edmonton at c2k11. Since then kettenis@ who has hardware has made yet more progress. Now the plan is to get this into the tree, but first some precursors. This kernel

Re: Sandybridge graphics support: part 1 basic kernel support.

2011-09-07 Thread Owain Ainsworth
On Thu, Sep 08, 2011 at 05:25:46AM +0100, Owain Ainsworth wrote: A few months ago jcs@ got a sandybridge laptop, he did some work to get it almost working. I continued this a few months ago in edmonton at c2k11. Since then kettenis@ who has hardware has made yet more progress. Now the plan

Re: Xorg vs. DRM AGP GART on IBM X40 laptop running 4.9 stable (workaround)

2011-08-19 Thread Owain Ainsworth
On Thu, Aug 18, 2011 at 02:58:31PM -0600, Richard Johnson wrote: [Posting for documentation of the workaround, and in case the details help find a bug beyond This ancient laptop's video card RAM is too small.] I resuscitated an IBM X40 laptop by putting in a HD with a clean install of

thou shalt not call hardclock() with biglock held.

2011-07-04 Thread Owain Ainsworth
i386 is a very naughty arch. While messing with this code make i386 and amd64 more identical. guenther@ tested this on an mp i386 for me yesterday, the machine seemed happy. Cheers, -0- diff --git a/arch/amd64/isa/clock.c b/arch/amd64/isa/clock.c index 23fc0f0..1b4ff7c 100644 ---

move uvm reserve enforcement to pmemrange

2011-07-03 Thread Owain Ainsworth
so all allocators obey it, not just uvm_pagealloc (which is increasingly rarely called). This actually makes it a lot harder to deadlock the machine under very heavy memory pressure (uvm_pglistalloc for 7 pages when you have 7 pages left, for example). I have been using variants of this diff on

Re: bus_dmamem_map fix (test+ok)

2011-06-23 Thread Owain Ainsworth
On Wed, Jun 22, 2011 at 09:32:06PM +0200, Ariane van der Steldt wrote: On Tue, Jun 21, 2011 at 09:00:49PM +0200, Ariane van der Steldt wrote: Bus_dmamem_map has a bug in its error path, where it frees the wrong memory in the wrong way. After some discussion on icb, the comments and the

Re: replaced handrolled version of uvmfault_unlockmaps with that function

2011-06-23 Thread Owain Ainsworth
How about this now? On Tue, May 31, 2011 at 12:06:15AM +0100, Owain Ainsworth wrote: ok? diff --git uvm/uvm_fault.c uvm/uvm_fault.c index 76f0708..76429dc 100644 --- uvm/uvm_fault.c +++ uvm/uvm_fault.c @@ -1936,11 +1936,7 @@ uvmfault_lookup(struct uvm_faultinfo *ufi, boolean_t

Re: Move uvm_pglist* to uvm_page.c

2011-06-23 Thread Owain Ainsworth
How about this now? On Tue, May 31, 2011 at 12:05:04AM +0100, Owain Ainsworth wrote: These functions used to be big and complicated, now they are glorified wrappers around pmemrange and don't really need their own file. Discussed with ariane@ a while ago. ok? diff --git conf/files

Re: Don't bother checking for an empty pageq before freeing the list

2011-06-23 Thread Owain Ainsworth
How about this now? On Tue, May 31, 2011 at 12:03:49AM +0100, Owain Ainsworth wrote: It will handle an empty list just fine (there is a potential small optimisation in there to avoid grabbing the fpageqlock if no pages need freeing but that is another diff) ok? diff --git uvm/uvm_km.c

Re: check for correct flag in uvm_page_unbusy

2011-06-23 Thread Owain Ainsworth
How about this now? I've got some more important uvm diffs on the way I but would like to get the small ones out of my tree. -0- On Tue, May 31, 2011 at 12:09:35AM +0100, Owain Ainsworth wrote: No functional change since aobjs should never hit this path. However, I introduced this diff when I

Re: Remove and clean up callers of pmap_clear_reference and pmap_page_protect

2011-06-23 Thread Owain Ainsworth
On Fri, Apr 15, 2011 at 05:15:02PM +0100, Owain Ainsworth wrote: audit callers of pmap_clear_reference() and pmap_page_protect(,,VM_PROT_NONE) just before uvm_pagedeactivate noting the fact that freshly deactivated pages have their reference cleared in uvm_pagedeactivate already. first off

Re: hibernate_machdep.c depends on acpi

2011-06-20 Thread Owain Ainsworth
On Mon, Jun 20, 2011 at 01:54:38PM +0200, Mark Kettenis wrote: Date: Mon, 20 Jun 2011 13:22:52 +0200 (CEST) From: Mark Kettenis mark.kette...@xs4all.nl Date: Mon, 20 Jun 2011 11:04:24 +0200 From: Mike Belopuhov m...@crypt.org.ru hi, the hibernate_machdep.c file depends

softraid crypto: preallocate crypops and dma buffers.

2011-06-17 Thread Owain Ainsworth
So here's the problem: ENOMEM on io in a hba driver is bad juju. In more detail: When preparing for each io softraid crypto does a sr_crypto_getcryptop(). This operation does a few things: - allocate a uio and iovec from a pool. - if this is a read then allocate a dma buffer with dma_alloc (up

Re: iwn(4) MSI

2011-06-16 Thread Owain Ainsworth
On Thu, Jun 02, 2011 at 11:55:54PM +0200, Mark Kettenis wrote: Date: Thu, 2 Jun 2011 22:49:43 +0100 From: Owain Ainsworth zer...@googlemail.com Been running with this for a couple of weeks, seems to work fine. ok? diff --git dev/pci/if_iwn.c dev/pci/if_iwn.c index 16765f4

Re: Fix page deactivation in uvm_vnode.c when clustering

2011-06-07 Thread Owain Ainsworth
On Tue, Jun 07, 2011 at 06:51:31PM +0200, Christian Ehrhardt wrote: Hi, while reading through uvm code I stubled accross a piece of code that appears to be buggy. Here's the proposed patch, rational follows: Index: uvm_vnode.c

iwn(4) MSI

2011-06-02 Thread Owain Ainsworth
Been running with this for a couple of weeks, seems to work fine. ok? diff --git dev/pci/if_iwn.c dev/pci/if_iwn.c index 16765f4..a54556b 100644 --- dev/pci/if_iwn.c +++ dev/pci/if_iwn.c @@ -338,7 +338,8 @@ iwn_attach(struct device *parent, struct device *self, void *aux) } /*

Re: cwm: utf-8 diff

2011-05-30 Thread Owain Ainsworth
On Fri, May 27, 2011 at 04:28:44PM +0400, Alexander Polakov wrote: This diff works for me with some fonts (fixed, snap, even verdana), but doesn't work with terminus (black squares instead of chars). I have been meaning to write this diff for years. I will try and get to it soon. Cheers, -0-

Don't bother checking for an empty pageq before freeing the

2011-05-30 Thread Owain Ainsworth
list Reply-To: It will handle an empty list just fine (there is a potential small optimisation in there to avoid grabbing the fpageqlock if no pages need freeing but that is another diff) ok? diff --git uvm/uvm_km.c uvm/uvm_km.c index 1990adf..818cb18 100644 --- uvm/uvm_km.c +++ uvm/uvm_km.c

replaced handrolled version of uvmfault_unlockmaps with that function

2011-05-30 Thread Owain Ainsworth
ok? diff --git uvm/uvm_fault.c uvm/uvm_fault.c index 76f0708..76429dc 100644 --- uvm/uvm_fault.c +++ uvm/uvm_fault.c @@ -1936,11 +1936,7 @@ uvmfault_lookup(struct uvm_faultinfo *ufi, boolean_t write_lock) */ if (UVM_ET_ISSUBMAP(ufi-entry)) {

Move uvm_pglist* to uvm_page.c

2011-05-30 Thread Owain Ainsworth
These functions used to be big and complicated, now they are glorified wrappers around pmemrange and don't really need their own file. Discussed with ariane@ a while ago. ok? diff --git conf/files conf/files index 02da860..017e5f9 100644 --- conf/files +++ conf/files @@ -1007,7 +1007,6 @@ file

check for correct flag in uvm_page_unbusy

2011-05-30 Thread Owain Ainsworth
No functional change since aobjs should never hit this path. However, I introduced this diff when I reworked the page releasing stuff for objects. ok? diff --git uvm/uvm_page.c uvm/uvm_page.c index 10ef7d1..27e970a 100644 --- uvm/uvm_page.c +++ uvm/uvm_page.c @@ -1099,7 +1099,7 @@

Re: AVL tree

2011-05-19 Thread Owain Ainsworth
On Thu, May 19, 2011 at 07:52:44PM +0300, Michael Pounov wrote: Add AVL tree implementation and merge few RB tree related macros. If you have comments or any claims, please send me feedback and I will fix them. First of all, before we get anto any technical discussion etc. please provide

Re: AVL tree

2011-05-19 Thread Owain Ainsworth
On Thu, May 19, 2011 at 08:16:22PM +0300, Michael Pounov wrote: Add AVL tree implementation and merge few RB tree related macros. If you have comments or any claims, please send me feedback and I will fix them. Include patch file -- M.Punov - AITNET -

Re: AVL tree

2011-05-19 Thread Owain Ainsworth
On Thu, May 19, 2011 at 05:27:01PM +, Thordur Bjornsson wrote: On Thu, May 19, 2011 at 07:21:21PM +0200, Mike Belopuhov wrote: On Thu, May 19, 2011 at 7:12 PM, Thordur Bjornsson t...@openbsd.org wrote: On Thu, May 19, 2011 at 07:52:44PM +0300, Michael Pounov wrote: Add AVL tree

Re: Fan mode management in acpithinkpad(4)

2011-05-13 Thread Owain Ainsworth
On Sat, May 14, 2011 at 01:37:51AM +0400, Vadim Zhukov wrote: On 14 May 2011 c. 01:09:03 Christopher Zimmermann wrote: On 05/13/11 20:56, Alexander Polakov wrote: * Marco Peereboomsl...@peereboom.us [110512 17:59]: On Thu, May 12, 2011 at 03:32:56PM +0200, Christopher Zimmermann wrote:

Re: Remove the freelist member from vm_physseg

2011-05-13 Thread Owain Ainsworth
On Mon, May 09, 2011 at 10:15:23PM +0100, Owain Ainsworth wrote: On Mon, May 09, 2011 at 07:22:01PM +0100, Owain Ainsworth wrote: The new world order of pmemrange makes this data completely redundant (being dealt with by the pmemrange constraints instead). Remove all code that messes

kill the unused vm_page_lookup_freelist()

2011-05-09 Thread Owain Ainsworth
ok? -0- diff --git uvm/uvm_page.c uvm/uvm_page.c index f1b5d04..10ef7d1 100644 --- uvm/uvm_page.c +++ uvm/uvm_page.c @@ -1477,23 +1477,6 @@ uvm_pagecopy(struct vm_page *src, struct vm_page *dst) } /* - * uvm_page_lookup_freelist: look up the free list for the specified page - */ -int

Remove the freelist member from vm_physseg

2011-05-09 Thread Owain Ainsworth
The new world order of pmemrange makes this data completely redundant (being dealt with by the pmemrange constraints instead). Remove all code that messes with the freelist. While touching every caller of uvm_page_physload() anyway, add the flags argument to all callers (all but one is 0 and that

Re: Remove the freelist member from vm_physseg

2011-05-09 Thread Owain Ainsworth
On Mon, May 09, 2011 at 07:22:01PM +0100, Owain Ainsworth wrote: The new world order of pmemrange makes this data completely redundant (being dealt with by the pmemrange constraints instead). Remove all code that messes with the freelist. While touching every caller of uvm_page_physload

Re: sudoers, add ENV to env_keep?

2011-05-06 Thread Owain Ainsworth
On Fri, May 06, 2011 at 12:46:40PM +0200, Claudio Jeker wrote: On Fri, May 06, 2011 at 11:37:53AM +0100, Stuart Henderson wrote: sudo doesn't preserve ENV by default, so any shell settings (e.g. set -o emacs) you might have in your ${ENV} file don't take effect. for people who like

Re: tunefs(8) don't need no stinkin' opendisk(3). And wants DUIDs!

2011-05-05 Thread Owain Ainsworth
On Wed, May 04, 2011 at 11:59:52PM -0400, Kenneth R Westerback wrote: And by using opendev(3) tunefs can accept disk UID's. Any actual tunefs(8) guru's out there who can explain what this might break? Inspired by oga@'s work on atactl. millert already provided a diff for that, the the

make atactl grok DUIDs.

2011-05-04 Thread Owain Ainsworth
millert@ wrote a diff earlier for scanffs, so that leaves atactl as the only opendisk() caller in the tree. With this diff, the following works: # atactl b9b455bd99e393cd Model: C300-CTFDDAC256MAG, Rev: 0001, Serial #: 1015C860 Device type: ATA, fixed Cylinders: 16383, heads: 16,

Re: Remove and clean up callers of pmap_clear_reference and pmap_page_protect

2011-05-04 Thread Owain Ainsworth
On Fri, Apr 15, 2011 at 05:15:02PM +0100, Owain Ainsworth wrote: audit callers of pmap_clear_reference() and pmap_page_protect(,,VM_PROT_NONE) just before uvm_pagedeactivate noting the fact that freshly deactivated pages have their reference cleared in uvm_pagedeactivate already. first off

save a little space in uvm aobjs

2011-05-04 Thread Owain Ainsworth
For storing swapslots aobj's select between a hashtable or an array (sizes vary between a page and the kernel address space), by definition we only need one of those, so make it a union and possibly shave some bytes. ok? been running with this for a while, I hit swap daily and my machine allocs

so long, uvm_pglist.h

2011-05-04 Thread Owain Ainsworth
uvm_pglist.h defines 3 things. two of whch are unused (ok, used in if0ed out code for page idle zeroing that needs completely rewriting because the code doesn't work like that anymore). The third thing is the defintion of struct pglist (a TAILQ_HEAD). Move that definiton to uvm_page.h with the

Re: Radeon HD3000

2011-05-02 Thread Owain Ainsworth
On Sun, Apr 03, 2011 at 10:47:15PM +0100, Pedro la Peu wrote: Indeed, thanks Brad. Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1592 diff -u -p -r1.1592 pcidevs ---

Support for OpenGL on r600/r700. Testing required.

2011-05-02 Thread Owain Ainsworth
The following diff provides the kernel support necessary for OpenGL to work on R600 and R700 radeon chipsets. One caveat: the drm doesn't have interrupt support yet (this involves another firmware (making 3 per chipset for r600+) and a rather funky ringbuffer for interrupt events (yes, this is

Re: du.c tree use

2011-05-01 Thread Owain Ainsworth
On Sun, May 01, 2011 at 04:21:27PM +0200, Ariane van der Steldt wrote: Hi, du.c doesn't define its tree prototypes. However, if I understand man tree, it should. The idea being that you're defining the rb functions without first prototyping them in this case RB_GENERATE_STATIC would

Re: Radeon HD5450

2011-04-24 Thread Owain Ainsworth
On Sat, Apr 23, 2011 at 11:07:16PM -0400, Mark Peoples wrote: On Sun, Apr 03, 2011 at 08:37:08AM -0400, Mark Peoples wrote: The following along with an update to xf86-video-ati-6.14.1 gets me some very sexy 1920x1080 on my Radeon HD5450 the xorg driver part getting updated probably isn't

Re: invalid ata_xfer state 06: Apr 23 snapshot amd64, Lenovo Thinkpad SL500

2011-04-24 Thread Owain Ainsworth
On Sun, Apr 24, 2011 at 06:23:13PM +0200, Peter N. M. Hansteen wrote: After upgrading my laptop to the latest snapshot earlier today, I noticed these messages in dmesg output: ahci0 at pci0 dev 31 function 2 Intel 82801I AHCI rev 0x03: apic 2 int 19, AHCI 1.2 ahci0: invalid ata_xfer state

Re: pmap hole handling

2011-04-24 Thread Owain Ainsworth
On Thu, Apr 21, 2011 at 01:38:35AM +0200, Ariane van der Steldt wrote: Hi, MMU address space holes are at a fixed position (ofcourse). This diff makes sure the FIXED position flag is specified when mapping them in and complains loudly otherwise. While there, check some other flag mistakes

Re: km_alloc for stack and exec

2011-04-19 Thread Owain Ainsworth
On Mon, Apr 18, 2011 at 03:47:27PM -0600, Artur Grabowski wrote: A repeat of an earlier diff. Change stack and exec arguments allocation from old allocators to km_alloc(9). //art Index: kern/kern_exec.c === RCS file:

Remove some dead struct members in uvm

2011-04-15 Thread Owain Ainsworth
When I swiched the uvm code over to using a per-object tree instead of the global hash I forgot to remove the declarations for these from struct uvm. Fix that. (pointed out by blambert) ok? -0- Index: uvm/uvm.h === RCS file:

use uvm_pageratop instead of handrolling our own

2011-04-15 Thread Owain Ainsworth
Rename uvm_pageratop() to uvm_atop and use it in uvm_km.c to replace the exact same code handrolled for a little bit of shrinkage. ok? -0- Index: uvm/uvm_glue.c === RCS file: /cvs/src/sys/uvm/uvm_glue.c,v retrieving revision 1.55

Remove a redundant pmap_page_protect

2011-04-15 Thread Owain Ainsworth
In uvm_pager_dropcluster in the PG_RELEASED case we specifically unbusy the page so that uvm_anfree will free it. in uvm_anfree, it will pmap_page_protect a page that it is going to free, so there is no need to do so beforehand ourselves. ok? -0- Index: uvm/uvm_pager.c

Remove redundant acpi event declarations

2011-04-15 Thread Owain Ainsworth
Remove the now superfluous acpi event flags. it uses the apm ones now and has for quite some time. ok? -0- Index: dev/acpi/acpivar.h === RCS file: /cvs/src/sys/dev/acpi/acpivar.h,v retrieving revision 1.69 diff -u -p -r1.69

A bit of paranoia for uvm objects

2011-04-15 Thread Owain Ainsworth
paranoia: check that uvm_pageinsert never inserts over an existing page. this is invalid (and means a memory leak). put in various places for debugging by at least myself and art more than once. (this was an #ifdef DEBUG || 1 in vfs_biomem.c using a more expensive checks until the hackathon, for

Remove and clean up callers of pmap_clear_reference and pmap_page_protect

2011-04-15 Thread Owain Ainsworth
audit callers of pmap_clear_reference() and pmap_page_protect(,,VM_PROT_NONE) just before uvm_pagedeactivate noting the fact that freshly deactivated pages have their reference cleared in uvm_pagedeactivate already. first off, clear_reference: uvm_anon.c - only called on swapoff. we don't really

Re: use uvm_pageratop instead of handrolling our own

2011-04-15 Thread Owain Ainsworth
On Fri, Apr 15, 2011 at 08:07:54PM +, Miod Vallat wrote: Rename uvm_pageratop() to uvm_atop and use it in uvm_km.c to replace the exact same code handrolled for a little bit of shrinkage. Bikeshedding, but an `atop' name implies it returns a pa. Use `atopg' to emphasis it returns a

Re: Defang buffer cache for bigmem.

2011-04-01 Thread Owain Ainsworth
On Fri, Apr 01, 2011 at 07:25:40AM -0600, Bob Beck wrote: This diff moves the buffer cache to only be allocated out of dma'able memory, along with a few pieces (flags) that I will need for the next step of allowing it to touch high memory. Appears to behave well for me under load and

Re: ls(1) displays future timestamps improperly

2011-03-21 Thread Owain Ainsworth
On Mon, Mar 21, 2011 at 12:04:33PM +0100, Benny Lofgren wrote: Realized I was sloppy with KNF. This diff is hopefully neater looking. Regards, /Benny 888888 (cut) Index: print.c

Re: small drm uvm diff

2010-12-15 Thread Owain Ainsworth
On Wed, Dec 15, 2010 at 12:05:31AM -0500, Ted Unangst wrote: there is no reason for drm_bufs to be poking inside the vmspace on its own, this is what the uvm_map_hint function is for. Yup, that's fine. This was in place in this initial import of this code, suprised i've not noticed and

Re: convert netisr to real softinterrupt

2010-11-25 Thread Owain Ainsworth
On Thu, Nov 25, 2010 at 11:50:06AM +0100, Claudio Jeker wrote: On Wed, Nov 24, 2010 at 05:42:59PM +0100, Mike Belopuhov wrote: On Wed, Nov 24, 2010 at 17:06 +0100, Claudio Jeker wrote: This diff was made by oga@ some time ago -- I just fixed a few conflicts and I would really like to see

Re: more assertwaitok() love

2010-10-07 Thread Owain Ainsworth
On Thu, Sep 30, 2010 at 12:29:54AM +, Thordur Bjornsson wrote: Hi. Try to catch more places where we sleep and are not allowed. One thing of note, msleep() is missing in this diff, but there it is needed to call to sleep_setup routines with the mutex held, and after we release it we

Re: Testers needed for strict locking diff; esp i386, amd64, softraid

2010-09-24 Thread Owain Ainsworth
On Thu, Sep 23, 2010 at 10:49:01PM -0700, Matthew Dempsky wrote: I'd like to commit this. I've received positive reports from a few amd64 users and an i386 and softraid user, and all of the locking bugs exposed so far have already been fixed. I plan to remove the #define panic() hacks and

Re: de-static uvm_swap

2010-09-24 Thread Owain Ainsworth
On Fri, Sep 24, 2010 at 10:33:28PM +, Thordur Bjornsson wrote: and I'd like to kill these to: Im fairly sure I did both of these diffs once (before c2k9), so sure. destatic away. OK. -0- Index: uvm_pdaemon.c === RCS file:

Re: Kill suser() call in tunopen()?

2010-09-22 Thread Owain Ainsworth
On Tue, Sep 21, 2010 at 06:32:50PM -0700, Matthew Dempsky wrote: /dev/tun* are already owned by root and mode 0600 by default, so it seems redundant to check suser() in tunopen(). Looks like vnd could have the same change for the same resons. If so i'll whip up the requisite two-liner. -0- --

Re: Kill suser() call in tunopen()?

2010-09-22 Thread Owain Ainsworth
On Wed, Sep 22, 2010 at 11:45:10AM +0100, Kevin Chadwick wrote: On Wed, 22 Sep 2010 11:25:02 +0100 Owain Ainsworth zer...@googlemail.com wrote: On Tue, Sep 21, 2010 at 06:32:50PM -0700, Matthew Dempsky wrote: /dev/tun* are already owned by root and mode 0600 by default, so it seems

Fix VOP_* callers WRT proc usage

2010-09-21 Thread Owain Ainsworth
The mail I wrote earlier seems to have vanished from my mail queue without trace, so here's a resend. Several of the vn_ and VOP functions take a struct proc as an argument, it doesn't actually ever make sense for this to be anything other than curproc (removing the argument is part of thib's

Re: Minor clarifications for bioctl.8 and softraid.4

2010-09-13 Thread Owain Ainsworth
On Sun, Sep 12, 2010 at 11:00:47PM -0700, Chris Palmer wrote: Jason McIntyre writes: ok, my diff below tries to collect the various bits of feedback. stuff i haven't taken: Thanks for doing this. - delete - detach, for reasons given by marco I'd still like to reconsider this.

Re: patch_bioctl_F.patch (inline)

2010-09-12 Thread Owain Ainsworth
On Sun, Sep 12, 2010 at 10:56:22PM +0200, Merlyn wrote: sending the patch fot bioctl I'm quite a newbie, so if you find some problem (and you certainly will), could you please explain it for me? there is a little change from the previous patch - parameter has been renamed to -t and expects

Re: add rc.firsttime to rc(8)

2010-09-09 Thread Owain Ainsworth
On Thu, Sep 09, 2010 at 10:30:38PM +0200, tst wrote: This makes rc(8) man page tell about /etc/rc.firsttime. tilo Index: rc.8 === RCS file: /zeug/OpenBSD/cvs/src/share/man/man8/rc.8,v retrieving revision 1.25 diff -u -p

Re: cut swap over to bufq

2010-09-05 Thread Owain Ainsworth
On Sun, Sep 05, 2010 at 04:39:33PM +0200, Mark Kettenis wrote: Date: Sun, 5 Sep 2010 14:07:03 + From: Thordur I Bjornsson bzt...@gmail.com On Fri, Sep 03, 2010 at 09:11:39AM +, Thordur I Bjornsson wrote: Hi gang, Gabriel Kihlman spotted a small problem, swd_active was

Re: cut swap over to bufq

2010-09-05 Thread Owain Ainsworth
On Sun, Sep 05, 2010 at 02:07:03PM +, Thordur I Bjornsson wrote: On Fri, Sep 03, 2010 at 09:11:39AM +, Thordur I Bjornsson wrote: Hi gang, Gabriel Kihlman spotted a small problem, swd_active was not being incremented. Here's an updated diff. Looks alright to me,

DVACT_QUIESCE for inteldrm -- TESTING NEEDED

2010-09-03 Thread Owain Ainsworth
Now that DVACT_QUIESCE is in the tree I can send this diff out. So, rev 1.67 of intagp (agp_i810.c) was added to deal with the problem where stuff was bound for a software fallback while we were vt switched, so we couldn't assume that the aperture was clear. Turns out that the 855 at least does

Re: Looking for testers for a simple X test

2010-08-31 Thread Owain Ainsworth
On Tue, Aug 31, 2010 at 02:54:44PM +0200, Alf Schlichting wrote: On Tue, Aug 31, 2010 at 10:58:08AM +0300, Oleksii Zhmyrov wrote: Hi, I use OpenBSD -current on my desktop with Xfce4. With Option UseSIGIO false xserver refuses to start at all. Same here, segmentation fault. I am on

Re: (another) Intel driver change needs testing.

2010-05-23 Thread Owain Ainsworth
On Sun, May 23, 2010 at 09:09:56AM -0600, Ted Roby wrote: On Tue, May 18, 2010 at 5:45 PM, Owain Ainsworth zer...@googlemail.comwrote: Can you please use cvs to bisect which commit caused the problem? (it is only three commits, will not take long). It may help me fix it to know what

Re: (another) Intel driver change needs testing.

2010-05-18 Thread Owain Ainsworth
On Tue, May 18, 2010 at 11:01:29AM -0600, Ted Roby wrote: On Tue, May 18, 2010 at 8:40 AM, J.C. Roberts list-...@designtools.orgwrote: On Mon, 17 May 2010 22:16:54 +0100 Owain Ainsworth zer...@googlemail.com wrote: For those of you new here, or termnally adsent minded, instructions

Re: (another) Intel driver change needs testing.

2010-05-18 Thread Owain Ainsworth
On Tue, May 18, 2010 at 07:40:23AM -0700, J.C. Roberts wrote: On Mon, 17 May 2010 22:16:54 +0100 Owain Ainsworth zer...@googlemail.com wrote: For those of you new here, or termnally adsent minded, instructions follow: You've got be careful with those termnally adsent folks. ;) Feh

Re: (another) Intel driver change needs testing.

2010-05-18 Thread Owain Ainsworth
On Tue, May 18, 2010 at 05:42:09PM -0600, Ted Roby wrote: On Tue, May 18, 2010 at 5:25 PM, Owain Ainsworth zer...@googlemail.comwrote: I was referring to which of the three drm commits on the 10th. Oh. They were all applied. Unfortunately, I built everything late that night and early

New intel X driver requires testing.

2010-04-11 Thread Owain Ainsworth
The tarball that may be found at http://xenocara.org/intel-current.tgz contains an update to the intel 2.9.1 driver (the last one that supported userland modesetting) with a load of backports for bugfixes and performance improvements from drivers up to 2.11. In order to test this, you will need

isa bus_dma madness

2010-03-23 Thread Owain Ainsworth
Hi, If you are testing pmemrange (you really should be), please also run with this diff. It fixes problems with isadma on i386. This is technically three diffs squashed together (bad oga! I know, but I need to do real work and this should fix pmemrange). 1) when you have a wrapper function in a

Re: mprotect(2) misbehaves when len == 0?

2010-02-12 Thread Owain Ainsworth
On Fri, Feb 12, 2010 at 03:21:33PM +, Jason McIntyre wrote: On Fri, Feb 12, 2010 at 02:01:26PM +, Owain Ainsworth wrote: saying that no action is taken does imply that it is not an error. -0- diff follows: Index: sys/mprotect.2

Re: cwm no blank labels

2010-02-09 Thread Owain Ainsworth
On Tue, Feb 02, 2010 at 09:10:56AM -0500, Okan Demirmen wrote: On Sun 2010.01.17 at 16:05 +0100, Thomas Pfaff wrote: This diff disallows setting blank labels and pressing Esc while editing the current one will leave it unchanged. I don't see the point in allowing empty labels as the windows

Re: uvm_pseg_get uvm_pseg_lck fix

2010-02-08 Thread Owain Ainsworth
On Mon, Feb 01, 2010 at 11:30:06PM -0500, Ted Unangst wrote: I think this fixes the problem with sleeping and holding pseg_lck. Index: uvm_extern.h === RCS file: /home/tedu/cvs/src/sys/uvm/uvm_extern.h,v retrieving revision

Re: UBC?

2010-02-03 Thread Owain Ainsworth
On Mon, Feb 01, 2010 at 03:59:24PM -0700, Bob Beck wrote: On 1 February 2010 10:41, Ted Unangst ted.unan...@gmail.com wrote: I think the pool allocator is doable. Will look at it when I get a spare hour or two (may be a while ;) Noo!!!

Re: uvm_pseg_get uvm_pseg_lck fix

2010-02-03 Thread Owain Ainsworth
On Wed, Feb 03, 2010 at 04:08:39PM +0100, Mark Kettenis wrote: Date: Wed, 3 Feb 2010 14:41:04 + From: Owain Ainsworth zer...@googlemail.com On Mon, Feb 01, 2010 at 11:30:06PM -0500, Ted Unangst wrote: I think this fixes the problem with sleeping and holding pseg_lck. Index

Re: UBC?

2010-02-01 Thread Owain Ainsworth
On Mon, Feb 01, 2010 at 10:08:08AM +0100, Artur Grabowski wrote: Ariane van der Steldt ari...@stack.nl writes: Why are the pventries allocated from the kmem_map anyway? I think they should be allocated using the uvm_km_getpage instead. Or even better, from a pvpool like amd64.

Re: uvm_pseg_get uvm_pseg_lck

2010-01-31 Thread Owain Ainsworth
On Sun, Jan 31, 2010 at 02:05:35PM +0100, Mark Kettenis wrote: Date: Thu, 28 Jan 2010 18:55:55 +0300 From: Mike Belopuhov m...@crypt.org.ru Hi all, could someone please enlighten me how this uvm_pseg_get is supposed to work? uvm_pseg_get mtx_enter(uvm_pseg_lck); `-

Re: [patch] patch:util.c does free memory after strdup(3)

2010-01-08 Thread Owain Ainsworth
On Fri, Jan 08, 2010 at 12:45:11AM +0300, Igor Zinovik wrote: Hello, t...@. tmpbuf is allocated via strdup(3) but it is leaved unfreed when we leave makedirs() function. I have commited a few of these (this one, the libc/hash one and the pwd_mkdb one). I shall look at the others shortly.

Re: SiS190 driver: How to do pci_get_device and pci_read_config_byte

2009-10-05 Thread Owain Ainsworth
On Mon, Oct 05, 2009 at 10:26:32AM +0200, Mark Kettenis wrote: Date: Mon, 5 Oct 2009 09:51:39 +0200 From: Christopher Zimmermann madro...@zakweb.de rc = sis190_get_mac_addr_from_eeprom(pdev, dev); /* This seems to fail */ if (rc 0) { u8 reg; pci_read_config_byte(pdev,

Re: OpenBSD 4.6 crashing on kernel boot due to ahci0 seemingly

2009-10-05 Thread Owain Ainsworth
On Mon, Oct 05, 2009 at 11:01:24PM +0900, Christophe Prevotaux wrote: Hi, My machine is Running OpenBSD/amd64 4.6 (snapshot 02 Oct 2009) The kernel crashed on AHCI detection. ahci0 at pci0 dev 18 function 0 ATI SB600 SATA rev 0x00: apic 2 int 22 (irq 11), AHCI 1.1 scsibus0 at

Re: cwm(1) change on 9/25

2009-10-05 Thread Owain Ainsworth
On Fri, Oct 02, 2009 at 12:32:42AM +0159, Simon Nicolussi wrote: Hello, as a consequence to the last change to cwm(1) no borders are being drawn for maximized windows. This is fine as long as there's no gap defined in the cwmrc(5), otherwise the borders between window and gaps are missing.

Re: cwm: hmaximize

2009-08-24 Thread Owain Ainsworth
On Thu, Aug 20, 2009 at 01:50:37PM +0200, Thomas Pfaff wrote: This diff adds a new command, hmaximize, that maximizes the current window horizontally. I find it useful when lines displayed by commands are longer than my xterm; this way I can quickly maximize horizontally and get the whole

Re: cwm: hmaximize

2009-08-24 Thread Owain Ainsworth
On Mon, Aug 24, 2009 at 05:17:08PM +0100, Owain Ainsworth wrote: On Thu, Aug 20, 2009 at 01:50:37PM +0200, Thomas Pfaff wrote: This diff adds a new command, hmaximize, that maximizes the current window horizontally. I find it useful when lines displayed by commands are longer than my xterm

Re: ACPI PDC/OSC Evaluation (Getting more EST states)

2009-06-10 Thread Owain Ainsworth
On Wed, Jun 10, 2009 at 06:26:46PM +0800, danielcavan...@aanet.com.au wrote: Please test this ecpecially if your system was one of those that had problems with this patch when it was in the tree before 4.5 release. i noticed that you've already checked in this diff but i thought i'd send