k
> for errors at all), POSIX at least doesn't forbid it, and most
> others seem to do it, too.
I agree. People assume that asprintf() will return -1 on malloc
failure. Doing anything else is going to create subtle bugs.
- todd
On Mon, 24 Jul 2017 13:02:12 +0200, Marc Espie wrote:
> Here's a proper error message:
OK millert@
- todd
I am not really sure if this is
interesting enough to warrant more work, but I figured there isn't any
harm in posting it up. So I'm not looking for okays, but figured it
might be interesting to some others on the list.
Todd
diff --git llvm/lib/Target/X86/CMakeLists.txt llvm/lib/Target
On Thu, 20 Jul 2017 17:26:59 +0200, Alexander Bluhm wrote:
> When login_skey is called for a user without skey it crashes with
> NULL pointer dereference. It tries to pass a file descriptor that
> does not exist. This has to be done conditionally.
OK millert@
- todd
On Wed, 19 Jul 2017 21:44:43 +0200, Anton Lindqvist wrote:
> Fairly straightforward, replace usage of strtol with strtonum.
> No intended functional change.
Looks good. OK millert@
- todd
n the exit status in the manpage.
OK millert@
- todd
, so this
change seems to be stable. I would interested to get feedback from
someone running arm64, since this change does touch some generic code
shared across architectures, but there shouldn't be any binary changes
outside X86.
Any other feedback / bikeshedding is welcome.
ok?
Todd
lling up which seems more
dangerous than just ignoring a bogus line.
- todd
On Fri, 14 Jul 2017 22:59:58 +0200, Jeremie Courreges-Anglas wrote:
> "Todd C. Miller" writes:
>
> > On Fri, 14 Jul 2017 22:15:49 +0200, Jeremie Courreges-Anglas wrote:
> >
> >> the proposal in
> >>
> >> https://marc.info/?l=openbs
nfig file, we only add an entry to the list once we
> know it is "good".
>
> I find this more readable. ok?
OK millert@
- todd
obvious offender.
Alternately, we could just initialize s to -42.
- todd
On Tue, 11 Jul 2017 19:47:41 +0200, Ingo Schwarze wrote:
> So here is a patch that makes putting UTF-8 characters into
> fortune/datfiles safe.
OK millert@
- todd
e liner for parsing
| > known_hosts files.
|
| YIKES, what a horrible idea.
|
| I think the support for complete_* arrays ought to be summarily
| deleted from emacs.c. It is excessive complexity and creeping
| featurism and has no place in a program as sensitve as the shell.
|
| Yours,
| Ingo
--
Todd T. Fries . http://todd.fries.net/pgp.txt . @unix2mars . github:toddfries
- }
| > - /* ignore badness */
| > - if (p - buf + 1 > sizeof(hostbuf))
| > - continue;
| > - (void)strlcpy(hostbuf, buf, p - buf + 1);
| > - menuq_add(&menuq, NULL, "%s", hostbuf);
| > - }
| > - free(lbuf);
| > - (void)fclose(fp);
| > -menu:
| > if ((mi = menu_filter(sc, &menuq, "ssh", NULL, (CWM_MENU_DUMMY),
| > search_match_text, search_print_text)) != NULL) {
| > if (mi->text[0] == '\0')
| >
--
Todd T. Fries . http://todd.fries.net/pgp.txt . @unix2mars . github:toddfries
On Sun, 09 Jul 2017 15:38:18 +0200, Marc Espie wrote:
> On Sun, Jul 09, 2017 at 07:30:30AM -0600, Todd C. Miller wrote:
> > On Sun, 09 Jul 2017 10:40:43 +0200, Marc Espie wrote:
> >
> > > After a full bulk, no parts of xenocara are affected and just five ports.
> >
On Sun, 09 Jul 2017 10:40:43 +0200, Marc Espie wrote:
> After a full bulk, no parts of xenocara are affected and just five ports.
Those are all ports that include bsd.*.mk in their Makefiles, right?
If so, it doesn't seem like a big deal.
-todd
I've just committed a fix for this.
- todd
On Thu, 06 Jul 2017 07:37:19 -0600, "Todd C. Miller" wrote:
> Sorry, HP-UX actually has the same behavior as us. Here's what I
> have so far:
>
> 4.4BSD strtol() behavior:
> HP-UX
> NetBSD
> OpenBSD
strtol(3) was added to BSD in 4.3-Reno a
Sorry, HP-UX actually has the same behavior as us. Here's what I
have so far:
4.4BSD strtol() behavior:
HP-UX
NetBSD
OpenBSD
glibc strtol() behavior:
AIX
FreeBSD
GNU/Linux
Solaris
macOS
- todd
Solaris, AIX, and HP-UX all have the same behavior as glibc.
We are the outlier.
Since the standard is clear that the 0x/0X prefix is optional I
believe our behavior is wrong.
- todd
C99 states that the 0x or 0X prefix is optional so we should only
consume the prefix if the following character is a valid hex char.
This is equivalent to the fix in FreeBSD but I used isxdigit(3).
- todd
Index: lib/libc/stdlib/strtoimax.c
On Wed, 05 Jul 2017 14:55:00 +0200, Marc Espie wrote:
> Sure thing. apart from that, okay ?
OK millert@
- todd
I wonder if it would be better to use lex.${.PREFIX}.c instead of
${.PREFIX}.lex.c. This would be more consistent with how lex's
-Pprefix flag behaves.
It's not a big deal either way as the file is strictly temporary.
- todd
On Wed, 28 Jun 2017 15:35:36 -0600, "Theo de Raadt" wrote:
> Nope. It requires a parameter. lukem messed this up two decades ago,
> he should have used _IO but used the wrong one.
Ah right, I missed that it is _IOW. OK millert@ as-is then.
- todd
ttycom.h.
I think you want:
.It Dv TIOCSTAT Fa void
which is how the other ioctls that do not require a parameter behave.
- todd
hing else in Makefile.bsd-wrapper1...
>
> I hope I haven't forgotten any small piece, but it seems okay to me.
Looks good to me and appears to work as expected.
- todd
On Mon, 26 Jun 2017 16:09:30 +0200, Martin Pieuchot wrote:
> This is similar to the socket & kqueue diff I just sent.
>
> Check for NOTE_SUBMIT hint in order to protect `so_state', `so_snd'
> and `so_rcv'.
OK millert@
- todd
in tcp_input().
One comment inline, otherwise OK.
- todd
> Index: kern/uipc_socket.c
> ===
> RCS file: /cvs/src/sys/kern/uipc_socket.c,v
> retrieving revision 1.189
> diff -u -p -r1.189 uipc_socket.c
> --- kern/uipc_
On Mon, 26 Jun 2017 08:50:30 -0600, "Todd C. Miller" wrote:
> On Sun, 25 Jun 2017 14:34:40 -0400, "Ted Unangst" wrote:
>
> > will this cause problems if a number repeats? we've seen problems with that
> > before, where you get a sequence like 4, 7, 4 an
ential
generator like we use for IP sequence numbers might work better.
- todd
through a kernel and base build on i386 without apparent
ill effect, and the amd64 parts are unchanged from the last diff.
Todd
Index: gas/config/tc-i386.c
===
RCS file: /cvs/src/gnu/usr.bin/binutils-2.17/gas/config/tc-i386.c,v
retrieving
hits NOP sleds > 8 bytes on i386. We could also hit
the NOP sleds between 3 and 7 bytes if there are no objections.
Comments and suggestions are welcome. Thanks to Theo for suggesting it
in the hallway track at BSDCan.
Todd
Index: gas/confi
could do this.
Either way OK millert@
- todd
Index: usr.bin/m4/Makefile
===
RCS file: /cvs/src/usr.bin/m4/Makefile,v
retrieving revision 1.13
diff -u -p -u -r1.13 Makefile
--- usr.bin/m4/Makefile 12 May 2014 19:11:19 - 1.
This looks useful to me. Do you plan to do anything with the fails
stats?
- todd
On Tue, 13 Jun 2017 17:05:56 -0400, Brian Callahan wrote:
> Whoops, that was unintentional. Fixed.
Looks good to me.
- todd
both will be added by vwarnx().
- todd
ivalent to also call check_fatal_warns().
- todd
Also use syslog's %m format instead of %s + strerror().
We can't use devname() because the database file may be
out of date and savecore runs early in the boot sequence.
- todd
Index: sbin/savecore/savecore.c
===
RCS
.
- todd
Index: sbin/badsect/badsect.c
===
RCS file: /cvs/src/sbin/badsect/badsect.c,v
retrieving revision 1.27
diff -u -p -u -r1.27 badsect.c
--- sbin/badsect/badsect.c 12 Nov 2015 22:33:07 - 1.27
+++ sbin/badsect/badsect.c
Fine with me. OK millert@
- todd
We neglected to add dprintf/vdprintf to RETURN VALUES when they
were added to the manual.
- todd
Index: lib/libc/stdio/printf.3
===
RCS file: /cvs/src/lib/libc/stdio/printf.3,v
retrieving revision 1.75
diff -u -p -u -r1.75 printf.3
Use openat() and unlinkat() instead of chdir(). The path in the
.recover file is absolute and not relative so the existing stat()
is fine.
Also, since our vi always uses flock(), not fcntl locking, we can
open recovery read-only.
- todd
Index: usr.bin/vi/common/recover.c
ersed
mode. There is not currently a flag to error out when patch would
otherwise prompt the user.
- todd
e qsort regress run
time is reduced slightly.
It also restores the performance lost for the particular workload
that went quadratic when we removed the optimization.
- todd
Index: lib/libc/stdlib/qsort.c
===
RCS file: /cvs/src/lib/libc
On Mon, 05 Jun 2017 09:18:31 -0600, "Todd C. Miller" wrote:
> If you assign 0x to a long on i386 the compiler should warn
> about it since it is too big to fit unless the value is unsigned.
> That is why ULONG_MAX is defined as defined as 0xUL on
> 32-bit pl
On Mon, 05 Jun 2017 16:32:01 +0200, Christian Weisgerber wrote:
> Todd C. Miller:
>
> > I think you want 0xU, not 0xL. Otherwise you will
> > have the same issue on i386.
>
> ???
>
> We need a constant that comes out as the "long" v
I think you want 0xU, not 0xL. Otherwise you will
have the same issue on i386.
- todd
ro). We have been using a MINIMUM
macro elsewhere so it wouldn't hurt to be consistent here.
- todd
On Fri, 26 May 2017 21:13:05 +0100, Stuart Henderson wrote:
> It's part of the on-disk format, so changing it to a 32-bit value
> breaks it for existing users. Following an idea from deraadt@:
OK millert@
- todd
ting directories.
Seems reasonable. It adds a bit of ugliness but is useful enough
that we can ignore that. OK millert@
- todd
houghts?
>
> I think this is a better fix. the user shouldn't worry about such things. at
> least until a better path forward is determined.
That does seem better. OK millert@
- todd
On Wed, 24 May 2017 18:00:22 +0200, Alexander Bluhm wrote:
> When using "tcpdump proto 128" the filter never matches. Protocols
> up to 127 work fine. It is a sign extension bug in bpf. m_data
> is signed.
OK millert@
- todd
On Sat, 20 May 2017 15:27:06 -0600, "Todd C. Miller" wrote:
> One optimization implemented in the sample code from "Engineering
> a Sort Function" that our qsort lacks is storing the partition value
> out of line when convenient. Currently, we swap the partition va
On Sat, 20 May 2017 15:27:06 -0600, "Todd C. Miller" wrote:
> One optimization implemented in the sample code from "Engineering
> a Sort Function" that our qsort lacks is storing the partition value
> out of line when convenient. Currently, we swap the partition va
put.
This diff requires my "support swapping int-sized elements" diff
be applied first.
- todd
Index: lib/libc/stdlib/qsort.c
===
--- lib/libc/stdlib/qsort.c Sat May 20 08:08:08 2017
+++ lib/libc/stdlib/qsort.c Sat May 2
it
is that this fixes a run-time regression compared to 32-bit systems.
We only need to set swaptype once since the element size never
changes and we always increment the array by the element size so
the array alignment is also consistent.
Basic idea from FreeBSD.
- todd
Index: lib/libc/stdlib
On Thu, 18 May 2017 09:58:14 -0600, "Todd C. Miller" wrote:
> I believe the best approach is to switch qsort.c to "introsort".
> The changes are minimal and the elimination of the O(n^2) worst
> case is compelling.
I've added input arrays to the qsort regress te
wapping. If this happens
(unlikely) we can just continue with quicksort. This will result
in maxdepth wrapping but that is defined behavior since it is
unsigned.
- todd
Index: lib/libc/stdlib/qsort.c
===
RCS file: /cvs/src/lib/libc
owever, it is only used when the system's
real time clock is not set to UTC. See options(4) for info.
It is also possible to set the real time clock's UTC offset via
settimeofday(2).
I'll admit that this is not documented very well.
- todd
Since netcat is generally used as a debugging tool I think this is
a reasonable addition.
OK millert@
- todd
On Wed, 03 May 2017 08:03:06 +0200, Anton Lindqvist wrote:
> On Mon, May 01, 2017 at 01:36:51PM +0100, Nicholas Marriott wrote:
> >
> > looks good, ok nicm
>
> Anyone willing to commit?
Committed.
- todd
On Tue, 02 May 2017 11:12:58 -0600, "Todd C. Miller" wrote:
> On Tue, 02 May 2017 18:59:44 +0200, Mike Belopuhov wrote:
>
> > After switching the ph_timestamp to int64_t, the implementation
> > can be re-adjusted to use int64_t timestamps throughout.
> >
fore getting this in.
Would it be worth converting codel_intervals from us to ns so you
don't need to multiply by 1000 in so many places?
- todd
On Fri, 28 Apr 2017 15:31:34 -0600, "Todd C. Miller" wrote:
> Here's a diff that hews a bit more closely to the example code in
> https://research.swtch.com/glob
Ignore that diff for now, it is not correct.
- todd
Here's a diff that hews a bit more closely to the example code in
https://research.swtch.com/glob
- todd
Index: lib/libc/gen/glob.c
===
RCS file: /cvs/src/lib/libc/gen/glob.c,v
retrieving revision 1.46
diff -u -p -u -r1.46 g
That patch seems to have gotten munged and there was a duplicate
return statement. This one works for me.
- todd
Index: lib/libc/gen/glob.c
===
RCS file: /cvs/src/lib/libc/gen/glob.c,v
retrieving revision 1.46
diff -u -p -u -r1.46
*dp++ = '@' + 0x80;
~ ^~
The .s file is unchanged with either gcc or clang.
- todd
Index: bin/ksh/eval.c
===
RCS file: /cvs/src/bin/ksh/eval.c,v
retrieving revision 1.50
diff -u -p -u -r
t; 530 Please login with USER and PASS.
> 500 'PORT 12567': command not understood.
>
> After:
>
> USER foo
> 331 Password required for foo.
> PORT 12567
> 530 Please login with USER and PASS.
>
> OK?
OK millert@
- todd
f !garrulous which
is different from the others. If you prefer to keep it as-is that
is OK.
- todd
reeBSD bungled the glbl.c change in their treee.
- todd
> Index: glbl.c
> ===
> RCS file: /cvs/src/bin/ed/glbl.c,v
> retrieving revision 1.18
> diff -u -p -r1.18 glbl.c
> --- glbl.c22 Mar 2016 17:58:28 -
Thanks, fixed.
- todd
I don't have any objection to this but if it is committed a
similar change should be made to check_login_epsvall.
- todd
In general, if -fdo-something is supported I think it should also
accept -fno-do-something. Since this was seen in the wild, patching
llvm makes the most sense. Bonus points if you can get it upstreamed.
- todd
On Mon, 17 Apr 2017 17:12:13 +0200, Mark Kettenis wrote:
> > From: "Todd C. Miller"
> > Date: Mon, 17 Apr 2017 08:49:26 -0600
> >
> > Maybe use UINT_MAX since st_size gets cast to u_int below?
> > Either way OK millert@
>
> Already committed. But
Maybe use UINT_MAX since st_size gets cast to u_int below?
Either way OK millert@
- todd
first byte of growth?
lex doesn't zero its buffers at all right now. I don't see the
point in doing this in just one of many allocations.
- todd
On Wed, 12 Apr 2017 09:07:57 -0600, "Todd C. Miller" wrote:
> I found this diff rotting in my tree. It doesn't look like yy_buf_size
> gets updated when we realloc. Am I missing something?
We also need to account for the two end of buffer chars somehow.
I've opened a
I found this diff rotting in my tree. It doesn't look like yy_buf_size
gets updated when we realloc. Am I missing something?
- todd
Index: usr.bin/lex/flex.skl
===
RCS file: /cvs/src/usr.bin/lex/flex.skl,v
retrieving rev
isblank() is part of C99, no reason not to use it.
- todd
Index: usr.bin/lex/parse.y
===
RCS file: /cvs/src/usr.bin/lex/parse.y,v
retrieving revision 1.9
diff -u -p -u -r1.9 parse.y
--- usr.bin/lex/parse.y 19 Nov 2015 19:43:40
before performing the subtraction.
- todd
Index: sbin/fsck_ffs//pass1.c
===
RCS file: /cvs/src/sbin/fsck_ffs/pass1.c,v
retrieving revision 1.44
diff -u -p -u -r1.44 pass1.c
--- sbin/fsck_ffs//pass1.c 10 Apr 2017 08:19:12 -00
keep the TCP connections open
if they are still present in the config file after SIGHUP. That's
a more invasive change though.
- todd
This was fixed after 6.0 came out. I believe it was:
CVSROOT:/cvs
Module name:src
Changes by: mill...@cvs.openbsd.org 2016/08/17 06:02:38
Modified files:
usr.bin/compress: gzopen.c
Log message:
When returning the file size info, only use z_total_in/z_total_out
for the re
riable Startup is not used anymore and can be deleted. The
> functionality has moved into log_setdebug().
Sure, OK millert@
- todd
error string. Log the message where the error happens and make
> the function void.
OK millert@
- todd
On Wed, 05 Apr 2017 22:36:36 +0200, Alexander Bluhm wrote:
> On Wed, Apr 05, 2017 at 02:29:46PM -0600, Todd C. Miller wrote:
> > On Wed, 05 Apr 2017 22:23:58 +0200, Alexander Bluhm wrote:
> >
> > > The function logmsg() was used to generate local messages and to
> >
dn't vlogmsg() be renamed to vlogline() too?
- todd
> The manual pages will never list all restrictions.
In this case I think it makes sense to document it.
- todd
Index: /usr/src/lib/libc/sys/mmap.2
===
RCS file: /cvs/src/lib/libc/sys/mmap.2,v
retrieving revision 1.54
diff -u -p
Not all devices support mmap. Only those that define a d_mmap entry
in cdevsw[] will work (see conf.c and conf.h in the kernel).
On OpenBSD, disks can not be mmaped.
- todd
On Wed, 05 Apr 2017 18:17:38 +0200, Alexander Bluhm wrote:
> Replace logerror() functions with generic log_warn() from log.c.
> Make messages a bit more consistent. Note that the new function
> supports format strings. Replace some log_debug() with log_warn().
OK millert@
- todd
On Wed, 05 Apr 2017 16:51:13 +0200, Alexander Bluhm wrote:
> Syslogd's fatal() calls die() internally, so there is no change in
> behavior. The idea is that you may call fatal() anywhere and die()
> will do cleanup if necessary.
Ah, right, I missed that.
- todd
o all err(3) after log_init() are replaced.
This is before we start accepting log messages so no need to call die().
OK millert@
- todd
On Wed, 05 Apr 2017 02:10:44 +0200, Alexander Bluhm wrote:
> Updated diff after unlock, ok?
Looks correct. OK millert@
- todd
OK millert@
We should probably consider pruning out all the gcc < 3.x bits
from sys/cdefs.h.
- todd
d
to NULL and avoid those else clauses.
Either way OK millert@
- todd
ositives from humans as
well.
- todd
On Tue, 28 Mar 2017 09:33:53 -0600, "Todd C. Miller" wrote:
> It seems to me that in -C mode it should really process all the
> checksums that match the specified file(s), but the documentation
> does not actually specify what the behavior is in this case.
Here's a dif
really process all the
checksums that match the specified file(s), but the documentation
does not actually specify what the behavior is in this case.
- todd
I think that is a reasonable trade off.
- todd
>From FreeBSD, POSIX has identical wording.
Alternately, we could add an extra EACCESS entry similar to what
exists in open(2). I'm happy with either approach.
- todd
Index: lib/libc/sys/mkdir.2
===
RCS file: /cvs/src/
On Mon, 20 Mar 2017 21:06:23 +0100, Theo Buehler wrote:
> libskey reads directly from /var/db/host.random and falls back to the
> ctime of /dev/mem or / for generating the fake prompt for the user.
You should also remove SKEY_RAND_FILE_PATH from skey.h.
OK millert@ with that removed.
- todd
901 - 1000 of 1653 matches
Mail list logo
