On Thu, Sep 16, 2010 at 03:44:02PM -0400, Loganaden Velvindron wrote:
Greetings,
From brad, remove superfluous braces.
The direction of this diff is OK. The mclgeti() usage seems OK.
What made my alarmbells go off was the removal of xl_rx_resync(). Now that
function in itself is dumb but it
Works for me on
xl0 at pci0 dev 13 function 0 3Com 3c905C 100Base-TX rev 0x78: apic 2
int 16 (irq 10), address 00:04:75:b1:00:7d
xl1 at pci0 dev 17 function 0 3Com 3c905B 100Base-TX rev 0x24: apic 2
int 17 (irq 5), address 00:c0:4f:79:4d:d8
Greetings,
I've cleaned the diff a bit based on feedback from sthen@ b...@.
Here it is:
? xl.diff
Index: xl.c
===
RCS file: /cvs/src/sys/dev/ic/xl.c,v
retrieving revision 1.96
diff -u -p -r1.96 xl.c
--- xl.c7 Sep 2010
This is nice, there are some minor issues with the diff.
* The xl_fill_rx_ring function body uses spaces instead of tabs.
* Around -1125,11 +1138,11, you insert a few tabs unnecessarily.
* ..and around -1195,12 +1182,14, within the while loop, spaces.
* For the header patch, more spaces.
I am
Greetings,
Thanks bryan for testing it !
I've applied the necessary changes.
Here it is:
Index: src/sys/dev/ic/xl.c
===
RCS file: /cvs/src/sys/dev/ic/xl.c,v
retrieving revision 1.96
diff -u -p -r1.96 xl.c
--- src/sys/dev/ic/xl.c 7
Greetings,
From bryan, fix tabs around while loop.
Index: src/sys/dev/ic/xl.c
===
RCS file: /cvs/src/sys/dev/ic/xl.c,v
retrieving revision 1.96
diff -u -p -r1.96 xl.c
--- src/sys/dev/ic/xl.c 7 Sep 2010 16:21:43 - 1.96
+++
Greetings,
From brad, remove superfluous braces.
Index: src/sys/dev/ic/xl.c
===
RCS file: /cvs/src/sys/dev/ic/xl.c,v
retrieving revision 1.96
diff -u -p -r1.96 xl.c
--- src/sys/dev/ic/xl.c 7 Sep 2010 16:21:43 - 1.96
+++
Greetings,
With help from dlg@, claudio@, oga@, miod@ @weerd, I've been trying to
write
to get mclgeti support for xl(4).
It's been working fine on -current for quite some time.
I've tried flooding it with tcpbench, ping -f, and siege.
I'm looking for feedback on how I can improve
On 2010/09/15 00:31, Loganaden Velvindron wrote:
Here's the diff:
Diff doesn't apply; both due to whitespace issues (xclip might
help with this) and if you're using thunderbird to send then
please disable format=flowed.
