Re: PCI_PWR_D[0-3] vs. PCI_PMCSR_STATE_D[0-3]

2012-02-25 Thread Jonathan Gray
My impression on going over the netbsd commits where this came from is that this was intended to be used with pci_set_powerstate and friends. So I think the definitions should go, the bge changes go in, but the ifdef'd out chunks with cardbus_setpowerstate should be deleted entirely rather than

Re: PCI_PWR_D[0-3] vs. PCI_PMCSR_STATE_D[0-3]

2012-02-22 Thread Alexey Suslikov
Hello. Any feedback on this one? On Sat, Feb 4, 2012 at 02:02, Alexey Suslikov alexey.susli...@gmail.com wrote: hello tech@ aren't these PCI_PWR_D[0-3] defines just duplicates of PCI_PMCSR_STATE_D[0-3] from pcireg.h? --- /usr/src/sys/dev/pci/pcivar.h.orig Sat Feb 4 01:28:05 2012 +++

PCI_PWR_D[0-3] vs. PCI_PMCSR_STATE_D[0-3]

2012-02-03 Thread Alexey Suslikov
hello tech@ aren't these PCI_PWR_D[0-3] defines just duplicates of PCI_PMCSR_STATE_D[0-3] from pcireg.h? --- /usr/src/sys/dev/pci/pcivar.h.orig Sat Feb 4 01:28:05 2012 +++ /usr/src/sys/dev/pci/pcivar.h Sat Feb 4 01:28:41 2012 @@ -53,14 +53,6 @@ */ typedef u_int32_t pcireg_t;