Re: dhclient support for /32 assignments

2013-12-09 Thread Matthew Dempsky
On Tue, Dec 3, 2013 at 4:15 PM, Matthew Dempsky wrote: > The patch below extends dhclient to mimic this logic from ISC DHCP's > linux script: > > if [ "x$new_subnet_mask" = "x255.255.255.255" ] ; then > route add -host $router dev $interface > fi > route add defau

Re: dhclient support for /32 assignments

2013-12-05 Thread Kenneth R Westerback
On Wed, Dec 04, 2013 at 12:47:19PM -0800, Matthew Dempsky wrote: > On Wed, Dec 04, 2013 at 02:10:21PM -0500, Kenneth R Westerback wrote: > > No, that was my point. i.e. don't avoid adding the route when given > > a /32 address just because class static routes are also present. > > I think there mi

Re: dhclient support for /32 assignments

2013-12-04 Thread Matthew Dempsky
On Wed, Dec 04, 2013 at 02:10:21PM -0500, Kenneth R Westerback wrote: > No, that was my point. i.e. don't avoid adding the route when given > a /32 address just because class static routes are also present. I think there might be a misunderstanding, so let me back up and try to clarify. :) Comput

Re: dhclient support for /32 assignments

2013-12-04 Thread Chris Cappuccio
Chris Cappuccio [ch...@nmedia.net] wrote: > Matthew Dempsky [matt...@dempsky.org] wrote: > > > > void > > -add_static_routes(int rdomain, struct option_data *static_routes) > > +add_static_routes(int rdomain, struct in_addr addr, struct in_addr > > addrmask, > > +struct option_data *static_

Re: dhclient support for /32 assignments

2013-12-04 Thread Chris Cappuccio
Matthew Dempsky [matt...@dempsky.org] wrote: > > void > -add_static_routes(int rdomain, struct option_data *static_routes) > +add_static_routes(int rdomain, struct in_addr addr, struct in_addr addrmask, > +struct option_data *static_routes) > { > struct in_addr dest, netmask

Re: dhclient support for /32 assignments

2013-12-04 Thread Kenneth R Westerback
On Wed, Dec 04, 2013 at 10:57:41AM -0800, Matthew Dempsky wrote: > On Tue, Dec 03, 2013 at 11:48:05PM -0500, Kenneth Westerback wrote: > > Rfc 3442 is what I referred to. > > I don't think RFC 3442 discusses what to do with /32 IP address > assignments though? No, that was my point. i.e. don't av

Re: dhclient support for /32 assignments

2013-12-04 Thread Matthew Dempsky
On Tue, Dec 03, 2013 at 11:48:05PM -0500, Kenneth Westerback wrote: > Rfc 3442 is what I referred to. I don't think RFC 3442 discusses what to do with /32 IP address assignments though? Anyway, below is a revised diff that does the same direct-route magic for all gateway IPs, not just the default

Re: dhclient support for /32 assignments

2013-12-03 Thread Kenneth Westerback
Rfc 3442 is what I referred to. Ken On 3 Dec 2013 22:54, "Matthew Dempsky" wrote: > On Tue, Dec 3, 2013 at 5:55 PM, Kenneth R Westerback > wrote: > > Located here, the addition of the 255.255.255.255 route is not done in > the > > presence of DHO_CLASSLESS_STATIC_ROUTES. As I recall only D

Re: dhclient support for /32 assignments

2013-12-03 Thread Matthew Dempsky
On Tue, Dec 3, 2013 at 5:55 PM, Kenneth R Westerback wrote: > Located here, the addition of the 255.255.255.255 route is not done in the > presence of DHO_CLASSLESS_STATIC_ROUTES. As I recall only DHO_ROUTERS and > DHO_STATIC_ROUTES are incompatible with DHO_CLASSLESS_STATIC_ROUTES. So > we may wa

Re: dhclient support for /32 assignments

2013-12-03 Thread Kenneth R Westerback
On Tue, Dec 03, 2013 at 04:15:10PM -0800, Matthew Dempsky wrote: > The patch below extends dhclient to mimic this logic from ISC DHCP's > linux script: > > if [ "x$new_subnet_mask" = "x255.255.255.255" ] ; then > route add -host $router dev $interface > fi > route

dhclient support for /32 assignments

2013-12-03 Thread Matthew Dempsky
The patch below extends dhclient to mimic this logic from ISC DHCP's linux script: if [ "x$new_subnet_mask" = "x255.255.255.255" ] ; then route add -host $router dev $interface fi route add default gw $router $metric_arg dev $interface With this change, dhclient