Re: fix kernel crash in pf_ioctl with WITH_PF_LOCK and NET_TASKQ > 1

2019-11-26 Thread Klemens Nanni
On Tue, Nov 26, 2019 at 10:42:42AM +0100, Joerg Goltermann wrote: > I think I found the problem inside pf_ioctl.c, it looks like > the problem was introduced with a "mechanical" patch which > replaced all "breaks;" with "PF_UNLOCK(); break;" This seems > to be wrong in this particular case: I agree

Re: fix kernel crash in pf_ioctl with WITH_PF_LOCK and NET_TASKQ > 1

2019-11-26 Thread Alexandr Nedvedicky
Hello Joerg, your patch looks OK. thank you for testing & fixing. thanks and regard sashan On Tue, Nov 26, 2019 at 10:42:42AM +0100, Joerg Goltermann wrote: > Hello, > > I tested a kernel with WITH_PF_LOCK and NET_TASKQ > 1 and got a > kernel panic during switching between the pf statics inside

fix kernel crash in pf_ioctl with WITH_PF_LOCK and NET_TASKQ > 1

2019-11-26 Thread Joerg Goltermann
Hello, I tested a kernel with WITH_PF_LOCK and NET_TASKQ > 1 and got a kernel panic during switching between the pf statics inside systat. I think I found the problem inside pf_ioctl.c, it looks like the problem was introduced with a "mechanical" patch which replaced all "breaks;" with "PF_UNLO