Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Stefan Sperling
On Sat, Apr 09, 2022 at 05:46:29PM +0200, Sven Wolf wrote: > Hi Stefan, > > thanks for your effort. > I've successfully tested your latest patch. > I also got the sw_hw_rev: > > sc_hw_rev=354 Thank you! Now everything makes sense :)

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Sven Wolf
Hi Stefan, thanks for your effort. I've successfully tested your latest patch. I also got the sw_hw_rev: sc_hw_rev=354 Thanks, Sven On 4/9/22 17:11, Stefan Sperling wrote: On Sat, Apr 09, 2022 at 04:53:50PM +0200, Stefan Sperling wrote: On Sat, Apr 09, 2022 at 04:52:12PM +0200, Stefan

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Stefan Sperling
On Sat, Apr 09, 2022 at 04:53:50PM +0200, Stefan Sperling wrote: > On Sat, Apr 09, 2022 at 04:52:12PM +0200, Stefan Sperling wrote: > > On Sat, Apr 09, 2022 at 04:29:42PM +0200, Stefan Sperling wrote: > > > As sthen points out, please show sc_hw_rev without any of its bits > > > masked out, with a

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Stefan Sperling
On Sat, Apr 09, 2022 at 04:52:12PM +0200, Stefan Sperling wrote: > On Sat, Apr 09, 2022 at 04:29:42PM +0200, Stefan Sperling wrote: > > As sthen points out, please show sc_hw_rev without any of its bits > > masked out, with a patch like this: > > Nevermind, I found a bug in my patch which most

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Stefan Sperling
On Sat, Apr 09, 2022 at 04:29:42PM +0200, Stefan Sperling wrote: > As sthen points out, please show sc_hw_rev without any of its bits > masked out, with a patch like this: Nevermind, I found a bug in my patch which most certainly breaks your device. Please try this on top of the patch I sent

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Stefan Sperling
On Sat, Apr 09, 2022 at 03:28:14PM +0200, Stefan Sperling wrote: > On Sat, Apr 09, 2022 at 12:47:56PM +0200, Sven Wolf wrote: > > Hi Stefan, > > > > sorry, I'm not sure how I can get the sc_hw_rev value. > > Hopefully this is the requested value: > > > > iwx0: hw rev 0x350, fw ver 67.8f59b80b.0

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Sven Wolf
On 4/9/22 15:28, Stefan Sperling wrote: On Sat, Apr 09, 2022 at 12:47:56PM +0200, Sven Wolf wrote: Hi Stefan, sorry, I'm not sure how I can get the sc_hw_rev value. Hopefully this is the requested value: iwx0: hw rev 0x350, fw ver 67.8f59b80b.0 This is not the "QuZ" (0x354) hardware

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Stefan Sperling
On Sat, Apr 09, 2022 at 12:47:56PM +0200, Sven Wolf wrote: > Hi Stefan, > > sorry, I'm not sure how I can get the sc_hw_rev value. > Hopefully this is the requested value: > > iwx0: hw rev 0x350, fw ver 67.8f59b80b.0 This is not the "QuZ" (0x354) hardware revision. However, Linux obviously

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Stuart Henderson
On 2022/04/09 12:47, Sven Wolf wrote: > Hi Stefan, > > sorry, I'm not sure how I can get the sc_hw_rev value. > Hopefully this is the requested value: > > iwx0: hw rev 0x350, fw ver 67.8f59b80b.0 hw rev in this line is masked (sc->sc_hw_rev & IWX_CSR_HW_REV_TYPE_MSK which is 0x000FFF0), the

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Sven Wolf
Hi Stefan, sorry, I'm not sure how I can get the sc_hw_rev value. Hopefully this is the requested value: iwx0: hw rev 0x350, fw ver 67.8f59b80b.0 Best regards, Sven On 4/9/22 11:35, Stefan Sperling wrote: On Sat, Apr 09, 2022 at 12:31:09AM +0200, Sven Wolf wrote: Hi Stefan, on my device

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-09 Thread Stefan Sperling
On Sat, Apr 09, 2022 at 12:31:09AM +0200, Sven Wolf wrote: > Hi Stefan, > > on my device WL_22500_8 0x4df0 this patch doesn't work directly. > I get the error message: > iwx0: could not load firmware, 35 > iwx0: failed to load init firmware > > Under Linux the firmware

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-08 Thread Sven Wolf
Hi Stefan, on my device WL_22500_8 0x4df0 this patch doesn't work directly. I get the error message: iwx0: could not load firmware, 35 iwx0: failed to load init firmware Under Linux the firmware iwlwifi-QuZ-a0-hr-b0-67.ucode is loaded for this device. Also my old patch

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-04-08 Thread Stefan Sperling
On Tue, Jan 11, 2022 at 10:33:39PM +, Iraklis Karagkiozoglou wrote: > Hello Stefan, > > I tried to port the firmware detection and config values > from iwlwifi. > > On iwx_cfg_trans_params and iwx_cfg structs I ported only > the fields iwx_attach was setting based on the iwx_device. > >

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-01-11 Thread Iraklis Karagkiozoglou
Hello Stefan, I tried to port the firmware detection and config values from iwlwifi. On iwx_cfg_trans_params and iwx_cfg structs I ported only the fields iwx_attach was setting based on the iwx_device. With best regards, Iraklis Karagkiozoglou diff --git sys/dev/pci/if_iwx.c

Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-01-09 Thread Stefan Sperling
On Sun, Jan 09, 2022 at 05:32:21PM +, Iraklis Karagkiozoglou wrote: > Hi, > > I've added support for AX201 with subsystem id 0x0030 in if_iwx. > > I am only loading a different firmware for the specific subsystem id to > avoid introducing any regressions or bugs. We are receiving more and

patch: if_iwx.c add support for ax201 with subsystem id 0x0030

2022-01-09 Thread Iraklis Karagkiozoglou
Hi, I've added support for AX201 with subsystem id 0x0030 in if_iwx. I am only loading a different firmware for the specific subsystem id to avoid introducing any regressions or bugs. -- Iraklis Karagkiozoglou diff --git sys/dev/pci/if_iwx.c sys/dev/pci/if_iwx.c index 4c85ad108a8..78b73303f42