Re: preparing pfi_kif to MP world

2015-10-29 Thread Martin Pieuchot
On 29/10/15(Thu) 13:32, Mike Belopuhov wrote: > On Thu, Oct 29, 2015 at 11:58 +0100, Martin Pieuchot wrote: > > On 29/10/15(Thu) 02:49, Mike Belopuhov wrote: > > > On 28 October 2015 at 18:41, Alexandr Nedvedicky > > > wrote: > > > > Hello Mike, > > > > > > > >

Re: preparing pfi_kif to MP world

2015-10-29 Thread Mike Belopuhov
On Thu, Oct 29, 2015 at 11:58 +0100, Martin Pieuchot wrote: > On 29/10/15(Thu) 02:49, Mike Belopuhov wrote: > > On 28 October 2015 at 18:41, Alexandr Nedvedicky > > wrote: > > > Hello Mike, > > > > > > just a quick question: > > > > > > are you going to

Re: preparing pfi_kif to MP world

2015-10-29 Thread Alexandr Nedvedicky
Hello, On Fri, Oct 16, 2015 at 01:51:31PM +0200, Alexandr Nedvedicky wrote: > On Fri, Oct 16, 2015 at 01:41:50PM +0200, Mike Belopuhov wrote: > > On 16 October 2015 at 13:28, Alexandr Nedvedicky > > wrote: > > > > > > may be it's kind of bike shading... > > > How

Re: preparing pfi_kif to MP world

2015-10-29 Thread Alexandr Nedvedicky
On Thu, Oct 29, 2015 at 02:49:40AM +0100, Mike Belopuhov wrote: > On 28 October 2015 at 18:41, Alexandr Nedvedicky > wrote: > > Hello Mike, > > > > just a quick question: > > > > are you going to commit your pfi_kif_find() et. al.? > > or more work

Re: preparing pfi_kif to MP world

2015-10-29 Thread Martin Pieuchot
On 29/10/15(Thu) 02:49, Mike Belopuhov wrote: > On 28 October 2015 at 18:41, Alexandr Nedvedicky > wrote: > > Hello Mike, > > > > just a quick question: > > > > are you going to commit your pfi_kif_find() et. al.? > > or more work is needed there? >

Re: preparing pfi_kif to MP world

2015-10-28 Thread Alexandr Nedvedicky
Hello Mike, just a quick question: are you going to commit your pfi_kif_find() et. al.? or more work is needed there? thanks a lot regards sasha > > Turns out this is a rather simple issue that got slightly > complicated by the code diverging quite a bit since the > inception.

Re: preparing pfi_kif to MP world

2015-10-28 Thread Mike Belopuhov
On 28 October 2015 at 18:41, Alexandr Nedvedicky wrote: > Hello Mike, > > just a quick question: > > are you going to commit your pfi_kif_find() et. al.? > or more work is needed there? > I need OKs > thanks a lot > regards > sasha > >> >> Turns

Re: preparing pfi_kif to MP world

2015-10-16 Thread Mike Belopuhov
On 16 October 2015 at 13:28, Alexandr Nedvedicky wrote: > > may be it's kind of bike shading... > How about make kifs to stick to convention we see for other objects > such as rulesets/anchors: > > pfi_kif_find() > pfi_kif_find_or_create() >

Re: preparing pfi_kif to MP world

2015-10-16 Thread Alexandr Nedvedicky
On Fri, Oct 16, 2015 at 01:41:50PM +0200, Mike Belopuhov wrote: > On 16 October 2015 at 13:28, Alexandr Nedvedicky > wrote: > > > > may be it's kind of bike shading... > > How about make kifs to stick to convention we see for other objects > > such as

Re: preparing pfi_kif to MP world

2015-10-16 Thread Alexandr Nedvedicky
> > Turns out this is a rather simple issue that got slightly > complicated by the code diverging quite a bit since the > inception. Essentially the clr->ifname comes from the > interface specification in the "pfctl -i foo0 -Fs" for > if-bound states (floating states use fake interface "any"). >

Re: preparing pfi_kif to MP world

2015-10-13 Thread David Gwynne
> On 12 Oct 2015, at 12:00 AM, Alexandr Nedvedicky > wrote: > > Hello, > > patch below introduces struct refcnt to pfi_kif structure. Patch also changes > pfi_kif_get() function to always return a reference to pfi_kif instance. > > Furthermore existing

Re: preparing pfi_kif to MP world

2015-10-13 Thread Mike Belopuhov
On Tue, Oct 13, 2015 at 20:36 +1000, David Gwynne wrote: > > > On 12 Oct 2015, at 12:00 AM, Alexandr Nedvedicky > > wrote: > > > > Hello, > > > > patch below introduces struct refcnt to pfi_kif structure. Patch also > > changes > > pfi_kif_get() function to

Re: preparing pfi_kif to MP world

2015-10-13 Thread Alexandr Nedvedicky
Hello, > > > Furthermore existing functions pfi_kif_ref()/pfi_kif_unref() are thrown > > > away > > > in favor of pfi_kif_take()/pfi_kif_rele(), which follow naming convention > > > set by refcnt_init(9). Patch also removes kif reference types (enum > > > pfi_kif_refs). > > > > [snip] > > > @@

Re: preparing pfi_kif to MP world

2015-10-13 Thread Mike Belopuhov
On Tue, Oct 13, 2015 at 20:36 +1000, David Gwynne wrote: > > > On 12 Oct 2015, at 12:00 AM, Alexandr Nedvedicky > > wrote: > > > > Hello, > > > > patch below introduces struct refcnt to pfi_kif structure. Patch also > > changes > > pfi_kif_get() function to

Re: preparing pfi_kif to MP world

2015-10-13 Thread David Gwynne
> On 13 Oct 2015, at 21:12, Mike Belopuhov wrote: > > On Tue, Oct 13, 2015 at 20:36 +1000, David Gwynne wrote: >> >>> On 12 Oct 2015, at 12:00 AM, Alexandr Nedvedicky >>> wrote: >>> >>> Hello, >>> >>> patch below introduces struct refcnt