Re: refactor PF option parsing loops

2017-01-24 Thread Martin Pieuchot
On 24/01/17(Tue) 14:43, Richard Procter wrote: > Hi, > > PF implements six distinct TCP option parsing loops. This patch converts > these to one inline function in pfvar_priv.h, normalises their semantics, > and strips ~100 lines. I like it. > I've laid out the existing semantics below. The

Re: refactor PF option parsing loops

2017-01-24 Thread Alexandr Nedvedicky
Hello Richard, > PF implements six distinct TCP option parsing loops. This patch converts > these to one inline function in pfvar_priv.h, normalises their semantics, > and strips ~100 lines. what is the reason to keep function definition in pfvar_priv.h? I would expect to stick

Re: refactor PF option parsing loops

2017-01-23 Thread Richard Procter
PS Find this patch broken down for easier review here: http://203.79.107.124/opts/ On Tue, 24 Jan 2017, Richard Procter wrote: > Hi, > > PF implements six distinct TCP option parsing loops. This patch converts > these to one inline function in pfvar_priv.h, normalises their semantics, > and

refactor PF option parsing loops

2017-01-23 Thread Richard Procter
Hi, PF implements six distinct TCP option parsing loops. This patch converts these to one inline function in pfvar_priv.h, normalises their semantics, and strips ~100 lines. I've laid out the existing semantics below. The new loop implements the timestamp parser's semantics of "(s-b) (v-3)