Re: relayd interrupted transfers

2017-08-25 Thread Alexander Bluhm
On Fri, Aug 25, 2017 at 06:38:01AM +, Rivo Nurges wrote: > Your version works for me. Good. Any ok for this diff then? bluhm Index: usr.sbin/relayd/relay.c === RCS file: /data/mirror/openbsd/cvs/src/usr.sbin/relayd/relay.c,v

Re: relayd interrupted transfers

2017-08-25 Thread Rivo Nurges
Hi! Your version works for me. Rivo On 24/08/2017, 17:10, "Alexander Bluhm" wrote: On Thu, Aug 24, 2017 at 12:44:27PM +, Rivo Nurges wrote: > This will fix my problem and regress still passes. Yes this also works for me. I think the

Re: relayd interrupted transfers

2017-08-24 Thread Rivo Nurges
Hi! This will fix my problem and regress still passes. Index: usr.sbin/relayd/relay.c === RCS file: /cvs/src/usr.sbin/relayd/relay.c,v retrieving revision 1.225 diff -u -p -r1.225 relay.c --- usr.sbin/relayd/relay.c 9 Aug 2017

Re: relayd interrupted transfers

2017-08-24 Thread Alexander Bluhm
On Thu, Aug 24, 2017 at 12:44:27PM +, Rivo Nurges wrote: > This will fix my problem and regress still passes. Yes this also works for me. I think the variable name "dst" is not good. Normally it refers to someting on the cre->dst side. As the buffer is on our side, I think

Re: relayd interrupted transfers

2017-08-23 Thread Rivo Nurges
Hi! I'll look into it. Rivo On 23/08/2017, 14:42, "Alexander Bluhm" wrote: On Tue, Aug 22, 2017 at 05:31:17PM +, Rivo Nurges wrote: > relay_error() sets se_done even if write buffer is not drained and > relay_write() will close the connection if

Re: relayd interrupted transfers

2017-08-23 Thread Alexander Bluhm
On Tue, Aug 22, 2017 at 05:31:17PM +, Rivo Nurges wrote: > relay_error() sets se_done even if write buffer is not drained and > relay_write() will close the connection if se_done is set I have seen a sporadic fail with chunked encoding in the daily regression test run. So something might be

relayd interrupted transfers

2017-08-22 Thread Rivo Nurges
Hi! relay_error() sets se_done even if write buffer is not drained and relay_write() will close the connection if se_done is set I have a case with 76k json payload where relay_error() detects EOF on read socket, sets so_done but write socket is not drained yet and socket is closed before all