On 2023/05/15 07:34:03 -0600, "Todd C. Miller" wrote:
> On Mon, 15 May 2023 13:54:35 +0200, Omar Polo wrote:
>
> > almost always (cast)var. I've adjusted the spacing in the line I was
> > touching, grepping for common types I could only find one instance of
> > a '(long long) src' in envelope.c
May 15, 2023 3:34 PM, "Todd C. Miller" wrote:
> On Mon, 15 May 2023 13:54:35 +0200, Omar Polo wrote:
>
>> almost always (cast)var. I've adjusted the spacing in the line I was
>> touching, grepping for common types I could only find one instance of
>> a '(long long) src' in envelope.c which I'm n
On Mon, 15 May 2023 13:54:35 +0200, Omar Polo wrote:
> almost always (cast)var. I've adjusted the spacing in the line I was
> touching, grepping for common types I could only find one instance of
> a '(long long) src' in envelope.c which I'm not addressing here.
OK millert@. It would be nice to
On 2023/05/15 09:40:50 +0200, theo Buehler wrote:
> Do we care that sometimes we (cast)var and sometimes we (cast) var?
> Is this at least consistent per-file?
almost always (cast)var. I've adjusted the spacing in the line I was
touching, grepping for common types I could only find one instance
On Mon, May 15, 2023 at 09:22:47AM +0200, Omar Polo wrote:
> On 2023/05/15 09:03:47 +0200, Omar Polo wrote:
> > On 2023/05/14 18:03:17 -0600, "Theo de Raadt" wrote:
> > > Omar Polo wrote:
> > > > On 2023/05/10 09:30:12 +0200, Theo Buehler wrote:
> > > > > > I forgot to include one off_t cast si
On 2023/05/15 09:03:47 +0200, Omar Polo wrote:
> On 2023/05/14 18:03:17 -0600, "Theo de Raadt" wrote:
> > Omar Polo wrote:
> > > On 2023/05/10 09:30:12 +0200, Theo Buehler wrote:
> > > > > I forgot to include one off_t cast since it was in a different
> > > > > directory and -even if off topic
On 2023/05/14 18:03:17 -0600, "Theo de Raadt" wrote:
> Omar Polo wrote:
> > On 2023/05/10 09:30:12 +0200, Theo Buehler wrote:
> > > > I forgot to include one off_t cast since it was in a different
> > > > directory and -even if off topic because it's not in portable- instead
> > > > of "const"-i
Omar Polo wrote:
> On 2023/05/10 09:30:12 +0200, Theo Buehler wrote:
> > > I forgot to include one off_t cast since it was in a different
> > > directory and -even if off topic because it's not in portable- instead
> > > of "const"-ify only tz why don't mark as const also the two arrays day
> >
> + (long long int)tv.tv_sec, tv.tv_usec,
Please do not use that form. (long long) is enough.
On Wed, 10 May 2023 09:25:43 +0200, Omar Polo wrote:
> I forgot to include one off_t cast since it was in a different
> directory and -even if off topic because it's not in portable- instead
> of "const"-ify only tz why don't mark as const also the two arrays day
> and month?
Sure. OK millert@ f
On 2023/05/10 09:30:12 +0200, Theo Buehler wrote:
> > I forgot to include one off_t cast since it was in a different
> > directory and -even if off topic because it's not in portable- instead
> > of "const"-ify only tz why don't mark as const also the two arrays day
> > and month?
>
> ok.
>
> Th
On Wed, May 10, 2023 at 09:25:43AM +0200, Omar Polo wrote:
> On 2023/05/09 19:41:51 -0600, "Todd C. Miller" wrote:
> > On Wed, 10 May 2023 00:55:54 +0200, Omar Polo wrote:
> >
> > > As per subject, here's a few misc nits that would reduce the
> > > difference with -portable. There's some printin
On 2023/05/09 19:41:51 -0600, "Todd C. Miller" wrote:
> On Wed, 10 May 2023 00:55:54 +0200, Omar Polo wrote:
>
> > As per subject, here's a few misc nits that would reduce the
> > difference with -portable. There's some printing of time_t via
> > casting to long long, some missing includes (even
On Wed, 10 May 2023 00:55:54 +0200, Omar Polo wrote:
> As per subject, here's a few misc nits that would reduce the
> difference with -portable. There's some printing of time_t via
> casting to long long, some missing includes (even if in tree it builds
> nevertheless) and a const for a variable
As per subject, here's a few misc nits that would reduce the
difference with -portable. There's some printing of time_t via
casting to long long, some missing includes (even if in tree it builds
nevertheless) and a const for a variable (no idea how it went there in
-portable but it's not wrong so
15 matches
Mail list logo
