- I don't like the refactoring because it makes ptyfs less optional (brings
in code and headers to the base kernel). I think it is simpler to provide
an entry function to get the mount point instead, and this way all the guts
of ptyfs stay in ptyfs.
Looks better, thank you.
- Is it
Some misspelling corrections.
fs/ptyfs/ptyfs.h|2 +
fs/ptyfs/ptyfs_vfsops.c | 63 ++--
fs/ptyfs/ptyfs_vnops.c | 25 ++-
kern/tty_bsdpty.c | 11 +++-
kern/tty_ptm.c | 45
On Thu, Apr 03, 2014 at 05:51:38PM +0200, Manuel Bouyer wrote:
Hello,
trying to debug
http://mail-index.netbsd.org/current-users/2014/03/26/msg024535.html
I built a kernel with MBUFTRACE (this is netbsd-6 of december).
I got this almost immediatly:
panic: kernel diagnostic assertion off
On Apr 4, 12:29pm, net...@izyk.ru (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
|
| - I don't like the refactoring because it makes ptyfs less optional (brings
|in code and headers to the base kernel). I think it is simpler to provide
|an entry
Should we put a pointer in the pty node that points to the primary mount point
then so we get the correct one?
Why? In general case we forever must return first which mount first, next mount
point,
shouldn't replace previous, else incorrect TIOCPTMGET(path) for already opened
pty we will
On 04.04.2014 18:40, Ilya Zykov wrote:
Should we put a pointer in the pty node that points to the primary mount
point
then so we get the correct one?
Why? In general case we forever must return first which mount first, next
mount point,
shouldn't replace previous, else incorrect
On Apr 4, 6:40pm, net...@izyk.ru (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
|
| Should we put a pointer in the pty node that points to the primary mount
point
| then so we get the correct one?
|
| Why? In general case we forever must return first which
On 04.04.2014 18:55, Christos Zoulas wrote:
On Apr 4, 6:40pm, net...@izyk.ru (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
|
| Should we put a pointer in the pty node that points to the primary mount
point
| then so we get the correct one?
|
|
On 04.04.2014 18:55, Christos Zoulas wrote:
On Apr 4, 6:40pm, net...@izyk.ru (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
|
| Should we put a pointer in the pty node that points to the primary mount
point
| then so we get the correct one?
|
|
On 04.04.2014 18:55, Christos Zoulas wrote:
On Apr 4, 6:40pm, net...@izyk.ru (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
|
| Should we put a pointer in the pty node that points to the primary mount
point
| then so we get the correct one?
|
|
On Apr 4, 7:28pm, net...@izyk.ru (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
| On 04.04.2014 18:55, Christos Zoulas wrote:
| On Apr 4, 6:40pm, net...@izyk.ru (Ilya Zykov) wrote:
| -- Subject: Re: Enhance ptyfs to handle multiple instances.
|
| |
| |
Small test.
#include util.h
#include stdio.h
#include termios.h
#include err.h
#include stdlib.h
#include sys/types.h
#include sys/ioctl.h
#include sys/stat.h
#include errno.h
#include fcntl.h
#include grp.h
#include stdio.h
#include string.h
#include unistd.h
main (){
int amaster,
12 matches
Mail list logo
