Disclaimer: I know nothing about LFS, but it seems to me that there is no
guarantee for curpg to not be NULL in the following code from
src/sys/ufs/lfs/lfs_vnops.c:
while (by_list || soff MIN(blkeof, endoffset)) {
if (by_list) {
/*
On Wed, 5 Jan 2011, Martin Husemann wrote:
Disclaimer: I know nothing about LFS, but it seems to me that there is no
guarantee for curpg to not be NULL in the following code from
src/sys/ufs/lfs/lfs_vnops.c:
while (by_list || soff MIN(blkeof, endoffset)) {
if
On Wed, Jan 05, 2011 at 04:25:09PM +, Eduardo Horvath wrote:
I think you're right. While I'm pretty sure that curpg won't be NULL on
the first iteration, I think it can be NULL on subsequent iterations. I'd
commit that change.
It shouldn't get there on subsequent iterations if it
On Wed, 5 Jan 2011, Martin Husemann wrote:
On Wed, Jan 05, 2011 at 04:25:09PM +, Eduardo Horvath wrote:
I think you're right. While I'm pretty sure that curpg won't be NULL on
the first iteration, I think it can be NULL on subsequent iterations. I'd
commit that change.
It
On Wed, Jan 05, 2011 at 05:03:15PM +, Eduardo Horvath wrote:
If by_list is set we'll always get here, and I don't think we'd be called
if the vnode had no pages at all
Ok, I'll add a KASSERT() to check for that and re-run the tests.
Martin
On Wed, Jan 05, 2011 at 06:06:17PM +0100, Martin Husemann wrote:
Ok, I'll add a KASSERT() to check for that and re-run the tests.
Indeed, it never happens on first entry to the loop, but via the goto top
later.
I'll commit the original patch. Unfortunately I run into locking issues
later, so
On Wed, 5 Jan 2011, Martin Husemann wrote:
I'll commit the original patch. Unfortunately I run into locking issues
later, so this still does not fix the full test.
Really? Last time I tried (about a month or two ago) I wasn't able to
hang LFS. OTOH, looks like there's been quite some churn
On Wed, Jan 05, 2011 at 07:35:53PM +, Eduardo Horvath wrote:
Really? Last time I tried (about a month or two ago) I wasn't able to
hang LFS. OTOH, looks like there's been quite some churn since then.
What's your setup and what tests are you running?
I run src/tests/fs/vfs/t_full
On Wed, 5 Jan 2011, Martin Husemann wrote:
On Wed, Jan 05, 2011 at 07:35:53PM +, Eduardo Horvath wrote:
Really? Last time I tried (about a month or two ago) I wasn't able to
hang LFS. OTOH, looks like there's been quite some churn since then.
What's your setup and what tests
