Re: Move the vnode lock into file systems

2010-07-01 Thread Andrew Doran
On Tue, Jun 29, 2010 at 04:23:53PM +0100, Mindaugas Rasiukevicius wrote: David Holland dholland-t...@netbsd.org wrote: Vaguely related to which, does anyone object to wrapping VOP_UNLOCK in a vn_unlock() function (doing nothing extra), so as to be symmetric with vn_lock()? I think I've

Re: Move the vnode lock into file systems

2010-06-30 Thread Bill Stouder-Studenmund
On Tue, Jun 29, 2010 at 04:23:53PM +0100, Mindaugas Rasiukevicius wrote: David Holland dholland-t...@netbsd.org wrote: Vaguely related to which, does anyone object to wrapping VOP_UNLOCK in a vn_unlock() function (doing nothing extra), so as to be symmetric with vn_lock()? I think I've

Re: Move the vnode lock into file systems

2010-06-30 Thread Bill Stouder-Studenmund
On Tue, Jun 29, 2010 at 04:54:46PM +0200, Juergen Hannken-Illjes wrote: On Sat, Jun 26, 2010 at 10:39:27AM +0200, Juergen Hannken-Illjes wrote: The vnode lock operations currently work on a rw lock located inside the vnode. I propose to move this lock into the file system node. This

Re: Move the vnode lock into file systems

2010-06-29 Thread Mindaugas Rasiukevicius
David Holland dholland-t...@netbsd.org wrote: Vaguely related to which, does anyone object to wrapping VOP_UNLOCK in a vn_unlock() function (doing nothing extra), so as to be symmetric with vn_lock()? I think I've mentioned this before, but I'm not sure, and if so it was a while back... I

Re: Move the vnode lock into file systems

2010-06-28 Thread Andrew Doran
On Sat, Jun 26, 2010 at 10:39:27AM +0200, Juergen Hannken-Illjes wrote: The vnode lock operations currently work on a rw lock located inside the vnode. I propose to move this lock into the file system node. This place is more logical as we lock a file system node and not a vnode. This

Re: Move the vnode lock into file systems

2010-06-28 Thread Juergen Hannken-Illjes
On Mon, Jun 28, 2010 at 09:06:57AM +, Andrew Doran wrote: On Sat, Jun 26, 2010 at 10:39:27AM +0200, Juergen Hannken-Illjes wrote: The vnode lock operations currently work on a rw lock located inside the vnode. I propose to move this lock into the file system node. This place is more

Re: Move the vnode lock into file systems

2010-06-27 Thread Juergen Hannken-Illjes
On Sun, Jun 27, 2010 at 02:06:31AM +, David Holland wrote: On Sat, Jun 26, 2010 at 10:39:27AM +0200, Juergen Hannken-Illjes wrote: The vnode lock operations currently work on a rw lock located inside the vnode. I propose to move this lock into the file system node. This place is

Re: Move the vnode lock into file systems

2010-06-27 Thread David Holland
On Sun, Jun 27, 2010 at 06:18:19PM +0200, Juergen Hannken-Illjes wrote: (In the absence of some clear benefits I don't think it's a particularly good idea to paste a dozen or two copies of genfs_lock everywhere. But folding vcrackmgr() into genfs_lock and genfs_unlock seems like a fine

Move the vnode lock into file systems

2010-06-26 Thread Juergen Hannken-Illjes
The vnode lock operations currently work on a rw lock located inside the vnode. I propose to move this lock into the file system node. This place is more logical as we lock a file system node and not a vnode. This becomes clear if we think of a file system where one file system node is attached

Re: Move the vnode lock into file systems

2010-06-26 Thread David Holland
On Sat, Jun 26, 2010 at 10:39:27AM +0200, Juergen Hannken-Illjes wrote: The vnode lock operations currently work on a rw lock located inside the vnode. I propose to move this lock into the file system node. This place is more logical as we lock a file system node and not a vnode. This