Re: the bouyer-quota2 branch

2011-03-12 Thread Manuel Bouyer
On Thu, Mar 10, 2011 at 07:40:59PM +0100, Manuel Bouyer wrote: I'll look at extract some functions from ufs/ufs this week-end. Here is a first attemps. Some functions from quota2_prop have moved to lib/proplib, some other in a new common/lib/quota/quotaprop.c quota2_prop.[ch] will go,

Re: the bouyer-quota2 branch

2011-03-11 Thread Manuel Bouyer
On Fri, Mar 11, 2011 at 03:09:28PM +1100, matthew green wrote: Agreed. So let's keep quotactl(2) ... it's fine and is working. i'd rather use quotactl2() than the old name. other ideas: quotapropctl() quotaprop() and i'd be ok with quotapctl() as well.

Re: the bouyer-quota2 branch

2011-03-10 Thread Manuel Bouyer
On Thu, Mar 10, 2011 at 11:42:08AM +1100, matthew green wrote: On Sat Feb 19 2011 at 23:21:35 +0100, Manuel Bouyer wrote: This branch is for the developement of a modernized disk quota system. The 2 main changes are: a new quotactl(2) interface and a new on-disk format, compatible

Re: the bouyer-quota2 branch

2011-03-10 Thread Antti Kantee
On Thu Mar 10 2011 at 09:36:20 +0100, Manuel Bouyer wrote: On Thu, Mar 10, 2011 at 11:42:08AM +1100, matthew green wrote: On Sat Feb 19 2011 at 23:21:35 +0100, Manuel Bouyer wrote: This branch is for the developement of a modernized disk quota system. The 2 main changes are: a new

Re: the bouyer-quota2 branch

2011-03-10 Thread Antti Kantee
On Thu Mar 10 2011 at 20:29:58 +1100, matthew green wrote: (Just to explain the rationale for this nomenclatural crisis, yesterday I discovered that the changed signature broke some assumptions about syscall compat I'd made in makesyscalls.sh, and that caused the script to fail in a

Re: the bouyer-quota2 branch

2011-03-10 Thread Manuel Bouyer
On Thu, Mar 10, 2011 at 11:01:44AM +0200, Antti Kantee wrote: On Thu Mar 10 2011 at 09:36:20 +0100, Manuel Bouyer wrote: On Thu, Mar 10, 2011 at 11:42:08AM +1100, matthew green wrote: On Sat Feb 19 2011 at 23:21:35 +0100, Manuel Bouyer wrote: This branch is for the developement of

Re: the bouyer-quota2 branch

2011-03-10 Thread Antti Kantee
On Thu Mar 10 2011 at 11:28:14 +0100, Manuel Bouyer wrote: Considering that quotactl is not used by programmers (unless they're hacking on the quota utils ;) I don't think we need to spend a lot someone who looks at quotactl(8) will also look at quotactl(2) ... You can still MLINKS the

Re: the bouyer-quota2 branch

2011-03-10 Thread Manuel Bouyer
On Thu, Mar 10, 2011 at 09:52:58PM +1100, matthew green wrote: that seems reasonable to me. What do you propose then ? quotactl is the best name I can find for this syscall ... quotactl2? quotapctl? quota_pctl? quotactl_the_next_generation? ... quota_king? All

Re: the bouyer-quota2 branch

2011-03-10 Thread David Holland
On Wed, Mar 09, 2011 at 08:20:00PM +0100, Manuel Bouyer wrote: On Wed, Mar 09, 2011 at 06:28:11PM +, David Holland wrote: struct quota2_entry (and so struct quota2_val) is used for both on-disk storage, and in-memory representation in tools and kernel. I agree this should be

Re: the bouyer-quota2 branch

2011-03-10 Thread Manuel Bouyer
On Thu, Mar 10, 2011 at 06:00:06PM +, David Holland wrote: On Wed, Mar 09, 2011 at 08:20:00PM +0100, Manuel Bouyer wrote: On Wed, Mar 09, 2011 at 06:28:11PM +, David Holland wrote: struct quota2_entry (and so struct quota2_val) is used for both on-disk storage, and

re: the bouyer-quota2 branch

2011-03-10 Thread matthew green
Agreed. So let's keep quotactl(2) ... it's fine and is working. i'd rather use quotactl2() than the old name. other ideas: quotapropctl() quotaprop() and i'd be ok with quotapctl() as well. I still don't understand what problem we're trying to fix. OK, by

Re: the bouyer-quota2 branch

2011-03-09 Thread Manuel Bouyer
On Wed, Mar 09, 2011 at 06:28:11PM +, David Holland wrote: struct quota2_entry (and so struct quota2_val) is used for both on-disk storage, and in-memory representation in tools and kernel. I agree this should be split; with an extra level of conversion (between in-memory and

Re: the bouyer-quota2 branch

2011-03-09 Thread Antti Kantee
On Sat Feb 19 2011 at 23:21:35 +0100, Manuel Bouyer wrote: This branch is for the developement of a modernized disk quota system. The 2 main changes are: a new quotactl(2) interface and a new on-disk format, compatible with journaled ffs. Hmm, I'm wondering if the new quotactl syscall should

Re: the bouyer-quota2 branch

2011-03-07 Thread David Holland
On Sat, Feb 19, 2011 at 11:21:35PM +0100, Manuel Bouyer wrote: I think the code in the bouyer-quota2 branch is stable now, and ready to be merged to HEAD. Unless objections, I'll merge it in about 2 weeks. [...] So, I thought one of the points of this was to make the quota interface fs

the bouyer-quota2 branch

2011-02-19 Thread Manuel Bouyer
Hi, I think the code in the bouyer-quota2 branch is stable now, and ready to be merged to HEAD. Unless objections, I'll merge it in about 2 weeks. To get a diff: cvs -d anon...@anoncvs.netbsd.org:/cvsroot -kk -u -r bouyer-quota2 -r bouyer-quota2-base src This branch is for the developement

Re: the bouyer-quota2 branch

2011-02-19 Thread Manuel Bouyer
On Sat, Feb 19, 2011 at 11:21:35PM +0100, Manuel Bouyer wrote: [...] quota are enabled with tunefs -q user and/or -q group (and disabled with -q nouser -q nogroup), of at newfs time with the same -q option. I forgot to note that mount_mfs also gain -q (the code is shared with newfs), so as a