Re: [PATCH] Style police for mod_specweb99.c

2003-01-22 Thread Greg Ames
Greg Ames wrote: MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: As regards the function names at the end of the function, I sure like it - it's a lot easier when you browse through the code.. But then, I thought it should be there for all of them or for none of them.. That's the reason I decided

Re: [PATCH] Style police for mod_specweb99.c

2003-01-22 Thread Greg Ames
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: As regards the function names at the end of the function, I sure like it - it's a lot easier when you browse through the code.. But then, I thought it should be there for all of them or for none of them.. That's the reason I decided to take it away..

RE: [PATCH] Style police for mod_specweb99.c

2003-01-22 Thread MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)
Okay.. Here it comes (with the changes suggested by Greg), and a couple more fixes that I'd overseen earlier. -Madhu -Original Message- From: Greg Ames [mailto:[EMAIL PROTECTED] Sent: Wednesday, January 22, 2003 11:26 AM To: [EMAIL PROTECTED] Subject: Re: [PATCH] Style police for mod_sp

RE: [PATCH] Style police for mod_specweb99.c

2003-01-22 Thread MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)
I wonder how I missed the first one :-?.. Anyways, thanks for the careful review.. (Ah.. now I know - I did a "cb" before I did the expand", and cb must have been the culprit).. As regards the function names at the end of the function, I sure like it - it's a lot easier when you browse through the

Re: [PATCH] Style police for mod_specweb99.c

2003-01-22 Thread Greg Ames
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: Summary of the patch : 1. convert tabs to spaces 2. try to follow apache styleguide Overall, a big improvement...thanks much! nitpicky comments follow: --- mod_specweb99.c 15 Jan 2003 16:15:02 - 1.18 +++ mod_specweb99.c 21 Jan 2003 21

Re: [PATCH] Style police for mod_specweb99.c

2003-01-22 Thread Dirk-Willem van Gulik
On Wed, 22 Jan 2003, Greg Ames wrote: > MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: > > Summary of the patch : > > 1. convert tabs to spaces > > hmmm, I wonder how I missed 'em? IIRC I used "expand -i -t4 mod_specweb99.c" > > > 2. try to follow apache styleguide > > I plan on reviewing this

Re: [PATCH] Style police for mod_specweb99.c

2003-01-22 Thread Greg Ames
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: Summary of the patch : 1. convert tabs to spaces hmmm, I wonder how I missed 'em? IIRC I used "expand -i -t4 mod_specweb99.c" 2. try to follow apache styleguide I plan on reviewing this, but I'm pretty weak on style other than not liking tabs. Oth