mod_include test shuffling

2003-12-10 Thread Geoffrey Young
well, since I know andre is paying attention, I thought I'd start with mod_include :) ok, I made some adjustments to t/modules/include.t to accommodate 1.3, 2.0, and 2.1. hopefully, all I did was shuffle things around so that it's easier to keep track of the three cases: proper behavior, in-proce

Re: mod_include test shuffling

2003-12-10 Thread Cliff Woolley
On Wed, 10 Dec 2003, Geoffrey Young wrote: > oh, and I'm very impressed with the thoroughness of the tests, btw. nice > work. That's what happens when you keep adding more and more tests and you STILL get people reporting failure cases. Sigh. Thanks though. :-) --Cliff

Re: mod_include test shuffling

2003-12-10 Thread Stas Bekman
Geoffrey Young wrote: well, since I know andre is paying attention, I thought I'd start with mod_include :) ok, I made some adjustments to t/modules/include.t to accommodate 1.3, 2.0, and 2.1. hopefully, all I did was shuffle things around so that it's easier to keep track of the three cases: prop

Re: mod_include test shuffling

2003-12-10 Thread Geoffrey Young
> Just to add to the concern Bill has voiced, there is a risk of "fixing" > testing here. You see that the sub-tests have failed only if you run in > the verbose mode. Most people won't do that, and will miss those > failures, thinking that everything is proper. hmm, what gives you that impres

limits.t and 400/413

2003-12-10 Thread Geoffrey Young
hi all t/apache/limits.t has one failure on Apache 1.3 - a chunked body that exceeds the limits. 2.0/2.1 returns 413 (entity too large) while 1.3 returns 400 (bad request). after looking at the code in 1.3 I think this is intentional - ap_get_client_block specifically handles this condition, whi

Re: mod_include test shuffling

2003-12-10 Thread Stas Bekman
Geoffrey Young wrote: Just to add to the concern Bill has voiced, there is a risk of "fixing" testing here. You see that the sub-tests have failed only if you run in the verbose mode. Most people won't do that, and will miss those failures, thinking that everything is proper. hmm, what gives yo

Re: mod_include test shuffling

2003-12-10 Thread André Malo
* Geoffrey Young <[EMAIL PROTECTED]> wrote: > well, since I know andre is paying attention, I thought I'd start with > mod_include :) heh ;-) > the only place I'm a bit confused is the flastmod/fsize test, which is > marked as TODO currently but is "unexpectedly passing" in 2.0/2.1. the > comme