Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2004-04-02 Thread Stas Bekman
Geoffrey Young wrote: [EMAIL PROTECTED] wrote: coar2004/04/01 15:57:17 Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm Log: add an '-httpd_conf_extra filename' option to allow an *additional* server config file to

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2004-04-02 Thread Geoffrey Young
right, I think I got that. but that requires knowing the hard-coded path. That's what Ken wanted ok, but just because you get substitution doesn't mean you have to use it :) perhaps I wasn't clear enough, but the proposed httpd.extra.conf.in would be appended to the generated

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2004-04-02 Thread Geoffrey Young
By splicing you mean 'Include ken_extra.conf' from t/conf/httpd.conf? Yes, but have_module() doesn't look it up in any of the conf files, it looks it up from the config object $cfg-{modules} which get populate with available modules when the config is generated, and it only scans the

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2001-09-06 Thread Stas Bekman
On Wed, 5 Sep 2001, Doug MacEachern wrote: On 6 Sep 2001 [EMAIL PROTECTED] wrote: --- TestConfig.pm 2001/09/05 16:41:57 1.51 +++ TestConfig.pm 2001/09/06 02:36:44 1.52 @@ -940,6 +940,9 @@ HostnameLookups Off +# make sure that we test under Taint mode

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2001-09-06 Thread Gary Benson
On 6 Sep 2001 [EMAIL PROTECTED] wrote: stas01/09/05 19:36:44 Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm Log: - enable taint mode in tests via PerlSwitches -T - untaint $ENV{PATH} before using open -| [snip]

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2001-09-06 Thread Barrie Slaymaker
On Thu, Sep 06, 2001 at 12:33:43PM +0100, Gary Benson wrote: +$ENV{PATH} = '/bin:/usr/bin'; Hmmm, just noticed this in the reply. On Win32, the PATH sep is ';' (assuming that you want this code to work there, don't know). Don't know about the taint issues. - Barrie

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2001-09-06 Thread Stas Bekman
On Thu, 6 Sep 2001, Barrie Slaymaker wrote: On Thu, Sep 06, 2001 at 12:33:43PM +0100, Gary Benson wrote: +$ENV{PATH} = '/bin:/usr/bin'; Hmmm, just noticed this in the reply. On Win32, the PATH sep is ';' (assuming that you want this code to work there, don't know). Oops,

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2001-09-06 Thread Stas Bekman
On Thu, 6 Sep 2001, Gary Benson wrote: On 6 Sep 2001 [EMAIL PROTECTED] wrote: stas01/09/05 19:36:44 Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm Log: - enable taint mode in tests via PerlSwitches -T -

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2001-09-06 Thread Gary Benson
On Thu, 6 Sep 2001, Stas Bekman wrote: On Thu, 6 Sep 2001, Gary Benson wrote: On 6 Sep 2001 [EMAIL PROTECTED] wrote: stas01/09/05 19:36:44 Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm Log: -

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2001-09-06 Thread Doug MacEachern
On Thu, 6 Sep 2001, Gary Benson wrote: +# untaint +$ENV{PATH} = '/bin:/usr/bin'; this should be 'local $ENV{PATH} = ...;', does that help at all?

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm TestConfigParse.pm

2001-09-06 Thread Stas Bekman
On Thu, 6 Sep 2001, Doug MacEachern wrote: On Thu, 6 Sep 2001, Gary Benson wrote: +# untaint +$ENV{PATH} = '/bin:/usr/bin'; this should be 'local $ENV{PATH} = ...;', does that help at all? oops, I've missed the point that you were explicitly set PATH: % export