Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-07 Thread DRC
On 9/7/10 4:53 AM, Adam Tkac wrote: > Imagine this situation: > > server: > - admin starts it with following parameter: > "-SecurityTypes VeNCrypt,Plain,TLSNone,None" > > client: > - started with following parameter > "-SecurityTypes VeNCrypt,TLSNone,Plain" > > In this situation client will

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-07 Thread Adam Tkac
On Sat, Sep 04, 2010 at 09:39:19AM -0600, DRC wrote: > On 9/4/10 12:34 AM, Martin Koegler wrote: > >The client skips security types, if it is not somewhere in its > >SecurityType parameter. > > I guess I will have to build and test it when I'm back in the > office, because I still cannot picture w

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-07 Thread Adam Tkac
On Fri, Sep 03, 2010 at 08:00:38AM +0200, Martin Koegler wrote: > On Thu, Sep 02, 2010 at 08:48:47PM -0600, DRC wrote: > > On 9/2/10 9:50 AM, Adam Tkac wrote: > > > This type is, by default, disabled on the server. It must be enabled > > > via commandline parameter (-SecurityTypes). Client has it d

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-04 Thread DRC
On 9/4/10 12:34 AM, Martin Koegler wrote: > The client skips security types, if it is not somewhere in its > SecurityType parameter. I guess I will have to build and test it when I'm back in the office, because I still cannot picture what's going on. -

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-03 Thread Martin Koegler
On Fri, Sep 03, 2010 at 07:50:07AM -0600, DRC wrote: > On 9/3/10 12:00 AM, Martin Koegler wrote: > >The client side honors the Security Type order of the server - code > >for using the client side order was removed with "Remove unused > >CConnection::setClientSecTypeOrder function" on Jul 20 2010.

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-03 Thread DRC
On 9/3/10 12:00 AM, Martin Koegler wrote: > The client side honors the Security Type order of the server - code > for using the client side order was removed with "Remove unused > CConnection::setClientSecTypeOrder function" on Jul 20 2010. So does that mean if Plain is enabled on the server and p

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-02 Thread Martin Koegler
On Thu, Sep 02, 2010 at 08:48:47PM -0600, DRC wrote: > On 9/2/10 9:50 AM, Adam Tkac wrote: > > This type is, by default, disabled on the server. It must be enabled > > via commandline parameter (-SecurityTypes). Client has it disabled as > > well but if user specify he wants to use it (and server h

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-02 Thread DRC
On 9/2/10 9:50 AM, Adam Tkac wrote: > This type is, by default, disabled on the server. It must be enabled > via commandline parameter (-SecurityTypes). Client has it disabled as > well but if user specify he wants to use it (and server has Plain type > enabled) then it is used. If it is client's f

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-02 Thread Adam Tkac
On Thu, Sep 02, 2010 at 09:18:15AM -0600, DRC wrote: > On 9/2/10 6:37 AM, Adam Tkac wrote: > > I would rather disable "Plain" type by default because it is real > > security hazard. I've commited your patch without "Plain" in the > > default list. User can manually select it. > > > > Rest of the pa

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-02 Thread DRC
On 9/2/10 6:37 AM, Adam Tkac wrote: > I would rather disable "Plain" type by default because it is real > security hazard. I've commited your patch without "Plain" in the > default list. User can manually select it. > > Rest of the patch is OK, I've commited it as r4127. Thank you very > much. I h

Re: [Tigervnc-devel] [PATCH] Implement Plain in the client

2010-09-02 Thread Adam Tkac
On Thu, Sep 02, 2010 at 09:05:53AM +0200, Martin Koegler wrote: > diff --git a/common/rfb/Security.cxx b/common/rfb/Security.cxx > index 71e45de..708c10a 100644 > --- a/common/rfb/Security.cxx > +++ b/common/rfb/Security.cxx > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include >